)]}'
{"cinder/volume/drivers/dell/dell_storagecenter_iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"66b2014225f033cf524e960d444d5fb35fecba5c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                        return {\u0027driver_volume_type\u0027: \u0027iscsi\u0027,"},{"line_number":100,"context_line":"                                \u0027data\u0027: iscsiprops}"},{"line_number":101,"context_line":"            except Exception:"},{"line_number":102,"context_line":"                error \u003d (_LE(\u0027Failed to initialize connection %(i)s %(n)s\u0027),"},{"line_number":103,"context_line":"                         {\u0027i\u0027: initiator_name,"},{"line_number":104,"context_line":"                          \u0027n\u0027: volume_name})"},{"line_number":105,"context_line":"                LOG.error(error)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a0c5dc1_de120a62","line":102,"updated":"2015-05-13 19:51:47.000000000","message":"Since you are preformatting the string that gets passed to both the logger and the exception you will need to use % here instead of , so the formatting happens right away.","commit_id":"1c3b44a935e52e6d53df69af8ceef0b75957be32"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b6f4860e433ac96e416bbdb7cce12218079ce6cd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            or \u0027Dell-iSCSI\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def initialize_connection(self, volume, connector):"},{"line_number":46,"context_line":"        # Initialize_connection will find or create a server identified by the"},{"line_number":47,"context_line":"        # connector on the Dell backend.  It will then map the volume to it"},{"line_number":48,"context_line":"        # and return the properties as follows.."},{"line_number":49,"context_line":"        # {\u0027driver_volume_type\u0027: \u0027iscsi\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_5206ac52","line":46,"updated":"2015-05-21 17:44:50.000000000","message":"There is another patch (https://review.openstack.org/#/c/184820/) that is enabling the enforcement of proper DocStrings. I think this is good to document all of this detail, but probably better to follow those guidelines to prevent merge conflicts.","commit_id":"37c7147ae62c2c3630233375b060153a6513468c"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"59ca716bb19ead94ab943245f178a0e1c2d16be6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            or \u0027Dell-iSCSI\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def initialize_connection(self, volume, connector):"},{"line_number":46,"context_line":"        # Initialize_connection will find or create a server identified by the"},{"line_number":47,"context_line":"        # connector on the Dell backend.  It will then map the volume to it"},{"line_number":48,"context_line":"        # and return the properties as follows.."},{"line_number":49,"context_line":"        # {\u0027driver_volume_type\u0027: \u0027iscsi\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_9898c56b","line":46,"in_reply_to":"7a016987_5206ac52","updated":"2015-05-21 19:21:17.000000000","message":"Since this isn\u0027t actually a docstring I don\u0027t think that should be an issue? (He said with a raising lilt to indicate that was a question.)","commit_id":"37c7147ae62c2c3630233375b060153a6513468c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b6f4860e433ac96e416bbdb7cce12218079ce6cd","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                        return {\u0027driver_volume_type\u0027: \u0027iscsi\u0027,"},{"line_number":116,"context_line":"                                \u0027data\u0027: iscsiprops}"},{"line_number":117,"context_line":"            except Exception:"},{"line_number":118,"context_line":"                error \u003d (_LE(\u0027Failed to initialize connection \u0027"},{"line_number":119,"context_line":"                             \u0027%(initiator)s %(vol)s\u0027) %"},{"line_number":120,"context_line":"                         {\u0027initiator\u0027: initiator_name,"},{"line_number":121,"context_line":"                          \u0027vol\u0027: volume_name})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_3253306d","line":118,"updated":"2015-05-21 17:44:50.000000000","message":"Since error is being used in both LOG.error and the exception it needs _() instead of _LE().","commit_id":"37c7147ae62c2c3630233375b060153a6513468c"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"59ca716bb19ead94ab943245f178a0e1c2d16be6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                        return {\u0027driver_volume_type\u0027: \u0027iscsi\u0027,"},{"line_number":116,"context_line":"                                \u0027data\u0027: iscsiprops}"},{"line_number":117,"context_line":"            except Exception:"},{"line_number":118,"context_line":"                error \u003d (_LE(\u0027Failed to initialize connection \u0027"},{"line_number":119,"context_line":"                             \u0027%(initiator)s %(vol)s\u0027) %"},{"line_number":120,"context_line":"                         {\u0027initiator\u0027: initiator_name,"},{"line_number":121,"context_line":"                          \u0027vol\u0027: volume_name})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_78ad099a","line":118,"in_reply_to":"7a016987_3253306d","updated":"2015-05-21 19:21:17.000000000","message":"Done","commit_id":"37c7147ae62c2c3630233375b060153a6513468c"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"23c3eea2484491b31fb1df3dee605590988560a4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        volume_driver\u003dcinder.volume.drivers.dell.DellStorageCenterISCSIDriver"},{"line_number":35,"context_line":"    \u0027\u0027\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    VERSION \u003d \u00271.0.1\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":40,"context_line":"        super(DellStorageCenterISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_3cedb0b7","line":37,"updated":"2015-05-27 20:15:55.000000000","message":"Do you want to bump this version as it\u0027s adding a new feature for multipath?    Up to you guys how you manage your versions though.","commit_id":"4d0325dc89f910901f079ec2bea8343476065d2b"}]}