)]}'
{"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b8be86bca42403fd657f4e7350f68aabf17ab026","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                                dest_vg_ref)"},{"line_number":564,"context_line":"            # copy_volume expects sizes in MiB, we store integer GiB"},{"line_number":565,"context_line":"            # be sure to convert before passing in"},{"line_number":566,"context_line":"            size_in_mb \u003d int(volume[\u0027size\u0027]) * units.Ki"},{"line_number":567,"context_line":"            volutils.copy_volume(self.local_path(volume),"},{"line_number":568,"context_line":"                                 self.local_path(volume, vg\u003ddest_vg),"},{"line_number":569,"context_line":"                                 size_in_mb,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_94035342","line":566,"updated":"2015-05-13 20:48:39.000000000","message":"Why do we need cast to int here?","commit_id":"a5da4c353a1df17341c1e745796e00a4ec1afd21"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1af41e3ee8036b9db6bc37fe51b92b15a5398166","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                                dest_vg_ref)"},{"line_number":564,"context_line":"            # copy_volume expects sizes in MiB, we store integer GiB"},{"line_number":565,"context_line":"            # be sure to convert before passing in"},{"line_number":566,"context_line":"            size_in_mb \u003d int(volume[\u0027size\u0027]) * units.Ki"},{"line_number":567,"context_line":"            volutils.copy_volume(self.local_path(volume),"},{"line_number":568,"context_line":"                                 self.local_path(volume, vg\u003ddest_vg),"},{"line_number":569,"context_line":"                                 size_in_mb,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_2bce855a","line":566,"in_reply_to":"9a0c5dc1_0f7aaef1","updated":"2015-05-13 21:37:20.000000000","message":"I don\u0027t see a problem with being explicit about the type.","commit_id":"a5da4c353a1df17341c1e745796e00a4ec1afd21"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"e6e5b52fe02b005bc374d23d6c2c7f174c3fe0e9","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                                dest_vg_ref)"},{"line_number":564,"context_line":"            # copy_volume expects sizes in MiB, we store integer GiB"},{"line_number":565,"context_line":"            # be sure to convert before passing in"},{"line_number":566,"context_line":"            size_in_mb \u003d int(volume[\u0027size\u0027]) * units.Ki"},{"line_number":567,"context_line":"            volutils.copy_volume(self.local_path(volume),"},{"line_number":568,"context_line":"                                 self.local_path(volume, vg\u003ddest_vg),"},{"line_number":569,"context_line":"                                 size_in_mb,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_0f7aaef1","line":566,"in_reply_to":"9a0c5dc1_94035342","updated":"2015-05-13 21:16:21.000000000","message":"You are right, the volume[\u0027size\u0027] in DB is int value, so we don\u0027t need the cast.(but I saw this cast many places...)","commit_id":"a5da4c353a1df17341c1e745796e00a4ec1afd21"}]}