)]}'
{"cinder/api/contrib/types_manage.py":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"8ac42e54b5286259d86b60dc8befa17937eed570","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if description:"},{"line_number":74,"context_line":"            utils.check_string_length(description, \u0027Type description\u0027,"},{"line_number":75,"context_line":"                                      min_length\u003d1, max_length\u003d255)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            volume_types.create(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_bd6dfe99","line":75,"updated":"2015-05-18 16:58:22.000000000","message":"I think this is slightly misleading. The length of the description can equal 0. I think it would be clearer if you set \u0027min_length\u003d0\u0027 and \u0027if description is not None:\u0027.","commit_id":"dfa8d16a3ec0ee36e9ed6518b3c71e848781f2c8"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"91144318bb9e8cbfdf621f0933f23350bd35aa33","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if description:"},{"line_number":74,"context_line":"            utils.check_string_length(description, \u0027Type description\u0027,"},{"line_number":75,"context_line":"                                      min_length\u003d1, max_length\u003d255)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            volume_types.create(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_d0189420","line":75,"in_reply_to":"7a016987_bd6dfe99","updated":"2015-05-19 09:09:52.000000000","message":"+1, also please add unit tests covering this case","commit_id":"dfa8d16a3ec0ee36e9ed6518b3c71e848781f2c8"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"8ac42e54b5286259d86b60dc8befa17937eed570","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if description:"},{"line_number":128,"context_line":"            utils.check_string_length(description, \u0027Type description\u0027,"},{"line_number":129,"context_line":"                                      min_length\u003d1, max_length\u003d255)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        try:"},{"line_number":132,"context_line":"            volume_types.update(context, id, name, description)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_ddf55acb","line":129,"updated":"2015-05-18 16:58:22.000000000","message":"Same comment as above.","commit_id":"dfa8d16a3ec0ee36e9ed6518b3c71e848781f2c8"}],"cinder/tests/unit/api/contrib/test_types_manage.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1a370d2f0ac26288b0aa4d4033b59b097b61baf4","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    @mock.patch(\u0027cinder.volume.volume_types.get_volume_type_by_name\u0027)"},{"line_number":204,"context_line":"    def test_create_with_description_of_zero_length("},{"line_number":205,"context_line":"            self, mock_get_volume_type_by_name, mock_create_type):"},{"line_number":206,"context_line":"        mock_get_volume_type_by_name.return_value \u003d \\"},{"line_number":207,"context_line":"            {\u0027extra_specs\u0027: {\"key1\": \"value1\"},"},{"line_number":208,"context_line":"             \u0027id\u0027: 1,"},{"line_number":209,"context_line":"             \u0027name\u0027: u\u0027vol_type_1\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_70d71dc0","line":206,"updated":"2015-05-26 01:33:43.000000000","message":"It\u0027s generally preferred to avoid use of \\ and other means to do multi-line statements.","commit_id":"aeed2a788608b7b93bcdd70826ff0a3102c15027"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1a370d2f0ac26288b0aa4d4033b59b097b61baf4","unresolved":false,"context_lines":[{"line_number":209,"context_line":"             \u0027name\u0027: u\u0027vol_type_1\u0027,"},{"line_number":210,"context_line":"             \u0027description\u0027: u\u0027\u0027}"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        type_description \u003d \"\""},{"line_number":213,"context_line":"        body \u003d {\"volume_type\": {\"name\": \"vol_type_1\","},{"line_number":214,"context_line":"                                \"description\": type_description,"},{"line_number":215,"context_line":"                                \"extra_specs\": {\"key1\": \"value1\"}}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_10ed898e","line":212,"updated":"2015-05-26 01:33:43.000000000","message":"What\u0027s the point of this variable, its only used once in the body below.","commit_id":"aeed2a788608b7b93bcdd70826ff0a3102c15027"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1a370d2f0ac26288b0aa4d4033b59b097b61baf4","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        type_description \u003d \"\""},{"line_number":213,"context_line":"        body \u003d {\"volume_type\": {\"name\": \"vol_type_1\","},{"line_number":214,"context_line":"                                \"description\": type_description,"},{"line_number":215,"context_line":"                                \"extra_specs\": {\"key1\": \"value1\"}}}"},{"line_number":216,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/types\u0027)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_f0f1cd6b","line":214,"updated":"2015-05-26 01:33:43.000000000","message":"just assign to \"\"","commit_id":"aeed2a788608b7b93bcdd70826ff0a3102c15027"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1a370d2f0ac26288b0aa4d4033b59b097b61baf4","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    def test_update_type_with_description_having_length_zero("},{"line_number":290,"context_line":"            self, mock_get_volume_type, mock_type_update):"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        mock_get_volume_type.return_value \u003d \\"},{"line_number":293,"context_line":"            {\u0027id\u0027: 1, \u0027name\u0027: u\u0027vol_type_1\u0027, \u0027description\u0027: u\u0027\u0027}"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        type_description \u003d \"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_d0cff127","line":292,"updated":"2015-05-26 01:33:43.000000000","message":"It\u0027s generally preferred to avoid use of \\ and other means to do multi-line statements.","commit_id":"aeed2a788608b7b93bcdd70826ff0a3102c15027"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1a370d2f0ac26288b0aa4d4033b59b097b61baf4","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        mock_get_volume_type.return_value \u003d \\"},{"line_number":293,"context_line":"            {\u0027id\u0027: 1, \u0027name\u0027: u\u0027vol_type_1\u0027, \u0027description\u0027: u\u0027\u0027}"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        type_description \u003d \"\""},{"line_number":296,"context_line":"        body \u003d {\"volume_type\": {\"description\": type_description}}"},{"line_number":297,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/types/1\u0027)"},{"line_number":298,"context_line":"        req.method \u003d \u0027PUT\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_b0eb5578","line":295,"updated":"2015-05-26 01:33:43.000000000","message":"Remove variable","commit_id":"aeed2a788608b7b93bcdd70826ff0a3102c15027"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1a370d2f0ac26288b0aa4d4033b59b097b61baf4","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            {\u0027id\u0027: 1, \u0027name\u0027: u\u0027vol_type_1\u0027, \u0027description\u0027: u\u0027\u0027}"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        type_description \u003d \"\""},{"line_number":296,"context_line":"        body \u003d {\"volume_type\": {\"description\": type_description}}"},{"line_number":297,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/types/1\u0027)"},{"line_number":298,"context_line":"        req.method \u003d \u0027PUT\u0027"},{"line_number":299,"context_line":"        resp \u003d self.controller._update(req, \u00271\u0027, body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_9001793c","line":296,"updated":"2015-05-26 01:33:43.000000000","message":"just assign description to \"\"","commit_id":"aeed2a788608b7b93bcdd70826ff0a3102c15027"}]}