)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a66bab36033ef7c924c124126733161ce5aa7c58","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug  :  Not able to create a resource without sync attribute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"description : when user just want to check the limit of quota, without sync the attribute it gives the error"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Full Description https://bugs.launchpad.net/cinder/+bug/1455346"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_7d0bf88e","line":9,"updated":"2015-05-19 11:09:13.000000000","message":"too long line, please follow commit messages recommendation \nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"3fb882d3f1fdd422de3a85b52c1e14b78dcfb88d"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a66bab36033ef7c924c124126733161ce5aa7c58","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"description : when user just want to check the limit of quota, without sync the attribute it gives the error"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Full Description https://bugs.launchpad.net/cinder/+bug/1455346"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I910b5bf8ab936272d793fa8cce9d14e5f1674816"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_ddf0ac93","line":11,"updated":"2015-05-19 11:09:13.000000000","message":"should be Closes-Bug: #number, read  recommendations on link above","commit_id":"3fb882d3f1fdd422de3a85b52c1e14b78dcfb88d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a518609dc42f12bbdc7b43ae4ca4c7d45ad69216","unresolved":false,"context_lines":[{"line_number":10,"context_line":"without sync attribute,function gives error."},{"line_number":11,"context_line":"for more information please have a look into below link"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Full Description https://bugs.launchpad.net/cinder/+bug/1455346"},{"line_number":14,"context_line":"closes-Bug:1455346"},{"line_number":15,"context_line":"Change-Id: I910b5bf8ab936272d793fa8cce9d14e5f1674816"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a016987_5e435d13","line":13,"updated":"2015-05-21 14:49:10.000000000","message":"Remove this line, \"closes-bug\" is sufficient.\nNeed to add blueprint reference to commit. See https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"2a74877b770df732506b6714c0eef4f0c408d559"},{"author":{"_account_id":15254,"name":"rakesh mishra","email":"mishra.rakesh510@gmail.com","username":"mishra.rakesh510"},"change_message_id":"2f1bb8701aa60ca991cb7f8971279bf485816c42","unresolved":false,"context_lines":[{"line_number":10,"context_line":"without sync attribute,function gives error."},{"line_number":11,"context_line":"for more information please have a look into below link"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Full Description https://bugs.launchpad.net/cinder/+bug/1455346"},{"line_number":14,"context_line":"closes-Bug:1455346"},{"line_number":15,"context_line":"Change-Id: I910b5bf8ab936272d793fa8cce9d14e5f1674816"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a016987_ea1b547f","line":13,"in_reply_to":"7a016987_5e435d13","updated":"2015-05-22 03:55:36.000000000","message":"ok, i wil do it","commit_id":"2a74877b770df732506b6714c0eef4f0c408d559"},{"author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"change_message_id":"f95a85bb5676bfad6e8adfb88df3686c7d9d497b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rakesh Mishra \u003cmishra.rakesh510@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-22 11:16:28 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug  :  Not able to create a resource without sync attribute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"description : when user just want to check the limit of quota,"},{"line_number":10,"context_line":"without sync attribute,function gives error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a016987_222cd797","line":7,"updated":"2015-05-23 05:03:54.000000000","message":"The first line should be \u003c\u003d50 chars.","commit_id":"643ace92de6d224c6f12202caa819c223d7d24ef"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bb348f98b11ab16e78e6d51bc3f1cb8359df0649","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rakesh Mishra \u003cmishra.rakesh510@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-22 11:16:28 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug  :  Not able to create a resource without sync attribute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"description : when user just want to check the limit of quota,"},{"line_number":10,"context_line":"without sync attribute,function gives error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a016987_bfb34497","line":7,"updated":"2015-05-23 05:04:57.000000000","message":"You do not need to prefix it with \"Bug : \"","commit_id":"643ace92de6d224c6f12202caa819c223d7d24ef"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bb348f98b11ab16e78e6d51bc3f1cb8359df0649","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug  :  Not able to create a resource without sync attribute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"description : when user just want to check the limit of quota,"},{"line_number":10,"context_line":"without sync attribute,function gives error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a016987_5fa45049","line":9,"updated":"2015-05-23 05:04:57.000000000","message":"You do not need to prefix it with \"description : \".  See https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"643ace92de6d224c6f12202caa819c223d7d24ef"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bb348f98b11ab16e78e6d51bc3f1cb8359df0649","unresolved":false,"context_lines":[{"line_number":10,"context_line":"without sync attribute,function gives error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"closes-Bug:1455346"},{"line_number":14,"context_line":"Implements: blueprint Adding cinder qutoa to limit per volume size"},{"line_number":15,"context_line":"Change-Id: I910b5bf8ab936272d793fa8cce9d14e5f1674816"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a016987_9f0ac824","line":13,"updated":"2015-05-23 05:04:57.000000000","message":"s/closes-Bug:1455346/Closes-Bug: #1455346","commit_id":"643ace92de6d224c6f12202caa819c223d7d24ef"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"4a349181490aad294b3a86eef9d7da7fc99eae79","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"closes-Bug:1455346"},{"line_number":14,"context_line":"Implements: blueprint Adding cinder qutoa to limit per volume size"},{"line_number":15,"context_line":"Change-Id: I910b5bf8ab936272d793fa8cce9d14e5f1674816"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a016987_5000ba01","line":14,"updated":"2015-05-24 07:15:22.000000000","message":"I think here you should use \"cinder-quota-define-per-volume\", if you really want to Implement blueprint.","commit_id":"643ace92de6d224c6f12202caa819c223d7d24ef"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bb348f98b11ab16e78e6d51bc3f1cb8359df0649","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"closes-Bug:1455346"},{"line_number":14,"context_line":"Implements: blueprint Adding cinder qutoa to limit per volume size"},{"line_number":15,"context_line":"Change-Id: I910b5bf8ab936272d793fa8cce9d14e5f1674816"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a016987_df6e00ff","line":14,"updated":"2015-05-23 05:04:57.000000000","message":"Not a blueprint if you are fixing a bug.  Should remove this line.","commit_id":"643ace92de6d224c6f12202caa819c223d7d24ef"}],"cinder/quota.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bca2a9f07cccdac95b42875717041c264e2253db","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        \"\"\""},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        super(ReservableResource, self).__init__(name, flag\u003dflag)"},{"line_number":526,"context_line":"        if(sync):"},{"line_number":527,"context_line":"            self.sync \u003d sync"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_ae746d35","line":526,"updated":"2015-05-20 22:33:30.000000000","message":"so self.sync can never be set to False ?\n\nAlso the () isn\u0027t needed.","commit_id":"2a74877b770df732506b6714c0eef4f0c408d559"},{"author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"change_message_id":"994c116df63d2851a0b9482fecf0d3e518242546","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        \"\"\""},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        super(ReservableResource, self).__init__(name, flag\u003dflag)"},{"line_number":526,"context_line":"        if(sync):"},{"line_number":527,"context_line":"            self.sync \u003d sync"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_45070fca","line":526,"in_reply_to":"7a016987_025d9078","updated":"2015-05-21 09:41:26.000000000","message":"better remove ()","commit_id":"2a74877b770df732506b6714c0eef4f0c408d559"},{"author":{"_account_id":15254,"name":"rakesh mishra","email":"mishra.rakesh510@gmail.com","username":"mishra.rakesh510"},"change_message_id":"c4c5ecbd3b5260e474ed6fa94e019e336f0fa96a","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        \"\"\""},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        super(ReservableResource, self).__init__(name, flag\u003dflag)"},{"line_number":526,"context_line":"        if(sync):"},{"line_number":527,"context_line":"            self.sync \u003d sync"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_025d9078","line":526,"in_reply_to":"7a016987_ae746d35","updated":"2015-05-21 06:08:42.000000000","message":"self.sync is not for True or False flag.\nthis is for the sync attribute exist or not.\n\nplease see the definition of  _get_quotas function in quota.py file\n\n\"\"\"\nif has_sync:\n            sync_filt \u003d lambda x: hasattr(x, \u0027sync\u0027)\n        else:\n            sync_filt \u003d lambda x: not hasattr(x, \u0027sync\u0027)\n        desired \u003d set(keys)\n        sub_resources \u003d dict((k, v) for k, v in resources.items()\n                             if k in desired and sync_filt(v))\n\"\"\"\nplease have a look into the bug description for more clarification \nBug ID : 1455346 \n\n\nin the if condition \u0027()\u0027 don\u0027t affect to code or pep8, we already have used if with \u0027()\u0027  at several places.[for single condition]","commit_id":"2a74877b770df732506b6714c0eef4f0c408d559"},{"author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"change_message_id":"994c116df63d2851a0b9482fecf0d3e518242546","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        super(ReservableResource, self).__init__(name, flag\u003dflag)"},{"line_number":526,"context_line":"        if(sync):"},{"line_number":527,"context_line":"            self.sync \u003d sync"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"class AbsoluteResource(BaseResource):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_05db5750","line":527,"updated":"2015-05-21 09:41:26.000000000","message":"Why you want to create a resource without sync option?\nWhat is the use-case?","commit_id":"2a74877b770df732506b6714c0eef4f0c408d559"},{"author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"change_message_id":"3392548c6c99a0af823acfe145dec6e023fd3a75","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        super(ReservableResource, self).__init__(name, flag\u003dflag)"},{"line_number":526,"context_line":"        if(sync):"},{"line_number":527,"context_line":"            self.sync \u003d sync"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"class AbsoluteResource(BaseResource):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_45914f46","line":527,"in_reply_to":"7a016987_05db5750","updated":"2015-05-21 09:47:46.000000000","message":"ok, I got it form description.\n\nWhat error you have seen. You haven\u0027t mentioned the error (traceback or error message) in the bug https://bugs.launchpad.net/cinder/+bug/1455346","commit_id":"2a74877b770df732506b6714c0eef4f0c408d559"},{"author":{"_account_id":15254,"name":"rakesh mishra","email":"mishra.rakesh510@gmail.com","username":"mishra.rakesh510"},"change_message_id":"839f71dff15332fe442903f50a682aae4a56437d","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        super(ReservableResource, self).__init__(name, flag\u003dflag)"},{"line_number":526,"context_line":"        if(sync):"},{"line_number":527,"context_line":"            self.sync \u003d sync"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"class AbsoluteResource(BaseResource):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_251f736d","line":527,"in_reply_to":"7a016987_45914f46","updated":"2015-05-21 10:12:42.000000000","message":"i am working on the below blueprint\n\nhttps://blueprints.launchpad.net/cinder/+spec/cinder-quota-define-per-volume\n\nit depends on no sync option because i just want to check per_volume_quota_limit.","commit_id":"2a74877b770df732506b6714c0eef4f0c408d559"}],"cinder/tests/unit/test_quota.py":[{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a66bab36033ef7c924c124126733161ce5aa7c58","unresolved":false,"context_lines":[{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        self.assertEqual(result, 5)"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def test_limit_check(self):"},{"line_number":627,"context_line":"        context \u003d FakeContext(None, None)"},{"line_number":628,"context_line":"        driver \u003d FakeDriver()"},{"line_number":629,"context_line":"        quota_obj \u003d self._make_quota_obj(driver)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_1dde44dd","line":626,"updated":"2015-05-19 11:09:13.000000000","message":"Please make separate test for you test case, this test seems overcomplicated","commit_id":"3fb882d3f1fdd422de3a85b52c1e14b78dcfb88d"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a66bab36033ef7c924c124126733161ce5aa7c58","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                 test_resource3\u003d2,"},{"line_number":656,"context_line":"                 test_resource4\u003d1,),"},{"line_number":657,"context_line":"             None), ])"},{"line_number":658,"context_line":"        self.stubs.Set(cinder.quota.VolumeTypeQuotaEngine,"},{"line_number":659,"context_line":"                       \u0027resources\u0027, test_resources)"},{"line_number":660,"context_line":"        self.stubs.Set(cinder.quota.DbQuotaDriver,"},{"line_number":661,"context_line":"                       \u0027get_project_quotas\u0027, test_get_project_quotas)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_7df53855","line":658,"updated":"2015-05-19 11:09:13.000000000","message":"Please use mock instead stubs","commit_id":"3fb882d3f1fdd422de3a85b52c1e14b78dcfb88d"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bb348f98b11ab16e78e6d51bc3f1cb8359df0649","unresolved":false,"context_lines":[{"line_number":662,"context_line":""},{"line_number":663,"context_line":"        value \u003d {\u0027resource_quota\u0027: 123}"},{"line_number":664,"context_line":"        try:"},{"line_number":665,"context_line":"            cinder.quota.QUOTAS.limit_check(context, project_id\u003d123, **value)"},{"line_number":666,"context_line":"        except Exception as e:"},{"line_number":667,"context_line":"            # quota limit is 100 , so it shoud raise an exception"},{"line_number":668,"context_line":"            self.assertEqual(e.kwargs[\u0027overs\u0027], [\u0027resource_quota\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_021f9b5b","line":665,"updated":"2015-05-23 05:04:57.000000000","message":"If this raises an exception, then you should use self.assertRaises(exception.OverQuota, cinder.quota.QUOTAS.limit_check, context, project_id\u003d123, **value)","commit_id":"643ace92de6d224c6f12202caa819c223d7d24ef"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"4a349181490aad294b3a86eef9d7da7fc99eae79","unresolved":false,"context_lines":[{"line_number":665,"context_line":"            cinder.quota.QUOTAS.limit_check(context, project_id\u003d123, **value)"},{"line_number":666,"context_line":"        except Exception as e:"},{"line_number":667,"context_line":"            # quota limit is 100 , so it shoud raise an exception"},{"line_number":668,"context_line":"            self.assertEqual(e.kwargs[\u0027overs\u0027], [\u0027resource_quota\u0027])"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        value \u003d {\u0027resource_quota\u0027: 55}"},{"line_number":671,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_1305ac0f","line":668,"updated":"2015-05-24 07:15:22.000000000","message":"Here the order of arguments is incorrect. This should be (expected, actual)","commit_id":"643ace92de6d224c6f12202caa819c223d7d24ef"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bb348f98b11ab16e78e6d51bc3f1cb8359df0649","unresolved":false,"context_lines":[{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        value \u003d {\u0027resource_quota\u0027: 55}"},{"line_number":671,"context_line":"        try:"},{"line_number":672,"context_line":"            cinder.quota.QUOTAS.limit_check(context, project_id\u003dNone, **value)"},{"line_number":673,"context_line":"        except Exception as e:"},{"line_number":674,"context_line":"            # quota limit is 100 , and it\u0027s under the limit"},{"line_number":675,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_622e4f8d","line":672,"updated":"2015-05-23 05:04:57.000000000","message":"You do not need to put this in a try/except.  Just validate that a few methods are called, e.g. get_project_quotas.","commit_id":"643ace92de6d224c6f12202caa819c223d7d24ef"}]}