)]}'
{"cinder/db/api.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"15ae5f9c9f5218596d3c565c501151c0c2b6c882","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def service_version_update(context, service_id, values):"},{"line_number":152,"context_line":"    \"\"\"Set the given properties on an service version and update it."},{"line_number":153,"context_line":"    Raises NotFound if service does not exist."},{"line_number":154,"context_line":"    \"\"\""},{"line_number":155,"context_line":"    return IMPL.service_version_update(context, service_id, values)"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a4dcd0f_8da096f5","line":152,"updated":"2015-08-13 03:25:36.000000000","message":"New line after 152","commit_id":"bfc97a593b9b3b4db8cfd25392174a54a65f6f3c"}],"cinder/db/sqlalchemy/migrate_repo/versions/049_add_service_version.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"15ae5f9c9f5218596d3c565c501151c0c2b6c882","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    try:"},{"line_number":46,"context_line":"        service_versions.create()"},{"line_number":47,"context_line":"    except Exception:"},{"line_number":48,"context_line":"        LOG.error(_LE(\"Table |%s| not created!\"), repr(service_versions))"},{"line_number":49,"context_line":"        raise"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1a4dcd0f_edb11a48","line":48,"updated":"2015-08-13 03:25:36.000000000","message":"Remove logging in migrations.  So you don\u0027t need try except here.","commit_id":"bfc97a593b9b3b4db8cfd25392174a54a65f6f3c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"15ae5f9c9f5218596d3c565c501151c0c2b6c882","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    try:"},{"line_number":58,"context_line":"        service_versions.drop()"},{"line_number":59,"context_line":"    except Exception:"},{"line_number":60,"context_line":"        LOG.error(_LE(\"serviceversions table not dropped\"))"},{"line_number":61,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a4dcd0f_cdb21e49","line":60,"updated":"2015-08-13 03:25:36.000000000","message":"Same","commit_id":"bfc97a593b9b3b4db8cfd25392174a54a65f6f3c"}],"cinder/scheduler/rpcapi.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"15ae5f9c9f5218596d3c565c501151c0c2b6c882","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.current_rpc_version \u003d service_version.get(\u0027rpc_current_version\u0027)"},{"line_number":91,"context_line":"        self.object_current_version \u003d service_version.get("},{"line_number":92,"context_line":"            \u0027object_current_version\u0027)"},{"line_number":93,"context_line":"        LOG.debug(\"thangp: cinder-scheduler running rpc_version\u003d%s \""},{"line_number":94,"context_line":"                  \"obj_version\u003d%s\", self.current_rpc_version,"},{"line_number":95,"context_line":"                  self.object_current_version)"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1a4dcd0f_4df4ceef","line":93,"updated":"2015-08-13 03:25:36.000000000","message":"Please remove your name from the message:).","commit_id":"bfc97a593b9b3b4db8cfd25392174a54a65f6f3c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"15ae5f9c9f5218596d3c565c501151c0c2b6c882","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if self.current_rpc_version !\u003d self.RPC_API_VERSION:"},{"line_number":98,"context_line":"            self.BACKWARD_COMPAT_MODE \u003d True"},{"line_number":99,"context_line":"            LOG.debug(\"thangp: cinder-scheduler BACKWARD_COMPAT_MODE set to \""},{"line_number":100,"context_line":"                      \"%s\", self.BACKWARD_COMPAT_MODE)"},{"line_number":101,"context_line":"        else:"},{"line_number":102,"context_line":"            # NOTE(thangp): If this service was restarted and the RPC versions"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a4dcd0f_0ddb267d","line":99,"updated":"2015-08-13 03:25:36.000000000","message":"Here too.","commit_id":"bfc97a593b9b3b4db8cfd25392174a54a65f6f3c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"15ae5f9c9f5218596d3c565c501151c0c2b6c882","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            # than 5 seconds"},{"line_number":114,"context_line":"            if (timeutils.utcnow() - self.service_version_last_updated"},{"line_number":115,"context_line":"                    \u003c datetime.timedelta(seconds\u003d5)):"},{"line_number":116,"context_line":"                LOG.debug(\"thangp: Using cache copy of service_version\")"},{"line_number":117,"context_line":"                return self.service_version"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"            LOG.debug(\"thangp: Refreshing cache copy of service_version\")"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a4dcd0f_ade55238","line":116,"updated":"2015-08-13 03:25:36.000000000","message":"Here","commit_id":"bfc97a593b9b3b4db8cfd25392174a54a65f6f3c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"15ae5f9c9f5218596d3c565c501151c0c2b6c882","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                LOG.debug(\"thangp: Using cache copy of service_version\")"},{"line_number":117,"context_line":"                return self.service_version"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"            LOG.debug(\"thangp: Refreshing cache copy of service_version\")"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Get the current/pin object and RPC versions"},{"line_number":122,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a4dcd0f_cde0de28","line":119,"updated":"2015-08-13 03:25:36.000000000","message":"Here.  Please remove from all messages.","commit_id":"bfc97a593b9b3b4db8cfd25392174a54a65f6f3c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"15ae5f9c9f5218596d3c565c501151c0c2b6c882","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            version_compat[self.object_current_version])"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # Now that the object is compatible, update its version"},{"line_number":161,"context_line":"        cinder_primitive[\u0027versioned_object.version\u0027] \u003d \\"},{"line_number":162,"context_line":"            version_compat[self.object_current_version]"},{"line_number":163,"context_line":"        # Since the cinder object is already a primitive, the object serialize"},{"line_number":164,"context_line":"        # will not have to serialize it"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a4dcd0f_6d398aa3","line":161,"updated":"2015-08-13 03:25:36.000000000","message":"Use () instead of \\","commit_id":"bfc97a593b9b3b4db8cfd25392174a54a65f6f3c"}],"cinder/service.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"15ae5f9c9f5218596d3c565c501151c0c2b6c882","unresolved":false,"context_lines":[{"line_number":169,"context_line":"              \u0027Available object version - %s. \u0027"},{"line_number":170,"context_line":"              \u0027Current (pinned) object version - %s.\u0027,"},{"line_number":171,"context_line":"              service_id, rpc_available_version, rpc_current_version,"},{"line_number":172,"context_line":"              object_available_version, object_current_version)"},{"line_number":173,"context_line":"    return service_version"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1a4dcd0f_8d63b6b0","line":172,"updated":"2015-08-13 03:25:36.000000000","message":"If you are going to keep this message, please remove your name and use string interpolation.","commit_id":"bfc97a593b9b3b4db8cfd25392174a54a65f6f3c"}],"cinder/volume/rpcapi.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"15ae5f9c9f5218596d3c565c501151c0c2b6c882","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                # Return the cache copy of service_version if it is not older"},{"line_number":144,"context_line":"                # than 5 seconds"},{"line_number":145,"context_line":"                if (timeutils.utcnow() - self.service_version_last_updated"},{"line_number":146,"context_line":"                        \u003c datetime.timedelta(seconds\u003d5)):"},{"line_number":147,"context_line":"                    LOG.debug(\"thangp: Using cache copy of service_version\")"},{"line_number":148,"context_line":"                    return self.service_version"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1a4dcd0f_ad6a327f","line":146,"updated":"2015-08-13 03:25:36.000000000","message":"Should this 5 seconds be hard-coded?","commit_id":"bfc97a593b9b3b4db8cfd25392174a54a65f6f3c"}]}
