)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"024d14c75f9dba585e0e35259e4ae4dcea9622dd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Liu Xinguo \u003c295988511@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-20 19:19:48 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix a bug in brocade driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Brocade driver does not handle switch data correctly."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_ef1dcd62","line":7,"updated":"2015-05-20 14:36:51.000000000","message":"Please update this to be more descriptive of what the actual problem is. Maybe something along the lines of:\n\n    Brocade driver not parsing zone data correctly\n\n    There is an error in the parsing of zone information in the Brocade zone\n    manager driver. This patch ensures the zone information is correctly parsed.\n\n\nSee here for more guidelines around writing good commit messages:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"4a32af9885c05f1b102c3f05386fe3158354dcaf"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f6c0238437a19ee55ffc0c9df9ecc40ff268dbfe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Liu Xinguo \u003c295988511@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-20 19:19:48 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix a bug in brocade driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Brocade driver does not handle switch data correctly."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_d058118d","line":7,"in_reply_to":"7a016987_ef1dcd62","updated":"2015-05-26 01:27:31.000000000","message":"+1","commit_id":"4a32af9885c05f1b102c3f05386fe3158354dcaf"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"7d586db5125d2c86dc5500c3fde20e7125a2bbfa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Liu Xinguo \u003c295988511@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-20 19:19:48 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix a bug in brocade driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Brocade driver does not handle switch data correctly."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_c58bffc1","line":7,"in_reply_to":"7a016987_ef1dcd62","updated":"2015-05-26 04:07:48.000000000","message":"Done","commit_id":"4a32af9885c05f1b102c3f05386fe3158354dcaf"}],"cinder/zonemanager/drivers/brocade/brcd_fc_zone_client_cli.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"024d14c75f9dba585e0e35259e4ae4dcea9622dd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    if line_split[1]:"},{"line_number":98,"context_line":"                        zone_name \u003d line_split[1]"},{"line_number":99,"context_line":"                        zone[zone_name] \u003d list()"},{"line_number":100,"context_line":"                        zone_member \u003d None"},{"line_number":101,"context_line":"                    if line_split[2]:"},{"line_number":102,"context_line":"                        zone_member \u003d line_split[2]"},{"line_number":103,"context_line":"                    if zone_member:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_b4604c02","line":100,"updated":"2015-05-20 14:36:51.000000000","message":"I think it would be cleaner/safer if zone_member, zone_name, and zone_set_name were just moved from lines 74-77 (excluding switch_data) and put at the start of the for loop on line 86. So every time through the loop these values are set to None since they are really used each time independently of other iterations.","commit_id":"4a32af9885c05f1b102c3f05386fe3158354dcaf"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"7d586db5125d2c86dc5500c3fde20e7125a2bbfa","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    if line_split[1]:"},{"line_number":98,"context_line":"                        zone_name \u003d line_split[1]"},{"line_number":99,"context_line":"                        zone[zone_name] \u003d list()"},{"line_number":100,"context_line":"                        zone_member \u003d None"},{"line_number":101,"context_line":"                    if line_split[2]:"},{"line_number":102,"context_line":"                        zone_member \u003d line_split[2]"},{"line_number":103,"context_line":"                    if zone_member:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_813da9bd","line":100,"in_reply_to":"7a016987_70227d03","updated":"2015-05-26 04:07:48.000000000","message":"Thanks, please see my new patch.","commit_id":"4a32af9885c05f1b102c3f05386fe3158354dcaf"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f6c0238437a19ee55ffc0c9df9ecc40ff268dbfe","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    if line_split[1]:"},{"line_number":98,"context_line":"                        zone_name \u003d line_split[1]"},{"line_number":99,"context_line":"                        zone[zone_name] \u003d list()"},{"line_number":100,"context_line":"                        zone_member \u003d None"},{"line_number":101,"context_line":"                    if line_split[2]:"},{"line_number":102,"context_line":"                        zone_member \u003d line_split[2]"},{"line_number":103,"context_line":"                    if zone_member:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_70227d03","line":100,"in_reply_to":"7a016987_b4604c02","updated":"2015-05-26 01:27:31.000000000","message":"Good suggestion. zone_set_name is still used on line 107, outside of the for loop, so this one still needs to be declared outside of the for loop. The other two zone_member and zone_name are only used inside the loop and can be set to None in the beginning of the for loop.","commit_id":"4a32af9885c05f1b102c3f05386fe3158354dcaf"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"7d586db5125d2c86dc5500c3fde20e7125a2bbfa","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    if line_split[1]:"},{"line_number":98,"context_line":"                        zone_name \u003d line_split[1]"},{"line_number":99,"context_line":"                        zone[zone_name] \u003d list()"},{"line_number":100,"context_line":"                        zone_member \u003d None"},{"line_number":101,"context_line":"                    if line_split[2]:"},{"line_number":102,"context_line":"                        zone_member \u003d line_split[2]"},{"line_number":103,"context_line":"                    if zone_member:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4130d1e8","line":100,"in_reply_to":"7a016987_b4604c02","updated":"2015-05-26 04:07:48.000000000","message":"Thanks, I have updated this patch, please check it.","commit_id":"4a32af9885c05f1b102c3f05386fe3158354dcaf"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"ad4ffb7301708d46dfb5b97f837239bd78c95d74","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                        zone_member \u003d None"},{"line_number":101,"context_line":"                    if line_split[2]:"},{"line_number":102,"context_line":"                        zone_member \u003d line_split[2]"},{"line_number":103,"context_line":"                    if zone_member:"},{"line_number":104,"context_line":"                        zone_member_list \u003d zone.get(zone_name)"},{"line_number":105,"context_line":"                        zone_member_list.append(zone_member)"},{"line_number":106,"context_line":"            zone_set[ZoneConstant.CFG_ZONES] \u003d zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_179dd409","line":103,"updated":"2015-05-21 03:42:10.000000000","message":"\"if zone_member\" condition check seems no necessary. Because \"if line_split[2]\" is TRUE, \"if zone_member\" must be also TRUE. These two sections could combine together.","commit_id":"4a32af9885c05f1b102c3f05386fe3158354dcaf"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"7d586db5125d2c86dc5500c3fde20e7125a2bbfa","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                        zone_member \u003d None"},{"line_number":101,"context_line":"                    if line_split[2]:"},{"line_number":102,"context_line":"                        zone_member \u003d line_split[2]"},{"line_number":103,"context_line":"                    if zone_member:"},{"line_number":104,"context_line":"                        zone_member_list \u003d zone.get(zone_name)"},{"line_number":105,"context_line":"                        zone_member_list.append(zone_member)"},{"line_number":106,"context_line":"            zone_set[ZoneConstant.CFG_ZONES] \u003d zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_0178998e","line":103,"in_reply_to":"7a016987_179dd409","updated":"2015-05-26 04:07:48.000000000","message":"Yes, I think it would be ok to combine them.","commit_id":"4a32af9885c05f1b102c3f05386fe3158354dcaf"}]}