)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds VF support with HTTPS southbound connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enhances the driver and look-up service to set the VFID\tcontext"},{"line_number":10,"context_line":"context to support any virtual fabric configured in the chassis."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The zone driver and look-up service will read the fabric configuration"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba3cc151_cc581b34","line":9,"updated":"2015-07-08 14:26:55.000000000","message":"Extra \"context\" and strange characters here.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds VF support with HTTPS southbound connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enhances the driver and look-up service to set the VFID\tcontext"},{"line_number":10,"context_line":"context to support any virtual fabric configured in the chassis."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The zone driver and look-up service will read the fabric configuration"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba3cc151_12f6f15c","line":9,"in_reply_to":"ba3cc151_cc581b34","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6e382d4089f979f61b188fe60eb524d6ff4b5e8b","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Marked \u0027principal_switch_wwn\u0027 parameter from the config options as"},{"line_number":12,"context_line":"deprecated."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint brocade-zone-driver-virtualfabrics-support"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0b40b520580eaa6821c0af29abc6d2497d884ad2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"7a740942_cf1faf6a","line":13,"updated":"2015-12-07 16:36:14.000000000","message":"I think this should also have a DocImpact flag.","commit_id":"90f66a919af3a6b9a4977246bf658eec82a4fba1"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"313bbe49c48b8780c909ecbd2577d9986f7409dd","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Marked \u0027principal_switch_wwn\u0027 parameter from the config options as"},{"line_number":12,"context_line":"deprecated."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint brocade-zone-driver-virtualfabrics-support"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0b40b520580eaa6821c0af29abc6d2497d884ad2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"7a740942_e74a3cac","line":13,"in_reply_to":"7a740942_cf1faf6a","updated":"2015-12-10 00:10:27.000000000","message":"Done","commit_id":"90f66a919af3a6b9a4977246bf658eec82a4fba1"}],"cinder/exception.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"8e0350e96f3f47e6978d5fac37dbd2867b044501","unresolved":false,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"class VolumeGroupNotFound(CinderException):"},{"line_number":697,"context_line":"    message \u003d _(\u0027Unable to find Volume Group: %(vg_name)s\u0027)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class VolumeGroupCreationFailed(CinderException):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a1a9d01_56ec0e8f","line":697,"updated":"2015-10-02 01:18:18.000000000","message":"\".\" at EOL","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"bc1ed90ff7a4ada14451438b6dc55c5155e2d96c","unresolved":false,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"class VolumeGroupNotFound(CinderException):"},{"line_number":697,"context_line":"    message \u003d _(\u0027Unable to find Volume Group: %(vg_name)s\u0027)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class VolumeGroupCreationFailed(CinderException):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a2fa921_042402ad","line":697,"in_reply_to":"9a1a9d01_05a4ecb6","updated":"2015-10-08 18:42:17.000000000","message":"There is a mix of single quote and double quote usage in this file.  Since this is not an exception that is being added as part of this code change, not sure why I\u0027m being asked to modify this now.  I would prefer to leave this exception as defined.  If cleanup is required, it can be done in a different code review.","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"bc1ed90ff7a4ada14451438b6dc55c5155e2d96c","unresolved":false,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"class VolumeGroupNotFound(CinderException):"},{"line_number":697,"context_line":"    message \u003d _(\u0027Unable to find Volume Group: %(vg_name)s\u0027)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class VolumeGroupCreationFailed(CinderException):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a2fa921_c1d7dcbd","line":697,"in_reply_to":"9a1a9d01_56ec0e8f","updated":"2015-10-08 18:42:17.000000000","message":"I find that there are many exception definitions that do not contain a \u0027.\u0027 at the end of the message, so I do not feel it warranted to modify this.  Also, this exception is not being added as part of this code change, so not sure why I\u0027m being asked to modify this.  I would prefer to leave these exceptions as defined.  If cleanup is required, it can be done in a different code review.","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"0abffb36ecfbc45feba2cbbe05ad7009e60de3c5","unresolved":false,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"class VolumeGroupNotFound(CinderException):"},{"line_number":697,"context_line":"    message \u003d _(\u0027Unable to find Volume Group: %(vg_name)s\u0027)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class VolumeGroupCreationFailed(CinderException):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a1a9d01_05a4ecb6","line":697,"in_reply_to":"9a1a9d01_56ec0e8f","updated":"2015-10-03 10:07:29.000000000","message":"to maintain consistency, please use double quote","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"8e0350e96f3f47e6978d5fac37dbd2867b044501","unresolved":false,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class VolumeGroupCreationFailed(CinderException):"},{"line_number":701,"context_line":"    message \u003d _(\u0027Failed to create Volume Group: %(vg_name)s\u0027)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"class VolumeDeviceNotFound(CinderException):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a1a9d01_16ff7635","line":701,"updated":"2015-10-02 01:18:18.000000000","message":"\".\" at EOL","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"bc1ed90ff7a4ada14451438b6dc55c5155e2d96c","unresolved":false,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class VolumeGroupCreationFailed(CinderException):"},{"line_number":701,"context_line":"    message \u003d _(\u0027Failed to create Volume Group: %(vg_name)s\u0027)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"class VolumeDeviceNotFound(CinderException):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a2fa921_44519a0d","line":701,"in_reply_to":"9a1a9d01_16ff7635","updated":"2015-10-08 18:42:17.000000000","message":"ditto ^^^","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"0abffb36ecfbc45feba2cbbe05ad7009e60de3c5","unresolved":false,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class VolumeGroupCreationFailed(CinderException):"},{"line_number":701,"context_line":"    message \u003d _(\u0027Failed to create Volume Group: %(vg_name)s\u0027)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"class VolumeDeviceNotFound(CinderException):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a1a9d01_a5aae083","line":701,"in_reply_to":"9a1a9d01_16ff7635","updated":"2015-10-03 10:07:29.000000000","message":"to maintain consistency, please use double quote","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"bc1ed90ff7a4ada14451438b6dc55c5155e2d96c","unresolved":false,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class VolumeGroupCreationFailed(CinderException):"},{"line_number":701,"context_line":"    message \u003d _(\u0027Failed to create Volume Group: %(vg_name)s\u0027)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"class VolumeDeviceNotFound(CinderException):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a2fa921_a442ee3c","line":701,"in_reply_to":"9a1a9d01_a5aae083","updated":"2015-10-08 18:42:17.000000000","message":"ditto ^^^","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"}],"cinder/tests/unit/zonemanager/test_brcd_fc_san_lookup_service.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    (c) Copyright 2014 Brocade Communications Systems Inc."},{"line_number":2,"context_line":"#    All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_6cb0ef43","line":3,"updated":"2015-07-08 14:26:55.000000000","message":"Existing copyrights should not be removed normally.\n\nAttribution to the OpenStack Foundation should only be used if code was written by someone working for the foundation, so if this was originally added incorrectly and you are just cleaning it up that should be fine.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    (c) Copyright 2014 Brocade Communications Systems Inc."},{"line_number":2,"context_line":"#    All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_af84825d","line":3,"in_reply_to":"ba3cc151_6cb0ef43","updated":"2015-07-09 09:06:10.000000000","message":"It was added incorrectly, thats the reason it is removed in this review","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"}],"cinder/tests/unit/zonemanager/test_brcd_fc_zone_client_cli.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from cinder import exception"},{"line_number":26,"context_line":"from cinder import test"},{"line_number":27,"context_line":"from cinder.zonemanager.drivers.brocade.brcd_fc_zone_client_cli import ("},{"line_number":28,"context_line":"    BrcdFCZoneClientCLI)"},{"line_number":29,"context_line":"import cinder.zonemanager.drivers.brocade.fc_zone_constants as ZoneConstant"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_4c8acb65","line":28,"updated":"2015-07-08 14:26:55.000000000","message":"Please only import modules, not classes. And if you want to clean up the ZoneConstant import as well that would be bonus.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from cinder import exception"},{"line_number":26,"context_line":"from cinder import test"},{"line_number":27,"context_line":"from cinder.zonemanager.drivers.brocade.brcd_fc_zone_client_cli import ("},{"line_number":28,"context_line":"    BrcdFCZoneClientCLI)"},{"line_number":29,"context_line":"import cinder.zonemanager.drivers.brocade.fc_zone_constants as ZoneConstant"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0fb80e10","line":28,"in_reply_to":"ba3cc151_4c8acb65","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinder import exception"},{"line_number":26,"context_line":"from cinder import test"},{"line_number":27,"context_line":"from cinder.zonemanager.drivers.brocade import brcd_fc_zone_client_cli \\"},{"line_number":28,"context_line":"    as client_cli"},{"line_number":29,"context_line":"import cinder.zonemanager.drivers.brocade.fc_zone_constants as zone_constant"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_8465caaf","line":27,"updated":"2015-07-09 13:25:34.000000000","message":"I\u0027m fairly sure that \u0027\\\u0027 isn\u0027t supposed to be used in openstack anywhere; can you find a different way to continue the line or break it up?","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinder import exception"},{"line_number":26,"context_line":"from cinder import test"},{"line_number":27,"context_line":"from cinder.zonemanager.drivers.brocade import brcd_fc_zone_client_cli \\"},{"line_number":28,"context_line":"    as client_cli"},{"line_number":29,"context_line":"import cinder.zonemanager.drivers.brocade.fc_zone_constants as zone_constant"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_67e0a197","line":27,"in_reply_to":"ba3cc151_1ccc9f33","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0e8708f577f50561798a51da0e263e376f77f745","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinder import exception"},{"line_number":26,"context_line":"from cinder import test"},{"line_number":27,"context_line":"from cinder.zonemanager.drivers.brocade import brcd_fc_zone_client_cli \\"},{"line_number":28,"context_line":"    as client_cli"},{"line_number":29,"context_line":"import cinder.zonemanager.drivers.brocade.fc_zone_constants as zone_constant"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_1ccc9f33","line":27,"in_reply_to":"ba3cc151_8465caaf","updated":"2015-07-09 18:08:32.000000000","message":"We\u0027ve had this weird double standard where we\u0027ve allowed \\ in the unit tests but not elsewhere. I would like to see it cleaned up in unit tests too, but I know it is being used in a lot of places currently.\n\nProbably good to start not allowing new instances to make their way in, but since this is just reformatting the existing line of code I\u0027m OK if this one isn\u0027t addressed.","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"6402ad2a8e053d81013df4e0675293b61a3d5969","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\"Unit tests for brcd fc zone client cli.\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"from mock import patch"},{"line_number":22,"context_line":"from oslo_concurrency import processutils"},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_1d13b067","line":21,"updated":"2015-07-14 14:22:26.000000000","message":"Please  import only modules  http://docs.openstack.org/developer/hacking/#imports","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"512ecef6dd17e5b6edc49740fb6ed33ece6d0851","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\"Unit tests for brcd fc zone client cli.\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"from mock import patch"},{"line_number":22,"context_line":"from oslo_concurrency import processutils"},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_c006981b","line":21,"in_reply_to":"9a41bdd9_1d13b067","updated":"2015-07-15 10:07:29.000000000","message":"Done","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"}],"cinder/tests/unit/zonemanager/test_brcd_fc_zone_driver.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from cinder import test"},{"line_number":30,"context_line":"from cinder.volume import configuration as conf"},{"line_number":31,"context_line":"from cinder.zonemanager.drivers.brocade.brcd_fc_zone_driver \\"},{"line_number":32,"context_line":"    import BrcdFCZoneDriver"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_8cc21384","line":32,"updated":"2015-07-08 14:26:55.000000000","message":"Do not import classes.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from cinder import test"},{"line_number":30,"context_line":"from cinder.volume import configuration as conf"},{"line_number":31,"context_line":"from cinder.zonemanager.drivers.brocade.brcd_fc_zone_driver \\"},{"line_number":32,"context_line":"    import BrcdFCZoneDriver"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_2f75d262","line":32,"in_reply_to":"ba3cc151_8cc21384","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            conn \u003d \u0027cinder.tests.unit.zonemanager.test_brcd_fc_zone_driver\u0027 \\"},{"line_number":125,"context_line":"                   \u0027.FakeBrcdHttpsFCZoneClient\u0027"},{"line_number":126,"context_line":"            pass"},{"line_number":127,"context_line":"        client \u003d importutils.import_object("},{"line_number":128,"context_line":"            conn,"},{"line_number":129,"context_line":"            ipaddress\u003d\"10.24.48.213\","}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0c3da38e","line":126,"updated":"2015-07-08 14:26:55.000000000","message":"pass is not needed here, please remove.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            conn \u003d \u0027cinder.tests.unit.zonemanager.test_brcd_fc_zone_driver\u0027 \\"},{"line_number":125,"context_line":"                   \u0027.FakeBrcdHttpsFCZoneClient\u0027"},{"line_number":126,"context_line":"            pass"},{"line_number":127,"context_line":"        client \u003d importutils.import_object("},{"line_number":128,"context_line":"            conn,"},{"line_number":129,"context_line":"            ipaddress\u003d\"10.24.48.213\","}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_4f493630","line":126,"in_reply_to":"ba3cc151_0c3da38e","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        LOG.info(_LI(\"_zone_state: %s\"), GlobalVars._zone_state)"},{"line_number":238,"context_line":"        self.firmware_supported \u003d True"},{"line_number":239,"context_line":"        if not GlobalVars._is_normal_test:"},{"line_number":240,"context_line":"            raise paramiko.SSHException(\"Unable to connect to fabric\")"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class FakeBrcdHttpsFCZoneClient(FakeClient):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_24a39eb3","line":240,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        LOG.info(_LI(\"_zone_state: %s\"), GlobalVars._zone_state)"},{"line_number":238,"context_line":"        self.firmware_supported \u003d True"},{"line_number":239,"context_line":"        if not GlobalVars._is_normal_test:"},{"line_number":240,"context_line":"            raise paramiko.SSHException(\"Unable to connect to fabric\")"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class FakeBrcdHttpsFCZoneClient(FakeClient):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_07ec3591","line":240,"in_reply_to":"ba3cc151_24a39eb3","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"10e4eb941dba50745d660986b07e9fc7877b78e0","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def get_client(self, protocol\u003d\u0027HTTPS\u0027):"},{"line_number":118,"context_line":"        conn \u003d None"},{"line_number":119,"context_line":"        if(protocol \u003d\u003d \"CLI\"):"},{"line_number":120,"context_line":"            conn \u003d \u0027cinder.tests.unit.zonemanager.test_brcd_fc_zone_driver\u0027 \\"},{"line_number":121,"context_line":"                   \u0027.FakeBrcdFCZoneClientCLI\u0027"},{"line_number":122,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_68c7b345","line":119,"updated":"2015-07-14 03:09:07.000000000","message":"Parentheses not needed and should have a space after \"if\".","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"512ecef6dd17e5b6edc49740fb6ed33ece6d0851","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def get_client(self, protocol\u003d\u0027HTTPS\u0027):"},{"line_number":118,"context_line":"        conn \u003d None"},{"line_number":119,"context_line":"        if(protocol \u003d\u003d \"CLI\"):"},{"line_number":120,"context_line":"            conn \u003d \u0027cinder.tests.unit.zonemanager.test_brcd_fc_zone_driver\u0027 \\"},{"line_number":121,"context_line":"                   \u0027.FakeBrcdFCZoneClientCLI\u0027"},{"line_number":122,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_15fabb75","line":119,"in_reply_to":"9a41bdd9_68c7b345","updated":"2015-07-15 10:07:29.000000000","message":"Used Anton\u0027s suggestion","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"6402ad2a8e053d81013df4e0675293b61a3d5969","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def get_client(self, protocol\u003d\u0027HTTPS\u0027):"},{"line_number":118,"context_line":"        conn \u003d None"},{"line_number":119,"context_line":"        if(protocol \u003d\u003d \"CLI\"):"},{"line_number":120,"context_line":"            conn \u003d \u0027cinder.tests.unit.zonemanager.test_brcd_fc_zone_driver\u0027 \\"},{"line_number":121,"context_line":"                   \u0027.FakeBrcdFCZoneClientCLI\u0027"},{"line_number":122,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_981b4e1b","line":119,"in_reply_to":"9a41bdd9_68c7b345","updated":"2015-07-14 14:22:26.000000000","message":"just suggestion:\nconn \u003d (\u0027cinder.tests.unit.zonemanager.test_brcd_fc_zone_driver.\u0027 +\n                 (\u0027FakeBrcdFCZoneClientCLI\u0027 if protocol \u003d\u003d \"CLI\"\n                  else \u0027FakeBrcdHttpsFCZoneClient\u0027))","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"10e4eb941dba50745d660986b07e9fc7877b78e0","unresolved":false,"context_lines":[{"line_number":233,"context_line":"class FakeBrcdFCZoneClientCLI(FakeClient):"},{"line_number":234,"context_line":"    def __init__(self, ipaddress, username,"},{"line_number":235,"context_line":"                 password, port, key, vfid, protocol):"},{"line_number":236,"context_line":"        LOG.info(_LI(\"User: %s\"), username)"},{"line_number":237,"context_line":"        LOG.info(_LI(\"_zone_state: %s\"), GlobalVars._zone_state)"},{"line_number":238,"context_line":"        self.firmware_supported \u003d True"},{"line_number":239,"context_line":"        if not GlobalVars._is_normal_test:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_a8eb7baf","line":236,"updated":"2015-07-14 03:09:07.000000000","message":"Remove logging from unit tests.","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"512ecef6dd17e5b6edc49740fb6ed33ece6d0851","unresolved":false,"context_lines":[{"line_number":233,"context_line":"class FakeBrcdFCZoneClientCLI(FakeClient):"},{"line_number":234,"context_line":"    def __init__(self, ipaddress, username,"},{"line_number":235,"context_line":"                 password, port, key, vfid, protocol):"},{"line_number":236,"context_line":"        LOG.info(_LI(\"User: %s\"), username)"},{"line_number":237,"context_line":"        LOG.info(_LI(\"_zone_state: %s\"), GlobalVars._zone_state)"},{"line_number":238,"context_line":"        self.firmware_supported \u003d True"},{"line_number":239,"context_line":"        if not GlobalVars._is_normal_test:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_f5c0772c","line":236,"in_reply_to":"9a41bdd9_a8eb7baf","updated":"2015-07-15 10:07:29.000000000","message":"Done","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"}],"cinder/tests/unit/zonemanager/test_brcd_http_fc_zone_client.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6e382d4089f979f61b188fe60eb524d6ff4b5e8b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder import exception"},{"line_number":21,"context_line":"from cinder import test"},{"line_number":22,"context_line":"from cinder.zonemanager.drivers.brocade import brcd_http_fc_zone_client \\"},{"line_number":23,"context_line":"    as client"},{"line_number":24,"context_line":"import cinder.zonemanager.drivers.brocade.fc_zone_constants as zone_constant"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"7a740942_8c477576","line":22,"updated":"2015-12-07 16:36:14.000000000","message":"We\u0027ve allowed \\ for multiline code in the tests directory, but in general we are trying to get rid of it everywhere. If you have other updates it would be nice to get rid of these. Not a blocking issue though.","commit_id":"90f66a919af3a6b9a4977246bf658eec82a4fba1"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"313bbe49c48b8780c909ecbd2577d9986f7409dd","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder import exception"},{"line_number":21,"context_line":"from cinder import test"},{"line_number":22,"context_line":"from cinder.zonemanager.drivers.brocade import brcd_http_fc_zone_client \\"},{"line_number":23,"context_line":"    as client"},{"line_number":24,"context_line":"import cinder.zonemanager.drivers.brocade.fc_zone_constants as zone_constant"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"7a740942_87c6d814","line":22,"in_reply_to":"7a740942_8c477576","updated":"2015-12-10 00:10:27.000000000","message":"Done","commit_id":"90f66a919af3a6b9a4977246bf658eec82a4fba1"}],"cinder/tests/unit/zonemanager/test_brcd_https_fc_zone_client.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    (c) Copyright 2015 Brocade Communications Systems Inc.\r"},{"line_number":2,"context_line":"#    All Rights Reserved.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_ac0b57d4","line":1,"updated":"2015-07-08 14:26:55.000000000","message":"Remove carriage return (\\r) characters.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    (c) Copyright 2015 Brocade Communications Systems Inc.\r"},{"line_number":2,"context_line":"#    All Rights Reserved.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_6f243a5f","line":1,"in_reply_to":"ba3cc151_ac0b57d4","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from cinder import exception\r"},{"line_number":24,"context_line":"from cinder import test\r"},{"line_number":25,"context_line":"from cinder.zonemanager.drivers.brocade.brcd_https_fc_zone_client import (\r"},{"line_number":26,"context_line":"    BrcdHttpsFCZoneClient)\r"},{"line_number":27,"context_line":"import cinder.zonemanager.drivers.brocade.fc_zone_constants as ZoneConstant\r"},{"line_number":28,"context_line":"\r"},{"line_number":29,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_ec2cff4b","line":26,"updated":"2015-07-08 14:26:55.000000000","message":"Do not import classes.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from cinder import exception\r"},{"line_number":24,"context_line":"from cinder import test\r"},{"line_number":25,"context_line":"from cinder.zonemanager.drivers.brocade.brcd_https_fc_zone_client import (\r"},{"line_number":26,"context_line":"    BrcdHttpsFCZoneClient)\r"},{"line_number":27,"context_line":"import cinder.zonemanager.drivers.brocade.fc_zone_constants as ZoneConstant\r"},{"line_number":28,"context_line":"\r"},{"line_number":29,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_cf31c6a3","line":26,"in_reply_to":"ba3cc151_ec2cff4b","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"10e4eb941dba50745d660986b07e9fc7877b78e0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from mock import patch"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from cinder import exception"},{"line_number":24,"context_line":"from cinder import test"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_48d3cf04","line":21,"updated":"2015-07-14 03:09:07.000000000","message":"Do not perform logging in unit tests.","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"512ecef6dd17e5b6edc49740fb6ed33ece6d0851","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from mock import patch"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from cinder import exception"},{"line_number":24,"context_line":"from cinder import test"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_b52f4ff5","line":21,"in_reply_to":"9a41bdd9_48d3cf04","updated":"2015-07-15 10:07:29.000000000","message":"Done","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"6402ad2a8e053d81013df4e0675293b61a3d5969","unresolved":false,"context_lines":[{"line_number":622,"context_line":"        self.qlps \u003d qlps.copy()"},{"line_number":623,"context_line":"        self.ifas \u003d ifas.copy()"},{"line_number":624,"context_line":"        self.active_cfg \u003d active_cfg"},{"line_number":625,"context_line":"        add_zones_info \u003d {\u0027openstack50060b0000c26604201900051ee8e329\u0027:"},{"line_number":626,"context_line":"                          [\u002750:06:0b:00:00:c2:66:04\u0027,"},{"line_number":627,"context_line":"                              \u002720:19:00:05:1e:e8:e3:29\u0027]"},{"line_number":628,"context_line":"                          }"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_f8f4da87","line":625,"updated":"2015-07-14 14:22:26.000000000","message":"A lot of tests use it, I think you should make it common","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"512ecef6dd17e5b6edc49740fb6ed33ece6d0851","unresolved":false,"context_lines":[{"line_number":622,"context_line":"        self.qlps \u003d qlps.copy()"},{"line_number":623,"context_line":"        self.ifas \u003d ifas.copy()"},{"line_number":624,"context_line":"        self.active_cfg \u003d active_cfg"},{"line_number":625,"context_line":"        add_zones_info \u003d {\u0027openstack50060b0000c26604201900051ee8e329\u0027:"},{"line_number":626,"context_line":"                          [\u002750:06:0b:00:00:c2:66:04\u0027,"},{"line_number":627,"context_line":"                              \u002720:19:00:05:1e:e8:e3:29\u0027]"},{"line_number":628,"context_line":"                          }"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_cddecc10","line":625,"in_reply_to":"9a41bdd9_f8f4da87","updated":"2015-07-15 10:07:29.000000000","message":"Done","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"}],"cinder/tests/unit/zonemanager/test_brcd_lookup_service.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from cinder import exception"},{"line_number":22,"context_line":"from cinder import test"},{"line_number":23,"context_line":"from cinder.volume import configuration as conf"},{"line_number":24,"context_line":"from cinder.zonemanager.fc_san_lookup_service import FCSanLookupService"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_ccb57bed","line":24,"updated":"2015-07-08 14:26:55.000000000","message":"Change back.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from cinder import exception"},{"line_number":22,"context_line":"from cinder import test"},{"line_number":23,"context_line":"from cinder.volume import configuration as conf"},{"line_number":24,"context_line":"from cinder.zonemanager.fc_san_lookup_service import FCSanLookupService"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_afbc82dc","line":24,"in_reply_to":"ba3cc151_ccb57bed","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"}],"cinder/zonemanager/drivers/brocade/brcd_fabric_opts.py":[{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from cinder.volume.configuration import Configuration"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"brcd_zone_opts \u003d ["},{"line_number":22,"context_line":"    cfg.StrOpt(\u0027fc_southbound_connector\u0027,"},{"line_number":23,"context_line":"               default\u003dNone,"},{"line_number":24,"context_line":"               help\u003d\u0027South bound connector for the fabric\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027fc_secure\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_ffe87f18","line":22,"updated":"2015-06-01 22:20:56.000000000","message":"Can we name this as fc_southbound_protocol?  Otherwise, this is likely to confuse the user with other zonemanager config option for brcd_sb_connector.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from cinder.volume.configuration import Configuration"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"brcd_zone_opts \u003d ["},{"line_number":22,"context_line":"    cfg.StrOpt(\u0027fc_southbound_connector\u0027,"},{"line_number":23,"context_line":"               default\u003dNone,"},{"line_number":24,"context_line":"               help\u003d\u0027South bound connector for the fabric\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027fc_secure\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_74daf14d","line":22,"in_reply_to":"5afe65bd_ffe87f18","updated":"2015-06-04 12:06:28.000000000","message":"Done","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"brcd_zone_opts \u003d ["},{"line_number":22,"context_line":"    cfg.StrOpt(\u0027fc_southbound_connector\u0027,"},{"line_number":23,"context_line":"               default\u003dNone,"},{"line_number":24,"context_line":"               help\u003d\u0027South bound connector for the fabric\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027fc_secure\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"},{"line_number":27,"context_line":"                help\u003d\u0027Fabric Connection mode\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_f3be73d3","line":24,"updated":"2015-06-01 22:20:56.000000000","message":"Should include options tag listing SSH, HTTP, HTTPS as the options for this config option.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"brcd_zone_opts \u003d ["},{"line_number":22,"context_line":"    cfg.StrOpt(\u0027fc_southbound_connector\u0027,"},{"line_number":23,"context_line":"               default\u003dNone,"},{"line_number":24,"context_line":"               help\u003d\u0027South bound connector for the fabric\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027fc_secure\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"},{"line_number":27,"context_line":"                help\u003d\u0027Fabric Connection mode\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_54db754f","line":24,"in_reply_to":"5afe65bd_f3be73d3","updated":"2015-06-04 12:06:28.000000000","message":"Done","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"               help\u003d\u0027South bound connector for the fabric\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027fc_secure\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"},{"line_number":27,"context_line":"                help\u003d\u0027Fabric Connection mode\u0027),"},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027fc_fabric_address\u0027,"},{"line_number":29,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":30,"context_line":"               help\u003d\u0027Management IP of fabric\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_7f680fbb","line":27,"updated":"2015-06-01 22:20:56.000000000","message":"What is fc_secure used for?  The help description doesn\u0027t clarify this at all.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"               help\u003d\u0027South bound connector for the fabric\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027fc_secure\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"},{"line_number":27,"context_line":"                help\u003d\u0027Fabric Connection mode\u0027),"},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027fc_fabric_address\u0027,"},{"line_number":29,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":30,"context_line":"               help\u003d\u0027Management IP of fabric\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_d4ef65e7","line":27,"in_reply_to":"5afe65bd_7f680fbb","updated":"2015-06-04 12:06:28.000000000","message":"This parameter is removed as it is no longer required.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"               help\u003d\u0027Local SSH certificate Path\u0027),"},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027fc_fabric_port\u0027,"},{"line_number":42,"context_line":"               default\u003d22,"},{"line_number":43,"context_line":"               help\u003d\u0027Connecting port\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027zoning_policy\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027initiator-target\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027overridden zoning policy\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_b3247baf","line":43,"updated":"2015-06-01 22:20:56.000000000","message":"does this apply to HTTPs as well as SSH?  Is HTTPs port configurable on the switch?  If not, help text should be updated to indicate this is only for SSH.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"               help\u003d\u0027Local SSH certificate Path\u0027),"},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027fc_fabric_port\u0027,"},{"line_number":42,"context_line":"               default\u003d22,"},{"line_number":43,"context_line":"               help\u003d\u0027Connecting port\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027zoning_policy\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027initiator-target\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027overridden zoning policy\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_94bc4ddd","line":43,"in_reply_to":"5afe65bd_b3247baf","updated":"2015-06-04 12:06:28.000000000","message":"Done","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.StrOpt(\u0027zone_name_prefix\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027openstack\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027overridden zone name prefix\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027fc_virtual_fabric_id\u0027,"},{"line_number":54,"context_line":"               default\u003dNone,"},{"line_number":55,"context_line":"               help\u003d\u0027Virtual fabric ID\u0027),"},{"line_number":56,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_5fdaf379","line":53,"updated":"2015-06-01 22:20:56.000000000","message":"I see you are removing the principal_switch_wwn config option.  You should document in the commit message that this is no longer used and that\u0027s why it\u0027s being removed.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.StrOpt(\u0027zone_name_prefix\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027openstack\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027overridden zone name prefix\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027fc_virtual_fabric_id\u0027,"},{"line_number":54,"context_line":"               default\u003dNone,"},{"line_number":55,"context_line":"               help\u003d\u0027Virtual fabric ID\u0027),"},{"line_number":56,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_54b25507","line":53,"in_reply_to":"5afe65bd_5fdaf379","updated":"2015-06-04 12:06:28.000000000","message":"Done","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"102868d2f197e190738cc65628da56e561cd4f18","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               default\u003dNone,"},{"line_number":45,"context_line":"               help\u003d\u0027overridden zone name prefix\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027principal_switch_wwn\u0027,"},{"line_number":47,"context_line":"               default\u003dNone,"},{"line_number":48,"context_line":"               help\u003d\u0027Principal switch WWN of the fabric\u0027),"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_94c9fb7b","side":"PARENT","line":47,"updated":"2015-06-22 20:29:33.000000000","message":"AFAIR, we need to depricate config option before removing it","commit_id":"a874f951830e35a2a9080f51e992476e6ebfcd49"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"a7fb8ace56f095787d2ed40aa79a37365d4394a3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               default\u003dNone,"},{"line_number":45,"context_line":"               help\u003d\u0027overridden zone name prefix\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027principal_switch_wwn\u0027,"},{"line_number":47,"context_line":"               default\u003dNone,"},{"line_number":48,"context_line":"               help\u003d\u0027Principal switch WWN of the fabric\u0027),"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_1085a2cd","side":"PARENT","line":47,"in_reply_to":"fa32b979_94c9fb7b","updated":"2015-06-24 12:03:49.000000000","message":"Done","commit_id":"a874f951830e35a2a9080f51e992476e6ebfcd49"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":"from oslo_log import log as logging"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cinder.volume.configuration import Configuration"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"brcd_zone_opts \u003d ["},{"line_number":22,"context_line":"    cfg.StrOpt(\u0027fc_southbound_protocol\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0ca7e3bd","line":19,"updated":"2015-07-08 14:26:55.000000000","message":"Change back.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":"from oslo_log import log as logging"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cinder.volume.configuration import Configuration"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"brcd_zone_opts \u003d ["},{"line_number":22,"context_line":"    cfg.StrOpt(\u0027fc_southbound_protocol\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_6fb2fa07","line":19,"in_reply_to":"ba3cc151_0ca7e3bd","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.IntOpt(\u0027fc_fabric_port\u0027,"},{"line_number":40,"context_line":"               default\u003d22,"},{"line_number":41,"context_line":"               help\u003d\u0027Connecting port. This is applicable only for SSH \u0027"},{"line_number":42,"context_line":"                    \u0027protocol\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027zoning_policy\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027initiator-target\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027overridden zoning policy\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_e4adb684","line":42,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.IntOpt(\u0027fc_fabric_port\u0027,"},{"line_number":40,"context_line":"               default\u003d22,"},{"line_number":41,"context_line":"               help\u003d\u0027Connecting port. This is applicable only for SSH \u0027"},{"line_number":42,"context_line":"                    \u0027protocol\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027zoning_policy\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027initiator-target\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027overridden zoning policy\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_e7ea7174","line":42,"in_reply_to":"ba3cc151_e4adb684","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    cfg.StrOpt(\u0027fc_southbound_protocol\u0027,"},{"line_number":23,"context_line":"               default\u003d\u0027HTTP\u0027,"},{"line_number":24,"context_line":"               choices\u003d(\u0027SSH\u0027, \u0027HTTP\u0027, \u0027HTTPS\u0027),"},{"line_number":25,"context_line":"               help\u003d\u0027South bound connector for the fabric\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027fc_fabric_address\u0027,"},{"line_number":27,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027Management IP of fabric\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_2f3f8ad7","line":25,"updated":"2015-07-21 05:47:41.000000000","message":"For the purpose of consistency please end the help with \".\" like line 42","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    cfg.StrOpt(\u0027fc_southbound_protocol\u0027,"},{"line_number":23,"context_line":"               default\u003d\u0027HTTP\u0027,"},{"line_number":24,"context_line":"               choices\u003d(\u0027SSH\u0027, \u0027HTTP\u0027, \u0027HTTPS\u0027),"},{"line_number":25,"context_line":"               help\u003d\u0027South bound connector for the fabric\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027fc_fabric_address\u0027,"},{"line_number":27,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027Management IP of fabric\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_65e7a711","line":25,"in_reply_to":"3a50d1a3_2f3f8ad7","updated":"2015-07-22 11:39:56.000000000","message":"Done","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                    \u0027protocol.\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027zoning_policy\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027initiator-target\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027overridden zoning policy\u0027),"},{"line_number":46,"context_line":"    cfg.BoolOpt(\u0027zone_activate\u0027,"},{"line_number":47,"context_line":"                default\u003dTrue,"},{"line_number":48,"context_line":"                help\u003d\u0027overridden zoning activation state\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_2f48ea86","line":45,"updated":"2015-07-21 05:47:41.000000000","message":"Capitalize the first char","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                    \u0027protocol.\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027zoning_policy\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027initiator-target\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027overridden zoning policy\u0027),"},{"line_number":46,"context_line":"    cfg.BoolOpt(\u0027zone_activate\u0027,"},{"line_number":47,"context_line":"                default\u003dTrue,"},{"line_number":48,"context_line":"                help\u003d\u0027overridden zoning activation state\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_c5bc7bde","line":45,"in_reply_to":"3a50d1a3_2f48ea86","updated":"2015-07-22 11:39:56.000000000","message":"Done","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               help\u003d\u0027overridden zoning policy\u0027),"},{"line_number":46,"context_line":"    cfg.BoolOpt(\u0027zone_activate\u0027,"},{"line_number":47,"context_line":"                default\u003dTrue,"},{"line_number":48,"context_line":"                help\u003d\u0027overridden zoning activation state\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027zone_name_prefix\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027openstack\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027overridden zone name prefix\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_ef5a0250","line":48,"updated":"2015-07-21 05:47:41.000000000","message":"ditto.","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               help\u003d\u0027overridden zoning policy\u0027),"},{"line_number":46,"context_line":"    cfg.BoolOpt(\u0027zone_activate\u0027,"},{"line_number":47,"context_line":"                default\u003dTrue,"},{"line_number":48,"context_line":"                help\u003d\u0027overridden zoning activation state\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027zone_name_prefix\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027openstack\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027overridden zone name prefix\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_85b2f304","line":48,"in_reply_to":"3a50d1a3_ef5a0250","updated":"2015-07-22 11:39:56.000000000","message":"Done","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                help\u003d\u0027overridden zoning activation state\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027zone_name_prefix\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027openstack\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027overridden zone name prefix\u0027),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027fc_virtual_fabric_id\u0027,"},{"line_number":53,"context_line":"               default\u003dNone,"},{"line_number":54,"context_line":"               help\u003d\u0027Virtual fabric ID\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_af54fa20","line":51,"updated":"2015-07-21 05:47:41.000000000","message":"ditto","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                help\u003d\u0027overridden zoning activation state\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027zone_name_prefix\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027openstack\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027overridden zone name prefix\u0027),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027fc_virtual_fabric_id\u0027,"},{"line_number":53,"context_line":"               default\u003dNone,"},{"line_number":54,"context_line":"               help\u003d\u0027Virtual fabric ID\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_a5b7eff3","line":51,"in_reply_to":"3a50d1a3_af54fa20","updated":"2015-07-22 11:39:56.000000000","message":"Done","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"238916e11bd9303c526a81b8bbee571bd1a0e271","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                help\u003d\u0027Overridden zoning activation state\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027zone_name_prefix\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027openstack\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027Overridden zone name prefix\u0027),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027fc_virtual_fabric_id\u0027,"},{"line_number":53,"context_line":"               default\u003dNone,"},{"line_number":54,"context_line":"               help\u003d\u0027Virtual fabric ID\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_250294b5","line":51,"updated":"2015-07-23 20:52:17.000000000","message":"Please end with a period.","commit_id":"a0e134cf4e1ca039851f27303c5c6e1695c59b05"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"b1e5fc556ce1fbc7d985a2f30d3af4be6645ff91","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                help\u003d\u0027Overridden zoning activation state\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027zone_name_prefix\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027openstack\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027Overridden zone name prefix\u0027),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027fc_virtual_fabric_id\u0027,"},{"line_number":53,"context_line":"               default\u003dNone,"},{"line_number":54,"context_line":"               help\u003d\u0027Virtual fabric ID\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_816f4efb","line":51,"in_reply_to":"3a50d1a3_250294b5","updated":"2015-07-28 09:08:24.000000000","message":"Done","commit_id":"a0e134cf4e1ca039851f27303c5c6e1695c59b05"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e130a57c653060c146733df1273ee49c15515b66","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from cinder.volume import configuration"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"brcd_zone_opts \u003d ["},{"line_number":22,"context_line":"    cfg.StrOpt(\u0027fc_southbound_protocol\u0027,"},{"line_number":23,"context_line":"               default\u003d\u0027HTTP\u0027,"},{"line_number":24,"context_line":"               choices\u003d(\u0027SSH\u0027, \u0027HTTP\u0027, \u0027HTTPS\u0027),"},{"line_number":25,"context_line":"               help\u003d\u0027South bound connector for the fabric.\u0027),"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a29b11f_0b2411ad","line":22,"updated":"2015-10-19 22:42:45.000000000","message":"does fc_client_protocol make it more clear?","commit_id":"4a6d1ee5afd08e3827e1cf9b473b6511142fd94c"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e130a57c653060c146733df1273ee49c15515b66","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    cfg.StrOpt(\u0027fc_southbound_protocol\u0027,"},{"line_number":23,"context_line":"               default\u003d\u0027HTTP\u0027,"},{"line_number":24,"context_line":"               choices\u003d(\u0027SSH\u0027, \u0027HTTP\u0027, \u0027HTTPS\u0027),"},{"line_number":25,"context_line":"               help\u003d\u0027South bound connector for the fabric.\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027fc_fabric_address\u0027,"},{"line_number":27,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027Management IP of fabric.\u0027),"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a29b11f_6b3585d8","line":25,"updated":"2015-10-19 22:42:45.000000000","message":"The protocol used to talk to the FC switch for provisioning requests. ?","commit_id":"4a6d1ee5afd08e3827e1cf9b473b6511142fd94c"}],"cinder/zonemanager/drivers/brocade/brcd_fc_zone_client_cli.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"102868d2f197e190738cc65628da56e561cd4f18","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \"zone_config\u003d%(zone_config)s).\""},{"line_number":111,"context_line":"                    ) % {\u0027switch\u0027: self.switch_ip,"},{"line_number":112,"context_line":"                         \u0027zone_config\u0027: switch_data}"},{"line_number":113,"context_line":"            LOG.error(msg)"},{"line_number":114,"context_line":"            LOG.exception(ex)"},{"line_number":115,"context_line":"            raise exception.FCZoneDriverException(reason\u003dmsg)"},{"line_number":116,"context_line":"        switch_data \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_9477bb3a","line":113,"updated":"2015-06-22 20:29:33.000000000","message":"It is not necessary change. Actually, almost nothing changed in log message","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"a7fb8ace56f095787d2ed40aa79a37365d4394a3","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \"zone_config\u003d%(zone_config)s).\""},{"line_number":111,"context_line":"                    ) % {\u0027switch\u0027: self.switch_ip,"},{"line_number":112,"context_line":"                         \u0027zone_config\u0027: switch_data}"},{"line_number":113,"context_line":"            LOG.error(msg)"},{"line_number":114,"context_line":"            LOG.exception(ex)"},{"line_number":115,"context_line":"            raise exception.FCZoneDriverException(reason\u003dmsg)"},{"line_number":116,"context_line":"        switch_data \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_d04bef29","line":113,"in_reply_to":"fa32b979_9477bb3a","updated":"2015-06-24 12:03:49.000000000","message":"Done","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":541,"context_line":"                channel.close()"},{"line_number":542,"context_line":"            except Exception:"},{"line_number":543,"context_line":"                LOG.exception(_LE(\u0027Error closing channel.\u0027))"},{"line_number":544,"context_line":"            LOG.debug(\"_execute_cmd: stdout to return:%s\" % stdout)"},{"line_number":545,"context_line":"            LOG.debug(\"_execute_cmd: stderr to return: %s\", stderr)"},{"line_number":546,"context_line":"        return (stdout, stderr)"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_ace357d7","line":544,"updated":"2015-07-08 14:26:55.000000000","message":"Pass stdout in to the logger as an argument rather than performing the string formatting in place. See next line.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":541,"context_line":"                channel.close()"},{"line_number":542,"context_line":"            except Exception:"},{"line_number":543,"context_line":"                LOG.exception(_LE(\u0027Error closing channel.\u0027))"},{"line_number":544,"context_line":"            LOG.debug(\"_execute_cmd: stdout to return:%s\" % stdout)"},{"line_number":545,"context_line":"            LOG.debug(\"_execute_cmd: stderr to return: %s\", stderr)"},{"line_number":546,"context_line":"        return (stdout, stderr)"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_efc60a67","line":544,"in_reply_to":"ba3cc151_ace357d7","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":541,"context_line":"                channel.close()"},{"line_number":542,"context_line":"            except Exception:"},{"line_number":543,"context_line":"                LOG.exception(_LE(\u0027Error closing channel.\u0027))"},{"line_number":544,"context_line":"            LOG.debug(\"_execute_cmd: stdout to return: %s\", stdout)"},{"line_number":545,"context_line":"            LOG.debug(\"_execute_cmd: stderr to return: %s\", stderr)"},{"line_number":546,"context_line":"        return (stdout, stderr)"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_ca14d445","line":544,"updated":"2015-07-21 05:47:41.000000000","message":"Consider consolidation of bug statements.","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":541,"context_line":"                channel.close()"},{"line_number":542,"context_line":"            except Exception:"},{"line_number":543,"context_line":"                LOG.exception(_LE(\u0027Error closing channel.\u0027))"},{"line_number":544,"context_line":"            LOG.debug(\"_execute_cmd: stdout to return: %s\", stdout)"},{"line_number":545,"context_line":"            LOG.debug(\"_execute_cmd: stderr to return: %s\", stderr)"},{"line_number":546,"context_line":"        return (stdout, stderr)"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_fe490461","line":544,"in_reply_to":"3a50d1a3_ca14d445","updated":"2015-07-22 11:39:56.000000000","message":"Since the output could be a large, I thought it would be better to have separate log messages.","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"238916e11bd9303c526a81b8bbee571bd1a0e271","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \"zone_config\u003d%(zone_config)s) exception: % (excep)s.\""},{"line_number":111,"context_line":"                    ) % {\u0027switch\u0027: self.switch_ip,"},{"line_number":112,"context_line":"                         \u0027zone_config\u0027: switch_data,"},{"line_number":113,"context_line":"                         \u0027excep\u0027: ex}"},{"line_number":114,"context_line":"            LOG.exception(msg)"},{"line_number":115,"context_line":"            raise exception.FCZoneDriverException(reason\u003dmsg)"},{"line_number":116,"context_line":"        switch_data \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_45c4805e","line":113,"updated":"2015-07-23 20:52:17.000000000","message":"Needs six.text_type around ex, or ex should be removed.\n\nSince you are using LOG.exception below I would say remove the exception from the msg. That will be logged automatically by LOG.exception, so if you think you need it in the actual message text I would say change that to LOG.error instead. My preference would be to remove it from the text though.","commit_id":"a0e134cf4e1ca039851f27303c5c6e1695c59b05"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"b1e5fc556ce1fbc7d985a2f30d3af4be6645ff91","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \"zone_config\u003d%(zone_config)s) exception: % (excep)s.\""},{"line_number":111,"context_line":"                    ) % {\u0027switch\u0027: self.switch_ip,"},{"line_number":112,"context_line":"                         \u0027zone_config\u0027: switch_data,"},{"line_number":113,"context_line":"                         \u0027excep\u0027: ex}"},{"line_number":114,"context_line":"            LOG.exception(msg)"},{"line_number":115,"context_line":"            raise exception.FCZoneDriverException(reason\u003dmsg)"},{"line_number":116,"context_line":"        switch_data \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_415dc645","line":113,"in_reply_to":"3a50d1a3_45c4805e","updated":"2015-07-28 09:08:24.000000000","message":"Done","commit_id":"a0e134cf4e1ca039851f27303c5c6e1695c59b05"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"81101072cb27a3334e72e7d1fe140a647c496b25","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \"zone_config\u003d%(zone_config)s) exception: % (excep)s.\""},{"line_number":111,"context_line":"                    ) % {\u0027switch\u0027: self.switch_ip,"},{"line_number":112,"context_line":"                         \u0027zone_config\u0027: switch_data,"},{"line_number":113,"context_line":"                         \u0027excep\u0027: ex}"},{"line_number":114,"context_line":"            LOG.exception(msg)"},{"line_number":115,"context_line":"            raise exception.FCZoneDriverException(reason\u003dmsg)"},{"line_number":116,"context_line":"        switch_data \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_a60e60e3","line":113,"in_reply_to":"3a50d1a3_45c4805e","updated":"2015-07-26 14:23:23.000000000","message":"good point.\nmore good if we could document it here \"http://docs.openstack.org/developer/oslo.i18n/guidelines.html\".","commit_id":"a0e134cf4e1ca039851f27303c5c6e1695c59b05"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6e382d4089f979f61b188fe60eb524d6ff4b5e8b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \"zone_config\u003d%(zone_config)s) exception: % (excep)s.\""},{"line_number":111,"context_line":"                    ) % {\u0027switch\u0027: self.switch_ip,"},{"line_number":112,"context_line":"                         \u0027zone_config\u0027: switch_data,"},{"line_number":113,"context_line":"                         \u0027excep\u0027: six.text_type(ex)}"},{"line_number":114,"context_line":"            LOG.exception(msg)"},{"line_number":115,"context_line":"            raise exception.FCZoneDriverException(reason\u003dmsg)"},{"line_number":116,"context_line":"        switch_data \u003d None"}],"source_content_type":"text/x-python","patch_set":25,"id":"7a740942_ef606bd1","line":113,"updated":"2015-12-07 16:36:14.000000000","message":"I would actually change this exception block back. LOG.exception will automatically log the exception details, so your log will now have duplicated exception details. And I don\u0027t think we want to bubble up the exception details in the new exception.","commit_id":"90f66a919af3a6b9a4977246bf658eec82a4fba1"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"313bbe49c48b8780c909ecbd2577d9986f7409dd","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \"zone_config\u003d%(zone_config)s) exception: % (excep)s.\""},{"line_number":111,"context_line":"                    ) % {\u0027switch\u0027: self.switch_ip,"},{"line_number":112,"context_line":"                         \u0027zone_config\u0027: switch_data,"},{"line_number":113,"context_line":"                         \u0027excep\u0027: six.text_type(ex)}"},{"line_number":114,"context_line":"            LOG.exception(msg)"},{"line_number":115,"context_line":"            raise exception.FCZoneDriverException(reason\u003dmsg)"},{"line_number":116,"context_line":"        switch_data \u003d None"}],"source_content_type":"text/x-python","patch_set":25,"id":"7a740942_47d0f0c9","line":113,"in_reply_to":"7a740942_ef606bd1","updated":"2015-12-10 00:10:27.000000000","message":"Done","commit_id":"90f66a919af3a6b9a4977246bf658eec82a4fba1"}],"cinder/zonemanager/drivers/brocade/brcd_fc_zone_connector_factory.py":[{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    (c) Copyright 2015 Brocade Communications Systems Inc.\r"},{"line_number":2,"context_line":"#    All Rights Reserved.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain\r"},{"line_number":6,"context_line":"#    a copy of the License at\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_d2e9e01b","line":3,"updated":"2015-06-01 22:20:56.000000000","message":"Please fix this file and remove \\r","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    (c) Copyright 2015 Brocade Communications Systems Inc.\r"},{"line_number":2,"context_line":"#    All Rights Reserved.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain\r"},{"line_number":6,"context_line":"#    a copy of the License at\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_f494a143","line":3,"in_reply_to":"7a016987_d2e9e01b","updated":"2015-06-04 12:06:28.000000000","message":"Done","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"        self.sb_conn_map \u003d {}\r"},{"line_number":33,"context_line":"        self.connectors \u003d {\r"},{"line_number":34,"context_line":"            \"CLI\": \"cinder.zonemanager.drivers.brocade.\"\r"},{"line_number":35,"context_line":"            \"brcd_fc_zone_client_cli.BrcdFCZoneClientCLI\",\r"},{"line_number":36,"context_line":"            \"HTTPS\": \"cinder.zonemanager.drivers.brocade.\"\r"},{"line_number":37,"context_line":"            \"brcd_https_fc_zone_client.BrcdHttpsFCZoneClient\",\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_3369ab8c","line":34,"updated":"2015-06-01 22:20:56.000000000","message":"This should be SSH, not CLI.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"        self.sb_conn_map \u003d {}\r"},{"line_number":33,"context_line":"        self.connectors \u003d {\r"},{"line_number":34,"context_line":"            \"CLI\": \"cinder.zonemanager.drivers.brocade.\"\r"},{"line_number":35,"context_line":"            \"brcd_fc_zone_client_cli.BrcdFCZoneClientCLI\",\r"},{"line_number":36,"context_line":"            \"HTTPS\": \"cinder.zonemanager.drivers.brocade.\"\r"},{"line_number":37,"context_line":"            \"brcd_https_fc_zone_client.BrcdHttpsFCZoneClient\",\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_54a9358f","line":34,"in_reply_to":"5afe65bd_3369ab8c","updated":"2015-06-04 12:06:28.000000000","message":"Done","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"\r"},{"line_number":51,"context_line":"        if not client:\r"},{"line_number":52,"context_line":"\r"},{"line_number":53,"context_line":"            fc_secure \u003d fabric.safe_get(\u0027fc_secure\u0027)\r"},{"line_number":54,"context_line":"            if sb_connector \u003d\u003d \"HTTP\" and fc_secure:\r"},{"line_number":55,"context_line":"                sb_connector \u003d \"HTTPS\"\r"},{"line_number":56,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_f330b3a0","line":53,"updated":"2015-06-01 22:20:56.000000000","message":"Why is this config option needed?","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"\r"},{"line_number":51,"context_line":"        if not client:\r"},{"line_number":52,"context_line":"\r"},{"line_number":53,"context_line":"            fc_secure \u003d fabric.safe_get(\u0027fc_secure\u0027)\r"},{"line_number":54,"context_line":"            if sb_connector \u003d\u003d \"HTTP\" and fc_secure:\r"},{"line_number":55,"context_line":"                sb_connector \u003d \"HTTPS\"\r"},{"line_number":56,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_b4c3c956","line":53,"in_reply_to":"5afe65bd_f330b3a0","updated":"2015-06-04 12:06:28.000000000","message":"The parameter is removed.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"102868d2f197e190738cc65628da56e561cd4f18","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class BrcdFCZoneFactory(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        self.sb_conn_map \u003d {}"},{"line_number":33,"context_line":"        self.connectors \u003d {"},{"line_number":34,"context_line":"            \"SSH\": \"cinder.zonemanager.drivers.brocade.\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_f48e4726","line":31,"updated":"2015-06-22 20:29:33.000000000","message":"Please, remove blank line","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"a7fb8ace56f095787d2ed40aa79a37365d4394a3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class BrcdFCZoneFactory(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        self.sb_conn_map \u003d {}"},{"line_number":33,"context_line":"        self.connectors \u003d {"},{"line_number":34,"context_line":"            \"SSH\": \"cinder.zonemanager.drivers.brocade.\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_906c879d","line":31,"in_reply_to":"fa32b979_f48e4726","updated":"2015-06-24 12:03:49.000000000","message":"Done","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            fc_vfid \u003d fabric.safe_get(\u0027fc_virtual_fabric_id\u0027)"},{"line_number":56,"context_line":"            fabric_ssh_cert_path \u003d fabric.safe_get(\u0027fc_fabric_ssh_cert_path\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            LOG.debug(\"Client not found. Creating for %(ip)s with\""},{"line_number":59,"context_line":"                      \"%(connector)s protocol \""},{"line_number":60,"context_line":"                      \"for the user %(user)s at port %(port)s \""},{"line_number":61,"context_line":"                      \"for VFID %(vf_id)s\","}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_ccffbb64","line":58,"updated":"2015-07-08 14:26:55.000000000","message":"Needs trailing space.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            fc_vfid \u003d fabric.safe_get(\u0027fc_virtual_fabric_id\u0027)"},{"line_number":56,"context_line":"            fabric_ssh_cert_path \u003d fabric.safe_get(\u0027fc_fabric_ssh_cert_path\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            LOG.debug(\"Client not found. Creating for %(ip)s with\""},{"line_number":59,"context_line":"                      \"%(connector)s protocol \""},{"line_number":60,"context_line":"                      \"for the user %(user)s at port %(port)s \""},{"line_number":61,"context_line":"                      \"for VFID %(vf_id)s\","}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0fc24e53","line":58,"in_reply_to":"ba3cc151_ccffbb64","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            LOG.debug(\"Client not found. Creating for %(ip)s with \""},{"line_number":59,"context_line":"                      \"%(connector)s protocol \""},{"line_number":60,"context_line":"                      \"for the user %(user)s at port %(port)s \""},{"line_number":61,"context_line":"                      \"for VFID %(vf_id)s\","},{"line_number":62,"context_line":"                      {\u0027ip\u0027: fabric_ip,"},{"line_number":63,"context_line":"                       \u0027connector\u0027: sb_connector,"},{"line_number":64,"context_line":"                       \u0027user\u0027: fabric_user,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_e4093685","line":61,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            LOG.debug(\"Client not found. Creating for %(ip)s with \""},{"line_number":59,"context_line":"                      \"%(connector)s protocol \""},{"line_number":60,"context_line":"                      \"for the user %(user)s at port %(port)s \""},{"line_number":61,"context_line":"                      \"for VFID %(vf_id)s\","},{"line_number":62,"context_line":"                      {\u0027ip\u0027: fabric_ip,"},{"line_number":63,"context_line":"                       \u0027connector\u0027: sb_connector,"},{"line_number":64,"context_line":"                       \u0027user\u0027: fabric_user,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_47fa3d45","line":61,"in_reply_to":"ba3cc151_e4093685","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            fc_vfid \u003d fabric.safe_get(\u0027fc_virtual_fabric_id\u0027)"},{"line_number":56,"context_line":"            fabric_ssh_cert_path \u003d fabric.safe_get(\u0027fc_fabric_ssh_cert_path\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            LOG.debug(\"Client not found. Creating for %(ip)s with \""},{"line_number":59,"context_line":"                      \"%(connector)s protocol \""},{"line_number":60,"context_line":"                      \"for the user %(user)s at port %(port)s \""},{"line_number":61,"context_line":"                      \"for VFID %(vf_id)s.\","}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_cade146d","line":58,"updated":"2015-07-21 05:47:41.000000000","message":"\"Creating [connection client] for ... \"","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            fc_vfid \u003d fabric.safe_get(\u0027fc_virtual_fabric_id\u0027)"},{"line_number":56,"context_line":"            fabric_ssh_cert_path \u003d fabric.safe_get(\u0027fc_fabric_ssh_cert_path\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            LOG.debug(\"Client not found. Creating for %(ip)s with \""},{"line_number":59,"context_line":"                      \"%(connector)s protocol \""},{"line_number":60,"context_line":"                      \"for the user %(user)s at port %(port)s \""},{"line_number":61,"context_line":"                      \"for VFID %(vf_id)s.\","}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_850af377","line":58,"in_reply_to":"3a50d1a3_cade146d","updated":"2015-07-22 11:39:56.000000000","message":"Done","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"449c37663c51441b43995256096b242480b6820c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            fc_vfid \u003d fabric.safe_get(\u0027fc_virtual_fabric_id\u0027)"},{"line_number":56,"context_line":"            fabric_ssh_cert_path \u003d fabric.safe_get(\u0027fc_fabric_ssh_cert_path\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            LOG.debug(\"Client not found. Creating connection client for\""},{"line_number":59,"context_line":"                      \" %(ip)s with %(connector)s protocol \""},{"line_number":60,"context_line":"                      \"for the user %(user)s at port %(port)s \""},{"line_number":61,"context_line":"                      \"for VFID %(vf_id)s.\","}],"source_content_type":"text/x-python","patch_set":20,"id":"7a2fa921_c0e4d6ad","line":58,"updated":"2015-10-12 18:25:16.000000000","message":"Please, move it right after \u0027if\u0027 statement to make it less confusable","commit_id":"7735a6347891696101dbb530bc6107c0df0bb698"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"a001f18e5121b37bf4c2f4ee201e3a516ef89634","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            fc_vfid \u003d fabric.safe_get(\u0027fc_virtual_fabric_id\u0027)"},{"line_number":56,"context_line":"            fabric_ssh_cert_path \u003d fabric.safe_get(\u0027fc_fabric_ssh_cert_path\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            LOG.debug(\"Client not found. Creating connection client for\""},{"line_number":59,"context_line":"                      \" %(ip)s with %(connector)s protocol \""},{"line_number":60,"context_line":"                      \"for the user %(user)s at port %(port)s \""},{"line_number":61,"context_line":"                      \"for VFID %(vf_id)s.\","}],"source_content_type":"text/x-python","patch_set":20,"id":"7a2fa921_55487f87","line":58,"in_reply_to":"7a2fa921_c0e4d6ad","updated":"2015-10-20 21:35:21.000000000","message":"The variables need to be retrieved first in order to print out in the debug msg, so cannot move it to right after the if stmt.","commit_id":"7735a6347891696101dbb530bc6107c0df0bb698"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e130a57c653060c146733df1273ee49c15515b66","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def __init__(self):"},{"line_number":31,"context_line":"        self.sb_conn_map \u003d {}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_connector(self, fabric, sb_connector):"},{"line_number":34,"context_line":"        \"\"\"Returns Device Connector."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        Factory method to create and return"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a29b11f_51c076e0","line":33,"updated":"2015-10-19 22:42:45.000000000","message":"get_client ?","commit_id":"4a6d1ee5afd08e3827e1cf9b473b6511142fd94c"}],"cinder/zonemanager/drivers/brocade/brcd_fc_zone_driver.py":[{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"brcd_opts \u003d ["},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027brcd_southbound_connector\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027HTTP\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027South bound connector for zoning operation\u0027),"},{"line_number":49,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_52de106e","line":46,"updated":"2015-06-01 22:20:56.000000000","message":"If you change this NVP name you will run into backwards compatibility issues.  Let\u0027s leave the name as is.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"brcd_opts \u003d ["},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027brcd_southbound_connector\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027HTTP\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027South bound connector for zoning operation\u0027),"},{"line_number":49,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_548015f7","line":46,"in_reply_to":"7a016987_52de106e","updated":"2015-06-04 12:06:28.000000000","message":"Done","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                        zone_map, zone_activate,"},{"line_number":189,"context_line":"                        cfgmap_from_fabric)"},{"line_number":190,"context_line":"                    client.cleanup()"},{"line_number":191,"context_line":"                except exception.BrocadeZoningCliException as brocade_ex:"},{"line_number":192,"context_line":"                    raise exception.FCZoneDriverException(brocade_ex)"},{"line_number":193,"context_line":"                except Exception as e:"},{"line_number":194,"context_line":"                    msg \u003d _(\"Failed to add zoning configuration %s\") % e"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_b871f8e2","line":191,"updated":"2015-06-01 22:20:56.000000000","message":"Do you need to add except for HTTPs exception here?","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                        zone_map, zone_activate,"},{"line_number":189,"context_line":"                        cfgmap_from_fabric)"},{"line_number":190,"context_line":"                    client.cleanup()"},{"line_number":191,"context_line":"                except exception.BrocadeZoningCliException as brocade_ex:"},{"line_number":192,"context_line":"                    raise exception.FCZoneDriverException(brocade_ex)"},{"line_number":193,"context_line":"                except Exception as e:"},{"line_number":194,"context_line":"                    msg \u003d _(\"Failed to add zoning configuration %s\") % e"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_147f3d16","line":191,"in_reply_to":"5afe65bd_b871f8e2","updated":"2015-06-04 12:06:28.000000000","message":"Yes. Done.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                    target \u003d t.lower()"},{"line_number":260,"context_line":"                    zone_members.append(self.get_formatted_wwn(target))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"                    zone_name \u003d zone_name_prefix + initiator.replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"                if (zone_names and (zone_name in zone_names)):"},{"line_number":265,"context_line":"                    filtered_members \u003d filter("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_9241280e","line":262,"updated":"2015-06-01 22:20:56.000000000","message":"why is this indented and added to the for loop?","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                    target \u003d t.lower()"},{"line_number":260,"context_line":"                    zone_members.append(self.get_formatted_wwn(target))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"                    zone_name \u003d zone_name_prefix + initiator.replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"                if (zone_names and (zone_name in zone_names)):"},{"line_number":265,"context_line":"                    filtered_members \u003d filter("}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_5497f539","line":262,"in_reply_to":"7a016987_9241280e","updated":"2015-06-04 12:06:28.000000000","message":"Corrected.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                        zone_name_string, zone_activate,"},{"line_number":311,"context_line":"                        cfgmap_from_fabric)"},{"line_number":312,"context_line":"                conn.cleanup()"},{"line_number":313,"context_line":"            except Exception as e:"},{"line_number":314,"context_line":"                msg \u003d _(\"Failed to update or delete zoning \""},{"line_number":315,"context_line":"                        \"configuration %s\") % e"},{"line_number":316,"context_line":"                LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_f83530f7","line":313,"updated":"2015-06-01 22:20:56.000000000","message":"Why is exception handling different in delete_connection compared to add_connection?","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                        zone_name_string, zone_activate,"},{"line_number":311,"context_line":"                        cfgmap_from_fabric)"},{"line_number":312,"context_line":"                conn.cleanup()"},{"line_number":313,"context_line":"            except Exception as e:"},{"line_number":314,"context_line":"                msg \u003d _(\"Failed to update or delete zoning \""},{"line_number":315,"context_line":"                        \"configuration %s\") % e"},{"line_number":316,"context_line":"                LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_14a61dae","line":313,"in_reply_to":"5afe65bd_f83530f7","updated":"2015-06-04 12:06:28.000000000","message":"Corrected","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                LOG.exception(msg)"},{"line_number":317,"context_line":"                raise exception.FCZoneDriverException(msg)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def get_san_context(self, target_wwn_list):"},{"line_number":320,"context_line":"        \"\"\"Lookup SAN context for visible end devices."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        Look up each SAN configured and return a map of SAN (fabric IP) to"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_f81c1079","line":319,"updated":"2015-06-01 22:20:56.000000000","message":"need to add HTTPs exception handling to this method too","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                LOG.exception(msg)"},{"line_number":317,"context_line":"                raise exception.FCZoneDriverException(msg)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def get_san_context(self, target_wwn_list):"},{"line_number":320,"context_line":"        \"\"\"Lookup SAN context for visible end devices."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        Look up each SAN configured and return a map of SAN (fabric IP) to"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_f4a26198","line":319,"in_reply_to":"5afe65bd_f81c1079","updated":"2015-06-04 12:06:28.000000000","message":"Done","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"102868d2f197e190738cc65628da56e561cd4f18","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from cinder import exception"},{"line_number":39,"context_line":"from cinder.i18n import _, _LE, _LI"},{"line_number":40,"context_line":"from cinder.zonemanager.drivers.brocade import brcd_fabric_opts as fabric_opts"},{"line_number":41,"context_line":"from cinder.zonemanager.drivers.fc_zone_driver import FCZoneDriver"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_949edb52","line":41,"updated":"2015-06-22 20:29:33.000000000","message":"Please, import modules, not objects","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"a7fb8ace56f095787d2ed40aa79a37365d4394a3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from cinder import exception"},{"line_number":39,"context_line":"from cinder.i18n import _, _LE, _LI"},{"line_number":40,"context_line":"from cinder.zonemanager.drivers.brocade import brcd_fabric_opts as fabric_opts"},{"line_number":41,"context_line":"from cinder.zonemanager.drivers.fc_zone_driver import FCZoneDriver"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_900327b8","line":41,"in_reply_to":"fa32b979_949edb52","updated":"2015-06-24 12:03:49.000000000","message":"Done","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                        exception.BrocadeZoningHttpsException) as brocade_ex:"},{"line_number":193,"context_line":"                    raise exception.FCZoneDriverException(brocade_ex)"},{"line_number":194,"context_line":"                except Exception as e:"},{"line_number":195,"context_line":"                    msg \u003d _(\"Failed to add zoning configuration %s\") % e"},{"line_number":196,"context_line":"                    LOG.exception(msg)"},{"line_number":197,"context_line":"                    raise exception.FCZoneDriverException(msg)"},{"line_number":198,"context_line":"            LOG.debug(\"Zones added successfully: %s\", zone_map)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0ccda330","line":195,"updated":"2015-07-08 14:26:55.000000000","message":"Need six.text_type around e if you are going to format it in the string here. Can also change LOG.exception to LOG.error then since you are including the exeption info in the test.\n\nI\u0027d actually rather see this all left as it was before.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                        exception.BrocadeZoningHttpsException) as brocade_ex:"},{"line_number":193,"context_line":"                    raise exception.FCZoneDriverException(brocade_ex)"},{"line_number":194,"context_line":"                except Exception as e:"},{"line_number":195,"context_line":"                    msg \u003d _(\"Failed to add zoning configuration %s\") % e"},{"line_number":196,"context_line":"                    LOG.exception(msg)"},{"line_number":197,"context_line":"                    raise exception.FCZoneDriverException(msg)"},{"line_number":198,"context_line":"            LOG.debug(\"Zones added successfully: %s\", zone_map)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0f99ee78","line":195,"in_reply_to":"ba3cc151_0ccda330","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                    exception.BrocadeZoningHttpsException) as brocade_ex:"},{"line_number":316,"context_line":"                raise exception.FCZoneDriverException(brocade_ex)"},{"line_number":317,"context_line":"            except Exception as e:"},{"line_number":318,"context_line":"                msg \u003d _(\"Failed to update or delete zoning \""},{"line_number":319,"context_line":"                        \"configuration %s\") % e"},{"line_number":320,"context_line":"                LOG.exception(msg)"},{"line_number":321,"context_line":"                raise exception.FCZoneDriverException(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_ccd25bd1","line":318,"updated":"2015-07-08 14:26:55.000000000","message":"Same as above.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                    exception.BrocadeZoningHttpsException) as brocade_ex:"},{"line_number":316,"context_line":"                raise exception.FCZoneDriverException(brocade_ex)"},{"line_number":317,"context_line":"            except Exception as e:"},{"line_number":318,"context_line":"                msg \u003d _(\"Failed to update or delete zoning \""},{"line_number":319,"context_line":"                        \"configuration %s\") % e"},{"line_number":320,"context_line":"                LOG.exception(msg)"},{"line_number":321,"context_line":"                raise exception.FCZoneDriverException(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_cf8d4632","line":318,"in_reply_to":"ba3cc151_ccd25bd1","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                        LOG.error(msg)"},{"line_number":358,"context_line":"                        raise exception.FCZoneDriverException(msg)"},{"line_number":359,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":360,"context_line":"                        LOG.exception(_LE(\"Error getting name server \""},{"line_number":361,"context_line":"                                          \"info: %s\"), ex)"},{"line_number":362,"context_line":"                except Exception as e:"},{"line_number":363,"context_line":"                    msg \u003d _(\"Failed to get name server info: %s\") % e"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_cce9fb80","line":360,"updated":"2015-07-08 14:26:55.000000000","message":"Switch to LOG.error, or don\u0027t include the exception in the log string. Was better in it\u0027s previous state without ex.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                        LOG.error(msg)"},{"line_number":358,"context_line":"                        raise exception.FCZoneDriverException(msg)"},{"line_number":359,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":360,"context_line":"                        LOG.exception(_LE(\"Error getting name server \""},{"line_number":361,"context_line":"                                          \"info: %s\"), ex)"},{"line_number":362,"context_line":"                except Exception as e:"},{"line_number":363,"context_line":"                    msg \u003d _(\"Failed to get name server info: %s\") % e"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_ef74ca36","line":360,"in_reply_to":"ba3cc151_cce9fb80","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                        LOG.exception(_LE(\"Error getting name server \""},{"line_number":361,"context_line":"                                          \"info: %s\"), ex)"},{"line_number":362,"context_line":"                except Exception as e:"},{"line_number":363,"context_line":"                    msg \u003d _(\"Failed to get name server info: %s\") % e"},{"line_number":364,"context_line":"                    LOG.exception(msg)"},{"line_number":365,"context_line":"                    raise exception.FCZoneDriverException(msg)"},{"line_number":366,"context_line":"                visible_targets \u003d filter("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0c9b6319","line":363,"updated":"2015-07-08 14:26:55.000000000","message":"Same as higher up. Use six.text_type and change to LOG.error, or change it back to how it was.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                        LOG.exception(_LE(\"Error getting name server \""},{"line_number":361,"context_line":"                                          \"info: %s\"), ex)"},{"line_number":362,"context_line":"                except Exception as e:"},{"line_number":363,"context_line":"                    msg \u003d _(\"Failed to get name server info: %s\") % e"},{"line_number":364,"context_line":"                    LOG.exception(msg)"},{"line_number":365,"context_line":"                    raise exception.FCZoneDriverException(msg)"},{"line_number":366,"context_line":"                visible_targets \u003d filter("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0f700e3f","line":363,"in_reply_to":"ba3cc151_0c9b6319","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        except Exception as e:"},{"line_number":429,"context_line":"            LOG.error(e)"},{"line_number":430,"context_line":"            msg \u003d _LE(\"Failed to create south bound connector for %s\") % fc_ip"},{"line_number":431,"context_line":"            raise exception.FCZoneDriverException(msg)"},{"line_number":432,"context_line":"        return client"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_8c5c534c","line":430,"updated":"2015-07-08 14:26:55.000000000","message":"Should be _(), not _LE().\n\nWould also recommend moving this up, change LOG.error(e) to LOG.exception(msg), then getting rid of \"as e\" from the except line.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        except Exception as e:"},{"line_number":429,"context_line":"            LOG.error(e)"},{"line_number":430,"context_line":"            msg \u003d _LE(\"Failed to create south bound connector for %s\") % fc_ip"},{"line_number":431,"context_line":"            raise exception.FCZoneDriverException(msg)"},{"line_number":432,"context_line":"        return client"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_cfbb06c3","line":430,"in_reply_to":"ba3cc151_8c5c534c","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                                                sb_connector.upper())"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        except Exception:"},{"line_number":428,"context_line":"            msg \u003d _(\"Failed to create south bound connector for %s\") % fc_ip"},{"line_number":429,"context_line":"            LOG.exception(msg)"},{"line_number":430,"context_line":"            raise exception.FCZoneDriverException(msg)"},{"line_number":431,"context_line":"        return client"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_84470aa2","line":428,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                                                sb_connector.upper())"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        except Exception:"},{"line_number":428,"context_line":"            msg \u003d _(\"Failed to create south bound connector for %s\") % fc_ip"},{"line_number":429,"context_line":"            LOG.exception(msg)"},{"line_number":430,"context_line":"            raise exception.FCZoneDriverException(msg)"},{"line_number":431,"context_line":"        return client"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_67f7415a","line":428,"in_reply_to":"ba3cc151_84470aa2","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"10e4eb941dba50745d660986b07e9fc7877b78e0","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                LOG.error(msg)"},{"line_number":394,"context_line":"                raise exception.FCZoneDriverException(msg)"},{"line_number":395,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":396,"context_line":"                LOG.exception(_LE(\"Error getting name server \""},{"line_number":397,"context_line":"                                  \"info: %s\"), ex)"},{"line_number":398,"context_line":"        except Exception as e:"},{"line_number":399,"context_line":"            msg \u003d (_(\"Failed to retrieve active zoning configuration %s\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_0822a700","line":396,"updated":"2015-07-14 03:09:07.000000000","message":"Do not use LOG.exception and pass the exception in to be logged. LOG.exception will take care of logging whatever exception is currently in scope. This will result in duplicate information going to the log.\n\nEither use LOG.error with the current message, or use LOG.exception and remove ex from the log string.","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"512ecef6dd17e5b6edc49740fb6ed33ece6d0851","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                LOG.error(msg)"},{"line_number":394,"context_line":"                raise exception.FCZoneDriverException(msg)"},{"line_number":395,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":396,"context_line":"                LOG.exception(_LE(\"Error getting name server \""},{"line_number":397,"context_line":"                                  \"info: %s\"), ex)"},{"line_number":398,"context_line":"        except Exception as e:"},{"line_number":399,"context_line":"            msg \u003d (_(\"Failed to retrieve active zoning configuration %s\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_35233f07","line":396,"in_reply_to":"9a41bdd9_0822a700","updated":"2015-07-15 10:07:29.000000000","message":"Done","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                zone_map[zone_name] \u003d zone_members"},{"line_number":177,"context_line":"            else:"},{"line_number":178,"context_line":"                msg \u003d _(\"Zoning Policy: %s, not \""},{"line_number":179,"context_line":"                        \"recognized\") % zoning_policy"},{"line_number":180,"context_line":"                LOG.error(msg)"},{"line_number":181,"context_line":"                raise exception.FCZoneDriverException(msg)"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_ea92f09e","line":179,"updated":"2015-07-21 05:47:41.000000000","message":"Error messages to end with \".\" for consistency.","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                zone_map[zone_name] \u003d zone_members"},{"line_number":177,"context_line":"            else:"},{"line_number":178,"context_line":"                msg \u003d _(\"Zoning Policy: %s, not \""},{"line_number":179,"context_line":"                        \"recognized\") % zoning_policy"},{"line_number":180,"context_line":"                LOG.error(msg)"},{"line_number":181,"context_line":"                raise exception.FCZoneDriverException(msg)"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_c57b1bf4","line":179,"in_reply_to":"3a50d1a3_ea92f09e","updated":"2015-07-22 11:39:56.000000000","message":"Done","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"238916e11bd9303c526a81b8bbee571bd1a0e271","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        except Exception as e:"},{"line_number":399,"context_line":"            msg \u003d (_(\"Failed to retrieve active zoning configuration %s\")"},{"line_number":400,"context_line":"                   % six.text_type(e))"},{"line_number":401,"context_line":"            LOG.exception(msg)"},{"line_number":402,"context_line":"            raise exception.FCZoneDriverException(msg)"},{"line_number":403,"context_line":"        LOG.debug(\"Active zone set from fabric: %s\", cfgmap)"},{"line_number":404,"context_line":"        return cfgmap"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_a5978439","line":401,"updated":"2015-07-23 20:52:17.000000000","message":"Make this LOG.error to prevent redundant logging of exception details or remove it from the msg text.","commit_id":"a0e134cf4e1ca039851f27303c5c6e1695c59b05"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"b1e5fc556ce1fbc7d985a2f30d3af4be6645ff91","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        except Exception as e:"},{"line_number":399,"context_line":"            msg \u003d (_(\"Failed to retrieve active zoning configuration %s\")"},{"line_number":400,"context_line":"                   % six.text_type(e))"},{"line_number":401,"context_line":"            LOG.exception(msg)"},{"line_number":402,"context_line":"            raise exception.FCZoneDriverException(msg)"},{"line_number":403,"context_line":"        LOG.debug(\"Active zone set from fabric: %s\", cfgmap)"},{"line_number":404,"context_line":"        return cfgmap"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_a14b6a86","line":401,"in_reply_to":"3a50d1a3_a5978439","updated":"2015-07-28 09:08:24.000000000","message":"Done","commit_id":"a0e134cf4e1ca039851f27303c5c6e1695c59b05"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b4d718d022ab508fa6bd530c2c5f6fdc48d97b7d","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"brcd_opts \u003d ["},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027brcd_sb_connector\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027HTTP\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027South bound connector for zoning operation\u0027),"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"fa69d971_15869ab9","line":47,"updated":"2016-01-08 00:41:45.000000000","message":"use one of the constants?","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"615e71e2b6a328be2546c043923e96393fbf04ed","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"brcd_opts \u003d ["},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027brcd_sb_connector\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027HTTP\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027South bound connector for zoning operation\u0027),"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"da6ed579_9155a451","line":47,"in_reply_to":"fa69d971_15869ab9","updated":"2016-01-12 22:02:37.000000000","message":"Done","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b4d718d022ab508fa6bd530c2c5f6fdc48d97b7d","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                raise exception.FCZoneDriverException(msg)"},{"line_number":395,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":396,"context_line":"                LOG.exception(_LE(\"Error getting name server \""},{"line_number":397,"context_line":"                                  \"info.\"))"},{"line_number":398,"context_line":"        except Exception as e:"},{"line_number":399,"context_line":"            msg \u003d (_(\"Failed to retrieve active zoning configuration %s\")"},{"line_number":400,"context_line":"                   % six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa69d971_b5a9ce26","line":397,"updated":"2016-01-08 00:41:45.000000000","message":"This should fit on one line","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"615e71e2b6a328be2546c043923e96393fbf04ed","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                raise exception.FCZoneDriverException(msg)"},{"line_number":395,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":396,"context_line":"                LOG.exception(_LE(\"Error getting name server \""},{"line_number":397,"context_line":"                                  \"info.\"))"},{"line_number":398,"context_line":"        except Exception as e:"},{"line_number":399,"context_line":"            msg \u003d (_(\"Failed to retrieve active zoning configuration %s\")"},{"line_number":400,"context_line":"                   % six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":27,"id":"da6ed579_b1d788be","line":397,"in_reply_to":"fa69d971_b5a9ce26","updated":"2016-01-12 22:02:37.000000000","message":"Done","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"}],"cinder/zonemanager/drivers/brocade/brcd_http_fc_zone_client.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"449c37663c51441b43995256096b242480b6820c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class BrcdHTTPFCZoneClient(object):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    cfgs \u003d {}"},{"line_number":37,"context_line":"    zones \u003d {}"},{"line_number":38,"context_line":"    alias \u003d {}"},{"line_number":39,"context_line":"    qlps \u003d {}"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a2fa921_8049fe90","line":36,"updated":"2015-10-12 18:25:16.000000000","message":"Do we really want to have these data in class members instead of instance members? How will it work in multithread mode?","commit_id":"7735a6347891696101dbb530bc6107c0df0bb698"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"a001f18e5121b37bf4c2f4ee201e3a516ef89634","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class BrcdHTTPFCZoneClient(object):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    cfgs \u003d {}"},{"line_number":37,"context_line":"    zones \u003d {}"},{"line_number":38,"context_line":"    alias \u003d {}"},{"line_number":39,"context_line":"    qlps \u003d {}"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a29b11f_96b60bdb","line":36,"in_reply_to":"7a2fa921_8049fe90","updated":"2015-10-20 21:35:21.000000000","message":"moved these variables to init","commit_id":"7735a6347891696101dbb530bc6107c0df0bb698"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"449c37663c51441b43995256096b242480b6820c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        :param username: User id to login."},{"line_number":55,"context_line":"        :param password: User password."},{"line_number":56,"context_line":"        :param port: Device Communication port"},{"line_number":57,"context_line":"        :param key:"},{"line_number":58,"context_line":"        :param vfid: Virtual Fabric ID."},{"line_number":59,"context_line":"        :param protocol: Communication Protocol."},{"line_number":60,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"7a2fa921_e08f92ca","line":57,"updated":"2015-10-12 18:25:16.000000000","message":"This param is not used anywhere in the __init__","commit_id":"7735a6347891696101dbb530bc6107c0df0bb698"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"a001f18e5121b37bf4c2f4ee201e3a516ef89634","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        :param username: User id to login."},{"line_number":55,"context_line":"        :param password: User password."},{"line_number":56,"context_line":"        :param port: Device Communication port"},{"line_number":57,"context_line":"        :param key:"},{"line_number":58,"context_line":"        :param vfid: Virtual Fabric ID."},{"line_number":59,"context_line":"        :param protocol: Communication Protocol."},{"line_number":60,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a29b11f_ab14fd43","line":57,"in_reply_to":"7a2fa921_e08f92ca","updated":"2015-10-20 21:35:21.000000000","message":"Done","commit_id":"7735a6347891696101dbb530bc6107c0df0bb698"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"449c37663c51441b43995256096b242480b6820c","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            start \u003d start + len(delim1)"},{"line_number":247,"context_line":"            end \u003d data.index(demil2)"},{"line_number":248,"context_line":"            return data[start:end]"},{"line_number":249,"context_line":"        except Exception as e:"},{"line_number":250,"context_line":"            msg \u003d (_(\"Error while parsing the data %s.\") % six.text_type(e))"},{"line_number":251,"context_line":"            LOG.error(msg)"},{"line_number":252,"context_line":"            raise exception.BrocadeZoningHttpException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a2fa921_4308d028","line":249,"updated":"2015-10-12 18:25:16.000000000","message":"Please, handle more specific exception here","commit_id":"7735a6347891696101dbb530bc6107c0df0bb698"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"a001f18e5121b37bf4c2f4ee201e3a516ef89634","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            start \u003d start + len(delim1)"},{"line_number":247,"context_line":"            end \u003d data.index(demil2)"},{"line_number":248,"context_line":"            return data[start:end]"},{"line_number":249,"context_line":"        except Exception as e:"},{"line_number":250,"context_line":"            msg \u003d (_(\"Error while parsing the data %s.\") % six.text_type(e))"},{"line_number":251,"context_line":"            LOG.error(msg)"},{"line_number":252,"context_line":"            raise exception.BrocadeZoningHttpException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a29b11f_36cff757","line":249,"in_reply_to":"7a2fa921_4308d028","updated":"2015-10-20 21:35:21.000000000","message":"Done","commit_id":"7735a6347891696101dbb530bc6107c0df0bb698"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"449c37663c51441b43995256096b242480b6820c","unresolved":false,"context_lines":[{"line_number":726,"context_line":"            # empty string"},{"line_number":727,"context_line":"            if active_cfg not in cfgs:"},{"line_number":728,"context_line":"                active_cfg \u003d \"\""},{"line_number":729,"context_line":"        except Exception as e:"},{"line_number":730,"context_line":"            msg \u003d (_(\"Error while removing the zones and cfgs \""},{"line_number":731,"context_line":"                     \"in the zone string. Error %(description)s.\")"},{"line_number":732,"context_line":"                   % {\u0027description\u0027: six.text_type(e)})"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a2fa921_635b8c2f","line":729,"updated":"2015-10-12 18:25:16.000000000","message":"Can we handle more specific exception here?","commit_id":"7735a6347891696101dbb530bc6107c0df0bb698"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"a001f18e5121b37bf4c2f4ee201e3a516ef89634","unresolved":false,"context_lines":[{"line_number":726,"context_line":"            # empty string"},{"line_number":727,"context_line":"            if active_cfg not in cfgs:"},{"line_number":728,"context_line":"                active_cfg \u003d \"\""},{"line_number":729,"context_line":"        except Exception as e:"},{"line_number":730,"context_line":"            msg \u003d (_(\"Error while removing the zones and cfgs \""},{"line_number":731,"context_line":"                     \"in the zone string. Error %(description)s.\")"},{"line_number":732,"context_line":"                   % {\u0027description\u0027: six.text_type(e)})"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a29b11f_f6c17f2f","line":729,"in_reply_to":"7a2fa921_635b8c2f","updated":"2015-10-20 21:35:21.000000000","message":"Done","commit_id":"7735a6347891696101dbb530bc6107c0df0bb698"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b4d718d022ab508fa6bd530c2c5f6fdc48d97b7d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if self.protocol \u003d\u003d zone_constant.PROTOCOL_HTTPS:"},{"line_number":90,"context_line":"                protocol \u003d zone_constant.HTTPS"},{"line_number":91,"context_line":"            if self.session is None:"},{"line_number":92,"context_line":"                LOG.info(_LI(\"Creating new session.\"))"},{"line_number":93,"context_line":"                self.session \u003d requests.Session()"},{"line_number":94,"context_line":"                adapter \u003d requests.adapters.HTTPAdapter(pool_connections\u003d1,"},{"line_number":95,"context_line":"                                                        pool_maxsize\u003d1)"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa69d971_350e3ee6","line":92,"updated":"2016-01-08 00:41:45.000000000","message":"this probably should be a debug or remove.","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"615e71e2b6a328be2546c043923e96393fbf04ed","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if self.protocol \u003d\u003d zone_constant.PROTOCOL_HTTPS:"},{"line_number":90,"context_line":"                protocol \u003d zone_constant.HTTPS"},{"line_number":91,"context_line":"            if self.session is None:"},{"line_number":92,"context_line":"                LOG.info(_LI(\"Creating new session.\"))"},{"line_number":93,"context_line":"                self.session \u003d requests.Session()"},{"line_number":94,"context_line":"                adapter \u003d requests.adapters.HTTPAdapter(pool_connections\u003d1,"},{"line_number":95,"context_line":"                                                        pool_maxsize\u003d1)"}],"source_content_type":"text/x-python","patch_set":27,"id":"da6ed579_f1ebc076","line":92,"in_reply_to":"fa69d971_350e3ee6","updated":"2016-01-12 22:02:37.000000000","message":"Done","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2327c90e8877d27f4eca7f724eddad902f44498a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                response \u003d self.session.post(url,"},{"line_number":105,"context_line":"                                             payload,"},{"line_number":106,"context_line":"                                             headers\u003d(header),"},{"line_number":107,"context_line":"                                             verify\u003dFalse)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            # Throw exception when response status is not OK"},{"line_number":110,"context_line":"            if response.status_code !\u003d zone_constant.STATUS_OK:"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa69d971_a4a20599","line":107,"updated":"2016-01-07 23:46:21.000000000","message":"we shouldn\u0027t turn off SSL cert verification.","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b4d718d022ab508fa6bd530c2c5f6fdc48d97b7d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                response \u003d self.session.post(url,"},{"line_number":105,"context_line":"                                             payload,"},{"line_number":106,"context_line":"                                             headers\u003d(header),"},{"line_number":107,"context_line":"                                             verify\u003dFalse)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            # Throw exception when response status is not OK"},{"line_number":110,"context_line":"            if response.status_code !\u003d zone_constant.STATUS_OK:"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa69d971_fa5df548","line":107,"in_reply_to":"fa69d971_a4a20599","updated":"2016-01-08 00:41:45.000000000","message":"ignore this.  I think we\u0027re good.  Maybe we should have a cinder wide conf setting for verifying ssl connections ?","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b4d718d022ab508fa6bd530c2c5f6fdc48d97b7d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                                \u0027error\u0027: response.reason}"},{"line_number":114,"context_line":"                raise exception.BrocadeZoningHttpException(msg)"},{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                LOG.info(_LI(\"Connected to the switch.\"))"},{"line_number":117,"context_line":"                return response.text"},{"line_number":118,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":119,"context_line":"            msg \u003d (_(\"Error while connecting the switch %(switch_id)s \""}],"source_content_type":"text/x-python","patch_set":27,"id":"fa69d971_d5ffa2a8","line":116,"updated":"2016-01-08 00:41:45.000000000","message":"probably a debug as well ?","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"615e71e2b6a328be2546c043923e96393fbf04ed","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                                \u0027error\u0027: response.reason}"},{"line_number":114,"context_line":"                raise exception.BrocadeZoningHttpException(msg)"},{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                LOG.info(_LI(\"Connected to the switch.\"))"},{"line_number":117,"context_line":"                return response.text"},{"line_number":118,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":119,"context_line":"            msg \u003d (_(\"Error while connecting the switch %(switch_id)s \""}],"source_content_type":"text/x-python","patch_set":27,"id":"da6ed579_d1e8fc7e","line":116,"in_reply_to":"fa69d971_d5ffa2a8","updated":"2016-01-12 22:02:37.000000000","message":"Done","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b4d718d022ab508fa6bd530c2c5f6fdc48d97b7d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            auth_header \u003d (zone_constant.AUTH_STRING +"},{"line_number":163,"context_line":"                           auth_token)  # Build the proper header"},{"line_number":164,"context_line":"            LOG.debug(\"Authentication header: %(header)s.\","},{"line_number":165,"context_line":"                      {\u0027header\u0027: auth_header})"},{"line_number":166,"context_line":"        except Exception as e:"},{"line_number":167,"context_line":"            msg \u003d (_(\"Error while creating authentication token: %s\")"},{"line_number":168,"context_line":"                   % six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa69d971_d516c2f0","line":165,"updated":"2016-01-08 00:41:45.000000000","message":"since we have a password here, we probably shouldn\u0027t log this.","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"0fee01d78f4fd7e162f5b829762bf8aed840938f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            auth_header \u003d (zone_constant.AUTH_STRING +"},{"line_number":163,"context_line":"                           auth_token)  # Build the proper header"},{"line_number":164,"context_line":"            LOG.debug(\"Authentication header: %(header)s.\","},{"line_number":165,"context_line":"                      {\u0027header\u0027: auth_header})"},{"line_number":166,"context_line":"        except Exception as e:"},{"line_number":167,"context_line":"            msg \u003d (_(\"Error while creating authentication token: %s\")"},{"line_number":168,"context_line":"                   % six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":27,"id":"da6ed579_fb9237f5","line":165,"in_reply_to":"da6ed579_f5f9714e","updated":"2016-01-14 21:56:37.000000000","message":"It\u0027s base64 encdoded, that\u0027s not encryption.  :)","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"5fa6ec6b725d08ff5b7c7ff981c2153c989c00fd","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            auth_header \u003d (zone_constant.AUTH_STRING +"},{"line_number":163,"context_line":"                           auth_token)  # Build the proper header"},{"line_number":164,"context_line":"            LOG.debug(\"Authentication header: %(header)s.\","},{"line_number":165,"context_line":"                      {\u0027header\u0027: auth_header})"},{"line_number":166,"context_line":"        except Exception as e:"},{"line_number":167,"context_line":"            msg \u003d (_(\"Error while creating authentication token: %s\")"},{"line_number":168,"context_line":"                   % six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba63e191_1d620aae","line":165,"in_reply_to":"da6ed579_fb9237f5","updated":"2016-01-20 01:44:07.000000000","message":"Ok, removed.","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"615e71e2b6a328be2546c043923e96393fbf04ed","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            auth_header \u003d (zone_constant.AUTH_STRING +"},{"line_number":163,"context_line":"                           auth_token)  # Build the proper header"},{"line_number":164,"context_line":"            LOG.debug(\"Authentication header: %(header)s.\","},{"line_number":165,"context_line":"                      {\u0027header\u0027: auth_header})"},{"line_number":166,"context_line":"        except Exception as e:"},{"line_number":167,"context_line":"            msg \u003d (_(\"Error while creating authentication token: %s\")"},{"line_number":168,"context_line":"                   % six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":27,"id":"da6ed579_f5f9714e","line":165,"in_reply_to":"fa69d971_d516c2f0","updated":"2016-01-12 22:02:37.000000000","message":"Since it\u0027s encrypted it should be OK to log here.","commit_id":"aaf3251ddeacfbcb916b42f0248597d08bcab6bf"}],"cinder/zonemanager/drivers/brocade/brcd_https_fc_zone_client.py":[{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"33b1cb4d1f82925ae2c4de04fd08695773142e8d","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def get_zone_info(self):"},{"line_number":322,"context_line":"        \"\"\"Parse all the zone information and store it in the dictionary."},{"line_number":323,"context_line":"        \"\"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_8c087ddb","line":322,"updated":"2015-05-22 04:47:51.000000000","message":"A multi line docstring has a one-line summary, less than 80 characters.\n\nhttps://review.openstack.org/184820\nhttp://docs.openstack.org/developer/hacking/#docstrings","commit_id":"3a8c25180657b40a6b9c71568f7a6f4315fe1638"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"dd2051f3a7d251adc86a429533b86044d199c660","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def get_zone_info(self):"},{"line_number":322,"context_line":"        \"\"\"Parse all the zone information and store it in the dictionary."},{"line_number":323,"context_line":"        \"\"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4c8165fa","line":322,"in_reply_to":"7a016987_8c087ddb","updated":"2015-05-22 05:41:49.000000000","message":"Done","commit_id":"3a8c25180657b40a6b9c71568f7a6f4315fe1638"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"33b1cb4d1f82925ae2c4de04fd08695773142e8d","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            LOG.debug(\"Original Zone string\""},{"line_number":343,"context_line":"                      \"from the switch %s\" %"},{"line_number":344,"context_line":"                      self.parsed_raw_zoneinfo)"},{"line_number":345,"context_line":"            # convert to zone string to list"},{"line_number":346,"context_line":"            zoneinfo \u003d self.parsed_raw_zoneinfo.split()"},{"line_number":347,"context_line":"            i \u003d 0"},{"line_number":348,"context_line":"            while(i \u003c len(zoneinfo)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4c0e05e6","line":345,"updated":"2015-05-22 04:47:51.000000000","message":"This should be \"convert the zone string to list\"","commit_id":"3a8c25180657b40a6b9c71568f7a6f4315fe1638"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"dd2051f3a7d251adc86a429533b86044d199c660","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            LOG.debug(\"Original Zone string\""},{"line_number":343,"context_line":"                      \"from the switch %s\" %"},{"line_number":344,"context_line":"                      self.parsed_raw_zoneinfo)"},{"line_number":345,"context_line":"            # convert to zone string to list"},{"line_number":346,"context_line":"            zoneinfo \u003d self.parsed_raw_zoneinfo.split()"},{"line_number":347,"context_line":"            i \u003d 0"},{"line_number":348,"context_line":"            while(i \u003c len(zoneinfo)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_2c84e908","line":345,"in_reply_to":"7a016987_4c0e05e6","updated":"2015-05-22 05:41:49.000000000","message":"Done","commit_id":"3a8c25180657b40a6b9c71568f7a6f4315fe1638"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        :param username: User id to login."},{"line_number":55,"context_line":"        :param password: User password."},{"line_number":56,"context_line":"        :param port: Device Communication port"},{"line_number":57,"context_line":"        :param key:"},{"line_number":58,"context_line":"        :param vfid: Virtual Fabric ID."},{"line_number":59,"context_line":"        :param protocol: Communication Protocol."},{"line_number":60,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_13822f53","line":57,"updated":"2015-06-01 22:20:56.000000000","message":"Doesn\u0027t appear that key is ever used for HTTPs connector.  Why are we passing it in?","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        :param username: User id to login."},{"line_number":55,"context_line":"        :param password: User password."},{"line_number":56,"context_line":"        :param port: Device Communication port"},{"line_number":57,"context_line":"        :param key:"},{"line_number":58,"context_line":"        :param vfid: Virtual Fabric ID."},{"line_number":59,"context_line":"        :param protocol: Communication Protocol."},{"line_number":60,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_34ea39ad","line":57,"in_reply_to":"5afe65bd_13822f53","updated":"2015-06-04 12:06:28.000000000","message":"It is used by SSH connector. As the factory class calls the corresponding connectors, we need to have this parameter in both the classes.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                    # self.alias\u003d{alias_name:members1;members2}"},{"line_number":369,"context_line":"                    self.alias.update({alias_name: zoneinfo[i + 1]})"},{"line_number":370,"context_line":"                    i \u003d i + 2"},{"line_number":371,"context_line":"                # TODO(vinodh) QLP string format needs to verified with the"},{"line_number":372,"context_line":"                # back end team"},{"line_number":373,"context_line":"                elif ZoneConstant.QLP_DELIM in info:"},{"line_number":374,"context_line":"                    qlp_name \u003d info.lstrip(ZoneConstant.QLP_DELIM)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_f393134e","line":371,"updated":"2015-06-01 22:20:56.000000000","message":"Need to address this TODO","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                    # self.alias\u003d{alias_name:members1;members2}"},{"line_number":369,"context_line":"                    self.alias.update({alias_name: zoneinfo[i + 1]})"},{"line_number":370,"context_line":"                    i \u003d i + 2"},{"line_number":371,"context_line":"                # TODO(vinodh) QLP string format needs to verified with the"},{"line_number":372,"context_line":"                # back end team"},{"line_number":373,"context_line":"                elif ZoneConstant.QLP_DELIM in info:"},{"line_number":374,"context_line":"                    qlp_name \u003d info.lstrip(ZoneConstant.QLP_DELIM)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_14d4dde9","line":371,"in_reply_to":"5afe65bd_f393134e","updated":"2015-06-04 12:06:28.000000000","message":"Verified with backend team.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"6fd80a7f334e9dc1954c952e6cfc7e9621982d6d","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                    # update the map as self.qlps\u003d{qlp_name:members1;members2}"},{"line_number":376,"context_line":"                    self.qlps.update({qlp_name: zoneinfo[i + 1]})"},{"line_number":377,"context_line":"                    i \u003d i + 2"},{"line_number":378,"context_line":"                # TODO(vinodh) FAZone string format needs to verified with the"},{"line_number":379,"context_line":"                # back end team"},{"line_number":380,"context_line":"                elif ZoneConstant.IFA_DELIM in info:"},{"line_number":381,"context_line":"                    ifa_name \u003d info.lstrip(ZoneConstant.IFA_DELIM)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_53ad4787","line":378,"updated":"2015-06-01 22:20:56.000000000","message":"Need to address this TODO","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"5f181564eaae91f85f5080a231b04e90fd4edfa8","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                    # update the map as self.qlps\u003d{qlp_name:members1;members2}"},{"line_number":376,"context_line":"                    self.qlps.update({qlp_name: zoneinfo[i + 1]})"},{"line_number":377,"context_line":"                    i \u003d i + 2"},{"line_number":378,"context_line":"                # TODO(vinodh) FAZone string format needs to verified with the"},{"line_number":379,"context_line":"                # back end team"},{"line_number":380,"context_line":"                elif ZoneConstant.IFA_DELIM in info:"},{"line_number":381,"context_line":"                    ifa_name \u003d info.lstrip(ZoneConstant.IFA_DELIM)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_54fc9571","line":378,"in_reply_to":"5afe65bd_53ad4787","updated":"2015-06-04 12:06:28.000000000","message":"Verified with backend team.","commit_id":"0611c5117842d2b015914ff2a7fd95d5a254ff19"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"102868d2f197e190738cc65628da56e561cd4f18","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"from requests import Session"},{"line_number":24,"context_line":"import time"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_f403a774","line":23,"updated":"2015-06-22 20:29:33.000000000","message":"Same here","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"a7fb8ace56f095787d2ed40aa79a37365d4394a3","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"from requests import Session"},{"line_number":24,"context_line":"import time"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_10ddd741","line":23,"in_reply_to":"fa32b979_f403a774","updated":"2015-06-24 12:03:49.000000000","message":"Done","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"102868d2f197e190738cc65628da56e561cd4f18","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            LOG.error(msg)"},{"line_number":257,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def get_managable_VF_list(self, session_info):"},{"line_number":260,"context_line":"        \"\"\"List of VFIDs that can be managed."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        :param session_info: Session information from the switch"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_541b73ca","line":259,"updated":"2015-06-22 20:29:33.000000000","message":"According to python guidelines, method variable names should not contain upper-case letters","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"a7fb8ace56f095787d2ed40aa79a37365d4394a3","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            LOG.error(msg)"},{"line_number":257,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def get_managable_VF_list(self, session_info):"},{"line_number":260,"context_line":"        \"\"\"List of VFIDs that can be managed."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        :param session_info: Session information from the switch"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_38b80175","line":259,"in_reply_to":"fa32b979_541b73ca","updated":"2015-06-24 12:03:49.000000000","message":"Done","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"102868d2f197e190738cc65628da56e561cd4f18","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                                         ZoneConstant.MANAGEABLE_VF)"},{"line_number":271,"context_line":"            if VF_list:"},{"line_number":272,"context_line":"                VF_list \u003d VF_list.split(\",\")  # convert the string to list"},{"line_number":273,"context_line":"        except Exception as e:"},{"line_number":274,"context_line":"            msg \u003d _(\"Error while checking whether\""},{"line_number":275,"context_line":"                    \" VF is available for management %s \") % e"},{"line_number":276,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_d48543cf","line":273,"updated":"2015-06-22 20:29:33.000000000","message":"Can we catch more specific exception here and below?","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"a7fb8ace56f095787d2ed40aa79a37365d4394a3","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                                         ZoneConstant.MANAGEABLE_VF)"},{"line_number":271,"context_line":"            if VF_list:"},{"line_number":272,"context_line":"                VF_list \u003d VF_list.split(\",\")  # convert the string to list"},{"line_number":273,"context_line":"        except Exception as e:"},{"line_number":274,"context_line":"            msg \u003d _(\"Error while checking whether\""},{"line_number":275,"context_line":"                    \" VF is available for management %s \") % e"},{"line_number":276,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_d8b1d590","line":273,"in_reply_to":"fa32b979_d48543cf","updated":"2015-06-24 12:03:49.000000000","message":"Done","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            else:"},{"line_number":120,"context_line":"                LOG.info(_LI(\"Connected to the switch\"))"},{"line_number":121,"context_line":"                return response.text"},{"line_number":122,"context_line":"        except Exception as e:"},{"line_number":123,"context_line":"            msg \u003d _(\"Error while connecting the switch %{switch_id}\""},{"line_number":124,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":125,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0f05950f","line":122,"updated":"2015-07-08 14:26:55.000000000","message":"Can you catch something more specific than Exception?","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            else:"},{"line_number":120,"context_line":"                LOG.info(_LI(\"Connected to the switch\"))"},{"line_number":121,"context_line":"                return response.text"},{"line_number":122,"context_line":"        except Exception as e:"},{"line_number":123,"context_line":"            msg \u003d _(\"Error while connecting the switch %{switch_id}\""},{"line_number":124,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":125,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_b22e2541","line":122,"in_reply_to":"ba3cc151_0f05950f","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":125,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":126,"context_line":"                                          \u0027protocol\u0027: self.protocol,"},{"line_number":127,"context_line":"                                          \u0027error\u0027: e}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"            LOG.error(msg)"},{"line_number":130,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_6f146143","line":127,"updated":"2015-07-08 14:26:55.000000000","message":"Needs six.text_type().","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":125,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":126,"context_line":"                                          \u0027protocol\u0027: self.protocol,"},{"line_number":127,"context_line":"                                          \u0027error\u0027: e}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"            LOG.error(msg)"},{"line_number":130,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_2f42b2ae","line":127,"in_reply_to":"ba3cc151_6f146143","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            # Extract the random no from secinfo.html response"},{"line_number":150,"context_line":"            self.random_no \u003d self.get_nvp_value(parsed_data,"},{"line_number":151,"context_line":"                                                zone_constant.RANDOM)"},{"line_number":152,"context_line":"            auth_string \u003d self.switch_user + \":\" + self.switch_pwd + \\"},{"line_number":153,"context_line":"                \":\" + self.random_no  # Form the authentication string"},{"line_number":154,"context_line":"            auth_token \u003d auth_string.encode("},{"line_number":155,"context_line":"                \"base64\", \"strict\").strip()  # encode in base64 format"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_4f171d45","line":152,"updated":"2015-07-08 14:26:55.000000000","message":"Wrap in () to avoid using \\ for line continuation.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            # Extract the random no from secinfo.html response"},{"line_number":150,"context_line":"            self.random_no \u003d self.get_nvp_value(parsed_data,"},{"line_number":151,"context_line":"                                                zone_constant.RANDOM)"},{"line_number":152,"context_line":"            auth_string \u003d self.switch_user + \":\" + self.switch_pwd + \\"},{"line_number":153,"context_line":"                \":\" + self.random_no  # Form the authentication string"},{"line_number":154,"context_line":"            auth_token \u003d auth_string.encode("},{"line_number":155,"context_line":"                \"base64\", \"strict\").strip()  # encode in base64 format"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_ef47eab9","line":152,"in_reply_to":"ba3cc151_4f171d45","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                \":\" + self.random_no  # Form the authentication string"},{"line_number":154,"context_line":"            auth_token \u003d auth_string.encode("},{"line_number":155,"context_line":"                \"base64\", \"strict\").strip()  # encode in base64 format"},{"line_number":156,"context_line":"            auth_header \u003d zone_constant.AUTH_STRING + \\"},{"line_number":157,"context_line":"                auth_token  # Build the proper header"},{"line_number":158,"context_line":"            LOG.debug(\"Authentication header : %s\" % auth_header)"},{"line_number":159,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_ef2631b9","line":156,"updated":"2015-07-08 14:26:55.000000000","message":"Same.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                \":\" + self.random_no  # Form the authentication string"},{"line_number":154,"context_line":"            auth_token \u003d auth_string.encode("},{"line_number":155,"context_line":"                \"base64\", \"strict\").strip()  # encode in base64 format"},{"line_number":156,"context_line":"            auth_header \u003d zone_constant.AUTH_STRING + \\"},{"line_number":157,"context_line":"                auth_token  # Build the proper header"},{"line_number":158,"context_line":"            LOG.debug(\"Authentication header : %s\" % auth_header)"},{"line_number":159,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_af14829f","line":156,"in_reply_to":"ba3cc151_ef2631b9","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                auth_token  # Build the proper header"},{"line_number":158,"context_line":"            LOG.debug(\"Authentication header : %s\" % auth_header)"},{"line_number":159,"context_line":"        except Exception as e:"},{"line_number":160,"context_line":"            msg \u003d _(\"Error while creating authentication token %s \") % e"},{"line_number":161,"context_line":"            LOG.error(msg)"},{"line_number":162,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":163,"context_line":"        return auth_header"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_cf21ed9f","line":160,"updated":"2015-07-08 14:26:55.000000000","message":"Needs six.text_type or do LOG.exception and don\u0027t include this in the string.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                auth_token  # Build the proper header"},{"line_number":158,"context_line":"            LOG.debug(\"Authentication header : %s\" % auth_header)"},{"line_number":159,"context_line":"        except Exception as e:"},{"line_number":160,"context_line":"            msg \u003d _(\"Error while creating authentication token %s \") % e"},{"line_number":161,"context_line":"            LOG.error(msg)"},{"line_number":162,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":163,"context_line":"        return auth_header"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_af62423c","line":160,"in_reply_to":"ba3cc151_cf21ed9f","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                parsed_data, zone_constant.AUTHENTICATED)"},{"line_number":185,"context_line":"            if isauthenticated \u003d\u003d \"yes\":"},{"line_number":186,"context_line":"                # Replace password in the authentication string with xxx"},{"line_number":187,"context_line":"                auth_string \u003d self.switch_user + \\"},{"line_number":188,"context_line":"                    \":\" + \"xxx\" + \":\" + self.random_no"},{"line_number":189,"context_line":"                auth_token \u003d auth_string.encode(\"base64\", \"strict\").strip()"},{"line_number":190,"context_line":"                auth_header \u003d zone_constant.AUTH_STRING + auth_token"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_4f2e3d8d","line":187,"updated":"2015-07-08 14:26:55.000000000","message":"Use () instead of \\.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                parsed_data, zone_constant.AUTHENTICATED)"},{"line_number":185,"context_line":"            if isauthenticated \u003d\u003d \"yes\":"},{"line_number":186,"context_line":"                # Replace password in the authentication string with xxx"},{"line_number":187,"context_line":"                auth_string \u003d self.switch_user + \\"},{"line_number":188,"context_line":"                    \":\" + \"xxx\" + \":\" + self.random_no"},{"line_number":189,"context_line":"                auth_token \u003d auth_string.encode(\"base64\", \"strict\").strip()"},{"line_number":190,"context_line":"                auth_header \u003d zone_constant.AUTH_STRING + auth_token"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_4f529668","line":187,"in_reply_to":"ba3cc151_4f2e3d8d","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                LOG.error(msg)"},{"line_number":198,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":199,"context_line":"        except Exception as e:"},{"line_number":200,"context_line":"            msg \u003d _(\"Error while authenticating with switch %s \""},{"line_number":201,"context_line":"                    ) % e"},{"line_number":202,"context_line":"            LOG.error(msg)"},{"line_number":203,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_2f5f3910","line":200,"updated":"2015-07-08 14:26:55.000000000","message":"Get rid of trailing space and wrap e in six.text_type.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                LOG.error(msg)"},{"line_number":198,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":199,"context_line":"        except Exception as e:"},{"line_number":200,"context_line":"            msg \u003d _(\"Error while authenticating with switch %s \""},{"line_number":201,"context_line":"                    ) % e"},{"line_number":202,"context_line":"            LOG.error(msg)"},{"line_number":203,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_afc9e227","line":200,"in_reply_to":"ba3cc151_2f5f3910","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                                    zone_constant.SESSION_PAGE_ACTION,"},{"line_number":215,"context_line":"                                    header\u003dheaders)"},{"line_number":216,"context_line":"        except Exception as e:"},{"line_number":217,"context_line":"            msg \u003d _(\"Error while getting session information %s \") % e"},{"line_number":218,"context_line":"            LOG.error(msg)"},{"line_number":219,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":220,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_afa109f9","line":217,"updated":"2015-07-08 14:26:55.000000000","message":"Same.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                                    zone_constant.SESSION_PAGE_ACTION,"},{"line_number":215,"context_line":"                                    header\u003dheaders)"},{"line_number":216,"context_line":"        except Exception as e:"},{"line_number":217,"context_line":"            msg \u003d _(\"Error while getting session information %s \") % e"},{"line_number":218,"context_line":"            LOG.error(msg)"},{"line_number":219,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":220,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_efe36aa2","line":217,"in_reply_to":"ba3cc151_afa109f9","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            end \u003d data.index(demil2)"},{"line_number":234,"context_line":"            return data[start:end]"},{"line_number":235,"context_line":"        except Exception as e:"},{"line_number":236,"context_line":"            msg \u003d _(\"Error while parsing the data %s \") % e"},{"line_number":237,"context_line":"            LOG.error(msg)"},{"line_number":238,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0f883570","line":236,"updated":"2015-07-08 14:26:55.000000000","message":"Same.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            end \u003d data.index(demil2)"},{"line_number":234,"context_line":"            return data[start:end]"},{"line_number":235,"context_line":"        except Exception as e:"},{"line_number":236,"context_line":"            msg \u003d _(\"Error while parsing the data %s \") % e"},{"line_number":237,"context_line":"            LOG.error(msg)"},{"line_number":238,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0fdfaed6","line":236,"in_reply_to":"ba3cc151_0f883570","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            end \u003d temp.index(\"\\n\")"},{"line_number":252,"context_line":"            return(temp[:end].lstrip(\u0027\u003d \u0027))"},{"line_number":253,"context_line":"        except Exception as e:"},{"line_number":254,"context_line":"            msg \u003d _(\"Error while getting nvp value %s \") % e"},{"line_number":255,"context_line":"            LOG.error(msg)"},{"line_number":256,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_cf7d6d6e","line":254,"updated":"2015-07-08 14:26:55.000000000","message":"Same.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            end \u003d temp.index(\"\\n\")"},{"line_number":252,"context_line":"            return(temp[:end].lstrip(\u0027\u003d \u0027))"},{"line_number":253,"context_line":"        except Exception as e:"},{"line_number":254,"context_line":"            msg \u003d _(\"Error while getting nvp value %s \") % e"},{"line_number":255,"context_line":"            LOG.error(msg)"},{"line_number":256,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_122ef18b","line":254,"in_reply_to":"ba3cc151_cf7d6d6e","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                vf_list \u003d vf_list.split(\",\")  # convert the string to list"},{"line_number":272,"context_line":"        except exception.BrocadeZoningHttpsException as e:"},{"line_number":273,"context_line":"            msg \u003d _(\"Error while checking whether\""},{"line_number":274,"context_line":"                    \" VF is available for management %s \") % e"},{"line_number":275,"context_line":"            LOG.error(msg)"},{"line_number":276,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":277,"context_line":"        return vf_list[:-1]"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_2f8df97b","line":274,"updated":"2015-07-08 14:26:55.000000000","message":"Same.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                vf_list \u003d vf_list.split(\",\")  # convert the string to list"},{"line_number":272,"context_line":"        except exception.BrocadeZoningHttpsException as e:"},{"line_number":273,"context_line":"            msg \u003d _(\"Error while checking whether\""},{"line_number":274,"context_line":"                    \" VF is available for management %s \") % e"},{"line_number":275,"context_line":"            LOG.error(msg)"},{"line_number":276,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":277,"context_line":"        return vf_list[:-1]"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_cff30672","line":274,"in_reply_to":"ba3cc151_2f8df97b","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        try:"},{"line_number":287,"context_line":"            managable_vf_list \u003d self.get_managable_vf_list("},{"line_number":288,"context_line":"                session_data)  # Get the list of Manageable VF list"},{"line_number":289,"context_line":"            LOG.debug(\"Manageable VF IDs are %s\" % managable_vf_list)"},{"line_number":290,"context_line":"            # proceed changing the VF context"},{"line_number":291,"context_line":"            # if VF id can be managed if not throw exception"},{"line_number":292,"context_line":"            if vfid in managable_vf_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0fefd51e","line":289,"updated":"2015-07-08 14:26:55.000000000","message":"% \u003d\u003e ,","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        try:"},{"line_number":287,"context_line":"            managable_vf_list \u003d self.get_managable_vf_list("},{"line_number":288,"context_line":"                session_data)  # Get the list of Manageable VF list"},{"line_number":289,"context_line":"            LOG.debug(\"Manageable VF IDs are %s\" % managable_vf_list)"},{"line_number":290,"context_line":"            # proceed changing the VF context"},{"line_number":291,"context_line":"            # if VF id can be managed if not throw exception"},{"line_number":292,"context_line":"            if vfid in managable_vf_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_8fe97e81","line":289,"in_reply_to":"ba3cc151_0fefd51e","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"            else:"},{"line_number":312,"context_line":"                msg \u003d _(\"Cannot Change VF context,\""},{"line_number":313,"context_line":"                        \"Specified VF in not available\""},{"line_number":314,"context_line":"                        \"in the manageable VF list %(vf_list)s\""},{"line_number":315,"context_line":"                        ) % {\u0027vf_list\u0027: managable_vf_list}"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_4fe15d29","line":312,"updated":"2015-07-08 14:26:55.000000000","message":"Needs trailing space.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"            else:"},{"line_number":312,"context_line":"                msg \u003d _(\"Cannot Change VF context,\""},{"line_number":313,"context_line":"                        \"Specified VF in not available\""},{"line_number":314,"context_line":"                        \"in the manageable VF list %(vf_list)s\""},{"line_number":315,"context_line":"                        ) % {\u0027vf_list\u0027: managable_vf_list}"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_af97a2ea","line":312,"in_reply_to":"ba3cc151_4fe15d29","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"            else:"},{"line_number":312,"context_line":"                msg \u003d _(\"Cannot Change VF context,\""},{"line_number":313,"context_line":"                        \"Specified VF in not available\""},{"line_number":314,"context_line":"                        \"in the manageable VF list %(vf_list)s\""},{"line_number":315,"context_line":"                        ) % {\u0027vf_list\u0027: managable_vf_list}"},{"line_number":316,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_afc6e999","line":313,"updated":"2015-07-08 14:26:55.000000000","message":"Needs trailing space.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"            else:"},{"line_number":312,"context_line":"                msg \u003d _(\"Cannot Change VF context,\""},{"line_number":313,"context_line":"                        \"Specified VF in not available\""},{"line_number":314,"context_line":"                        \"in the manageable VF list %(vf_list)s\""},{"line_number":315,"context_line":"                        ) % {\u0027vf_list\u0027: managable_vf_list}"},{"line_number":316,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_6f9d1a09","line":313,"in_reply_to":"ba3cc151_afc6e999","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                LOG.error(msg)"},{"line_number":317,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":318,"context_line":"        except exception.BrocadeZoningHttpsException as e:"},{"line_number":319,"context_line":"            msg \u003d _(\"Error while changing VF context  %s\") % e"},{"line_number":320,"context_line":"            LOG.error(msg)"},{"line_number":321,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_2fbbb910","line":319,"updated":"2015-07-08 14:26:55.000000000","message":"Extra space, wrap e in six.text_type.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                LOG.error(msg)"},{"line_number":317,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":318,"context_line":"        except exception.BrocadeZoningHttpsException as e:"},{"line_number":319,"context_line":"            msg \u003d _(\"Error while changing VF context  %s\") % e"},{"line_number":320,"context_line":"            LOG.error(msg)"},{"line_number":321,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0f8d6ed2","line":319,"in_reply_to":"ba3cc151_2fbbb910","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                response,"},{"line_number":341,"context_line":"                zone_constant.ZONEINFO_BEGIN,"},{"line_number":342,"context_line":"                zone_constant.ZONEINFO_END).strip(\"\\n\")"},{"line_number":343,"context_line":"            LOG.debug(\"Original Zone string\""},{"line_number":344,"context_line":"                      \"from the switch %s\" %"},{"line_number":345,"context_line":"                      self.parsed_raw_zoneinfo)"},{"line_number":346,"context_line":"            # convert the zone string to list"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_4fb87d11","line":343,"updated":"2015-07-08 14:26:55.000000000","message":"Needs trailing space.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                response,"},{"line_number":341,"context_line":"                zone_constant.ZONEINFO_BEGIN,"},{"line_number":342,"context_line":"                zone_constant.ZONEINFO_END).strip(\"\\n\")"},{"line_number":343,"context_line":"            LOG.debug(\"Original Zone string\""},{"line_number":344,"context_line":"                      \"from the switch %s\" %"},{"line_number":345,"context_line":"                      self.parsed_raw_zoneinfo)"},{"line_number":346,"context_line":"            # convert the zone string to list"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_8f6e5efe","line":343,"in_reply_to":"ba3cc151_4fb87d11","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                zone_constant.ZONEINFO_BEGIN,"},{"line_number":342,"context_line":"                zone_constant.ZONEINFO_END).strip(\"\\n\")"},{"line_number":343,"context_line":"            LOG.debug(\"Original Zone string\""},{"line_number":344,"context_line":"                      \"from the switch %s\" %"},{"line_number":345,"context_line":"                      self.parsed_raw_zoneinfo)"},{"line_number":346,"context_line":"            # convert the zone string to list"},{"line_number":347,"context_line":"            zoneinfo \u003d self.parsed_raw_zoneinfo.split()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0f3d958e","line":344,"updated":"2015-07-08 14:26:55.000000000","message":"% \u003d\u003e ,","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                zone_constant.ZONEINFO_BEGIN,"},{"line_number":342,"context_line":"                zone_constant.ZONEINFO_END).strip(\"\\n\")"},{"line_number":343,"context_line":"            LOG.debug(\"Original Zone string\""},{"line_number":344,"context_line":"                      \"from the switch %s\" %"},{"line_number":345,"context_line":"                      self.parsed_raw_zoneinfo)"},{"line_number":346,"context_line":"            # convert the zone string to list"},{"line_number":347,"context_line":"            zoneinfo \u003d self.parsed_raw_zoneinfo.split()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_2f7ab2bd","line":344,"in_reply_to":"ba3cc151_0f3d958e","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            # convert the zone string to list"},{"line_number":347,"context_line":"            zoneinfo \u003d self.parsed_raw_zoneinfo.split()"},{"line_number":348,"context_line":"            i \u003d 0"},{"line_number":349,"context_line":"            while(i \u003c len(zoneinfo)):"},{"line_number":350,"context_line":"                info \u003d zoneinfo[i]"},{"line_number":351,"context_line":"                # check for the cfg delimiter"},{"line_number":352,"context_line":"                if zone_constant.CFG_DELIM in info:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0f0b55d7","line":349,"updated":"2015-07-08 14:26:55.000000000","message":"Remove unnecessary () around conditional.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            # convert the zone string to list"},{"line_number":347,"context_line":"            zoneinfo \u003d self.parsed_raw_zoneinfo.split()"},{"line_number":348,"context_line":"            i \u003d 0"},{"line_number":349,"context_line":"            while(i \u003c len(zoneinfo)):"},{"line_number":350,"context_line":"                info \u003d zoneinfo[i]"},{"line_number":351,"context_line":"                # check for the cfg delimiter"},{"line_number":352,"context_line":"                if zone_constant.CFG_DELIM in info:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_cf4f8690","line":349,"in_reply_to":"ba3cc151_0f0b55d7","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                else:"},{"line_number":393,"context_line":"                    i \u003d i + 1"},{"line_number":394,"context_line":"        except Exception as e:"},{"line_number":395,"context_line":"            msg \u003d _(\"Error while changing VF context  %s \""},{"line_number":396,"context_line":"                    ) % e"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0fd91557","line":395,"updated":"2015-07-08 14:26:55.000000000","message":"Extra spaces, six.text_type, yada, yada, yada.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                else:"},{"line_number":393,"context_line":"                    i \u003d i + 1"},{"line_number":394,"context_line":"        except Exception as e:"},{"line_number":395,"context_line":"            msg \u003d _(\"Error while changing VF context  %s \""},{"line_number":396,"context_line":"                    ) % e"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_4f5cd64a","line":395,"in_reply_to":"ba3cc151_0fd91557","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        except Exception as e:"},{"line_number":434,"context_line":"            msg \u003d _(\"Error while checking the firmware version %s\""},{"line_number":435,"context_line":"                    ) % e"},{"line_number":436,"context_line":"            LOG.error(msg)"},{"line_number":437,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":438,"context_line":"        return isfwsupported"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_6f96a14d","line":435,"updated":"2015-07-08 14:26:55.000000000","message":"six.text_type","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        except Exception as e:"},{"line_number":434,"context_line":"            msg \u003d _(\"Error while checking the firmware version %s\""},{"line_number":435,"context_line":"                    ) % e"},{"line_number":436,"context_line":"            LOG.error(msg)"},{"line_number":437,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":438,"context_line":"        return isfwsupported"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_6f399af1","line":435,"in_reply_to":"ba3cc151_6f96a14d","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            return active_zone_set"},{"line_number":471,"context_line":"        except Exception as e:"},{"line_number":472,"context_line":"            msg \u003d _(\"Failed getting active zone set \""},{"line_number":473,"context_line":"                    \"from fabric %s\") % e"},{"line_number":474,"context_line":"            LOG.error(msg)"},{"line_number":475,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":476,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_2f73b94f","line":473,"updated":"2015-07-08 14:26:55.000000000","message":"six","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            return active_zone_set"},{"line_number":471,"context_line":"        except Exception as e:"},{"line_number":472,"context_line":"            msg \u003d _(\"Failed getting active zone set \""},{"line_number":473,"context_line":"                    \"from fabric %s\") % e"},{"line_number":474,"context_line":"            LOG.error(msg)"},{"line_number":475,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":476,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_2f287299","line":473,"in_reply_to":"ba3cc151_2f73b94f","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":491,"context_line":"                              get_active_zone_set method"},{"line_number":492,"context_line":"        :raises: BrocadeZoningHttpsException"},{"line_number":493,"context_line":"        \"\"\""},{"line_number":494,"context_line":"        LOG.debug(\"Add Zones - Zones passed: %s\" % add_zones_info)"},{"line_number":495,"context_line":"        cfg_name \u003d zone_constant.CFG_NAME"},{"line_number":496,"context_line":"        cfgs \u003d self.cfgs"},{"line_number":497,"context_line":"        zones \u003d self.zones"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_af958932","line":494,"updated":"2015-07-08 14:26:55.000000000","message":"% \u003d\u003e ,","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":491,"context_line":"                              get_active_zone_set method"},{"line_number":492,"context_line":"        :raises: BrocadeZoningHttpsException"},{"line_number":493,"context_line":"        \"\"\""},{"line_number":494,"context_line":"        LOG.debug(\"Add Zones - Zones passed: %s\" % add_zones_info)"},{"line_number":495,"context_line":"        cfg_name \u003d zone_constant.CFG_NAME"},{"line_number":496,"context_line":"        cfgs \u003d self.cfgs"},{"line_number":497,"context_line":"        zones \u003d self.zones"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_4f2376bd","line":494,"in_reply_to":"ba3cc151_af958932","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":549,"context_line":""},{"line_number":550,"context_line":"            # Form the zone string based on the dictionary of each items"},{"line_number":551,"context_line":"            for cfg in cfgs.keys():"},{"line_number":552,"context_line":"                zoneString +\u003d zone_constant.CFG_DELIM + \\"},{"line_number":553,"context_line":"                    cfg + \" \" + cfgs.get(cfg) + \" \""},{"line_number":554,"context_line":"            for zone in zones.keys():"},{"line_number":555,"context_line":"                zoneString +\u003d zone_constant.ZONE_DELIM + \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_cfb1ede1","line":552,"updated":"2015-07-08 14:26:55.000000000","message":"Use () instead of \\ all throughout here.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":549,"context_line":""},{"line_number":550,"context_line":"            # Form the zone string based on the dictionary of each items"},{"line_number":551,"context_line":"            for cfg in cfgs.keys():"},{"line_number":552,"context_line":"                zoneString +\u003d zone_constant.CFG_DELIM + \\"},{"line_number":553,"context_line":"                    cfg + \" \" + cfgs.get(cfg) + \" \""},{"line_number":554,"context_line":"            for zone in zones.keys():"},{"line_number":555,"context_line":"                zoneString +\u003d zone_constant.ZONE_DELIM + \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_2f0f1238","line":552,"in_reply_to":"ba3cc151_cfb1ede1","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":571,"context_line":"            # Build the final zone string"},{"line_number":572,"context_line":"            zoneString +\u003d zone_constant.ZONE_END_DELIM + saveonly"},{"line_number":573,"context_line":"        except Exception as e:"},{"line_number":574,"context_line":"            msg \u003d _(\"Exception while forming the zone string : %s\") % e"},{"line_number":575,"context_line":"            LOG.error(msg)"},{"line_number":576,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":577,"context_line":"        return zoneString"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_4fbe3daf","line":574,"updated":"2015-07-08 14:26:55.000000000","message":"six","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":571,"context_line":"            # Build the final zone string"},{"line_number":572,"context_line":"            zoneString +\u003d zone_constant.ZONE_END_DELIM + saveonly"},{"line_number":573,"context_line":"        except Exception as e:"},{"line_number":574,"context_line":"            msg \u003d _(\"Exception while forming the zone string : %s\") % e"},{"line_number":575,"context_line":"            LOG.error(msg)"},{"line_number":576,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":577,"context_line":"        return zoneString"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_ef04ca18","line":574,"in_reply_to":"ba3cc151_4fbe3daf","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        except Exception as e:"},{"line_number":628,"context_line":"            msg \u003d _(\"Error while updating the new zones and cfgs \""},{"line_number":629,"context_line":"                    \"in the zone string. Error %(description)s\""},{"line_number":630,"context_line":"                    ) % {\u0027description\u0027: e}"},{"line_number":631,"context_line":"            LOG.error(msg)"},{"line_number":632,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":633,"context_line":"        return zones, cfgs, active_cfg"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_efddd114","line":630,"updated":"2015-07-08 14:26:55.000000000","message":"six","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        except Exception as e:"},{"line_number":628,"context_line":"            msg \u003d _(\"Error while updating the new zones and cfgs \""},{"line_number":629,"context_line":"                    \"in the zone string. Error %(description)s\""},{"line_number":630,"context_line":"                    ) % {\u0027description\u0027: e}"},{"line_number":631,"context_line":"            LOG.error(msg)"},{"line_number":632,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":633,"context_line":"        return zones, cfgs, active_cfg"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_d2040916","line":630,"in_reply_to":"ba3cc151_efddd114","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":676,"context_line":"    def delete_update_zones_cfgs("},{"line_number":677,"context_line":"            self, cfgs, zones,"},{"line_number":678,"context_line":"            delete_zones_info, active_cfg):"},{"line_number":679,"context_line":"        \"\"\"Add or update the zones and cfgs map based on the new zones info"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        Return the updated zones, cfgs and active_cfg after deleting the"},{"line_number":682,"context_line":"        required items."}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_ef12b1b3","line":679,"updated":"2015-07-08 14:26:55.000000000","message":"Please end summary line with a period.","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":676,"context_line":"    def delete_update_zones_cfgs("},{"line_number":677,"context_line":"            self, cfgs, zones,"},{"line_number":678,"context_line":"            delete_zones_info, active_cfg):"},{"line_number":679,"context_line":"        \"\"\"Add or update the zones and cfgs map based on the new zones info"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        Return the updated zones, cfgs and active_cfg after deleting the"},{"line_number":682,"context_line":"        required items."}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_920a011f","line":679,"in_reply_to":"ba3cc151_ef12b1b3","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f5558d51e0bed3f23eadc72af0c74c3473b94f0","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        except Exception as e:"},{"line_number":717,"context_line":"            msg \u003d _(\"Error while removing the zones and cfgs \""},{"line_number":718,"context_line":"                    \"in the zone string. Error %(description)s\""},{"line_number":719,"context_line":"                    ) % {\u0027description\u0027: e}"},{"line_number":720,"context_line":"            LOG.error(msg)"},{"line_number":721,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":722,"context_line":"        return zones, cfgs, active_cfg"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0f7fd5e0","line":719,"updated":"2015-07-08 14:26:55.000000000","message":"six","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f729c52c779ab5aef7d762e4c3e292f36018dcaf","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        except Exception as e:"},{"line_number":717,"context_line":"            msg \u003d _(\"Error while removing the zones and cfgs \""},{"line_number":718,"context_line":"                    \"in the zone string. Error %(description)s\""},{"line_number":719,"context_line":"                    ) % {\u0027description\u0027: e}"},{"line_number":720,"context_line":"            LOG.error(msg)"},{"line_number":721,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":722,"context_line":"        return zones, cfgs, active_cfg"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_f21b4d71","line":719,"in_reply_to":"ba3cc151_0f7fd5e0","updated":"2015-07-09 09:06:10.000000000","message":"Done","commit_id":"4ad706ff4bf7e8d3cfecde960d2158e7eeaaac84"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                LOG.error(msg)"},{"line_number":119,"context_line":"                raise exception.BrocadeZoningHttpsException(msg)"},{"line_number":120,"context_line":"            else:"},{"line_number":121,"context_line":"                LOG.info(_LI(\"Connected to the switch\"))"},{"line_number":122,"context_line":"                return response.text"},{"line_number":123,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":124,"context_line":"            msg \u003d _(\"Error while connecting the switch %{switch_id}\""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_44f34273","line":121,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                LOG.error(msg)"},{"line_number":119,"context_line":"                raise exception.BrocadeZoningHttpsException(msg)"},{"line_number":120,"context_line":"            else:"},{"line_number":121,"context_line":"                LOG.info(_LI(\"Connected to the switch\"))"},{"line_number":122,"context_line":"                return response.text"},{"line_number":123,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":124,"context_line":"            msg \u003d _(\"Error while connecting the switch %{switch_id}\""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_aa63d0dc","line":121,"in_reply_to":"ba3cc151_44f34273","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                return response.text"},{"line_number":123,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":124,"context_line":"            msg \u003d _(\"Error while connecting the switch %{switch_id}\""},{"line_number":125,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":126,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":127,"context_line":"                                          \u0027protocol\u0027: self.protocol,"},{"line_number":128,"context_line":"                                          \u0027error\u0027: six.text_type(e)}"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_c4ff5232","line":125,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                return response.text"},{"line_number":123,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":124,"context_line":"            msg \u003d _(\"Error while connecting the switch %{switch_id}\""},{"line_number":125,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":126,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":127,"context_line":"                                          \u0027protocol\u0027: self.protocol,"},{"line_number":128,"context_line":"                                          \u0027error\u0027: six.text_type(e)}"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_6a5dc814","line":125,"in_reply_to":"ba3cc151_c4ff5232","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"0115186579c7895df722e396f339c405a95c65e7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":126,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":127,"context_line":"                                          \u0027protocol\u0027: self.protocol,"},{"line_number":128,"context_line":"                                          \u0027error\u0027: six.text_type(e)}"},{"line_number":129,"context_line":"        except exception.BrocadeZoningHttpsException as ex:"},{"line_number":130,"context_line":"            msg \u003d _(\"Unexpected status code from the switch %{switch_id}\""},{"line_number":131,"context_line":"                    \" with protocol %{protocol} \""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_1e84a1d0","line":128,"updated":"2015-07-09 15:21:06.000000000","message":"how are we using \u0027msg\u0027  after caching exception?","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":126,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":127,"context_line":"                                          \u0027protocol\u0027: self.protocol,"},{"line_number":128,"context_line":"                                          \u0027error\u0027: six.text_type(e)}"},{"line_number":129,"context_line":"        except exception.BrocadeZoningHttpsException as ex:"},{"line_number":130,"context_line":"            msg \u003d _(\"Unexpected status code from the switch %{switch_id}\""},{"line_number":131,"context_line":"                    \" with protocol %{protocol} \""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_6ab4e834","line":128,"in_reply_to":"ba3cc151_1e84a1d0","updated":"2015-07-10 11:18:26.000000000","message":"Logged the msg and also raised exception.","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        except exception.BrocadeZoningHttpsException as ex:"},{"line_number":130,"context_line":"            msg \u003d _(\"Unexpected status code from the switch %{switch_id}\""},{"line_number":131,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":132,"context_line":"                    \" for url %{page} \""},{"line_number":133,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":134,"context_line":"                                          \u0027protocol\u0027: self.protocol,"},{"line_number":135,"context_line":"                                          \u0027page\u0027: requestURL,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_64fa0645","line":132,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        except exception.BrocadeZoningHttpsException as ex:"},{"line_number":130,"context_line":"            msg \u003d _(\"Unexpected status code from the switch %{switch_id}\""},{"line_number":131,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":132,"context_line":"                    \" for url %{page} \""},{"line_number":133,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":134,"context_line":"                                          \u0027protocol\u0027: self.protocol,"},{"line_number":135,"context_line":"                                          \u0027page\u0027: requestURL,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_ca797484","line":132,"in_reply_to":"ba3cc151_64fa0645","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                session_LF_Id \u003d self.get_nvp_value(parsed_info,"},{"line_number":315,"context_line":"                                                   zone_constant.SESSION_LF_ID)"},{"line_number":316,"context_line":"                if session_LF_Id \u003d\u003d vfid:"},{"line_number":317,"context_line":"                    LOG.info(_LI(\"VF context is changed in the session\"))"},{"line_number":318,"context_line":"                else:"},{"line_number":319,"context_line":"                    msg \u003d _(\"Cannot Change VF context in the session\")"},{"line_number":320,"context_line":"                    LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_04453a6d","line":317,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                session_LF_Id \u003d self.get_nvp_value(parsed_info,"},{"line_number":315,"context_line":"                                                   zone_constant.SESSION_LF_ID)"},{"line_number":316,"context_line":"                if session_LF_Id \u003d\u003d vfid:"},{"line_number":317,"context_line":"                    LOG.info(_LI(\"VF context is changed in the session\"))"},{"line_number":318,"context_line":"                else:"},{"line_number":319,"context_line":"                    msg \u003d _(\"Cannot Change VF context in the session\")"},{"line_number":320,"context_line":"                    LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_4a8ec47a","line":317,"in_reply_to":"ba3cc151_04453a6d","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                if session_LF_Id \u003d\u003d vfid:"},{"line_number":317,"context_line":"                    LOG.info(_LI(\"VF context is changed in the session\"))"},{"line_number":318,"context_line":"                else:"},{"line_number":319,"context_line":"                    msg \u003d _(\"Cannot Change VF context in the session\")"},{"line_number":320,"context_line":"                    LOG.error(msg)"},{"line_number":321,"context_line":"                    raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_6456862b","line":319,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                if session_LF_Id \u003d\u003d vfid:"},{"line_number":317,"context_line":"                    LOG.info(_LI(\"VF context is changed in the session\"))"},{"line_number":318,"context_line":"                else:"},{"line_number":319,"context_line":"                    msg \u003d _(\"Cannot Change VF context in the session\")"},{"line_number":320,"context_line":"                    LOG.error(msg)"},{"line_number":321,"context_line":"                    raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_6a8b8869","line":319,"in_reply_to":"ba3cc151_6456862b","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            else:"},{"line_number":324,"context_line":"                msg \u003d _(\"Cannot Change VF context, \""},{"line_number":325,"context_line":"                        \"Specified VF in not available \""},{"line_number":326,"context_line":"                        \"in the manageable VF list %(vf_list)s\""},{"line_number":327,"context_line":"                        ) % {\u0027vf_list\u0027: managable_vf_list}"},{"line_number":328,"context_line":"                LOG.error(msg)"},{"line_number":329,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_642d26a7","line":326,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            else:"},{"line_number":324,"context_line":"                msg \u003d _(\"Cannot Change VF context, \""},{"line_number":325,"context_line":"                        \"Specified VF in not available \""},{"line_number":326,"context_line":"                        \"in the manageable VF list %(vf_list)s\""},{"line_number":327,"context_line":"                        ) % {\u0027vf_list\u0027: managable_vf_list}"},{"line_number":328,"context_line":"                LOG.error(msg)"},{"line_number":329,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_0ae75c47","line":326,"in_reply_to":"ba3cc151_642d26a7","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            LOG.error(msg)"},{"line_number":775,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":776,"context_line":"        else:"},{"line_number":777,"context_line":"            LOG.info(_LI(\"Zones and Cfgs are deleted successfully\"))"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    def post_zone_data(self, data):"},{"line_number":780,"context_line":"        \"\"\"Send POST request to the switch with the payload."}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_67b7683a","line":777,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            LOG.error(msg)"},{"line_number":775,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":776,"context_line":"        else:"},{"line_number":777,"context_line":"            LOG.info(_LI(\"Zones and Cfgs are deleted successfully\"))"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    def post_zone_data(self, data):"},{"line_number":780,"context_line":"        \"\"\"Send POST request to the switch with the payload."}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_8adb6c7d","line":777,"in_reply_to":"ba3cc151_67b7683a","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        parsed_data_txn \u003d \"\""},{"line_number":787,"context_line":"        headers \u003d {zone_constant.AUTH_HEADER: self.auth_header}"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"        LOG.debug(\"Requesting the switch with posting the zone string\")"},{"line_number":790,"context_line":"        # POST request to gzoneinfo with zonestring as payload"},{"line_number":791,"context_line":"        response \u003d self.connect(zone_constant.POST_METHOD,"},{"line_number":792,"context_line":"                                zone_constant.ZONE_PAGE,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_e7f058ff","line":789,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        parsed_data_txn \u003d \"\""},{"line_number":787,"context_line":"        headers \u003d {zone_constant.AUTH_HEADER: self.auth_header}"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"        LOG.debug(\"Requesting the switch with posting the zone string\")"},{"line_number":790,"context_line":"        # POST request to gzoneinfo with zonestring as payload"},{"line_number":791,"context_line":"        response \u003d self.connect(zone_constant.POST_METHOD,"},{"line_number":792,"context_line":"                                zone_constant.ZONE_PAGE,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_aad8b080","line":789,"in_reply_to":"ba3cc151_e7f058ff","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        if vf_enabled:"},{"line_number":835,"context_line":"            if self.vfid is None:"},{"line_number":836,"context_line":"                msg \u003d _(\"No vfid is defined in the configuration file\")"},{"line_number":837,"context_line":"                LOG.error(msg)"},{"line_number":838,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":839,"context_line":"            elif self.vfid !\u003d 128:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_c7c19481","line":836,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        if vf_enabled:"},{"line_number":835,"context_line":"            if self.vfid is None:"},{"line_number":836,"context_line":"                msg \u003d _(\"No vfid is defined in the configuration file\")"},{"line_number":837,"context_line":"                LOG.error(msg)"},{"line_number":838,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":839,"context_line":"            elif self.vfid !\u003d 128:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_4ae56436","line":836,"in_reply_to":"ba3cc151_c7c19481","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd31f2442d8c41e4ebd267865f9b537d1a124542","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                self.change_vf_context(self.vfid, session_data)"},{"line_number":841,"context_line":"        else:"},{"line_number":842,"context_line":"            if self.vfid is not None:"},{"line_number":843,"context_line":"                msg \u003d _(\"VF is not Enabled\")"},{"line_number":844,"context_line":"                LOG.error(msg)"},{"line_number":845,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":846,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_07421c0f","line":843,"updated":"2015-07-09 13:25:34.000000000","message":"\u0027.\u0027 at EOL","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"25238c17ddf8bf897cf6b142f2627911a45e72db","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                self.change_vf_context(self.vfid, session_data)"},{"line_number":841,"context_line":"        else:"},{"line_number":842,"context_line":"            if self.vfid is not None:"},{"line_number":843,"context_line":"                msg \u003d _(\"VF is not Enabled\")"},{"line_number":844,"context_line":"                LOG.error(msg)"},{"line_number":845,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":846,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_0ace7cb7","line":843,"in_reply_to":"ba3cc151_07421c0f","updated":"2015-07-10 11:18:26.000000000","message":"Done","commit_id":"5c33fd2cc3173429b8bb0a8b8a3c18f1d0b8e204"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"10e4eb941dba50745d660986b07e9fc7877b78e0","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":131,"context_line":"        except exception.BrocadeZoningHttpsException as ex:"},{"line_number":132,"context_line":"            msg \u003d _(\"Unexpected status code from the switch %{switch_id}\""},{"line_number":133,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":134,"context_line":"                    \" for url %{page}. \""},{"line_number":135,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":136,"context_line":"                                          \u0027protocol\u0027: self.protocol,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_a887fbd5","line":133,"updated":"2015-07-14 03:09:07.000000000","message":"Trailing space not needed since the next line\u0027s string starts with a space.","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"512ecef6dd17e5b6edc49740fb6ed33ece6d0851","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":131,"context_line":"        except exception.BrocadeZoningHttpsException as ex:"},{"line_number":132,"context_line":"            msg \u003d _(\"Unexpected status code from the switch %{switch_id}\""},{"line_number":133,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":134,"context_line":"                    \" for url %{page}. \""},{"line_number":135,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":136,"context_line":"                                          \u0027protocol\u0027: self.protocol,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_55d283d3","line":133,"in_reply_to":"9a41bdd9_a887fbd5","updated":"2015-07-15 10:07:29.000000000","message":"Done","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"10e4eb941dba50745d660986b07e9fc7877b78e0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            msg \u003d _(\"Unexpected status code from the switch %{switch_id}\""},{"line_number":133,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":134,"context_line":"                    \" for url %{page}. \""},{"line_number":135,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":136,"context_line":"                                          \u0027protocol\u0027: self.protocol,"},{"line_number":137,"context_line":"                                          \u0027page\u0027: requestURL,"},{"line_number":138,"context_line":"                                          \u0027error\u0027: six.text_type(ex)}"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_087947f6","line":135,"updated":"2015-07-14 03:09:07.000000000","message":"Would be better with a space after the :.","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"512ecef6dd17e5b6edc49740fb6ed33ece6d0851","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            msg \u003d _(\"Unexpected status code from the switch %{switch_id}\""},{"line_number":133,"context_line":"                    \" with protocol %{protocol} \""},{"line_number":134,"context_line":"                    \" for url %{page}. \""},{"line_number":135,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":136,"context_line":"                                          \u0027protocol\u0027: self.protocol,"},{"line_number":137,"context_line":"                                          \u0027page\u0027: requestURL,"},{"line_number":138,"context_line":"                                          \u0027error\u0027: six.text_type(ex)}"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_356a5f1b","line":135,"in_reply_to":"9a41bdd9_087947f6","updated":"2015-07-15 10:07:29.000000000","message":"Done","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"10e4eb941dba50745d660986b07e9fc7877b78e0","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                \"base64\", \"strict\").strip()  # encode in base64 format"},{"line_number":168,"context_line":"            auth_header \u003d (zone_constant.AUTH_STRING +"},{"line_number":169,"context_line":"                           auth_token)  # Build the proper header"},{"line_number":170,"context_line":"            LOG.debug(\"Authentication header : %s\" % auth_header)"},{"line_number":171,"context_line":"        except Exception as e:"},{"line_number":172,"context_line":"            msg \u003d _(\"Error while creating authentication token \""},{"line_number":173,"context_line":"                    \"%s \") % six.text_type(e)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_885b1787","line":170,"updated":"2015-07-14 03:09:07.000000000","message":"Change % to ,","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"512ecef6dd17e5b6edc49740fb6ed33ece6d0851","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                \"base64\", \"strict\").strip()  # encode in base64 format"},{"line_number":168,"context_line":"            auth_header \u003d (zone_constant.AUTH_STRING +"},{"line_number":169,"context_line":"                           auth_token)  # Build the proper header"},{"line_number":170,"context_line":"            LOG.debug(\"Authentication header : %s\" % auth_header)"},{"line_number":171,"context_line":"        except Exception as e:"},{"line_number":172,"context_line":"            msg \u003d _(\"Error while creating authentication token \""},{"line_number":173,"context_line":"                    \"%s \") % six.text_type(e)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_5584c3d2","line":170,"in_reply_to":"9a41bdd9_885b1787","updated":"2015-07-15 10:07:29.000000000","message":"Done","commit_id":"e9a08d492c2286976a03538d6b015163e0fa7ef4"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if self.protocol \u003d\u003d zone_constant.PROTOCOL_HTTPS:"},{"line_number":95,"context_line":"                protocol \u003d zone_constant.HTTPS"},{"line_number":96,"context_line":"            if self.session is None:"},{"line_number":97,"context_line":"                LOG.info(_LI(\"Creating New Session\"))"},{"line_number":98,"context_line":"                self.session \u003d requests.Session()"},{"line_number":99,"context_line":"                adapter \u003d requests.adapters.HTTPAdapter(pool_connections\u003d1,"},{"line_number":100,"context_line":"                                                        pool_maxsize\u003d1)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_4a83e456","line":97,"updated":"2015-07-21 05:47:41.000000000","message":"End with \".\"\n\nwherever applicable.","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if self.protocol \u003d\u003d zone_constant.PROTOCOL_HTTPS:"},{"line_number":95,"context_line":"                protocol \u003d zone_constant.HTTPS"},{"line_number":96,"context_line":"            if self.session is None:"},{"line_number":97,"context_line":"                LOG.info(_LI(\"Creating New Session\"))"},{"line_number":98,"context_line":"                self.session \u003d requests.Session()"},{"line_number":99,"context_line":"                adapter \u003d requests.adapters.HTTPAdapter(pool_connections\u003d1,"},{"line_number":100,"context_line":"                                                        pool_maxsize\u003d1)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_e8ce2e2d","line":97,"in_reply_to":"3a50d1a3_4a83e456","updated":"2015-07-22 11:39:56.000000000","message":"Done","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # Throw exception when response status is not OK"},{"line_number":115,"context_line":"            if response.status_code !\u003d zone_constant.STATUS_OK:"},{"line_number":116,"context_line":"                msg \u003d _(\"Could not connect the \""},{"line_number":117,"context_line":"                        \"switch, Reason: %s\") % response.reason"},{"line_number":118,"context_line":"                LOG.error(msg)"},{"line_number":119,"context_line":"                raise exception.BrocadeZoningHttpsException(msg)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_6a3b409d","line":116,"updated":"2015-07-21 05:47:41.000000000","message":"Is this message representative for all !\u003d 200 error codes?","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # Throw exception when response status is not OK"},{"line_number":115,"context_line":"            if response.status_code !\u003d zone_constant.STATUS_OK:"},{"line_number":116,"context_line":"                msg \u003d _(\"Could not connect the \""},{"line_number":117,"context_line":"                        \"switch, Reason: %s\") % response.reason"},{"line_number":118,"context_line":"                LOG.error(msg)"},{"line_number":119,"context_line":"                raise exception.BrocadeZoningHttpsException(msg)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_68f8de7b","line":116,"in_reply_to":"3a50d1a3_6a3b409d","updated":"2015-07-22 11:39:56.000000000","message":"Yes. I have changed the log message.","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            if response.status_code !\u003d zone_constant.STATUS_OK:"},{"line_number":116,"context_line":"                msg \u003d _(\"Could not connect the \""},{"line_number":117,"context_line":"                        \"switch, Reason: %s\") % response.reason"},{"line_number":118,"context_line":"                LOG.error(msg)"},{"line_number":119,"context_line":"                raise exception.BrocadeZoningHttpsException(msg)"},{"line_number":120,"context_line":"            else:"},{"line_number":121,"context_line":"                LOG.info(_LI(\"Connected to the switch.\"))"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_8a56ccd0","line":118,"updated":"2015-07-21 05:47:41.000000000","message":"This will be duplicated as line 131 is going to catch the exception and log it.","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            if response.status_code !\u003d zone_constant.STATUS_OK:"},{"line_number":116,"context_line":"                msg \u003d _(\"Could not connect the \""},{"line_number":117,"context_line":"                        \"switch, Reason: %s\") % response.reason"},{"line_number":118,"context_line":"                LOG.error(msg)"},{"line_number":119,"context_line":"                raise exception.BrocadeZoningHttpsException(msg)"},{"line_number":120,"context_line":"            else:"},{"line_number":121,"context_line":"                LOG.info(_LI(\"Connected to the switch.\"))"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_4842c2af","line":118,"in_reply_to":"3a50d1a3_8a56ccd0","updated":"2015-07-22 11:39:56.000000000","message":"Removed the log","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            LOG.debug(\"Authentication header : %s\", auth_header)"},{"line_number":170,"context_line":"        except Exception as e:"},{"line_number":171,"context_line":"            msg \u003d _(\"Error while creating authentication token \""},{"line_number":172,"context_line":"                    \"%s \") % six.text_type(e)"},{"line_number":173,"context_line":"            LOG.error(msg)"},{"line_number":174,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":175,"context_line":"        return auth_header"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_2a5c58ec","line":172,"updated":"2015-07-21 05:47:41.000000000","message":"Inconsistent space at the end of msg.\nShould end with \".\"","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            LOG.debug(\"Authentication header : %s\", auth_header)"},{"line_number":170,"context_line":"        except Exception as e:"},{"line_number":171,"context_line":"            msg \u003d _(\"Error while creating authentication token \""},{"line_number":172,"context_line":"                    \"%s \") % six.text_type(e)"},{"line_number":173,"context_line":"            LOG.error(msg)"},{"line_number":174,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":175,"context_line":"        return auth_header"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_08e4baa9","line":172,"in_reply_to":"3a50d1a3_2a5c58ec","updated":"2015-07-22 11:39:56.000000000","message":"Done","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                LOG.error(msg)"},{"line_number":210,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":211,"context_line":"        except Exception as e:"},{"line_number":212,"context_line":"            msg \u003d _(\"Error while authenticating with switch %s \""},{"line_number":213,"context_line":"                    ) % six.text_type(e)"},{"line_number":214,"context_line":"            LOG.error(msg)"},{"line_number":215,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_0a107c00","line":212,"updated":"2015-07-21 05:47:41.000000000","message":"ditto","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                LOG.error(msg)"},{"line_number":210,"context_line":"                raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":211,"context_line":"        except Exception as e:"},{"line_number":212,"context_line":"            msg \u003d _(\"Error while authenticating with switch %s \""},{"line_number":213,"context_line":"                    ) % six.text_type(e)"},{"line_number":214,"context_line":"            LOG.error(msg)"},{"line_number":215,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_c8f0126a","line":212,"in_reply_to":"3a50d1a3_0a107c00","updated":"2015-07-22 11:39:56.000000000","message":"Done","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                    header\u003dheaders)"},{"line_number":228,"context_line":"        except Exception as e:"},{"line_number":229,"context_line":"            msg \u003d _(\"Error while getting session information \""},{"line_number":230,"context_line":"                    \"%s \") % six.text_type(e)"},{"line_number":231,"context_line":"            LOG.error(msg)"},{"line_number":232,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":233,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_2a13f80e","line":230,"updated":"2015-07-21 05:47:41.000000000","message":"ditto","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                    header\u003dheaders)"},{"line_number":228,"context_line":"        except Exception as e:"},{"line_number":229,"context_line":"            msg \u003d _(\"Error while getting session information \""},{"line_number":230,"context_line":"                    \"%s \") % six.text_type(e)"},{"line_number":231,"context_line":"            LOG.error(msg)"},{"line_number":232,"context_line":"            raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":233,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_88e68aae","line":230,"in_reply_to":"3a50d1a3_2a13f80e","updated":"2015-07-22 11:39:56.000000000","message":"Done","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":816,"context_line":"                break"},{"line_number":817,"context_line":"        if status !\u003d \"done\":"},{"line_number":818,"context_line":"            errorCode \u003d -1"},{"line_number":819,"context_line":"            errorMessage \u003d \"Timed out, waiting for transaction to complete\""},{"line_number":820,"context_line":"        else:"},{"line_number":821,"context_line":"            errorCode \u003d self.get_nvp_value(parsed_data_txn,"},{"line_number":822,"context_line":"                                           zone_constant.ZONE_ERROR_CODE)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_aa1628ef","line":819,"updated":"2015-07-21 05:47:41.000000000","message":"Would it be helpful to mention \"which\" transaction?","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":816,"context_line":"                break"},{"line_number":817,"context_line":"        if status !\u003d \"done\":"},{"line_number":818,"context_line":"            errorCode \u003d -1"},{"line_number":819,"context_line":"            errorMessage \u003d \"Timed out, waiting for transaction to complete\""},{"line_number":820,"context_line":"        else:"},{"line_number":821,"context_line":"            errorCode \u003d self.get_nvp_value(parsed_data_txn,"},{"line_number":822,"context_line":"                                           zone_constant.ZONE_ERROR_CODE)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_685e9e45","line":819,"in_reply_to":"3a50d1a3_aa1628ef","updated":"2015-07-22 11:39:56.000000000","message":"Done","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1af5d0adcb1310ca700b02c19d04ced3cd92ea3b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":124,"context_line":"            msg \u003d _(\"Error while connecting the switch %{switch_id}\""},{"line_number":125,"context_line":"                    \" with protocol %{protocol.} \""},{"line_number":126,"context_line":"                    \"Error:%{error} \") % {\u0027switch_id\u0027: self.switch_ip,"},{"line_number":127,"context_line":"                                          \u0027protocol\u0027: self.protocol,"},{"line_number":128,"context_line":"                                          \u0027error\u0027: six.text_type(e)}"},{"line_number":129,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a1a9d01_5f3911f1","line":126,"updated":"2015-09-29 09:27:42.000000000","message":"Add a space after the \":\" please.","commit_id":"efb707c1a44c7213aee7ba1a306d3e70db4117ec"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1af5d0adcb1310ca700b02c19d04ced3cd92ea3b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                \"base64\", \"strict\").strip()  # encode in base64 format"},{"line_number":167,"context_line":"            auth_header \u003d (zone_constant.AUTH_STRING +"},{"line_number":168,"context_line":"                           auth_token)  # Build the proper header"},{"line_number":169,"context_line":"            LOG.debug(\"Authentication header : %s.\", auth_header)"},{"line_number":170,"context_line":"        except Exception as e:"},{"line_number":171,"context_line":"            msg \u003d _(\"Error while creating authentication token \""},{"line_number":172,"context_line":"                    \"%s.\") % six.text_type(e)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a1a9d01_2216864c","line":169,"updated":"2015-09-29 09:27:42.000000000","message":"Remove the space in front of \":\" please.","commit_id":"efb707c1a44c7213aee7ba1a306d3e70db4117ec"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1af5d0adcb1310ca700b02c19d04ced3cd92ea3b","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            start \u003d start + len(keyname)"},{"line_number":263,"context_line":"            temp \u003d data[start:]"},{"line_number":264,"context_line":"            end \u003d temp.index(\"\\n\")"},{"line_number":265,"context_line":"            return(temp[:end].lstrip(\u0027\u003d \u0027))"},{"line_number":266,"context_line":"        except Exception as e:"},{"line_number":267,"context_line":"            msg \u003d _(\"Error while getting nvp value %s.\") % six.text_type(e)"},{"line_number":268,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a1a9d01_62555ef8","line":265,"updated":"2015-09-29 09:27:42.000000000","message":"Add a space after \"return\" please.","commit_id":"efb707c1a44c7213aee7ba1a306d3e70db4117ec"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1af5d0adcb1310ca700b02c19d04ced3cd92ea3b","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                if session_LF_Id \u003d\u003d vfid:"},{"line_number":318,"context_line":"                    LOG.info(_LI(\"VF context is changed in the session.\"))"},{"line_number":319,"context_line":"                else:"},{"line_number":320,"context_line":"                    msg \u003d _(\"Cannot Change VF context in the session.\")"},{"line_number":321,"context_line":"                    LOG.error(msg)"},{"line_number":322,"context_line":"                    raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9a1a9d01_0247c24b","line":320,"updated":"2015-09-29 09:27:42.000000000","message":"s/Change/change","commit_id":"efb707c1a44c7213aee7ba1a306d3e70db4117ec"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1af5d0adcb1310ca700b02c19d04ced3cd92ea3b","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                    raise exception.BrocadeZoningHttpsException(reason\u003dmsg)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"            else:"},{"line_number":325,"context_line":"                msg \u003d _(\"Cannot Change VF context, \""},{"line_number":326,"context_line":"                        \"Specified VF in not available \""},{"line_number":327,"context_line":"                        \"in the manageable VF list %(vf_list)s.\""},{"line_number":328,"context_line":"                        ) % {\u0027vf_list\u0027: managable_vf_list}"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a1a9d01_a27616a2","line":325,"updated":"2015-09-29 09:27:42.000000000","message":"s/Change/change, and change \u0027,\u0027 to \u0027.\u0027 or change \u0027Specified\u0027 to \u0027specified\u0027 in the next line.","commit_id":"efb707c1a44c7213aee7ba1a306d3e70db4117ec"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1af5d0adcb1310ca700b02c19d04ced3cd92ea3b","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                response,"},{"line_number":354,"context_line":"                zone_constant.ZONEINFO_BEGIN,"},{"line_number":355,"context_line":"                zone_constant.ZONEINFO_END).strip(\"\\n\")"},{"line_number":356,"context_line":"            LOG.debug(\"Original Zone string \""},{"line_number":357,"context_line":"                      \"from the switch %s.\", self.parsed_raw_zoneinfo)"},{"line_number":358,"context_line":"            # convert the zone string to list"},{"line_number":359,"context_line":"            zoneinfo \u003d self.parsed_raw_zoneinfo.split()"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a1a9d01_a2d2965a","line":356,"updated":"2015-09-29 09:27:42.000000000","message":"s/Zone/zone, if there is some particular reason to capitalize the first letter of the second word in the sentence, please let me know, thanks!","commit_id":"efb707c1a44c7213aee7ba1a306d3e70db4117ec"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1af5d0adcb1310ca700b02c19d04ced3cd92ea3b","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                                     ifas,"},{"line_number":767,"context_line":"                                     activate)"},{"line_number":768,"context_line":"        LOG.debug(\"Delete Zones: Final zone string\""},{"line_number":769,"context_line":"                  \" after for applying to the switch  : %s.\", data)"},{"line_number":770,"context_line":"        error_code, error_msg \u003d self.post_zone_data(data)"},{"line_number":771,"context_line":"        if error_code !\u003d \"0\":"},{"line_number":772,"context_line":"            msg \u003d _(\"Applying the zones and cfgs to the switch failed \""}],"source_content_type":"text/x-python","patch_set":16,"id":"9a1a9d01_22752663","line":769,"updated":"2015-09-29 09:27:42.000000000","message":"Should we remove the space in front of the \":\"?","commit_id":"efb707c1a44c7213aee7ba1a306d3e70db4117ec"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"76a073360547b2161507a4ef6239db92159a36db","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.switch_ip \u003d ipaddress"},{"line_number":62,"context_line":"        self.switch_user \u003d username"},{"line_number":63,"context_line":"        self.switch_pwd \u003d password"},{"line_number":64,"context_line":"        self.protocol \u003d protocol"},{"line_number":65,"context_line":"        self.vfid \u003d vfid"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Create and assign the authentication header based on the credentials"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a1a9d01_fd22a8a2","line":64,"updated":"2015-10-03 23:46:00.000000000","message":"I\u0027m a bit confused here.  the class name is called BrcdHttps...   Since the class name was specific to naming it httpS, I would expect it to only use a protocol \u003d \"https\", and yet this class allows you to pass in any protocol.   \n\nI would name the class BrcdHTTPFCZoneClient in that case.  This typically denotes that it\u0027s using the HTTP protocol as a generic term, which also includes HTTPS.  When you specify it as HTTPSClient, I\u0027d assume it\u0027s HTTPS only.","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"bc1ed90ff7a4ada14451438b6dc55c5155e2d96c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.switch_ip \u003d ipaddress"},{"line_number":62,"context_line":"        self.switch_user \u003d username"},{"line_number":63,"context_line":"        self.switch_pwd \u003d password"},{"line_number":64,"context_line":"        self.protocol \u003d protocol"},{"line_number":65,"context_line":"        self.vfid \u003d vfid"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Create and assign the authentication header based on the credentials"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a2fa921_b6f5d9ed","line":64,"in_reply_to":"9a1a9d01_fd22a8a2","updated":"2015-10-08 18:42:17.000000000","message":"Point taken, class name changed.","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"76a073360547b2161507a4ef6239db92159a36db","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                msg \u003d _(\"Error while querying page %(url)s on the switch, \""},{"line_number":117,"context_line":"                        \"reason %(error)s.\") % {\u0027url\u0027: url,"},{"line_number":118,"context_line":"                                                \u0027error\u0027: response.reason}"},{"line_number":119,"context_line":"                raise exception.BrocadeZoningHttpsException(msg)"},{"line_number":120,"context_line":"            else:"},{"line_number":121,"context_line":"                LOG.info(_LI(\"Connected to the switch.\"))"},{"line_number":122,"context_line":"                return response.text"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a1a9d01_3d50200a","line":119,"updated":"2015-10-03 23:46:00.000000000","message":"I also find the naming of the exceptions as Https as odd as well.  This isn\u0027t an HTTPS (SSL) error, this is a generic exception via the HTTP client.","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"bc1ed90ff7a4ada14451438b6dc55c5155e2d96c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                msg \u003d _(\"Error while querying page %(url)s on the switch, \""},{"line_number":117,"context_line":"                        \"reason %(error)s.\") % {\u0027url\u0027: url,"},{"line_number":118,"context_line":"                                                \u0027error\u0027: response.reason}"},{"line_number":119,"context_line":"                raise exception.BrocadeZoningHttpsException(msg)"},{"line_number":120,"context_line":"            else:"},{"line_number":121,"context_line":"                LOG.info(_LI(\"Connected to the switch.\"))"},{"line_number":122,"context_line":"                return response.text"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a2fa921_36e22930","line":119,"in_reply_to":"9a1a9d01_3d50200a","updated":"2015-10-08 18:42:17.000000000","message":"Point taken.  Exception renamed.","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"}],"cinder/zonemanager/drivers/brocade/fc_zone_constants.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"102868d2f197e190738cc65628da56e561cd4f18","unresolved":false,"context_lines":[{"line_number":84,"context_line":"MANAGEABLE_VF \u003d \"manageableLFList\""},{"line_number":85,"context_line":"CHANGE_VF_TEMPLATE \u003d \"Session\u003d--BEGIN SESSION\\n\\taction\u003dapply\\n\\tLFId\u003d  {vfid}  \" \\"},{"line_number":86,"context_line":"                     \"\\b\\t--END SESSION\""},{"line_number":87,"context_line":"ZoneTranStatus \u003d \"/gzoneinfo.htm?txnId\u003d{txnId}\""},{"line_number":88,"context_line":"CFG_DELIM \u003d \"\\x01\""},{"line_number":89,"context_line":"ZONE_DELIM \u003d \"\\x02\""},{"line_number":90,"context_line":"ALIAS_DELIM \u003d \"\\x03\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_944fbbbd","line":87,"updated":"2015-06-22 20:29:33.000000000","message":"Should be ZONE_TRAN_STATUS","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"a7fb8ace56f095787d2ed40aa79a37365d4394a3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"MANAGEABLE_VF \u003d \"manageableLFList\""},{"line_number":85,"context_line":"CHANGE_VF_TEMPLATE \u003d \"Session\u003d--BEGIN SESSION\\n\\taction\u003dapply\\n\\tLFId\u003d  {vfid}  \" \\"},{"line_number":86,"context_line":"                     \"\\b\\t--END SESSION\""},{"line_number":87,"context_line":"ZoneTranStatus \u003d \"/gzoneinfo.htm?txnId\u003d{txnId}\""},{"line_number":88,"context_line":"CFG_DELIM \u003d \"\\x01\""},{"line_number":89,"context_line":"ZONE_DELIM \u003d \"\\x02\""},{"line_number":90,"context_line":"ALIAS_DELIM \u003d \"\\x03\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_7869a9f8","line":87,"in_reply_to":"fa32b979_944fbbbd","updated":"2015-06-24 12:03:49.000000000","message":"Done","commit_id":"88ad5b65414b258ed2aa54dc77aa99ad65998a2e"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"f58c46217bc69e52f154b06cc6073dc8a2baf547","unresolved":false,"context_lines":[{"line_number":57,"context_line":"HTTPS connector constants"},{"line_number":58,"context_line":"\"\"\""},{"line_number":59,"context_line":"AUTH_HEADER \u003d \"Authorization\""},{"line_number":60,"context_line":"PROTOCOL_HTTPS \u003d \"HTTPS\""},{"line_number":61,"context_line":"STATUS_OK \u003d 200"},{"line_number":62,"context_line":"SECINFO_PAGE \u003d \"/secinfo.html\""},{"line_number":63,"context_line":"AUTHEN_PAGE \u003d \"/authenticate.html\""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_6abee0d5","line":60,"updated":"2015-07-21 05:47:41.000000000","message":"possible duplicate line 111","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":14802,"name":"Pradeep Sathasivam","email":"spradeepv@gmail.com","username":"spradeepv"},"change_message_id":"f3893901eac4836b02138c2ccb9553839669cec2","unresolved":false,"context_lines":[{"line_number":57,"context_line":"HTTPS connector constants"},{"line_number":58,"context_line":"\"\"\""},{"line_number":59,"context_line":"AUTH_HEADER \u003d \"Authorization\""},{"line_number":60,"context_line":"PROTOCOL_HTTPS \u003d \"HTTPS\""},{"line_number":61,"context_line":"STATUS_OK \u003d 200"},{"line_number":62,"context_line":"SECINFO_PAGE \u003d \"/secinfo.html\""},{"line_number":63,"context_line":"AUTHEN_PAGE \u003d \"/authenticate.html\""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_9bcd72b9","line":60,"in_reply_to":"3a50d1a3_6abee0d5","updated":"2015-07-22 11:39:56.000000000","message":"This constant is used to differentiate the protocol to use to query the device(HTTPS/SSH). The constant in line 111 is used to differentiate the protocol in the URL(http/https). Although I could have used a single constant, this is done intentionally to differentiate the use.","commit_id":"3bb5dce1dfe09b1cfc0940a6cefde2f0dcb21605"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"76a073360547b2161507a4ef6239db92159a36db","unresolved":false,"context_lines":[{"line_number":66,"context_line":"SECINFO_BEGIN \u003d \"--BEGIN SECINFO\""},{"line_number":67,"context_line":"SECINFO_END \u003d \"--END SECINFO\""},{"line_number":68,"context_line":"RANDOM \u003d \"RANDOM\""},{"line_number":69,"context_line":"AUTH_STRING \u003d \"Custom_Basic \""},{"line_number":70,"context_line":"AUTHEN_BEGIN \u003d \"--BEGIN AUTHENTICATE\""},{"line_number":71,"context_line":"AUTHEN_END \u003d \"--END AUTHENTICATE\""},{"line_number":72,"context_line":"AUTHENTICATED \u003d \"authenticated\""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a1a9d01_7d18d875","line":69,"updated":"2015-10-03 23:46:00.000000000","message":"is the space at the end required?","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"bc1ed90ff7a4ada14451438b6dc55c5155e2d96c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"SECINFO_BEGIN \u003d \"--BEGIN SECINFO\""},{"line_number":67,"context_line":"SECINFO_END \u003d \"--END SECINFO\""},{"line_number":68,"context_line":"RANDOM \u003d \"RANDOM\""},{"line_number":69,"context_line":"AUTH_STRING \u003d \"Custom_Basic \""},{"line_number":70,"context_line":"AUTHEN_BEGIN \u003d \"--BEGIN AUTHENTICATE\""},{"line_number":71,"context_line":"AUTHEN_END \u003d \"--END AUTHENTICATE\""},{"line_number":72,"context_line":"AUTHENTICATED \u003d \"authenticated\""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a2fa921_f6883173","line":69,"in_reply_to":"9a1a9d01_7d18d875","updated":"2015-10-08 18:42:17.000000000","message":"Yes, the space is required.  Have added a comment to this line.","commit_id":"0170b2db104df1c63df502c57c3772b9602c6110"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6e382d4089f979f61b188fe60eb524d6ff4b5e8b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"FIRMWARE_VERSION \u003d \"swFWVersion\""},{"line_number":74,"context_line":"VF_ENABLED \u003d \"vfEnabled\""},{"line_number":75,"context_line":"MANAGEABLE_VF \u003d \"manageableLFList\""},{"line_number":76,"context_line":"CHANGE_VF_TEMPLATE \u003d \"Session\u003d--BEGIN SESSION\\n\\taction\u003dapply\\n\\tLFId\u003d  {vfid}  \" \\"},{"line_number":77,"context_line":"                     \"\\b\\t--END SESSION\""},{"line_number":78,"context_line":"ZONE_TRAN_STATUS \u003d \"/gzoneinfo.htm?txnId\u003d{txnId}\""},{"line_number":79,"context_line":"CFG_DELIM \u003d \"\\x01\""}],"source_content_type":"text/x-python","patch_set":25,"id":"7a740942_4f25ffbe","line":76,"updated":"2015-12-07 16:36:14.000000000","message":"Can we wrap in () instead of using the \\.","commit_id":"90f66a919af3a6b9a4977246bf658eec82a4fba1"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"313bbe49c48b8780c909ecbd2577d9986f7409dd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"FIRMWARE_VERSION \u003d \"swFWVersion\""},{"line_number":74,"context_line":"VF_ENABLED \u003d \"vfEnabled\""},{"line_number":75,"context_line":"MANAGEABLE_VF \u003d \"manageableLFList\""},{"line_number":76,"context_line":"CHANGE_VF_TEMPLATE \u003d \"Session\u003d--BEGIN SESSION\\n\\taction\u003dapply\\n\\tLFId\u003d  {vfid}  \" \\"},{"line_number":77,"context_line":"                     \"\\b\\t--END SESSION\""},{"line_number":78,"context_line":"ZONE_TRAN_STATUS \u003d \"/gzoneinfo.htm?txnId\u003d{txnId}\""},{"line_number":79,"context_line":"CFG_DELIM \u003d \"\\x01\""}],"source_content_type":"text/x-python","patch_set":25,"id":"7a740942_07dbc8ee","line":76,"in_reply_to":"7a740942_4f25ffbe","updated":"2015-12-10 00:10:27.000000000","message":"Done","commit_id":"90f66a919af3a6b9a4977246bf658eec82a4fba1"}],"releasenotes/notes/brocade_http_connector-0021e41dfa56e671.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5c550e51709fff2203fbe08fe812fe7173e0867e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The HTTP connector allows for communication"},{"line_number":4,"context_line":"    between the Brocade zone plugin and the switch"},{"line_number":5,"context_line":"    to be over HTTP or HTTPs.  To make use of this"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9a68dd71_9bef24b0","line":2,"updated":"2016-01-20 19:11:17.000000000","message":"Please remove this prelude section. Some of these details can be moved under the features section. When the release notes are compiled, the prelude section is a top level summary for the whole release, so this wouldn\u0027t make much sense then.","commit_id":"649cfb56c45c1f5c8122732dd934540f56d8e7d7"}]}
