)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"376febd03b200f3c507ea0519c521121ec9bb3ea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Stinner \u003cvstinner@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-25 16:41:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t use dict.iteritems()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace list(dict.iterkeys()) with list(dict). The call to iterkeys() is"},{"line_number":10,"context_line":"useless and the iterkeys() method of dictionaries was removed in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_a015464a","line":7,"updated":"2015-05-25 20:22:03.000000000","message":"Oops, it\u0027s iterkeys() in fact.","commit_id":"0b5398bd4ae0813e9e6f6bf935bcdec84b3bb038"}],"tools/colorizer.py":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"1c0eea97769f80fa4197710ae9c49e80dbf5fe50","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        self.stopTestRun()"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def stopTestRun(self):"},{"line_number":277,"context_line":"        for cls in list(self.results):"},{"line_number":278,"context_line":"            self.writeTestCase(cls)"},{"line_number":279,"context_line":"        self.stream.writeln()"},{"line_number":280,"context_line":"        self.writeSlowTests()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_60f50eca","line":277,"updated":"2015-05-25 19:12:34.000000000","message":"you can use self.results.keys()\n\nI think that using it like this is more explicit to the user that results is a dictionary, but if you think otherwise please let me know why and i will remove the vote","commit_id":"0b5398bd4ae0813e9e6f6bf935bcdec84b3bb038"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"376febd03b200f3c507ea0519c521121ec9bb3ea","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        self.stopTestRun()"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def stopTestRun(self):"},{"line_number":277,"context_line":"        for cls in list(self.results):"},{"line_number":278,"context_line":"            self.writeTestCase(cls)"},{"line_number":279,"context_line":"        self.stream.writeln()"},{"line_number":280,"context_line":"        self.writeSlowTests()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_e01b3e7f","line":277,"in_reply_to":"7a016987_60f50eca","updated":"2015-05-25 20:22:03.000000000","message":"Iterating on a dictionary iterates on dictionary keys. IMHO it\u0027s part of the Python language, there is no need to be explicit here.\n\n\"for cls in self.results:\" should also work, but I don\u0027t know how to test this tool, so I chose to keep the creation of a list. The list avoids errors if self.results is modified by the loop.","commit_id":"0b5398bd4ae0813e9e6f6bf935bcdec84b3bb038"}]}