)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2df1ee670c2c1b744943328cd962c2d1f9ea81f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"POC: Tooz locks demo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Demo showing usage of Tooz locks with coordination module."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I25b088a6a7c5d89dd64b5365c0441cf8e94f33fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a50d1a3_020fa039","line":9,"updated":"2015-07-28 15:47:53.000000000","message":"Can you add to this commit message to explain why this is helpful? What it helps the us see?","commit_id":"80d87376d1a314fefdeb514e78f43fec28440773"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"c306243576498672b60fd534731376cc5d2c0a73","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"POC: Tooz locks demo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Demo showing usage of Tooz locks with coordination module."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I25b088a6a7c5d89dd64b5365c0441cf8e94f33fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a4dcd0f_1e3b00ed","line":9,"updated":"2015-08-04 08:59:38.000000000","message":"Guess you could add https://review.openstack.org/#/c/183537 so that people know what\u0027s inside `from cinder import coordinate`.","commit_id":"80d87376d1a314fefdeb514e78f43fec28440773"}],"cinder/test.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f8b158daace0a58259d90dba48dcc303279fd49e","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        # clear out the cache."},{"line_number":234,"context_line":"        sqla_api._GET_METHODS \u003d {}"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        coordination.COORDINATOR.start()"},{"line_number":237,"context_line":"        self.addCleanup(coordination.COORDINATOR.stop)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def _restore_obj_registry(self):"},{"line_number":240,"context_line":"        objects_base.CinderObjectRegistry._registry._obj_classes \u003d \\"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_9f49bc63","line":237,"range":{"start_line":236,"start_character":0,"end_line":237,"end_character":54},"updated":"2016-06-15 12:16:29.000000000","message":"Thinking out loud - this should be okay, as we\u0027re running with default configs and these point to simple file driver.","commit_id":"fa4442ef89ac09323a62f8270318605e33bc8701"}],"cinder/volume/drivers/netapp/dataontap/nfs_base.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2df1ee670c2c1b744943328cd962c2d1f9ea81f9","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        dir \u003d self._get_mount_point_for_share(share)"},{"line_number":336,"context_line":"        file_path \u003d \u0027%s/%s\u0027 % (dir, dst)"},{"line_number":337,"context_line":"        if not os.path.exists(file_path):"},{"line_number":338,"context_line":"            LOG.info(_LI(\u0027Cloning from cache to destination %s\u0027), dst)"},{"line_number":339,"context_line":"            self._clone_backing_file_for_volume(src, dst, volume_id\u003dNone,"},{"line_number":340,"context_line":"                                                share\u003dshare)"},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_82d8901f","line":338,"updated":"2015-07-28 15:47:53.000000000","message":"\".\" at EOL","commit_id":"80d87376d1a314fefdeb514e78f43fec28440773"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2df1ee670c2c1b744943328cd962c2d1f9ea81f9","unresolved":false,"context_lines":[{"line_number":712,"context_line":"                return True"},{"line_number":713,"context_line":"            except Exception as e:"},{"line_number":714,"context_line":"                LOG.warning(_LW("},{"line_number":715,"context_line":"                    \u0027Exception moving file %(src)s. Message - %(e)s\u0027),"},{"line_number":716,"context_line":"                    {\u0027src\u0027: source_path, \u0027e\u0027: e}"},{"line_number":717,"context_line":"                )"},{"line_number":718,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_22009c65","line":715,"updated":"2015-07-28 15:47:53.000000000","message":"\u0027:\u0027 instead of \u0027-\u0027","commit_id":"80d87376d1a314fefdeb514e78f43fec28440773"}],"cinder/volume/manager.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2df1ee670c2c1b744943328cd962c2d1f9ea81f9","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        host_name_sanitized \u003d utils.sanitize_hostname("},{"line_number":720,"context_line":"            host_name) if host_name else None"},{"line_number":721,"context_line":"        if instance_uuid:"},{"line_number":722,"context_line":"            attachment \u003d \\"},{"line_number":723,"context_line":"                self.db.volume_attachment_get_by_instance_uuid("},{"line_number":724,"context_line":"                    context, volume_id, instance_uuid)"},{"line_number":725,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_82f97050","line":722,"updated":"2015-07-28 15:47:53.000000000","message":"While I realize it\u0027s not possible to break this stuff up smaller, you should still avoid using \u0027\\\u0027 and use \u0027()\u0027 instead. Thanks!","commit_id":"80d87376d1a314fefdeb514e78f43fec28440773"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2df1ee670c2c1b744943328cd962c2d1f9ea81f9","unresolved":false,"context_lines":[{"line_number":723,"context_line":"                self.db.volume_attachment_get_by_instance_uuid("},{"line_number":724,"context_line":"                    context, volume_id, instance_uuid)"},{"line_number":725,"context_line":"        else:"},{"line_number":726,"context_line":"            attachment \u003d \\"},{"line_number":727,"context_line":"                self.db.volume_attachment_get_by_host(context, volume_id,"},{"line_number":728,"context_line":"                                                      host_name_sanitized)"},{"line_number":729,"context_line":"        if attachment is not None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_629b0419","line":726,"updated":"2015-07-28 15:47:53.000000000","message":"Same comment as above.","commit_id":"80d87376d1a314fefdeb514e78f43fec28440773"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"79ba40cf0e9a989f3e22f219dbef4bacdebe17e5","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        LOG.info(_LI(\"Created volume successfully.\"), resource\u003dvol_ref)"},{"line_number":541,"context_line":"        return vol_ref.id"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    @coordination.synchronized(\u0027{volume_id}-{f_name}\u0027)"},{"line_number":544,"context_line":"    def delete_volume(self, context, volume_id, unmanage_only\u003dFalse,"},{"line_number":545,"context_line":"                      volume\u003dNone):"},{"line_number":546,"context_line":"        \"\"\"Deletes and unexports volume."}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_960e5d3b","line":543,"updated":"2016-05-05 03:33:08.000000000","message":"does the below mean that we use three different locks for the same volume id? Don\u0027t we want to synchronize all operations(attach/detach/delete) on a given volume id with a single lock?\n\n@coordination.synchronized(\u0027{volume_id}-{f_name}\u0027)\ndef delete_volume(...)\n\n@coordination.synchronized(\u0027{volume_id}\u0027)\ndef attach_volume(...)\n\n@coordination.synchronized(\u0027{volume_id}-{f_name}\u0027)\ndef detach_volume(...)","commit_id":"4c01c91f5c825cc63ff138d64bab6c36ca2773c5"}]}
