)]}'
{"cinder/cmd/manage.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"9227772f2e83b6cb0bf3c4675935c22e9786571e","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                              _(\u0027State\u0027),"},{"line_number":447,"context_line":"                              _(\u0027Updated At\u0027)))"},{"line_number":448,"context_line":"        for svc in services:"},{"line_number":449,"context_line":"            alive \u003d utils.service_is_up(svc) \u0026\u0026 manager.init_host()"},{"line_number":450,"context_line":"            art \u003d \":-)\" if alive else \"XXX\""},{"line_number":451,"context_line":"            status \u003d \u0027enabled\u0027"},{"line_number":452,"context_line":"            if svc[\u0027disabled\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_20712fe1","line":449,"updated":"2015-05-26 21:29:00.000000000","message":"manager is a module, not the VolumeManager class, so you can\u0027t do manager.init_host().","commit_id":"b108601e5d6d4af809b257df699d89f7891f5f30"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b7deda9a0d3b313a7c146b57857f54efdecdc4e4","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                              _(\u0027State\u0027),"},{"line_number":447,"context_line":"                              _(\u0027Updated At\u0027)))"},{"line_number":448,"context_line":"        for svc in services:"},{"line_number":449,"context_line":"            alive \u003d utils.service_is_up(svc) and manager.init_host()"},{"line_number":450,"context_line":"            art \u003d \":-)\" if alive else \"XXX\""},{"line_number":451,"context_line":"            status \u003d \u0027enabled\u0027"},{"line_number":452,"context_line":"            if svc[\u0027disabled\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_38c72747","line":449,"updated":"2015-05-26 23:07:22.000000000","message":"You can\u0027t run the manager.init_host() again here.   Should probably add an RPC call into the host to see if the driver is initiatlized.","commit_id":"71a204d1aadf97d63da4fa0671639b855135d488"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"ecedcf28c4bd6942d7cc3e3b63e32bc45f2b2e80","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                              _(\u0027State\u0027),"},{"line_number":447,"context_line":"                              _(\u0027Updated At\u0027)))"},{"line_number":448,"context_line":"        for svc in services:"},{"line_number":449,"context_line":"            alive \u003d utils.service_is_up(svc) and manager.init_host()"},{"line_number":450,"context_line":"            art \u003d \":-)\" if alive else \"XXX\""},{"line_number":451,"context_line":"            status \u003d \u0027enabled\u0027"},{"line_number":452,"context_line":"            if svc[\u0027disabled\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_c0a8d879","line":449,"in_reply_to":"7a016987_2069ecbe","updated":"2015-05-28 09:48:39.000000000","message":"\u0027disable\u0027 and \u0027disable reason\u0027 column should help here, also I have spec for check service status via RPC https://review.openstack.org/#/c/176233/","commit_id":"71a204d1aadf97d63da4fa0671639b855135d488"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"ba3c0bd7486fea0c35c9ea3be1e3a9da6a530542","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                              _(\u0027State\u0027),"},{"line_number":447,"context_line":"                              _(\u0027Updated At\u0027)))"},{"line_number":448,"context_line":"        for svc in services:"},{"line_number":449,"context_line":"            alive \u003d utils.service_is_up(svc) and manager.init_host()"},{"line_number":450,"context_line":"            art \u003d \":-)\" if alive else \"XXX\""},{"line_number":451,"context_line":"            status \u003d \u0027enabled\u0027"},{"line_number":452,"context_line":"            if svc[\u0027disabled\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_2069ecbe","line":449,"in_reply_to":"7a016987_38c72747","updated":"2015-05-28 09:35:58.000000000","message":"RPC is a good way. And also we can use services table to set the info of driver un-initialize. Maybe need a new column or just use \u0027disable\u0027 and \u0027disable reason\u0027. Then we can get this status at there.","commit_id":"71a204d1aadf97d63da4fa0671639b855135d488"}],"cinder/volume/manager.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"d7411e04c3f38322886959f88d9c2668a6c3d810","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                                    \u0027id\u0027: self.__class__.__name__})"},{"line_number":307,"context_line":"            # we don\u0027t want to continue since we failed"},{"line_number":308,"context_line":"            # to initialize the driver correctly."},{"line_number":309,"context_line":"            return False"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        volumes \u003d self.db.volume_get_all_by_host(ctxt, self.host)"},{"line_number":312,"context_line":"        # FIXME volume count for exporting is wrong"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_bdaa9e17","line":309,"updated":"2015-05-28 14:09:37.000000000","message":"Where can init_host return true?","commit_id":"71a204d1aadf97d63da4fa0671639b855135d488"}]}