)]}'
{"cinder/tests/unit/test_netapp_eseries_iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"71905c58ac81076234f07afe65ce6ace37387376","unresolved":false,"context_lines":[{"line_number":788,"context_line":"            self.fake_eseries_pool_label,"},{"line_number":789,"context_line":"            self.fake_eseries_volume_label,"},{"line_number":790,"context_line":"            self.fake_size_gb)"},{"line_number":791,"context_line":"        log_info.assert_called_once_with(\"Created volume with label %s.\","},{"line_number":792,"context_line":"                                         self.fake_eseries_volume_label)"},{"line_number":793,"context_line":"        self.assertEqual(\u0027CorrectVolume\u0027, storage_vol)"},{"line_number":794,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_1aea6974","line":791,"updated":"2015-06-11 00:20:07.000000000","message":"Not related to this patch - just commenting here to voice my opinion as a thought for a potential future patch - but I am very much against unit tests asserting on specific log text.","commit_id":"c677ab00e9115c89af9f5e99bf586577ccbe7c78"}],"cinder/volume/drivers/netapp/common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"71905c58ac81076234f07afe65ce6ace37387376","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    },"},{"line_number":50,"context_line":"    \u0027eseries\u0027:"},{"line_number":51,"context_line":"    {"},{"line_number":52,"context_line":"        \u0027iscsi\u0027: ESERIES_PATH + \u0027.iscsi_driver.NetAppEseriesISCSIDriver\u0027"},{"line_number":53,"context_line":"    }}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_1a6f09fd","line":52,"updated":"2015-06-11 00:20:07.000000000","message":"Do you need to provide backward compatible deprecation for any existing deployments using the old driver name?","commit_id":"c677ab00e9115c89af9f5e99bf586577ccbe7c78"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"24f9799156c1ca328bbce1b3fa7a66d350343f29","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    },"},{"line_number":50,"context_line":"    \u0027eseries\u0027:"},{"line_number":51,"context_line":"    {"},{"line_number":52,"context_line":"        \u0027iscsi\u0027: ESERIES_PATH + \u0027.iscsi_driver.NetAppEseriesISCSIDriver\u0027"},{"line_number":53,"context_line":"    }}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_c7a4e0ba","line":52,"in_reply_to":"3afb71cf_1a6f09fd","updated":"2015-06-11 14:07:38.000000000","message":"No, that\u0027s what the value of the netapp common driver is. It will throw an error if they try to use the specific driver class directly. Good question though","commit_id":"c677ab00e9115c89af9f5e99bf586577ccbe7c78"}],"cinder/volume/drivers/netapp/eseries/iscsi_driver.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d7e9c4024fa79d20177be83005c81957cc043d8d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class NetAppEseriesISCSIDriver(driver.ISCSIDriver):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    DRIVER_NAME \u003d \u0027NetApp_iSCSI_ESeries\u0027"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_19b2a906","line":31,"updated":"2015-06-10 03:57:29.000000000","message":"You said you want the iSCSI and FC drivers to be similar. The FC driver inherited from the ABC abstract classes while the iSCSI driver is still inheriting from the driver.ISCSIDriver.","commit_id":"c677ab00e9115c89af9f5e99bf586577ccbe7c78"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e65e730c4b7ac9d747eb219e4fbdcb9060a3da59","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class NetAppEseriesISCSIDriver(driver.ISCSIDriver):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    DRIVER_NAME \u003d \u0027NetApp_iSCSI_ESeries\u0027"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_d4803a8d","line":31,"in_reply_to":"3afb71cf_19b2a906","updated":"2015-06-10 20:06:42.000000000","message":"Xing, we will do the ABC for iSCSI in another commit (not yet in upstream gerrit).  Alex just went on and did the ABC for FC now since this was brand new code.  The iSCSI change will match what Alex has done.","commit_id":"c677ab00e9115c89af9f5e99bf586577ccbe7c78"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"0275a18c578614a5a9c61c704d0013c5903368ea","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":36,"context_line":"        super(NetAppEseriesISCSIDriver, self).__init__(*args, **kwargs)"},{"line_number":37,"context_line":"        na_utils.validate_instantiation(**kwargs)"},{"line_number":38,"context_line":"        self.library \u003d library.NetAppESeriesLibrary(self.DRIVER_NAME,"},{"line_number":39,"context_line":"                                                    \u0027iSCSI\u0027, **kwargs)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def do_setup(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_3f007e65","line":38,"updated":"2015-06-10 20:12:20.000000000","message":"IMO, code will be more clean if NetAppESeriesLibrary will be added as parent class","commit_id":"c677ab00e9115c89af9f5e99bf586577ccbe7c78"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6fdbef6e9463e45e87150f8bcf5d3fbe59426c3d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":36,"context_line":"        super(NetAppEseriesISCSIDriver, self).__init__(*args, **kwargs)"},{"line_number":37,"context_line":"        na_utils.validate_instantiation(**kwargs)"},{"line_number":38,"context_line":"        self.library \u003d library.NetAppESeriesLibrary(self.DRIVER_NAME,"},{"line_number":39,"context_line":"                                                    \u0027iSCSI\u0027, **kwargs)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def do_setup(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_80e1522c","line":38,"in_reply_to":"3afb71cf_3f007e65","updated":"2015-06-10 20:50:18.000000000","message":"There are good arguments for your opinion that were made during the big refactor of all the NetApp drivers in kilo, but the arguments that prevailed were for using inheritance only for the protocol driver class (iSCSIDriver, FCDriver, etc.) and putting the NetApp code common to these in a library.\n\nWe are here just being consistent with what we are doing in the FAS drivers.  If we were to change to a multi-inheritance model here, we should do it there too :-)","commit_id":"c677ab00e9115c89af9f5e99bf586577ccbe7c78"}],"cinder/volume/drivers/netapp/eseries/library.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"71905c58ac81076234f07afe65ce6ace37387376","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Alex Meade.  All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_baa91526","line":1,"updated":"2015-06-11 00:20:07.000000000","message":"Should other copyrights be removed? Appears they are all within NetApp, so fine with me, but just verifying that is what you really want to do.","commit_id":"c677ab00e9115c89af9f5e99bf586577ccbe7c78"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"24f9799156c1ca328bbce1b3fa7a66d350343f29","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Alex Meade.  All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_a7e564dd","line":1,"in_reply_to":"3afb71cf_baa91526","updated":"2015-06-11 14:07:38.000000000","message":"heh not sure why i removed them. I will add them back.","commit_id":"c677ab00e9115c89af9f5e99bf586577ccbe7c78"}]}