)]}'
{"cinder/volume/drivers/netapp/eseries/client.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"435beb3de571c1093aebdab4d15a7a2d6d2e94f1","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        \"\"\"Creates host on array.\"\"\""},{"line_number":261,"context_line":"        path \u003d \"/storage-systems/{system-id}/hosts\""},{"line_number":262,"context_line":"        data \u003d {\u0027name\u0027: label, \u0027hostType\u0027: host_type}"},{"line_number":263,"context_line":"        data.setdefault(\u0027groupId\u0027, group_id if group_id else None)"},{"line_number":264,"context_line":"        data.setdefault(\u0027ports\u0027, ports if ports else None)"},{"line_number":265,"context_line":"        return self._invoke(\u0027POST\u0027, path, data)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_950f9538","line":263,"updated":"2015-05-29 09:46:13.000000000","message":"It looks like you\u0027ve changed the semantic of this line, though the original semantics were nonsense. A +1 off somebody from netapp would be nice, though it has passed CI.\n\nOriginally, I don\u0027t think setdefault would have been called if group_id \u003d\u003d None or group_id \u003d\u003d False","commit_id":"204dbdf9880d734f36b3f0786a24525bdfb83b85"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5951a25ebb9721941f24b18caf350c20293c5614","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        \"\"\"Creates host on array.\"\"\""},{"line_number":261,"context_line":"        path \u003d \"/storage-systems/{system-id}/hosts\""},{"line_number":262,"context_line":"        data \u003d {\u0027name\u0027: label, \u0027hostType\u0027: host_type}"},{"line_number":263,"context_line":"        data.setdefault(\u0027groupId\u0027, group_id if group_id else None)"},{"line_number":264,"context_line":"        data.setdefault(\u0027ports\u0027, ports if ports else None)"},{"line_number":265,"context_line":"        return self._invoke(\u0027POST\u0027, path, data)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_215c1918","line":263,"in_reply_to":"7a016987_950f9538","updated":"2015-05-29 14:05:07.000000000","message":"Looks fine, thanks for the fixes.","commit_id":"204dbdf9880d734f36b3f0786a24525bdfb83b85"}]}