)]}'
{"cinder/volume/drivers/vmware/volumeops.py":[{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"da2c2099224b2b5ccfcab436dd44c4362181bb8e","unresolved":false,"context_lines":[{"line_number":1422,"context_line":"        while retrieve_result:"},{"line_number":1423,"context_line":"            if retrieve_result.objects:"},{"line_number":1424,"context_line":"                for cluster in retrieve_result.objects:"},{"line_number":1425,"context_line":"                    name \u003d urllib.unquote(cluster.propSet[0].val)"},{"line_number":1426,"context_line":"                    clusters[name] \u003d cluster.obj"},{"line_number":1427,"context_line":"            retrieve_result \u003d self.continue_retrieval(retrieve_result)"},{"line_number":1428,"context_line":"        return clusters"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_b26fcb91","line":1425,"updated":"2015-06-02 06:12:48.000000000","message":"It\u0027s a little late to unquote the cluster name in here.\n\nI have committed a change on oslo.vmware, to decode special characters earlier.\n\nhttps://review.openstack.org/#/c/187457/","commit_id":"b3c11b51b052f6572beb6e0fc461040649ba44e6"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2bc0398848d3ef71094b6c53195b102466ca21b6","unresolved":false,"context_lines":[{"line_number":1422,"context_line":"        while retrieve_result:"},{"line_number":1423,"context_line":"            if retrieve_result.objects:"},{"line_number":1424,"context_line":"                for cluster in retrieve_result.objects:"},{"line_number":1425,"context_line":"                    name \u003d urllib.unquote(cluster.propSet[0].val)"},{"line_number":1426,"context_line":"                    clusters[name] \u003d cluster.obj"},{"line_number":1427,"context_line":"            retrieve_result \u003d self.continue_retrieval(retrieve_result)"},{"line_number":1428,"context_line":"        return clusters"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_9dba97e0","line":1425,"in_reply_to":"5afe65bd_b26fcb91","updated":"2015-06-02 12:12:01.000000000","message":"Is there any harm doing it here? No, right. If your patch is approved, it may take some time for the next version of oslo.vmware. Why should I hold this patch till then? Assume that your change landed in a future version of oslo.vmware, we can remove urllib.unquote here once Cinder syncs to that version.\n\nPlease remove your -1.","commit_id":"b3c11b51b052f6572beb6e0fc461040649ba44e6"}]}