)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"12e1ac3637f515acd3e8733d86d299fe36c04348","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    def _do_snapshot_create(self, params):"},{"line_number":457,"context_line":"        data \u003d self._issue_api_request(\u0027CreateSnapshot\u0027, params, version\u003d\u00276.0\u0027)"},{"line_number":458,"context_line":"        if ((\u0027result\u0027 not in data) or (\u0027snapshotID\u0027 not in data[\u0027result\u0027])):"},{"line_number":459,"context_line":"            msg \u003d _(\"Failed volume create: %s\") % data"},{"line_number":460,"context_line":"            raise exception.SolidFireAPIException(msg)"},{"line_number":461,"context_line":"        return data[\u0027result\u0027][\u0027snapshotID\u0027]"},{"line_number":462,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_98ae857f","line":459,"updated":"2015-05-31 03:39:58.000000000","message":"Since this is an exception, the message should be fixed:\n\nvolume -\u003e snapshot","commit_id":"86437d61b70227bb52f5625e6fbdd543ee2cfb23"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"4a7ee08df5336cbd5b7706f8141a58d3cf730c3d","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    def _do_snapshot_create(self, params):"},{"line_number":457,"context_line":"        data \u003d self._issue_api_request(\u0027CreateSnapshot\u0027, params, version\u003d\u00276.0\u0027)"},{"line_number":458,"context_line":"        if ((\u0027result\u0027 not in data) or (\u0027snapshotID\u0027 not in data[\u0027result\u0027])):"},{"line_number":459,"context_line":"            msg \u003d _(\"Failed volume create: %s\") % data"},{"line_number":460,"context_line":"            raise exception.SolidFireAPIException(msg)"},{"line_number":461,"context_line":"        return data[\u0027result\u0027][\u0027snapshotID\u0027]"},{"line_number":462,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_5d0d86e6","line":459,"in_reply_to":"7a016987_98ae857f","updated":"2015-06-01 14:36:09.000000000","message":"Done","commit_id":"86437d61b70227bb52f5625e6fbdd543ee2cfb23"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"12e1ac3637f515acd3e8733d86d299fe36c04348","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            params \u003d {\u0027volumeID\u0027: sf_volid}"},{"line_number":544,"context_line":"        data \u003d self._issue_api_request(\u0027ListSnapshots\u0027, params, version\u003d\u00276.0\u0027)"},{"line_number":545,"context_line":"        if \u0027result\u0027 not in data:"},{"line_number":546,"context_line":"            msg \u003d _(\"Failed to get SolidFire Volume: %s\") % data"},{"line_number":547,"context_line":"            raise exception.SolidFireAPIException(msg)"},{"line_number":548,"context_line":"        return data[\u0027result\u0027][\u0027snapshots\u0027]"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_58cdad64","line":546,"updated":"2015-05-31 03:39:58.000000000","message":"\"Volume\" should be \"Snapshot\".","commit_id":"86437d61b70227bb52f5625e6fbdd543ee2cfb23"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"4a7ee08df5336cbd5b7706f8141a58d3cf730c3d","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            params \u003d {\u0027volumeID\u0027: sf_volid}"},{"line_number":544,"context_line":"        data \u003d self._issue_api_request(\u0027ListSnapshots\u0027, params, version\u003d\u00276.0\u0027)"},{"line_number":545,"context_line":"        if \u0027result\u0027 not in data:"},{"line_number":546,"context_line":"            msg \u003d _(\"Failed to get SolidFire Volume: %s\") % data"},{"line_number":547,"context_line":"            raise exception.SolidFireAPIException(msg)"},{"line_number":548,"context_line":"        return data[\u0027result\u0027][\u0027snapshots\u0027]"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_bdfc7ab5","line":546,"in_reply_to":"7a016987_58cdad64","updated":"2015-06-01 14:36:09.000000000","message":"Done","commit_id":"86437d61b70227bb52f5625e6fbdd543ee2cfb23"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"213d346ce426424138e8ff4262a5198cfe632b09","unresolved":false,"context_lines":[{"line_number":833,"context_line":"                msg \u003d (_(\"Failed to delete SolidFire Snapshot: %s\") %"},{"line_number":834,"context_line":"                       data)"},{"line_number":835,"context_line":"                raise exception.SolidFireAPIException(msg)"},{"line_number":836,"context_line":"        else:"},{"line_number":837,"context_line":"            LOG.error(_LE(\"Snapshot ID %s was not found on \""},{"line_number":838,"context_line":"                          \"the SolidFire Cluster while attempting \""},{"line_number":839,"context_line":"                          \"delete_snapshot operation!\"), snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_25fbe548","line":836,"updated":"2015-05-31 12:57:52.000000000","message":"Can this be a non-SF snapshot which needs to be deleted using the old method (delete_volume)?","commit_id":"86437d61b70227bb52f5625e6fbdd543ee2cfb23"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"4a7ee08df5336cbd5b7706f8141a58d3cf730c3d","unresolved":false,"context_lines":[{"line_number":833,"context_line":"                msg \u003d (_(\"Failed to delete SolidFire Snapshot: %s\") %"},{"line_number":834,"context_line":"                       data)"},{"line_number":835,"context_line":"                raise exception.SolidFireAPIException(msg)"},{"line_number":836,"context_line":"        else:"},{"line_number":837,"context_line":"            LOG.error(_LE(\"Snapshot ID %s was not found on \""},{"line_number":838,"context_line":"                          \"the SolidFire Cluster while attempting \""},{"line_number":839,"context_line":"                          \"delete_snapshot operation!\"), snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_68d1b422","line":836,"in_reply_to":"7a016987_25fbe548","updated":"2015-06-01 14:36:09.000000000","message":"Indeed, that\u0027s the other pitfall I missed, thanks Vipin","commit_id":"86437d61b70227bb52f5625e6fbdd543ee2cfb23"}]}