)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"a20376be9d1a41cc5455fedd039ff460036f81c6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add a unit test for goodness weigher to test unset goodness"},{"line_number":10,"context_line":"function in host capabilities. It also removes an unused key"},{"line_number":11,"context_line":"in stats."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I67f86d065f2c740a7beef641250b0881cf63deaa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_e9491861","line":12,"updated":"2015-06-01 13:41:12.000000000","message":"I would like to see a link to a bug or a bp.","commit_id":"0aa4652fc89d21f2152ec23278a7d20d6e2d0377"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"fc9f2da15f186942269d1709dc91439703175db6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add a unit test for goodness weigher to test unset goodness"},{"line_number":10,"context_line":"function in host capabilities. It also removes an unused key"},{"line_number":11,"context_line":"in stats."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I67f86d065f2c740a7beef641250b0881cf63deaa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5afe65bd_c3170eec","line":12,"in_reply_to":"7a016987_bd4eba35","updated":"2015-06-02 13:00:59.000000000","message":"Vincent,\nThis patch is only improving the unit test coverage and not fixing any bug. Please remove -1.","commit_id":"0aa4652fc89d21f2152ec23278a7d20d6e2d0377"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c9a34d44673bf16887e84c0f2f0d7367fe8a8927","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add a unit test for goodness weigher to test unset goodness"},{"line_number":10,"context_line":"function in host capabilities. It also removes an unused key"},{"line_number":11,"context_line":"in stats."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I67f86d065f2c740a7beef641250b0881cf63deaa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_bd4eba35","line":12,"in_reply_to":"7a016987_e9491861","updated":"2015-06-01 14:37:04.000000000","message":"We don\u0027t need a bug or blueprint for a simple unit test addition.","commit_id":"0aa4652fc89d21f2152ec23278a7d20d6e2d0377"}],"cinder/scheduler/weights/goodness.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c9a34d44673bf16887e84c0f2f0d7367fe8a8927","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            \u0027extra_specs\u0027: extra_specs,"},{"line_number":137,"context_line":"            \u0027qos_specs\u0027: qos_specs,"},{"line_number":138,"context_line":"            \u0027volume_stats\u0027: volume_stats,"},{"line_number":139,"context_line":"            \u0027volume_type\u0027: volume_type,"},{"line_number":140,"context_line":"            \u0027goodness_function\u0027: goodness_function,"},{"line_number":141,"context_line":"        }"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_bdbd9ab2","side":"PARENT","line":139,"updated":"2015-06-01 14:37:04.000000000","message":"DriverFilter also returns this.  Is it wrong there too?","commit_id":"8ae4bdc8f3d04e47a839f8187dbd955ab2528189"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"9b4a57bbb33857670878a9c200ec7ee4ed9c5ae1","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            \u0027extra_specs\u0027: extra_specs,"},{"line_number":137,"context_line":"            \u0027qos_specs\u0027: qos_specs,"},{"line_number":138,"context_line":"            \u0027volume_stats\u0027: volume_stats,"},{"line_number":139,"context_line":"            \u0027volume_type\u0027: volume_type,"},{"line_number":140,"context_line":"            \u0027goodness_function\u0027: goodness_function,"},{"line_number":141,"context_line":"        }"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_83cc7636","side":"PARENT","line":139,"in_reply_to":"7a016987_bdbd9ab2","updated":"2015-06-02 13:30:37.000000000","message":"Looks like volume_type is unused there as well. I think it is better to handle such changes in a separate patch. Reverting this change.","commit_id":"8ae4bdc8f3d04e47a839f8187dbd955ab2528189"}]}