)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"77436de3311e3209f15ab83ee4f6333edb77faca","unresolved":false,"context_lines":[{"line_number":10,"context_line":"commit: 9f34d34d0ab92400223e3cc87285d0d4fbdf21f9"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds provider_id to the returned model"},{"line_number":13,"context_line":"update and uses it to provide the interal SolidFire"},{"line_number":14,"context_line":"volume ID mapping."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Next step will be to rewrite the awkward list search"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_24059979","line":13,"updated":"2015-06-03 11:52:25.000000000","message":"s/interal/internal","commit_id":"711e525d3dee0c7531d52bcb56adf64c352dda5c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7647c752c8a6a60b3669d1affc1c0a83d1f582f8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"volume ID mapping."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Next step will be to rewrite the awkward list search"},{"line_number":17,"context_line":"of volume names to find the cooresponding volume on"},{"line_number":18,"context_line":"the SolidFire backend."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ia44d46362bb1b688c4ac266afecca9ce66dcef25"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_be999f70","line":17,"updated":"2015-06-03 08:51:19.000000000","message":"s/cooresponding/corresponding/","commit_id":"711e525d3dee0c7531d52bcb56adf64c352dda5c"}],"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7647c752c8a6a60b3669d1affc1c0a83d1f582f8","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                                            chap_secret))"},{"line_number":342,"context_line":"        if not self.configuration.sf_emulate_512:"},{"line_number":343,"context_line":"            model_update[\u0027provider_geometry\u0027] \u003d (\u0027%s %s\u0027 % (4096, 4096))"},{"line_number":344,"context_line":"        model_update[\u0027provider_id\u0027] \u003d (\u0027%s\u0027 % sf_volume_id)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        return model_update"},{"line_number":347,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_3e6daf98","line":344,"updated":"2015-06-03 08:51:19.000000000","message":"Consider:\n     model_update[\u0027provider_id\u0027] \u003d sf_volume_id","commit_id":"711e525d3dee0c7531d52bcb56adf64c352dda5c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"77436de3311e3209f15ab83ee4f6333edb77faca","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                                            chap_secret))"},{"line_number":342,"context_line":"        if not self.configuration.sf_emulate_512:"},{"line_number":343,"context_line":"            model_update[\u0027provider_geometry\u0027] \u003d (\u0027%s %s\u0027 % (4096, 4096))"},{"line_number":344,"context_line":"        model_update[\u0027provider_id\u0027] \u003d (\u0027%s\u0027 % sf_volume_id)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        return model_update"},{"line_number":347,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_642151fb","line":344,"in_reply_to":"5afe65bd_3e6daf98","updated":"2015-06-03 11:52:25.000000000","message":"I have to agree unless you do this for consistency with the rest of the method.","commit_id":"711e525d3dee0c7531d52bcb56adf64c352dda5c"}]}
