)]}'
{"cinder/volume/drivers/san/hp/hpmsa_common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5e9cc338fc8dd37a2b0a2a4b1b49fc232dc8d7cf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"               help\u003d\"VDisk or Pool name to use for volume creation.\"),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027hpmsa_backend_type\u0027,"},{"line_number":27,"context_line":"               choices\u003d[\u0027linear\u0027, \u0027realstor\u0027],"},{"line_number":28,"context_line":"               help\u003d\"linear(for VDisk) or realstor(for Pool)\"),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027hpmsa_wbi_protocol\u0027,"},{"line_number":30,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":31,"context_line":"               help\u003d\"HPMSA web interface protocol\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_bd30c657","line":28,"updated":"2015-06-15 17:22:18.000000000","message":"Add space before ( and end with a . if doing another update.","commit_id":"055f5a72abe0f5800ab6577b6fab67b54f390d2b"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"c0d48d61da6529f16fad292ac6d27317cdea37be","unresolved":false,"context_lines":[{"line_number":25,"context_line":"               help\u003d\"VDisk or Pool name to use for volume creation.\"),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027hpmsa_backend_type\u0027,"},{"line_number":27,"context_line":"               choices\u003d[\u0027linear\u0027, \u0027realstor\u0027],"},{"line_number":28,"context_line":"               help\u003d\"linear(for VDisk) or realstor(for Pool)\"),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027hpmsa_wbi_protocol\u0027,"},{"line_number":30,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":31,"context_line":"               help\u003d\"HPMSA web interface protocol\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_20c80622","line":28,"in_reply_to":"fa32b979_7da9db7a","updated":"2015-06-15 18:56:32.000000000","message":"will surely change it if do another update","commit_id":"055f5a72abe0f5800ab6577b6fab67b54f390d2b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d36b92ec69a12be9e6cb1a6c713f293a1224c7e1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"               help\u003d\"VDisk or Pool name to use for volume creation.\"),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027hpmsa_backend_type\u0027,"},{"line_number":27,"context_line":"               choices\u003d[\u0027linear\u0027, \u0027realstor\u0027],"},{"line_number":28,"context_line":"               help\u003d\"linear(for VDisk) or realstor(for Pool)\"),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027hpmsa_wbi_protocol\u0027,"},{"line_number":30,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":31,"context_line":"               help\u003d\"HPMSA web interface protocol\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_7da9db7a","line":28,"in_reply_to":"fa32b979_bd30c657","updated":"2015-06-15 18:36:49.000000000","message":"Agree.","commit_id":"055f5a72abe0f5800ab6577b6fab67b54f390d2b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5e9cc338fc8dd37a2b0a2a4b1b49fc232dc8d7cf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"               help\u003d\"linear(for VDisk) or realstor(for Pool)\"),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027hpmsa_wbi_protocol\u0027,"},{"line_number":30,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":31,"context_line":"               help\u003d\"HPMSA web interface protocol\"),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"iscsi_opt \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_3d3d962b","line":31,"updated":"2015-06-15 17:22:18.000000000","message":"End with a . if doing another update.","commit_id":"055f5a72abe0f5800ab6577b6fab67b54f390d2b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d36b92ec69a12be9e6cb1a6c713f293a1224c7e1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"               help\u003d\"linear(for VDisk) or realstor(for Pool)\"),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027hpmsa_wbi_protocol\u0027,"},{"line_number":30,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":31,"context_line":"               help\u003d\"HPMSA web interface protocol\"),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"iscsi_opt \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_5dc5f739","line":31,"in_reply_to":"fa32b979_3d3d962b","updated":"2015-06-15 18:36:49.000000000","message":"++","commit_id":"055f5a72abe0f5800ab6577b6fab67b54f390d2b"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"c0d48d61da6529f16fad292ac6d27317cdea37be","unresolved":false,"context_lines":[{"line_number":28,"context_line":"               help\u003d\"linear(for VDisk) or realstor(for Pool)\"),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027hpmsa_wbi_protocol\u0027,"},{"line_number":30,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":31,"context_line":"               help\u003d\"HPMSA web interface protocol\"),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"iscsi_opt \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_00d5c2b7","line":31,"in_reply_to":"fa32b979_5dc5f739","updated":"2015-06-15 18:56:32.000000000","message":"will surely change it if do another update","commit_id":"055f5a72abe0f5800ab6577b6fab67b54f390d2b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5e9cc338fc8dd37a2b0a2a4b1b49fc232dc8d7cf","unresolved":false,"context_lines":[{"line_number":34,"context_line":"iscsi_opt \u003d ["},{"line_number":35,"context_line":"    cfg.ListOpt(\u0027hpmsa_iscsi_ips\u0027,"},{"line_number":36,"context_line":"                default\u003d[],"},{"line_number":37,"context_line":"                help\u003d\"List of target iSCSI addresses\"),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_5d0c1a94","line":37,"updated":"2015-06-15 17:22:18.000000000","message":"End with a . if doing another update.","commit_id":"055f5a72abe0f5800ab6577b6fab67b54f390d2b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d36b92ec69a12be9e6cb1a6c713f293a1224c7e1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"iscsi_opt \u003d ["},{"line_number":35,"context_line":"    cfg.ListOpt(\u0027hpmsa_iscsi_ips\u0027,"},{"line_number":36,"context_line":"                default\u003d[],"},{"line_number":37,"context_line":"                help\u003d\"List of target iSCSI addresses\"),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_1d052f79","line":37,"updated":"2015-06-15 18:36:49.000000000","message":"Need to include list format here.  Suggest comma separated.","commit_id":"055f5a72abe0f5800ab6577b6fab67b54f390d2b"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"c0d48d61da6529f16fad292ac6d27317cdea37be","unresolved":false,"context_lines":[{"line_number":34,"context_line":"iscsi_opt \u003d ["},{"line_number":35,"context_line":"    cfg.ListOpt(\u0027hpmsa_iscsi_ips\u0027,"},{"line_number":36,"context_line":"                default\u003d[],"},{"line_number":37,"context_line":"                help\u003d\"List of target iSCSI addresses\"),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_80a6b251","line":37,"in_reply_to":"fa32b979_1d052f79","updated":"2015-06-15 18:56:32.000000000","message":"there is no default ips, and in the code it is taken care if this list is empty,","commit_id":"055f5a72abe0f5800ab6577b6fab67b54f390d2b"}],"cinder/volume/drivers/san/hp/hpmsa_fc.py":[{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"1dd058cc1ad147eefd21814ffbe0965e7596fade","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class HPMSAFCDriver(dothill_fc.DotHillFCDriver):"},{"line_number":22,"context_line":"    \"\"\"Openstack Fibre Channel cinder drivers for HPMSA arrays."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Version history:"},{"line_number":25,"context_line":"        1.0    - Inheriting from DotHill cinder drivers."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_15106658","line":22,"updated":"2015-06-16 21:41:11.000000000","message":"s/Openstack/OpenStack","commit_id":"5b722e3889536e407b386869b08118b7533539d0"},{"author":{"_account_id":16121,"name":"Nikesh","email":"Nikesh.Mahalaka@dothill.com","username":"nikeshm"},"change_message_id":"44ba05054b77d90b274942c1d76b87c7d84c76d4","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class HPMSAFCDriver(dothill_fc.DotHillFCDriver):"},{"line_number":22,"context_line":"    \"\"\"Openstack Fibre Channel cinder drivers for HPMSA arrays."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Version history:"},{"line_number":25,"context_line":"        1.0    - Inheriting from DotHill cinder drivers."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_618a501d","line":22,"in_reply_to":"fa32b979_15106658","updated":"2015-06-16 23:58:22.000000000","message":"Done","commit_id":"5b722e3889536e407b386869b08118b7533539d0"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"1dd058cc1ad147eefd21814ffbe0965e7596fade","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"Openstack Fibre Channel cinder drivers for HPMSA arrays."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Version history:"},{"line_number":25,"context_line":"        1.0    - Inheriting from DotHill cinder drivers."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_f867f9e6","line":25,"updated":"2015-06-16 21:41:11.000000000","message":"Shouldn\u0027t your driver have it\u0027s own version?\nIf the base driver changes the version, it will change for your driver.","commit_id":"5b722e3889536e407b386869b08118b7533539d0"},{"author":{"_account_id":16121,"name":"Nikesh","email":"Nikesh.Mahalaka@dothill.com","username":"nikeshm"},"change_message_id":"44ba05054b77d90b274942c1d76b87c7d84c76d4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"Openstack Fibre Channel cinder drivers for HPMSA arrays."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Version history:"},{"line_number":25,"context_line":"        1.0    - Inheriting from DotHill cinder drivers."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_2180c8f6","line":25,"in_reply_to":"fa32b979_f867f9e6","updated":"2015-06-16 23:58:22.000000000","message":"Good suggestion,going with it,thanks","commit_id":"5b722e3889536e407b386869b08118b7533539d0"}],"cinder/volume/drivers/san/hp/hpmsa_iscsi.py":[{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"1dd058cc1ad147eefd21814ffbe0965e7596fade","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class HPMSAISCSIDriver(dothill_iscsi.DotHillISCSIDriver):"},{"line_number":22,"context_line":"    \"\"\"Openstack iSCSI cinder drivers for HPMSA arrays."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Version history:"},{"line_number":25,"context_line":"        1.0    - Inheriting from DotHill cinder drivers."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_f8129956","line":22,"updated":"2015-06-16 21:41:11.000000000","message":"s/Openstack/OpenStack","commit_id":"5b722e3889536e407b386869b08118b7533539d0"},{"author":{"_account_id":16121,"name":"Nikesh","email":"Nikesh.Mahalaka@dothill.com","username":"nikeshm"},"change_message_id":"44ba05054b77d90b274942c1d76b87c7d84c76d4","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class HPMSAISCSIDriver(dothill_iscsi.DotHillISCSIDriver):"},{"line_number":22,"context_line":"    \"\"\"Openstack iSCSI cinder drivers for HPMSA arrays."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Version history:"},{"line_number":25,"context_line":"        1.0    - Inheriting from DotHill cinder drivers."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_c171dc45","line":22,"in_reply_to":"fa32b979_f8129956","updated":"2015-06-16 23:58:22.000000000","message":"Done","commit_id":"5b722e3889536e407b386869b08118b7533539d0"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"1dd058cc1ad147eefd21814ffbe0965e7596fade","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class HPMSAISCSIDriver(dothill_iscsi.DotHillISCSIDriver):"},{"line_number":22,"context_line":"    \"\"\"Openstack iSCSI cinder drivers for HPMSA arrays."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Version history:"},{"line_number":25,"context_line":"        1.0    - Inheriting from DotHill cinder drivers."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_98490d63","line":24,"updated":"2015-06-16 21:41:11.000000000","message":"Same as previous version comment.","commit_id":"5b722e3889536e407b386869b08118b7533539d0"},{"author":{"_account_id":16121,"name":"Nikesh","email":"Nikesh.Mahalaka@dothill.com","username":"nikeshm"},"change_message_id":"44ba05054b77d90b274942c1d76b87c7d84c76d4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class HPMSAISCSIDriver(dothill_iscsi.DotHillISCSIDriver):"},{"line_number":22,"context_line":"    \"\"\"Openstack iSCSI cinder drivers for HPMSA arrays."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Version history:"},{"line_number":25,"context_line":"        1.0    - Inheriting from DotHill cinder drivers."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_e1a500a2","line":24,"in_reply_to":"fa32b979_98490d63","updated":"2015-06-16 23:58:22.000000000","message":"Good suggestion,going with it,thanks","commit_id":"5b722e3889536e407b386869b08118b7533539d0"}]}