)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"3d5d5e6b0b307e07709e5cb5b10fc9946907bf31","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix QoS support in Huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we create a volume with no QoS spec, or create a volume"},{"line_number":10,"context_line":"with other extra spec, create_volume method will raise a error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ibcb596d5c971f64a200c39706546b711560fd4ef"},{"line_number":13,"context_line":"Closes-Bug: 1461403"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5afe65bd_bf517dda","line":10,"updated":"2015-06-03 20:00:36.000000000","message":"This is the description of the issue, please also provide description for your fix too.","commit_id":"fcfb8afb1f82af257e79bea1937f280a902f3894"}],"cinder/volume/drivers/huawei/rest_common.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"4ff6331863efc821076ba629249d9b5ad55456d2","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"    def _get_qos_by_volume_type(self, volume_type):"},{"line_number":1606,"context_line":"        qos \u003d {}"},{"line_number":1607,"context_line":"        qos_specs_id \u003d volume_type.get(\u0027qos_specs_id\u0027)"},{"line_number":1608,"context_line":"        specs \u003d volume_type.get(\u0027extra_specs\u0027)"},{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":"        # NOTE(kmartin): We prefer the qos_specs association"},{"line_number":1611,"context_line":"        # and override any existing extra-specs settings"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_664dc83d","line":1608,"updated":"2015-06-03 16:26:20.000000000","message":"Please fix pep8 issue: ./cinder/volume/drivers/huawei/rest_common.py:1608:9: F841 local variable \u0027specs\u0027 is assigned to but never used","commit_id":"fcfb8afb1f82af257e79bea1937f280a902f3894"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"3d5d5e6b0b307e07709e5cb5b10fc9946907bf31","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"            kvs \u003d qos_specs.get_qos_specs(context.get_admin_context(),"},{"line_number":1615,"context_line":"                                          qos_specs_id)[\u0027specs\u0027]"},{"line_number":1616,"context_line":"        else:"},{"line_number":1617,"context_line":"            return qos"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"        LOG.info(_LI(\u0027The QoS sepcs is: %s.\u0027), kvs)"},{"line_number":1620,"context_line":"        for key, value in kvs.iteritems():"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_9f5fe1e4","line":1617,"updated":"2015-06-03 20:00:36.000000000","message":"By returning a empty dict, basically means the driver won\u0027t use anything in type extra specs, is that what you wanted?  Does extra specs ever work for your driver before?  If it does, removing supporting type extra spec defintly warrant an \u0027DocImpact\u0027 flag in commit message and an explanation of why it is no longer supported.","commit_id":"fcfb8afb1f82af257e79bea1937f280a902f3894"}]}