)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"d2946dde44972d754d838d88f085f98730c73ad0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"GlusterFS: Switch to Cinder Objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch modifies GlusterFS backup driver to use Cinder objects"},{"line_number":10,"context_line":"(volume and snapshot objects) instead of direct db calls."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also modified test cases accordingly."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa32b979_14a984df","line":10,"updated":"2015-06-15 20:14:50.000000000","message":"Volume objects are actually passed to the driver until https://review.openstack.org/177054, and even in that patch it is limited to a few volume APIs, so these changes are not actually using the oslo_versionedobject, but instead the SQLAlchemy object.   Better to just say snapshot objects.","commit_id":"6b840ee5fe9309af27530131d3225acc6e402d0f"}],"cinder/cmd/backup.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"d2946dde44972d754d838d88f085f98730c73ad0","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def main():"},{"line_number":46,"context_line":"    objects.register_all()"},{"line_number":47,"context_line":"    CONF(sys.argv[1:], project\u003d\u0027cinder\u0027,"},{"line_number":48,"context_line":"         version\u003dversion.version_string())"},{"line_number":49,"context_line":"    logging.setup(CONF, \"cinder\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_a9b16191","line":46,"updated":"2015-06-15 20:14:50.000000000","message":"Depending on when https://review.openstack.org/157085 gets merged, these changes will be unecessary.","commit_id":"6b840ee5fe9309af27530131d3225acc6e402d0f"}],"cinder/tests/unit/test_glusterfs.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"d2946dde44972d754d838d88f085f98730c73ad0","unresolved":false,"context_lines":[{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        return volume"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    def _simple_volume_object(self, id\u003dNone):"},{"line_number":532,"context_line":"        if id is None:"},{"line_number":533,"context_line":"            vol_id \u003d self.VOLUME_UUID"},{"line_number":534,"context_line":"        volume \u003d vol_obj.Volume(id\u003dvol_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_494e9597","line":531,"updated":"2015-06-15 20:14:50.000000000","message":"Could you use fake_snapshot.fake_snapshot_obj?  You can use that function to get you an object, even with the attributes you want below.","commit_id":"6b840ee5fe9309af27530131d3225acc6e402d0f"}],"cinder/volume/drivers/glusterfs.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"d2946dde44972d754d838d88f085f98730c73ad0","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    def delete_volume(self, volume):"},{"line_number":243,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        if not volume.provider_location:"},{"line_number":246,"context_line":"            LOG.warning(_LW(\u0027Volume %s does not have \u0027"},{"line_number":247,"context_line":"                            \u0027provider_location specified, \u0027"},{"line_number":248,"context_line":"                            \u0027skipping\u0027), volume.name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_d4647ce6","line":245,"updated":"2015-06-15 20:14:50.000000000","message":"Volume objects are actually passed to the driver until https://review.openstack.org/177054, and even in that patch it is limited to a few volume APIs, so these changes are not actually using the oslo_versionedobject, but instead the SQLAlchemy object.","commit_id":"6b840ee5fe9309af27530131d3225acc6e402d0f"}]}