)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0ea387c471b2512c77167c523d5cf6c3140d6eb1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"not limited to one to one match.  DriverFilter should just do one"},{"line_number":14,"context_line":"thing, that is evaluating filter_function supplied by backend."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change remove the volume_backend_name check from DriverFilter"},{"line_number":17,"context_line":"without touching its core function, thus no impact on existing"},{"line_number":18,"context_line":"documentation because the checking volume_backend_name is an"},{"line_number":19,"context_line":"undocumented side-effect of this filter.  This change also reduces"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_9eaf4d94","line":16,"updated":"2015-06-04 22:06:57.000000000","message":"s/remove/removes/","commit_id":"17880e4f9d078c68cc9fd224895b8912fccfe8b1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0ea387c471b2512c77167c523d5cf6c3140d6eb1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"thing, that is evaluating filter_function supplied by backend."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change remove the volume_backend_name check from DriverFilter"},{"line_number":17,"context_line":"without touching its core function, thus no impact on existing"},{"line_number":18,"context_line":"documentation because the checking volume_backend_name is an"},{"line_number":19,"context_line":"undocumented side-effect of this filter.  This change also reduces"},{"line_number":20,"context_line":"one warning log to debug log whenno filter_function found in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_be81e9fd","line":17,"updated":"2015-06-04 22:06:57.000000000","message":"s/thus/thus has/","commit_id":"17880e4f9d078c68cc9fd224895b8912fccfe8b1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0ea387c471b2512c77167c523d5cf6c3140d6eb1","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change remove the volume_backend_name check from DriverFilter"},{"line_number":17,"context_line":"without touching its core function, thus no impact on existing"},{"line_number":18,"context_line":"documentation because the checking volume_backend_name is an"},{"line_number":19,"context_line":"undocumented side-effect of this filter.  This change also reduces"},{"line_number":20,"context_line":"one warning log to debug log whenno filter_function found in"},{"line_number":21,"context_line":"host_state, because if only few of backends supply filter_function"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_5e79d52e","line":18,"updated":"2015-06-04 22:06:57.000000000","message":"s/the checking/the checking of/","commit_id":"17880e4f9d078c68cc9fd224895b8912fccfe8b1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0ea387c471b2512c77167c523d5cf6c3140d6eb1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"without touching its core function, thus no impact on existing"},{"line_number":18,"context_line":"documentation because the checking volume_backend_name is an"},{"line_number":19,"context_line":"undocumented side-effect of this filter.  This change also reduces"},{"line_number":20,"context_line":"one warning log to debug log whenno filter_function found in"},{"line_number":21,"context_line":"host_state, because if only few of backends supply filter_function"},{"line_number":22,"context_line":"in a multibackend deployment, there will be lots of warning log"},{"line_number":23,"context_line":"for those backends don\u0027t supply for EVERY create request."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_fe8e4126","line":20,"updated":"2015-06-04 22:06:57.000000000","message":"s/whenno/when no/","commit_id":"17880e4f9d078c68cc9fd224895b8912fccfe8b1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0ea387c471b2512c77167c523d5cf6c3140d6eb1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"one warning log to debug log whenno filter_function found in"},{"line_number":21,"context_line":"host_state, because if only few of backends supply filter_function"},{"line_number":22,"context_line":"in a multibackend deployment, there will be lots of warning log"},{"line_number":23,"context_line":"for those backends don\u0027t supply for EVERY create request."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"UpgradeImpact:"},{"line_number":26,"context_line":"DriverFilter had an undocumented side-effect before it evluates"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_deba65c0","line":23,"updated":"2015-06-04 22:06:57.000000000","message":"The previous sentence could be worded more clearly I think.","commit_id":"17880e4f9d078c68cc9fd224895b8912fccfe8b1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0ea387c471b2512c77167c523d5cf6c3140d6eb1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"for those backends don\u0027t supply for EVERY create request."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"UpgradeImpact:"},{"line_number":26,"context_line":"DriverFilter had an undocumented side-effect before it evluates"},{"line_number":27,"context_line":"filter_function - it checked if volume_backend_name in host_state"},{"line_number":28,"context_line":"reported by backend matches volume_backend_name in volume type"},{"line_number":29,"context_line":"extra specs, and if they don\u0027t, the backend would fail to pass"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_1eaa3d71","line":26,"updated":"2015-06-04 22:06:57.000000000","message":"s/evluates/evaluates/","commit_id":"17880e4f9d078c68cc9fd224895b8912fccfe8b1"}]}