)]}'
{"cinder/backup/chunkeddriver.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"27322c8d6597a51bc83b4982f73ae602539fb9ec","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    def _prepare_output_data(self, data):"},{"line_number":321,"context_line":"        if self.compressor is None:"},{"line_number":322,"context_line":"            return \u0027none\u0027, data"},{"line_number":323,"context_line":"        data_size_bytes \u003d len(data)"},{"line_number":324,"context_line":"        compressed_data \u003d self.compressor.compress(data)"},{"line_number":325,"context_line":"        comp_size_bytes \u003d len(compressed_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_7f6a481c","line":322,"updated":"2015-06-05 02:04:46.000000000","message":"Why do you use \u0027none\u0027 instead of None? Any reasons for that?","commit_id":"97c08d396e553cf23df3ebe38d81d11e06f5d920"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c0f4ec146897d31323d537564b6c0b2a88199b8e","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    def _prepare_output_data(self, data):"},{"line_number":321,"context_line":"        if self.compressor is None:"},{"line_number":322,"context_line":"            return \u0027none\u0027, data"},{"line_number":323,"context_line":"        data_size_bytes \u003d len(data)"},{"line_number":324,"context_line":"        compressed_data \u003d self.compressor.compress(data)"},{"line_number":325,"context_line":"        comp_size_bytes \u003d len(compressed_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_3f7e10af","line":322,"in_reply_to":"3afb71cf_7f6a481c","updated":"2015-06-05 02:11:55.000000000","message":"It\u0027s a good question.\n\nCheck get_compressor at line 69ff.\n\n\u0027none\u0027 is used (among other text strings) rather than None for the traditional (in Swift backup driver before it was refactored into \"chunked\") get_compressor method.\n\nI would think that if we were doing this fresh we would use None.\n\nBut I\u0027m just being compatible with what is already there in this change.","commit_id":"97c08d396e553cf23df3ebe38d81d11e06f5d920"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4f7b87c16e8d2b54b245d1c6ac10ca1f292c898a","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    def _prepare_output_data(self, data):"},{"line_number":321,"context_line":"        if self.compressor is None:"},{"line_number":322,"context_line":"            return \u0027none\u0027, data"},{"line_number":323,"context_line":"        data_size_bytes \u003d len(data)"},{"line_number":324,"context_line":"        compressed_data \u003d self.compressor.compress(data)"},{"line_number":325,"context_line":"        comp_size_bytes \u003d len(compressed_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_7fada830","line":322,"in_reply_to":"3afb71cf_7f6a481c","updated":"2015-06-05 02:11:15.000000000","message":"The original code on line 317 on the left hand side also uses \u0027none\u0027. So this is the same as before.","commit_id":"97c08d396e553cf23df3ebe38d81d11e06f5d920"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"27322c8d6597a51bc83b4982f73ae602539fb9ec","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                      {\u0027data_size_bytes\u0027: data_size_bytes,"},{"line_number":333,"context_line":"                       \u0027comp_size_bytes\u0027: comp_size_bytes,"},{"line_number":334,"context_line":"                       })"},{"line_number":335,"context_line":"            return \u0027none\u0027, data"},{"line_number":336,"context_line":"        LOG.debug(\u0027Compressed %(data_size_bytes)d bytes of data \u0027"},{"line_number":337,"context_line":"                  \u0027to %(comp_size_bytes)d bytes using %(algorithm)s.\u0027,"},{"line_number":338,"context_line":"                  {\u0027data_size_bytes\u0027: data_size_bytes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_3f74d0fb","line":335,"updated":"2015-06-05 02:04:46.000000000","message":"Why do you use \u0027none\u0027 instead of None? Any reasons for that?","commit_id":"97c08d396e553cf23df3ebe38d81d11e06f5d920"}]}
