)]}'
{"cinder/backup/manager.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ffa0a0299894974778c3a5b949db278bf910626c","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                \u0027expected_status\u0027: expected_status,"},{"line_number":283,"context_line":"                \u0027actual_status\u0027: actual_status,"},{"line_number":284,"context_line":"            }"},{"line_number":285,"context_line":"            self.db.volume_update(context, volume_id, {\u0027status\u0027: initial_vol_status})"},{"line_number":286,"context_line":"            self.db.backup_update(context, backup_id, {\u0027status\u0027: \u0027error\u0027,"},{"line_number":287,"context_line":"                                                       \u0027fail_reason\u0027: err})"},{"line_number":288,"context_line":"            raise exception.InvalidBackup(reason\u003derr)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_ba38ce3e","line":285,"updated":"2015-06-11 18:16:19.000000000","message":"wrap this line","commit_id":"40a98b34af2ccb6cb6b854d685a2ddc5b81a58d0"}],"cinder/tests/unit/api/contrib/test_backups.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"05dcfee981af4e475a605b352609709c38051736","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        res \u003d req.get_response(fakes.wsgi_app())"},{"line_number":650,"context_line":"        res_dict \u003d json.loads(res.body)"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        self.assertEqual(res.status_int, 400)"},{"line_number":653,"context_line":"        self.assertEqual(res_dict[\u0027badRequest\u0027][\u0027code\u0027], 400)"},{"line_number":654,"context_line":"        self.assertEqual(res_dict[\u0027badRequest\u0027][\u0027message\u0027],"},{"line_number":655,"context_line":"                         \u0027Invalid volume: Volume to be backed up is \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_a89a536c","line":652,"updated":"2015-06-09 08:58:49.000000000","message":"The parameter order for assertEqual is expected first and then actual result.","commit_id":"038c453653e3e80cb8fc935c239d699fa2efdb9b"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"05dcfee981af4e475a605b352609709c38051736","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        res_dict \u003d json.loads(res.body)"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        self.assertEqual(res.status_int, 400)"},{"line_number":653,"context_line":"        self.assertEqual(res_dict[\u0027badRequest\u0027][\u0027code\u0027], 400)"},{"line_number":654,"context_line":"        self.assertEqual(res_dict[\u0027badRequest\u0027][\u0027message\u0027],"},{"line_number":655,"context_line":"                         \u0027Invalid volume: Volume to be backed up is \u0027"},{"line_number":656,"context_line":"                         \u0027in-use, try forcing.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_888af719","line":653,"updated":"2015-06-09 08:58:49.000000000","message":"The parameter order for assertEqual is expected first and then actual result.","commit_id":"038c453653e3e80cb8fc935c239d699fa2efdb9b"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"05dcfee981af4e475a605b352609709c38051736","unresolved":false,"context_lines":[{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        self.assertEqual(res.status_int, 400)"},{"line_number":653,"context_line":"        self.assertEqual(res_dict[\u0027badRequest\u0027][\u0027code\u0027], 400)"},{"line_number":654,"context_line":"        self.assertEqual(res_dict[\u0027badRequest\u0027][\u0027message\u0027],"},{"line_number":655,"context_line":"                         \u0027Invalid volume: Volume to be backed up is \u0027"},{"line_number":656,"context_line":"                         \u0027in-use, try forcing.\u0027)"},{"line_number":657,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_688fbb2a","line":654,"updated":"2015-06-09 08:58:49.000000000","message":"The parameter order for assertEqual is expected first and then actual result.","commit_id":"038c453653e3e80cb8fc935c239d699fa2efdb9b"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"05dcfee981af4e475a605b352609709c38051736","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        res_dict \u003d json.loads(res.body)"},{"line_number":682,"context_line":"        LOG.info(res_dict)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        self.assertEqual(res.status_int, 202)"},{"line_number":685,"context_line":"        self.assertIn(\u0027id\u0027, res_dict[\u0027backup\u0027])"},{"line_number":686,"context_line":"        self.assertTrue(_mock_service_get_all_by_topic.called)"},{"line_number":687,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_087f2716","line":684,"updated":"2015-06-09 08:58:49.000000000","message":"The parameter order for assertEqual is expected first and then actual result.","commit_id":"038c453653e3e80cb8fc935c239d699fa2efdb9b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ffa0a0299894974778c3a5b949db278bf910626c","unresolved":false,"context_lines":[{"line_number":661,"context_line":"            {\u0027availability_zone\u0027: \"fake_az\", \u0027host\u0027: \u0027test_host\u0027,"},{"line_number":662,"context_line":"             \u0027disabled\u0027: 0, \u0027updated_at\u0027: timeutils.utcnow()}]"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        volume_id \u003d utils.create_volume(self.context, size\u003d5,"},{"line_number":665,"context_line":"                                        status\u003d\u0027in-use\u0027)[\u0027id\u0027]"},{"line_number":666,"context_line":"        body \u003d {\"backup\": {\"display_name\": \"nightly001\","},{"line_number":667,"context_line":"                           \"display_description\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_dfe4caac","line":664,"updated":"2015-06-11 18:16:19.000000000","message":"Maybe repeat the comment from the previous method?","commit_id":"40a98b34af2ccb6cb6b854d685a2ddc5b81a58d0"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ffa0a0299894974778c3a5b949db278bf910626c","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        req.body \u003d json.dumps(body)"},{"line_number":679,"context_line":"        res \u003d req.get_response(fakes.wsgi_app())"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        res_dict \u003d json.loads(res.body)"},{"line_number":682,"context_line":"        LOG.info(res_dict)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        self.assertEqual(202, res.status_int)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_5f9e9a07","line":681,"updated":"2015-06-11 18:16:19.000000000","message":"Consider adding a method for the common part of this method and the previous rather than having this big section of cut-and-paste.","commit_id":"40a98b34af2ccb6cb6b854d685a2ddc5b81a58d0"},{"author":{"_account_id":12160,"name":"Abhishek Lekshmanan","email":"abhishek.lekshmanan@gmail.com","username":"abhishekl"},"change_message_id":"934cb4b8ba2c95b810f675335af7d4306a9c10e2","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        req.body \u003d json.dumps(body)"},{"line_number":679,"context_line":"        res \u003d req.get_response(fakes.wsgi_app())"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        res_dict \u003d json.loads(res.body)"},{"line_number":682,"context_line":"        LOG.info(res_dict)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        self.assertEqual(202, res.status_int)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1af86dd1_7eada387","line":681,"in_reply_to":"3afb71cf_5f9e9a07","updated":"2015-06-12 09:50:25.000000000","message":"Sure makes sense","commit_id":"40a98b34af2ccb6cb6b854d685a2ddc5b81a58d0"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ffa0a0299894974778c3a5b949db278bf910626c","unresolved":false,"context_lines":[{"line_number":679,"context_line":"        res \u003d req.get_response(fakes.wsgi_app())"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        res_dict \u003d json.loads(res.body)"},{"line_number":682,"context_line":"        LOG.info(res_dict)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        self.assertEqual(202, res.status_int)"},{"line_number":685,"context_line":"        self.assertIn(\u0027id\u0027, res_dict[\u0027backup\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_9fbf7260","line":682,"updated":"2015-06-11 18:16:19.000000000","message":"Why are we doing LOG in a unit test?  I know other tests in this file are doing it, but ....","commit_id":"40a98b34af2ccb6cb6b854d685a2ddc5b81a58d0"},{"author":{"_account_id":12160,"name":"Abhishek Lekshmanan","email":"abhishek.lekshmanan@gmail.com","username":"abhishekl"},"change_message_id":"934cb4b8ba2c95b810f675335af7d4306a9c10e2","unresolved":false,"context_lines":[{"line_number":679,"context_line":"        res \u003d req.get_response(fakes.wsgi_app())"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        res_dict \u003d json.loads(res.body)"},{"line_number":682,"context_line":"        LOG.info(res_dict)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        self.assertEqual(202, res.status_int)"},{"line_number":685,"context_line":"        self.assertIn(\u0027id\u0027, res_dict[\u0027backup\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1af86dd1_5ec1c72d","line":682,"in_reply_to":"3afb71cf_9fbf7260","updated":"2015-06-12 09:50:25.000000000","message":"Yeah just followed most of what other tests were doing.. I\u0027ll remove this","commit_id":"40a98b34af2ccb6cb6b854d685a2ddc5b81a58d0"}]}