)]}'
{"cinder/volume/drivers/netapp/dataontap/client/client_7mode.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"52b9c684007491a3445656499a9d3bd8dcdcd4ba","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                    else:"},{"line_number":256,"context_line":"                        running \u003d False"},{"line_number":257,"context_line":"                        clone_ops_info \u003d info"},{"line_number":258,"context_line":"                        break"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        if clone_ops_info:"},{"line_number":261,"context_line":"            fmt \u003d {\u0027name\u0027: name, \u0027new_name\u0027: new_name}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_14a2c7ae","line":258,"updated":"2015-06-08 14:17:46.000000000","message":"As noted in the bug: are you sure that the correct behavior here isn\u0027t achieved by removing this break?","commit_id":"d0c69fdd1220cf050252257a34296be7dcd2e34b"},{"author":{"_account_id":10300,"name":"Pranali Deore","email":"pranalideore@gmail.com","username":"PranaliDeore"},"change_message_id":"e87ef0a12e578fd935f4636f804c612be33cf013","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                    else:"},{"line_number":256,"context_line":"                        running \u003d False"},{"line_number":257,"context_line":"                        clone_ops_info \u003d info"},{"line_number":258,"context_line":"                        break"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        if clone_ops_info:"},{"line_number":261,"context_line":"            fmt \u003d {\u0027name\u0027: name, \u0027new_name\u0027: new_name}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_934a2dab","line":258,"in_reply_to":"3afb71cf_14a2c7ae","updated":"2015-06-09 06:22:39.000000000","message":"Hi Eric,\n\nYou are right that \u0027else\u0027 block is not a dead code. The code is quite confusing hence I thought \u0027else\u0027 block is not reachable.But the break statement inside for loop will break for loop and not while loop.","commit_id":"d0c69fdd1220cf050252257a34296be7dcd2e34b"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"410ddb7de62472fe062e20fbfe20ae585cc3fbce","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                    else:"},{"line_number":256,"context_line":"                        running \u003d False"},{"line_number":257,"context_line":"                        clone_ops_info \u003d info"},{"line_number":258,"context_line":"                        break"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        if clone_ops_info:"},{"line_number":261,"context_line":"            fmt \u003d {\u0027name\u0027: name, \u0027new_name\u0027: new_name}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_7708c491","line":258,"in_reply_to":"3afb71cf_14a2c7ae","updated":"2015-06-09 00:45:57.000000000","message":"I think Eric is correct\n\nif you guys want to remove the while/else flow i would recommend removing the \u0027running\u0027 variable from the method since it doesn\u0027t really do anything and then commit to the while True: + break strategy or take the breaks out, only modify running, and stick to the while/else\n\nhaving it kind of a hybrid between the two strategies is a good way to accidentally have this kind of bug in the future","commit_id":"d0c69fdd1220cf050252257a34296be7dcd2e34b"}]}