)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"b6342e889e5a1e451d992d4177ebddb731755dc3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support SMI-S v8.0.3 in VMAX driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch makes changes in the VMAX driver to support"},{"line_number":10,"context_line":"interface changes in SMI-S v8.0.3."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia6333396a8111f110f540c367e5018cfad6e93e4"},{"line_number":13,"context_line":"Closes-Bug: #1463217"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_f7503460","line":10,"updated":"2015-06-09 01:52:25.000000000","message":"I was looking at http://www.snia.org/tech_activities/standards/curr_standards/smi to find the version v8.0.3 mentioned here. Could you please elaborate which version is this?","commit_id":"d616df6247aa0c678569879edc96e1d0658dc194"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"85c465b7b31c0e6ef3e32cc14d3ed5cc9feb05a7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support SMI-S v8.0.3 in VMAX driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch makes changes in the VMAX driver to support"},{"line_number":10,"context_line":"interface changes in SMI-S v8.0.3."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia6333396a8111f110f540c367e5018cfad6e93e4"},{"line_number":13,"context_line":"Closes-Bug: #1463217"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_4ace092f","line":10,"in_reply_to":"3afb71cf_f7503460","updated":"2015-06-10 00:45:05.000000000","message":"Apoorva,\n\nI added more description in the commit message. v8.0.3 is EMC\u0027s SMI-S provider version.","commit_id":"d616df6247aa0c678569879edc96e1d0658dc194"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"71c85bc1b53c4aaa431567f7a7bb19f733789a45","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  ReturnElementsToStoragePool to EMCReturnToStoragePool."},{"line_number":16,"context_line":"* Extend volume - removed InPool parameter from EMCUnBindElements"},{"line_number":17,"context_line":"  method."},{"line_number":18,"context_line":"* Create snapshot/clone with multi meta mebers -"},{"line_number":19,"context_line":"  EMC_PartialAllocOfConcreteExtentCIM was deprecated;"},{"line_number":20,"context_line":"  used \u0027GetCompositeElements\u0027 instead and changed how we get meta"},{"line_number":21,"context_line":"  members\u0027 capacities."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba3cc151_13e928b7","line":18,"updated":"2015-07-08 21:47:04.000000000","message":"mebers -\u003e members","commit_id":"a22ff90b191bed65cc961879b9396784b8b0236b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2af5b215daf247cd92de2d959b4bc6fe3f36baf3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  ReturnElementsToStoragePool to EMCReturnToStoragePool."},{"line_number":16,"context_line":"* Extend volume - removed InPool parameter from EMCUnBindElements"},{"line_number":17,"context_line":"  method."},{"line_number":18,"context_line":"* Create snapshot/clone with multi meta mebers -"},{"line_number":19,"context_line":"  EMC_PartialAllocOfConcreteExtentCIM was deprecated;"},{"line_number":20,"context_line":"  used \u0027GetCompositeElements\u0027 instead and changed how we get meta"},{"line_number":21,"context_line":"  members\u0027 capacities."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba3cc151_e77ef169","line":18,"in_reply_to":"ba3cc151_13e928b7","updated":"2015-07-10 04:18:44.000000000","message":"Done","commit_id":"a22ff90b191bed65cc961879b9396784b8b0236b"}],"cinder/volume/drivers/emc/emc_vmax_common.py":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"a88246789c31a8e97fa6712e70a26bfcb1967097","unresolved":false,"context_lines":[{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"            prefix1 \u003d \u0027SYMMETRIX+\u0027"},{"line_number":1325,"context_line":"            prefix2 \u003d \u0027SYMMETRIX-+-\u0027"},{"line_number":1326,"context_line":"            smiversion \u003d self.utils.get_smi_version(self.conn)"},{"line_number":1327,"context_line":"            if smiversion \u003e 800 and prefix1 in systemName:"},{"line_number":1328,"context_line":"                keys[\u0027SystemName\u0027] \u003d systemName.replace(prefix1, prefix2)"},{"line_number":1329,"context_line":"                name[\u0027keybindings\u0027] \u003d keys"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_63fdb839","line":1326,"updated":"2015-06-15 19:50:01.000000000","message":"Perhaps smiversion should be stored in pool_info like the property \u0027is_v3\u0027 is?","commit_id":"8b1df565616a7686f55ac01b09b67da18008b13c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1ae37cc13629d40f0c708bc385e7fe7bb8636deb","unresolved":false,"context_lines":[{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"            prefix1 \u003d \u0027SYMMETRIX+\u0027"},{"line_number":1325,"context_line":"            prefix2 \u003d \u0027SYMMETRIX-+-\u0027"},{"line_number":1326,"context_line":"            smiversion \u003d self.utils.get_smi_version(self.conn)"},{"line_number":1327,"context_line":"            if smiversion \u003e 800 and prefix1 in systemName:"},{"line_number":1328,"context_line":"                keys[\u0027SystemName\u0027] \u003d systemName.replace(prefix1, prefix2)"},{"line_number":1329,"context_line":"                name[\u0027keybindings\u0027] \u003d keys"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_8f16ddef","line":1326,"in_reply_to":"fa32b979_63fdb839","updated":"2015-06-16 04:23:33.000000000","message":"smiversion is the same for multiple pools on the same array and it is the same for multiple arrays if they are all managed by the same SMI-S provider as well.  So I don\u0027t think it should be part of pool_info.","commit_id":"8b1df565616a7686f55ac01b09b67da18008b13c"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"df9dccf3ca3d19522ff0324d790540b08881e7f9","unresolved":false,"context_lines":[{"line_number":1324,"context_line":"            prefix1 \u003d \u0027SYMMETRIX+\u0027"},{"line_number":1325,"context_line":"            prefix2 \u003d \u0027SYMMETRIX-+-\u0027"},{"line_number":1326,"context_line":"            smiversion \u003d self.utils.get_smi_version(self.conn)"},{"line_number":1327,"context_line":"            if smiversion \u003e 800 and prefix1 in systemName:"},{"line_number":1328,"context_line":"                keys[\u0027SystemName\u0027] \u003d systemName.replace(prefix1, prefix2)"},{"line_number":1329,"context_line":"                name[\u0027keybindings\u0027] \u003d keys"},{"line_number":1330,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_e6f57d83","line":1327,"updated":"2015-06-15 02:58:11.000000000","message":"Can you put 800 in a more meaningful variable, since it is helpful to folks without the back-end driver knowledge?","commit_id":"8b1df565616a7686f55ac01b09b67da18008b13c"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"71c85bc1b53c4aaa431567f7a7bb19f733789a45","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":"from oslo_utils import units"},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_d324200e","line":21,"updated":"2015-07-08 21:47:04.000000000","message":"I don\u0027t think the following blank line should have been removed.","commit_id":"a22ff90b191bed65cc961879b9396784b8b0236b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"71c85bc1b53c4aaa431567f7a7bb19f733789a45","unresolved":false,"context_lines":[{"line_number":1888,"context_line":"            self.provision.unbind_volume_from_storage_pool("},{"line_number":1889,"context_line":"                conn, storageConfigService, volumeInstanceName,"},{"line_number":1890,"context_line":"                volumeName, extraSpecs))"},{"line_number":1891,"context_line":"        # Check that the volume in unbound"},{"line_number":1892,"context_line":"        volumeInstance \u003d conn.GetInstance(volumeInstanceName)"},{"line_number":1893,"context_line":"        isVolumeBound \u003d self.utils.is_volume_bound_to_pool("},{"line_number":1894,"context_line":"            conn, volumeInstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_f39b6415","line":1891,"updated":"2015-07-08 21:47:04.000000000","message":"in -\u003e is","commit_id":"a22ff90b191bed65cc961879b9396784b8b0236b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2af5b215daf247cd92de2d959b4bc6fe3f36baf3","unresolved":false,"context_lines":[{"line_number":1888,"context_line":"            self.provision.unbind_volume_from_storage_pool("},{"line_number":1889,"context_line":"                conn, storageConfigService, volumeInstanceName,"},{"line_number":1890,"context_line":"                volumeName, extraSpecs))"},{"line_number":1891,"context_line":"        # Check that the volume in unbound"},{"line_number":1892,"context_line":"        volumeInstance \u003d conn.GetInstance(volumeInstanceName)"},{"line_number":1893,"context_line":"        isVolumeBound \u003d self.utils.is_volume_bound_to_pool("},{"line_number":1894,"context_line":"            conn, volumeInstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_678bc169","line":1891,"in_reply_to":"ba3cc151_f39b6415","updated":"2015-07-10 04:18:44.000000000","message":"Done","commit_id":"a22ff90b191bed65cc961879b9396784b8b0236b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"71c85bc1b53c4aaa431567f7a7bb19f733789a45","unresolved":false,"context_lines":[{"line_number":1894,"context_line":"            conn, volumeInstance)"},{"line_number":1895,"context_line":"        if \u0027False\u0027 not in isVolumeBound:"},{"line_number":1896,"context_line":"            exceptionMessage \u003d (_("},{"line_number":1897,"context_line":"                \"Failed to unbind volume %(volume)s\")"},{"line_number":1898,"context_line":"                % {\u0027volume\u0027: volumeInstanceName})"},{"line_number":1899,"context_line":"            LOG.error(exceptionMessage)"},{"line_number":1900,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexceptionMessage)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_53c250ea","line":1897,"updated":"2015-07-08 21:47:04.000000000","message":"suggest \u0027volume:\u0027","commit_id":"a22ff90b191bed65cc961879b9396784b8b0236b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2af5b215daf247cd92de2d959b4bc6fe3f36baf3","unresolved":false,"context_lines":[{"line_number":1894,"context_line":"            conn, volumeInstance)"},{"line_number":1895,"context_line":"        if \u0027False\u0027 not in isVolumeBound:"},{"line_number":1896,"context_line":"            exceptionMessage \u003d (_("},{"line_number":1897,"context_line":"                \"Failed to unbind volume %(volume)s\")"},{"line_number":1898,"context_line":"                % {\u0027volume\u0027: volumeInstanceName})"},{"line_number":1899,"context_line":"            LOG.error(exceptionMessage)"},{"line_number":1900,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexceptionMessage)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_07e75547","line":1897,"in_reply_to":"ba3cc151_53c250ea","updated":"2015-07-10 04:18:44.000000000","message":"Done","commit_id":"a22ff90b191bed65cc961879b9396784b8b0236b"}],"cinder/volume/drivers/emc/emc_vmax_provision.py":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"a88246789c31a8e97fa6712e70a26bfcb1967097","unresolved":false,"context_lines":[{"line_number":337,"context_line":"                  {\u0027delta\u0027: self.utils.get_time_delta(startTime,"},{"line_number":338,"context_line":"                                                      time.time())})"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def unbind_volume_from_storage_pool("},{"line_number":341,"context_line":"            self, conn, storageConfigService, poolInstanceName,"},{"line_number":342,"context_line":"            volumeInstanceName, volumeName, extraSpecs):"},{"line_number":343,"context_line":"        \"\"\"Unbind a volume from a pool and return the unbound volume."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_4eed3b24","line":340,"updated":"2015-06-15 19:50:01.000000000","message":"poolInstanceName no longer needs to be passed. If it is still required for SMI-S prior to 8.0.3, then the logic below needs to distinguish and reference it for the older versions.","commit_id":"8b1df565616a7686f55ac01b09b67da18008b13c"},{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"a88246789c31a8e97fa6712e70a26bfcb1967097","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"            RelationshipName\u003drelationName,"},{"line_number":1077,"context_line":"            SourceGroup\u003dsrcGroupInstanceName,"},{"line_number":1078,"context_line":"            TargetGroup\u003dtgtGroupInstanceName,"},{"line_number":1079,"context_line":"            SyncType\u003dself.utils.get_num(8, \u002716\u0027),"},{"line_number":1080,"context_line":"            WaitForCopyState\u003dself.utils.get_num(4, \u002716\u0027))"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        if rc !\u003d 0L:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_4e621baf","line":1079,"updated":"2015-06-15 19:50:01.000000000","message":"Please document meanings/semantic of SyncType of 8 and waitForCopyState of 4.","commit_id":"8b1df565616a7686f55ac01b09b67da18008b13c"}],"cinder/volume/drivers/emc/emc_vmax_utils.py":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"a88246789c31a8e97fa6712e70a26bfcb1967097","unresolved":false,"context_lines":[{"line_number":1669,"context_line":"            if poolnameStr is not None:"},{"line_number":1670,"context_line":"                if six.text_type(poolname) \u003d\u003d six.text_type(poolnameStr):"},{"line_number":1671,"context_line":"                    try:"},{"line_number":1672,"context_line":"                        conn.GetInstance(poolInstanceName)"},{"line_number":1673,"context_line":"                        foundPoolInstanceName \u003d poolInstanceName"},{"line_number":1674,"context_line":"                    except Exception:"},{"line_number":1675,"context_line":"                        foundPoolInstanceName \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_2e7a37f2","line":1672,"updated":"2015-06-15 19:50:01.000000000","message":"Actually, it looks like GetInstance() was just done on the poolInstanceName during _get_pool_name() a couple lines before. So this try/except seems redundant.","commit_id":"8b1df565616a7686f55ac01b09b67da18008b13c"},{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"a88246789c31a8e97fa6712e70a26bfcb1967097","unresolved":false,"context_lines":[{"line_number":1857,"context_line":"        \"\"\""},{"line_number":1858,"context_line":"        capacitiesInBit \u003d []"},{"line_number":1859,"context_line":"        headVolume \u003d conn.GetInstance(volumeInstanceNames[0])"},{"line_number":1860,"context_line":"        totalSizeInBits \u003d ("},{"line_number":1861,"context_line":"            headVolume[\u0027ConsumableBlocks\u0027] * headVolume[\u0027BlockSize\u0027])"},{"line_number":1862,"context_line":"        volumeInstanceNames.pop(0)"},{"line_number":1863,"context_line":"        for volumeInstanceName in volumeInstanceNames:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_2ec8f721","line":1860,"updated":"2015-06-15 19:50:01.000000000","message":"Everywhere in this method and others that reference \"bits\", it really is talking about \"bytes\". bit--\u003ebyte probably should be cleaned up at some point.","commit_id":"8b1df565616a7686f55ac01b09b67da18008b13c"},{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"a88246789c31a8e97fa6712e70a26bfcb1967097","unresolved":false,"context_lines":[{"line_number":1868,"context_line":"            capacitiesInBit.append(volumeSizeInbits)"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"        # Calculate the size of the meta head."},{"line_number":1871,"context_line":"        for memberSize in capacitiesInBit:"},{"line_number":1872,"context_line":"            totalSizeInBits \u003d totalSizeInBits - memberSize"},{"line_number":1873,"context_line":""},{"line_number":1874,"context_line":"        capacitiesInBit.insert(0, totalSizeInBits)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_4ec0dbe0","line":1871,"updated":"2015-06-15 19:50:01.000000000","message":"You don\u0027t need a separate loop for this. May as well do the same computation using volumeSizeInbits in prior loop instead of memberSize here.","commit_id":"8b1df565616a7686f55ac01b09b67da18008b13c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"3ed88ff2881c5d630d3b69752df673c264d8e54c","unresolved":false,"context_lines":[{"line_number":1673,"context_line":""},{"line_number":1674,"context_line":"        return foundPoolInstanceName, systemNameStr"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":"    def _get_pool_name(self, conn, poolInstanceName):"},{"line_number":1677,"context_line":"        \"\"\"The pool name from the instance"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"        :param conn: the ecom connection"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_4ac0f5e0","line":1676,"updated":"2015-06-19 16:21:28.000000000","message":"I don\u0027t find unit test coverage for this method, or for its callers, for that matter.","commit_id":"e914baf58f6d147b793b729d64243836bed57083"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8db475e881ea22f90fa07383cfaa66bf4fb4aa51","unresolved":false,"context_lines":[{"line_number":1673,"context_line":""},{"line_number":1674,"context_line":"        return foundPoolInstanceName, systemNameStr"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":"    def _get_pool_name(self, conn, poolInstanceName):"},{"line_number":1677,"context_line":"        \"\"\"The pool name from the instance"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"        :param conn: the ecom connection"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_e6e401a9","line":1676,"in_reply_to":"fa32b979_4ac0f5e0","updated":"2015-06-24 13:33:54.000000000","message":"Done","commit_id":"e914baf58f6d147b793b729d64243836bed57083"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"3ed88ff2881c5d630d3b69752df673c264d8e54c","unresolved":false,"context_lines":[{"line_number":1844,"context_line":"        LOG.debug(\"metaMembers: %(members)s.\", {\u0027members\u0027: metaMembers})"},{"line_number":1845,"context_line":"        return metaMembers"},{"line_number":1846,"context_line":""},{"line_number":1847,"context_line":"    def get_meta_members_capacity_in_byte(self, conn, volumeInstanceNames):"},{"line_number":1848,"context_line":"        \"\"\"Get the capacity in byte of all meta device member volumes."},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"        :param conn: the ecom connection"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_2a301107","line":1847,"updated":"2015-06-19 16:21:28.000000000","message":"unit test coverage?","commit_id":"e914baf58f6d147b793b729d64243836bed57083"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8db475e881ea22f90fa07383cfaa66bf4fb4aa51","unresolved":false,"context_lines":[{"line_number":1844,"context_line":"        LOG.debug(\"metaMembers: %(members)s.\", {\u0027members\u0027: metaMembers})"},{"line_number":1845,"context_line":"        return metaMembers"},{"line_number":1846,"context_line":""},{"line_number":1847,"context_line":"    def get_meta_members_capacity_in_byte(self, conn, volumeInstanceNames):"},{"line_number":1848,"context_line":"        \"\"\"Get the capacity in byte of all meta device member volumes."},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"        :param conn: the ecom connection"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_c600dd36","line":1847,"in_reply_to":"fa32b979_2a301107","updated":"2015-06-24 13:33:54.000000000","message":"Done","commit_id":"e914baf58f6d147b793b729d64243836bed57083"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"3ed88ff2881c5d630d3b69752df673c264d8e54c","unresolved":false,"context_lines":[{"line_number":2154,"context_line":"                       \u0027intV\u0027: intVersion})"},{"line_number":2155,"context_line":"        return intVersion"},{"line_number":2156,"context_line":""},{"line_number":2157,"context_line":"    def get_composite_elements("},{"line_number":2158,"context_line":"            self, conn, volumeInstance):"},{"line_number":2159,"context_line":"        \"\"\"Get the meta members of a composite volume."},{"line_number":2160,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_e56c9ad2","line":2157,"updated":"2015-06-19 16:21:28.000000000","message":"unit test coverage?","commit_id":"e914baf58f6d147b793b729d64243836bed57083"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8db475e881ea22f90fa07383cfaa66bf4fb4aa51","unresolved":false,"context_lines":[{"line_number":2154,"context_line":"                       \u0027intV\u0027: intVersion})"},{"line_number":2155,"context_line":"        return intVersion"},{"line_number":2156,"context_line":""},{"line_number":2157,"context_line":"    def get_composite_elements("},{"line_number":2158,"context_line":"            self, conn, volumeInstance):"},{"line_number":2159,"context_line":"        \"\"\"Get the meta members of a composite volume."},{"line_number":2160,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_469b6d18","line":2157,"in_reply_to":"fa32b979_e56c9ad2","updated":"2015-06-24 13:33:54.000000000","message":"Done","commit_id":"e914baf58f6d147b793b729d64243836bed57083"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"71c85bc1b53c4aaa431567f7a7bb19f733789a45","unresolved":false,"context_lines":[{"line_number":1650,"context_line":"            poolNameInStr)"},{"line_number":1651,"context_line":""},{"line_number":1652,"context_line":"    def _get_pool_instance_and_system_name("},{"line_number":1653,"context_line":"            self, conn, poolInstanceNames, storageSystemInstanceName,"},{"line_number":1654,"context_line":"            poolname):"},{"line_number":1655,"context_line":"        \"\"\"Get the pool instance and the system name"},{"line_number":1656,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_85172f44","line":1653,"updated":"2015-07-08 21:47:04.000000000","message":"The name here and the one below don\u0027t match storageSystemInstanceName vs. storageSystemInstanceNames .","commit_id":"a22ff90b191bed65cc961879b9396784b8b0236b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2af5b215daf247cd92de2d959b4bc6fe3f36baf3","unresolved":false,"context_lines":[{"line_number":1650,"context_line":"            poolNameInStr)"},{"line_number":1651,"context_line":""},{"line_number":1652,"context_line":"    def _get_pool_instance_and_system_name("},{"line_number":1653,"context_line":"            self, conn, poolInstanceNames, storageSystemInstanceName,"},{"line_number":1654,"context_line":"            poolname):"},{"line_number":1655,"context_line":"        \"\"\"Get the pool instance and the system name"},{"line_number":1656,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_87db657d","line":1653,"in_reply_to":"ba3cc151_85172f44","updated":"2015-07-10 04:18:44.000000000","message":"Done","commit_id":"a22ff90b191bed65cc961879b9396784b8b0236b"}]}