)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"34406a679a1cfaba37829412f5018cfbbbc86325","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-06-09 11:31:51 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix typos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I11b2d24a55bdeaf4713d770d80422e9463746474"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_370a427a","line":8,"updated":"2015-06-09 07:46:56.000000000","message":"Two suggestions:\n1. Be a bit specific about what kind of typos you are fixing in the second paragraph.\n2. Raise a bug and put the link here for better trace.","commit_id":"ab8422919f9d2a7560b0a546305a5701cb2c96b4"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"5f3d0413756b274486dfd9a6211945c8f85f11a0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-06-09 11:31:51 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix typos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I11b2d24a55bdeaf4713d770d80422e9463746474"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_5d327f60","line":8,"in_reply_to":"3afb71cf_370a427a","updated":"2015-06-09 08:36:45.000000000","message":"hi Vincent, this is just a simple typos fix, not a bug.","commit_id":"ab8422919f9d2a7560b0a546305a5701cb2c96b4"}],"cinder/exception.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"34406a679a1cfaba37829412f5018cfbbbc86325","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"class InvalidUUID(Invalid):"},{"line_number":227,"context_line":"    message \u003d _(\"Expected an uuid but received %(uuid)s.\")"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"class APIException(CinderException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_57bdbeb5","line":227,"updated":"2015-06-09 07:46:56.000000000","message":"I do not agree with this change.\nWe should put the article \"a\" before the word beginning with \"u\".","commit_id":"ab8422919f9d2a7560b0a546305a5701cb2c96b4"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"5f3d0413756b274486dfd9a6211945c8f85f11a0","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"class InvalidUUID(Invalid):"},{"line_number":227,"context_line":"    message \u003d _(\"Expected an uuid but received %(uuid)s.\")"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"class APIException(CinderException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_5a516535","line":227,"in_reply_to":"3afb71cf_57bdbeb5","updated":"2015-06-09 08:36:45.000000000","message":"thanks Vincent, it should be \u0027a\u0027.","commit_id":"ab8422919f9d2a7560b0a546305a5701cb2c96b4"}],"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"2ee0e6ffc361cf5663a5e678e74f3cd9c508fca8","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        return scserver"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def create_server(self, wwnoriscsiname, isfc\u003dFalse):"},{"line_number":601,"context_line":"        \u0027\u0027\u0027creates a server on the storage center self.ssn.  Adds the first"},{"line_number":602,"context_line":"        HBA to it."},{"line_number":603,"context_line":"        \u0027\u0027\u0027"},{"line_number":604,"context_line":"        scserver \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_f4a25d98","line":601,"updated":"2015-06-09 11:35:48.000000000","message":"There is a redundant space before the word \"Adds\".","commit_id":"d983d6bf5a1153e325c5b5a363057ac7a0b6a98a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"af9b73ddeae4da929b9565a15bedd82c48638c98","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        return scserver"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def create_server(self, wwnoriscsiname, isfc\u003dFalse):"},{"line_number":601,"context_line":"        \u0027\u0027\u0027creates a server on the storage center self.ssn.  Adds the first"},{"line_number":602,"context_line":"        HBA to it."},{"line_number":603,"context_line":"        \u0027\u0027\u0027"},{"line_number":604,"context_line":"        scserver \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_d8c2a852","line":601,"updated":"2015-06-10 18:28:49.000000000","message":"s/creates/Creates\n\nAlso, this doesn\u0027t follow PEP8(H405), it would be nice if it was fixed.","commit_id":"d983d6bf5a1153e325c5b5a363057ac7a0b6a98a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4eb979f214bd977f4dbf5845b9ad23396e1f5497","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        return scserver"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def create_server(self, wwnoriscsiname, isfc\u003dFalse):"},{"line_number":601,"context_line":"        \u0027\u0027\u0027creates a server on the storage center self.ssn.  Adds the first"},{"line_number":602,"context_line":"        HBA to it."},{"line_number":603,"context_line":"        \u0027\u0027\u0027"},{"line_number":604,"context_line":"        scserver \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_d56ed8fe","line":601,"in_reply_to":"3afb71cf_aff1d996","updated":"2015-06-11 07:43:42.000000000","message":"Sure you can, that\u0027s why I +1 the patch, because that wasn\u0027t the purpose of this patch. But since you were already modifying this docstring I suggested it. :-)","commit_id":"d983d6bf5a1153e325c5b5a363057ac7a0b6a98a"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"84ca5a4f0e339e399419a3e12c2c340299d08c7d","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        return scserver"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def create_server(self, wwnoriscsiname, isfc\u003dFalse):"},{"line_number":601,"context_line":"        \u0027\u0027\u0027creates a server on the storage center self.ssn.  Adds the first"},{"line_number":602,"context_line":"        HBA to it."},{"line_number":603,"context_line":"        \u0027\u0027\u0027"},{"line_number":604,"context_line":"        scserver \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_b0e3aaa3","line":601,"in_reply_to":"3afb71cf_c962273e","updated":"2015-06-10 01:56:56.000000000","message":"thanks Thang Pham for the explaination.\n\nXingguo, as Thang Pham said, it\u0027s standard to put a double space there.","commit_id":"d983d6bf5a1153e325c5b5a363057ac7a0b6a98a"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"bafe947d14dbd75e0b1b3f05d0ebc0401ce3d389","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        return scserver"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def create_server(self, wwnoriscsiname, isfc\u003dFalse):"},{"line_number":601,"context_line":"        \u0027\u0027\u0027creates a server on the storage center self.ssn.  Adds the first"},{"line_number":602,"context_line":"        HBA to it."},{"line_number":603,"context_line":"        \u0027\u0027\u0027"},{"line_number":604,"context_line":"        scserver \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_aff1d996","line":601,"in_reply_to":"3afb71cf_d8c2a852","updated":"2015-06-10 23:32:12.000000000","message":"thanks Gorka, I find we don\u0027t follow PEP(H405) all through cinder, can I push a separate patch to enable H405 check and fix all issues.","commit_id":"d983d6bf5a1153e325c5b5a363057ac7a0b6a98a"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"0183328d625b549759ee8def0d610d4c799221f3","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        return scserver"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def create_server(self, wwnoriscsiname, isfc\u003dFalse):"},{"line_number":601,"context_line":"        \u0027\u0027\u0027creates a server on the storage center self.ssn.  Adds the first"},{"line_number":602,"context_line":"        HBA to it."},{"line_number":603,"context_line":"        \u0027\u0027\u0027"},{"line_number":604,"context_line":"        scserver \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_c962273e","line":601,"in_reply_to":"3afb71cf_f4a25d98","updated":"2015-06-09 13:22:41.000000000","message":"It is standard to put a double space after every period.","commit_id":"d983d6bf5a1153e325c5b5a363057ac7a0b6a98a"}],"cinder/volume/drivers/emc/emc_vmax_fast.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"af9b73ddeae4da929b9565a15bedd82c48638c98","unresolved":false,"context_lines":[{"line_number":530,"context_line":"                return failedRet"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"            # Check that the storage group has been associated with the"},{"line_number":533,"context_line":"            # tier policy rule."},{"line_number":534,"context_line":"            assocTierPolicyInstanceName \u003d ("},{"line_number":535,"context_line":"                self.get_associated_tier_policy_from_storage_group("},{"line_number":536,"context_line":"                    conn, storageGroupInstanceName))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_d8be28ad","line":533,"updated":"2015-06-10 18:28:49.000000000","message":"Word tier should go now in line above.","commit_id":"d983d6bf5a1153e325c5b5a363057ac7a0b6a98a"}],"cinder/volume/drivers/quobyte.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"af9b73ddeae4da929b9565a15bedd82c48638c98","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    def _load_shares_config(self, share_file\u003dNone):"},{"line_number":295,"context_line":"        \"\"\"Put \u0027quobyte_volume_url\u0027 into the \u0027shares\u0027 list."},{"line_number":296,"context_line":"        :param share_file: string, Not used because the user has to specify"},{"line_number":297,"context_line":"                                   the Quobyte volume directly."},{"line_number":298,"context_line":"        \"\"\""},{"line_number":299,"context_line":"        self.shares \u003d {}"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_d843c8ad","line":297,"updated":"2015-06-10 18:28:49.000000000","message":"Should have removed the second \"the\" instead of the first one, as this the should now go in above line.","commit_id":"d983d6bf5a1153e325c5b5a363057ac7a0b6a98a"}],"cinder/volume/targets/tgt.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"701d690b5de1c9066f113fce40cb4f86822cb191","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        # if it wasn\u0027t, try again without the force."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        # This will NOT do any good for the case of multiple sessions"},{"line_number":330,"context_line":"        # which the force was aded for but it will however address"},{"line_number":331,"context_line":"        # the cases pointed out in bug:"},{"line_number":332,"context_line":"        #    https://bugs.launchpad.net/cinder/+bug/1304122"},{"line_number":333,"context_line":"        if self._get_target(iqn):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_fd3272f1","line":330,"updated":"2015-06-17 11:21:59.000000000","message":"aded?","commit_id":"d983d6bf5a1153e325c5b5a363057ac7a0b6a98a"}]}
