)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"2a6025b5f61b2190f154c0a693794082fe7f094c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Get urllib and urllib2 from six.moves"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Get urllib and urllib2 modules from six.moves to make cinder code compatible"},{"line_number":10,"context_line":"with Python 2 and Python 3."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch was generated by the urllib operation of the sixer tool version 0.4:"},{"line_number":13,"context_line":"https://pypi.python.org/pypi/sixer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_f1cc688a","line":10,"updated":"2015-06-10 15:31:27.000000000","message":"From what I can see the above statement doesn\u0027t really make sense.  For the most part all this seems to be doing is changing the import to pull in the whole parent module and modify the calls?\n\nThat\u0027s really all I see.. am I missing something?\n\nFrankly I don\u0027t care, but the commit message should be accurate, internally from what I can see the code path is going to end up being exactly the same... or is there something I\u0027m missing here?","commit_id":"d03cf89c732ac4a15cce3e208865fccc2cbdc95d"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a43fcbb8adacbc2422b8555a9815d6c6cf4c6e57","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Get urllib and urllib2 from six.moves"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Get urllib and urllib2 modules from six.moves to make cinder code compatible"},{"line_number":10,"context_line":"with Python 2 and Python 3."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch was generated by the urllib operation of the sixer tool version 0.4:"},{"line_number":13,"context_line":"https://pypi.python.org/pypi/sixer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_e866b9eb","line":10,"in_reply_to":"3afb71cf_f1cc688a","updated":"2015-06-10 16:55:15.000000000","message":"\u003e For the most part all this seems to be doing is changing the import to pull in the whole parent module and modify the calls?\n\nThere are two different changes:\n\n* replace urllib and urllib2 with six.moves.urllib\n* replace six.moves.urlib.parse (imported as \"urlparse\") with six.moves.urllib\n\nI rewrote the commit message to explain better what it does.","commit_id":"d03cf89c732ac4a15cce3e208865fccc2cbdc95d"}],"cinder/api/common.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"2a6025b5f61b2190f154c0a693794082fe7f094c","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from six.moves import urllib"},{"line_number":23,"context_line":"import webob"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinder.api.openstack import wsgi"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_8eb995ce","line":22,"updated":"2015-06-10 15:31:27.000000000","message":"Other than fixing the crappy syntax we had on the import... What\u0027s the actual difference here?  I mean... in the end it\u0027s just different import naming but in the end it\u0027s the exact same call?","commit_id":"d03cf89c732ac4a15cce3e208865fccc2cbdc95d"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a43fcbb8adacbc2422b8555a9815d6c6cf4c6e57","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from six.moves import urllib"},{"line_number":23,"context_line":"import webob"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinder.api.openstack import wsgi"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_1d9b9567","line":22,"in_reply_to":"3afb71cf_8eb995ce","updated":"2015-06-10 16:55:15.000000000","message":"It doesn\u0027t change anything, after the change, you call exactly the same functions. It\u0027s just a different naming: urllib.parse.symbol versus urlparse.symbol.\n\nI don\u0027t have a strong opinion on which naming is better. This change was generated by my dummy tool. At least, you get the same syntax in all source code files.","commit_id":"d03cf89c732ac4a15cce3e208865fccc2cbdc95d"}],"cinder/openstack/common/policy.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"2a6025b5f61b2190f154c0a693794082fe7f094c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"from oslo_serialization import jsonutils"},{"line_number":100,"context_line":"import six"},{"line_number":101,"context_line":"from six.moves import urllib"},{"line_number":102,"context_line":"import six.moves.urllib.parse as urlparse"},{"line_number":103,"context_line":"import six.moves.urllib.request as urlrequest"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"from cinder.openstack.common import fileutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_ae71f10d","line":102,"updated":"2015-06-10 15:31:27.000000000","message":"The \"import six.moves.urllib.parse as urlparse\" can go away now no?","commit_id":"d03cf89c732ac4a15cce3e208865fccc2cbdc95d"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a43fcbb8adacbc2422b8555a9815d6c6cf4c6e57","unresolved":false,"context_lines":[{"line_number":99,"context_line":"from oslo_serialization import jsonutils"},{"line_number":100,"context_line":"import six"},{"line_number":101,"context_line":"from six.moves import urllib"},{"line_number":102,"context_line":"import six.moves.urllib.parse as urlparse"},{"line_number":103,"context_line":"import six.moves.urllib.request as urlrequest"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"from cinder.openstack.common import fileutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_fdfb1977","line":102,"in_reply_to":"3afb71cf_ae71f10d","updated":"2015-06-10 16:55:15.000000000","message":"Ah, it\u0027s strange that tox -e pep8 doesn\u0027t complain that the import is not used.\n\nI removed it in the next patch set.","commit_id":"d03cf89c732ac4a15cce3e208865fccc2cbdc95d"}]}