)]}'
{"cinder/cmd/rtstool.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a417ec03274dd7ec6a1a5ed7b044bfa7d561548a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    import rtslib_fb"},{"line_number":24,"context_line":"except ImportError:"},{"line_number":25,"context_line":"    import rtslib as rtslib_fb"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from cinder import i18n"},{"line_number":29,"context_line":"from cinder.i18n import _"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_c03dffc4","line":26,"updated":"2015-06-11 02:35:57.000000000","message":"This change could be made much smaller by not changing rtslib to rtslib_fb ?  Could you just leave this check and import rtslib_fb as rtslib ?  I think that would make more sense.","commit_id":"6532be7eda2c7eec2984d51f06f0c69311b7b572"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d8f2195238d734fa5b780ecf7e82481d1c1c7084","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    import rtslib_fb"},{"line_number":24,"context_line":"except ImportError:"},{"line_number":25,"context_line":"    import rtslib as rtslib_fb"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from cinder import i18n"},{"line_number":29,"context_line":"from cinder.i18n import _"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_122ebbfa","line":26,"in_reply_to":"3afb71cf_c03dffc4","updated":"2015-06-11 12:01:10.000000000","message":"While it may make the patch smaller in this file (the test would still need all the changes) I considered it, mainly because it was easier, and I decided against it because future wise it made less sense to me.\n\nWhen in the future we change min required version, we\u0027ll remove the try...except and then we\u0027ll end up with an import renaming that won\u0027t make that much sense anymore (why rename rtslib_fb to rtslib instead of leaving with its original namespace?), or we\u0027ll have to change the code as I\u0027m changing it here.","commit_id":"6532be7eda2c7eec2984d51f06f0c69311b7b572"}]}