)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"beebc4602ed5a54e716dfa24c1844689ca99d907","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dmitry Guryanov \u003cdguryanov@parallels.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-10 23:03:17 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"smbfs: fix invalid check for smbfs_user_ratio correctness"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I34f4128a8a80ae57be5c0af90308d2d517022d8e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_9804097f","line":7,"updated":"2015-06-15 09:17:39.000000000","message":"It would be better: Fix the invalid check for smbfs_used_ratio in SMBFS based cinder volume driver.","commit_id":"2d79e97e1cb017e465054cda375bf6301ea48fd7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"75c24a619d496322c63c602cb26ebc37a44d5db0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dmitry Guryanov \u003cdguryanov@parallels.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-26 20:17:24 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"smbfs: fix invalid check for smbfs_used_ratio correctness"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1469249"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_8bd03555","line":7,"updated":"2015-06-29 18:31:48.000000000","message":"You should at least include a brief description.  Since bug report is a oneliner you could add that.","commit_id":"17a33fc4a486ff9891c4cc0577c69bb3569e893f"}],"cinder/tests/unit/test_smbfs.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"6b6b225aa3299066d36030b2c371d044cd472eb2","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        fake_config.smbfs_used_ratio \u003d -1"},{"line_number":133,"context_line":"        self._test_setup(config\u003dfake_config)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_setup_invalid_used_ratio2(self):"},{"line_number":136,"context_line":"        fake_config \u003d copy.copy(self._FAKE_SMBFS_CONFIG)"},{"line_number":137,"context_line":"        fake_config.smbfs_used_ratio \u003d 1.1"},{"line_number":138,"context_line":"        self._test_setup(config\u003dfake_config)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_bef10e6d","line":135,"updated":"2015-07-02 16:15:26.000000000","message":"Please, make more user friendly test name if you\u0027ll make one more patch","commit_id":"d79b2a2589ffb21e80e29eb909a021d4f1700374"},{"author":{"_account_id":12661,"name":"Dmitry Guryanov","email":"dmitry.guryanov@gmail.com","username":"dguryanov"},"change_message_id":"b0c802bc0544ccff545be97cbc13cad25b1372cd","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        fake_config.smbfs_used_ratio \u003d -1"},{"line_number":133,"context_line":"        self._test_setup(config\u003dfake_config)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_setup_invalid_used_ratio2(self):"},{"line_number":136,"context_line":"        fake_config \u003d copy.copy(self._FAKE_SMBFS_CONFIG)"},{"line_number":137,"context_line":"        fake_config.smbfs_used_ratio \u003d 1.1"},{"line_number":138,"context_line":"        self._test_setup(config\u003dfake_config)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_3ae987b7","line":135,"in_reply_to":"ba3cc151_bef10e6d","updated":"2015-07-02 16:58:16.000000000","message":"Ok, sorry for this name.","commit_id":"d79b2a2589ffb21e80e29eb909a021d4f1700374"}],"cinder/volume/drivers/smbfs.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"75c24a619d496322c63c602cb26ebc37a44d5db0","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            LOG.error(msg)"},{"line_number":157,"context_line":"            raise exception.SmbfsException(msg)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        if not ((self.configuration.smbfs_used_ratio \u003e 0) and"},{"line_number":160,"context_line":"                (self.configuration.smbfs_used_ratio \u003c\u003d 1)):"},{"line_number":161,"context_line":"            msg \u003d _(\"SMBFS config \u0027smbfs_used_ratio\u0027 invalid.  Must be \u003e 0 \""},{"line_number":162,"context_line":"                    \"and \u003c\u003d 1.0: %s\") % self.configuration.smbfs_used_ratio"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_0b21854d","line":159,"updated":"2015-06-29 18:31:48.000000000","message":"Why not change this to something more readable while you are making the change?\n\n if not 0 \u003c self.configuration.smbfs_used_ratio \u003c\u003d 1:","commit_id":"17a33fc4a486ff9891c4cc0577c69bb3569e893f"}]}