)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"0c7e8952182ac35b5be53feefe7cc03a5249e2ff","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        # collect and publish service capabilities"},{"line_number":380,"context_line":"        self.publish_service_capabilities(ctxt)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        # conditionally run replication status task"},{"line_number":383,"context_line":"        stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)"},{"line_number":384,"context_line":"        if stats:"},{"line_number":385,"context_line":"            # Append filter and goodness function if needed"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_7e5db147","line":382,"updated":"2015-06-11 17:22:52.000000000","message":"You may want to update this comment as it\u0027s doing more then running the replication stauts task now","commit_id":"8410fd09c199adae10804a8bed3a56d6cfc52598"},{"author":{"_account_id":13868,"name":"Danny Wilson","email":"daniel.wilson@purestorage.com","username":"dannywilson"},"change_message_id":"7a5ad4ce7a96e8dd2ec53c841e2360d1b66acb3a","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        # collect and publish service capabilities"},{"line_number":380,"context_line":"        self.publish_service_capabilities(ctxt)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        # conditionally run replication status task"},{"line_number":383,"context_line":"        stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)"},{"line_number":384,"context_line":"        if stats:"},{"line_number":385,"context_line":"            # Append filter and goodness function if needed"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_ca4967d2","line":382,"in_reply_to":"3afb71cf_7e5db147","updated":"2015-06-12 16:02:11.000000000","message":"Reverted this section of code.","commit_id":"8410fd09c199adae10804a8bed3a56d6cfc52598"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"9469a2320bbba88d4f5a5494ce884486cabfa7df","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)"},{"line_number":384,"context_line":"        if stats:"},{"line_number":385,"context_line":"            # Append filter and goodness function if needed"},{"line_number":386,"context_line":"            stats \u003d self._append_filter_goodness_functions(stats)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"            if stats.get(\u0027replication\u0027, False):"},{"line_number":389,"context_line":"                @periodic_task.periodic_task"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_0f4d6872","line":386,"updated":"2015-06-12 02:49:10.000000000","message":"No need to do this here because self.publish_service_capabilities() has already done that in _report_service_capabilities().","commit_id":"8410fd09c199adae10804a8bed3a56d6cfc52598"},{"author":{"_account_id":13868,"name":"Danny Wilson","email":"daniel.wilson@purestorage.com","username":"dannywilson"},"change_message_id":"7a5ad4ce7a96e8dd2ec53c841e2360d1b66acb3a","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)"},{"line_number":384,"context_line":"        if stats:"},{"line_number":385,"context_line":"            # Append filter and goodness function if needed"},{"line_number":386,"context_line":"            stats \u003d self._append_filter_goodness_functions(stats)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"            if stats.get(\u0027replication\u0027, False):"},{"line_number":389,"context_line":"                @periodic_task.periodic_task"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_2a035b75","line":386,"in_reply_to":"1af86dd1_0f4d6872","updated":"2015-06-12 16:02:11.000000000","message":"Removed this code and reverted this section of code.","commit_id":"8410fd09c199adae10804a8bed3a56d6cfc52598"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"28a5736a810ba1cff4aee744fb7a754c7698f81b","unresolved":false,"context_lines":[{"line_number":1502,"context_line":"                pool.update(pool_stats)"},{"line_number":1503,"context_line":""},{"line_number":1504,"context_line":"    def _append_filter_goodness_functions(self, volume_stats):"},{"line_number":1505,"context_line":"        # Returns volume_stats updated as needed"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"        # Append filter_function if needed"},{"line_number":1508,"context_line":"        if \u0027filter_function\u0027 not in volume_stats:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_59ca0f70","line":1505,"updated":"2015-06-11 16:02:09.000000000","message":"This line should be replaced by a docstring.","commit_id":"8410fd09c199adae10804a8bed3a56d6cfc52598"},{"author":{"_account_id":13868,"name":"Danny Wilson","email":"daniel.wilson@purestorage.com","username":"dannywilson"},"change_message_id":"7a5ad4ce7a96e8dd2ec53c841e2360d1b66acb3a","unresolved":false,"context_lines":[{"line_number":1502,"context_line":"                pool.update(pool_stats)"},{"line_number":1503,"context_line":""},{"line_number":1504,"context_line":"    def _append_filter_goodness_functions(self, volume_stats):"},{"line_number":1505,"context_line":"        # Returns volume_stats updated as needed"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"        # Append filter_function if needed"},{"line_number":1508,"context_line":"        if \u0027filter_function\u0027 not in volume_stats:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_ea230304","line":1505,"in_reply_to":"3afb71cf_59ca0f70","updated":"2015-06-12 16:02:11.000000000","message":"Done","commit_id":"8410fd09c199adae10804a8bed3a56d6cfc52598"}]}