)]}'
{"cinder/tests/unit/conf_fixture.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"fc11b0270b8261bcbdb9e64bea2560bcb3c71718","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d cfg.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF.import_opt(\u0027backup_enable_progress_timer\u0027,"},{"line_number":25,"context_line":"                \u0027cinder.backup.drivers.nfs\u0027)"},{"line_number":26,"context_line":"CONF.import_opt(\u0027backup_swift_enable_progress_timer\u0027,"},{"line_number":27,"context_line":"                \u0027cinder.backup.drivers.swift\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_1f74719a","line":24,"updated":"2015-06-14 11:14:01.000000000","message":"How this is related to Python 3?","commit_id":"26965064fa1912823af5b4b71745605b24565c02"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"6a92d40cc7ab2aa1de51170fd657c45d72f66add","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d cfg.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF.import_opt(\u0027backup_enable_progress_timer\u0027,"},{"line_number":25,"context_line":"                \u0027cinder.backup.drivers.nfs\u0027)"},{"line_number":26,"context_line":"CONF.import_opt(\u0027backup_swift_enable_progress_timer\u0027,"},{"line_number":27,"context_line":"                \u0027cinder.backup.drivers.swift\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_122698ce","line":24,"in_reply_to":"fa32b979_1f74719a","updated":"2015-06-15 08:34:11.000000000","message":"Ah. The relation is not obvious :-)\n\nRight now, I cannot use testr to run tests because testr has to load all tests, whereas loading tests still cause various Python 3 issues. I\u0027m using testtools to run tests. testtools doesn\u0027t load all tests, and so cinder.backup.drivers.nfs and cinder.backup.drivers.swift are not imported. As a result, this fixture fail because the configuration options are unknown.\n\nI plan to modify tox.ini to add py34 venv which will use testtools to run a subset of tests, so testtools should work to run tests. (see the blueprint for the whole plan)\n\nI explained that shortly in the commit message.","commit_id":"26965064fa1912823af5b4b71745605b24565c02"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ef7b89935614130ebf47efed47dc227912aba65a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d cfg.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF.import_opt(\u0027backup_enable_progress_timer\u0027,"},{"line_number":25,"context_line":"                \u0027cinder.backup.drivers.nfs\u0027)"},{"line_number":26,"context_line":"CONF.import_opt(\u0027backup_swift_enable_progress_timer\u0027,"},{"line_number":27,"context_line":"                \u0027cinder.backup.drivers.swift\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_675919fe","line":24,"updated":"2015-06-16 14:42:38.000000000","message":"Not technically related to Python 3, as this is broken in Python 2 as well... but we need this fix anyway.","commit_id":"d9b9ac893dd0e55676c6c2455236005dc352f2e0"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"1dd1d4cf5105c99f7ad14caee034a8f95c596682","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d cfg.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF.import_opt(\u0027backup_enable_progress_timer\u0027,"},{"line_number":25,"context_line":"                \u0027cinder.backup.drivers.nfs\u0027)"},{"line_number":26,"context_line":"CONF.import_opt(\u0027backup_swift_enable_progress_timer\u0027,"},{"line_number":27,"context_line":"                \u0027cinder.backup.drivers.swift\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_8790da44","line":24,"in_reply_to":"fa32b979_675919fe","updated":"2015-06-16 15:38:19.000000000","message":"Someone already asked me how this change is related to Python 3. I explained it in the commit message. The reason is that testr hides the issue, I hit the issue on Python 3.4 because I execute tests using testtools.run.","commit_id":"d9b9ac893dd0e55676c6c2455236005dc352f2e0"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"40784064937b2f777c252612e5679a41fbc58bc4","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d cfg.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF.import_opt(\u0027backup_enable_progress_timer\u0027,"},{"line_number":25,"context_line":"                \u0027cinder.backup.drivers.nfs\u0027)"},{"line_number":26,"context_line":"CONF.import_opt(\u0027backup_swift_enable_progress_timer\u0027,"},{"line_number":27,"context_line":"                \u0027cinder.backup.drivers.swift\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_2b367452","line":24,"in_reply_to":"fa32b979_8790da44","updated":"2015-06-16 18:05:54.000000000","message":"Sure.  But I hit it on Python 2 in my test environment too.  Bug 1461832 has other reports.","commit_id":"d9b9ac893dd0e55676c6c2455236005dc352f2e0"}],"cinder/utils.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"fc11b0270b8261bcbdb9e64bea2560bcb3c71718","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        hostname \u003d hostname.decode(\u0027latin-1\u0027)"},{"line_number":464,"context_line":"    hostname \u003d hostname.encode(\u0027latin-1\u0027, \u0027ignore\u0027)"},{"line_number":465,"context_line":"    if six.PY3:"},{"line_number":466,"context_line":"        hostname \u003d hostname.decode(\u0027latin-1\u0027)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    hostname \u003d re.sub(\u0027[ _]\u0027, \u0027-\u0027, hostname)"},{"line_number":469,"context_line":"    hostname \u003d re.sub(\u0027[^\\w.-]+\u0027, \u0027\u0027, hostname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_1f4d5172","line":466,"updated":"2015-06-14 11:14:01.000000000","message":"Can we change this code to encode only if six.PY3 is false?","commit_id":"26965064fa1912823af5b4b71745605b24565c02"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"6a92d40cc7ab2aa1de51170fd657c45d72f66add","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        hostname \u003d hostname.decode(\u0027latin-1\u0027)"},{"line_number":464,"context_line":"    hostname \u003d hostname.encode(\u0027latin-1\u0027, \u0027ignore\u0027)"},{"line_number":465,"context_line":"    if six.PY3:"},{"line_number":466,"context_line":"        hostname \u003d hostname.decode(\u0027latin-1\u0027)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    hostname \u003d re.sub(\u0027[ _]\u0027, \u0027-\u0027, hostname)"},{"line_number":469,"context_line":"    hostname \u003d re.sub(\u0027[^\\w.-]+\u0027, \u0027\u0027, hostname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_edbb150d","line":466,"in_reply_to":"fa32b979_1f4d5172","updated":"2015-06-15 08:34:11.000000000","message":"I changed the code to don\u0027t change the behaviour of Python 2.","commit_id":"26965064fa1912823af5b4b71745605b24565c02"}]}