)]}'
{"cinder/tests/unit/targets/targets_fixture.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"becd720baa85e489c44636925503df2a693fe449","unresolved":false,"context_lines":[{"line_number":91,"context_line":"             \u0027target_portal\u0027: \u002710.10.7.1:3260\u0027,"},{"line_number":92,"context_line":"             \u0027volume_id\u0027: self.fake_volume_id}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.VOLUME_ID \u003d \u002783c2e877-feed-46be-8435-77884fe55b45\u0027"},{"line_number":95,"context_line":"        self.volume_name \u003d \u0027volume-\u0027 + self.VOLUME_ID"},{"line_number":96,"context_line":"        self.test_vol \u003d (self.iscsi_target_prefix +"},{"line_number":97,"context_line":"                         self.volume_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_7e656a43","line":94,"updated":"2015-06-15 11:25:08.000000000","message":"I think if this attribute is in capital letters so should be lines 36 to 39, 41, 43, 58, 59, etc.","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc77795ca98837a414586be6de29740057af1a3c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"             \u0027target_portal\u0027: \u002710.10.7.1:3260\u0027,"},{"line_number":92,"context_line":"             \u0027volume_id\u0027: self.fake_volume_id}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.VOLUME_ID \u003d \u002783c2e877-feed-46be-8435-77884fe55b45\u0027"},{"line_number":95,"context_line":"        self.volume_name \u003d \u0027volume-\u0027 + self.VOLUME_ID"},{"line_number":96,"context_line":"        self.test_vol \u003d (self.iscsi_target_prefix +"},{"line_number":97,"context_line":"                         self.volume_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_0c742633","line":94,"in_reply_to":"fa32b979_7e656a43","updated":"2015-06-15 16:59:13.000000000","message":"I agree, but that\u0027s probably for a follow-up patch (depending on how big this one gets, but I\u0027d like to limit the scope somewhat).","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"becd720baa85e489c44636925503df2a693fe449","unresolved":false,"context_lines":[{"line_number":92,"context_line":"             \u0027volume_id\u0027: self.fake_volume_id}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.VOLUME_ID \u003d \u002783c2e877-feed-46be-8435-77884fe55b45\u0027"},{"line_number":95,"context_line":"        self.volume_name \u003d \u0027volume-\u0027 + self.VOLUME_ID"},{"line_number":96,"context_line":"        self.test_vol \u003d (self.iscsi_target_prefix +"},{"line_number":97,"context_line":"                         self.volume_name)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_3ed602c6","line":95,"updated":"2015-06-15 11:25:08.000000000","message":"Why is VOLUME_ID but not VOLUME_NAME?","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc77795ca98837a414586be6de29740057af1a3c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"             \u0027volume_id\u0027: self.fake_volume_id}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.VOLUME_ID \u003d \u002783c2e877-feed-46be-8435-77884fe55b45\u0027"},{"line_number":95,"context_line":"        self.volume_name \u003d \u0027volume-\u0027 + self.VOLUME_ID"},{"line_number":96,"context_line":"        self.test_vol \u003d (self.iscsi_target_prefix +"},{"line_number":97,"context_line":"                         self.volume_name)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_6c99326e","line":95,"in_reply_to":"fa32b979_3ed602c6","updated":"2015-06-15 16:59:13.000000000","message":"Yeah, should be VOLUME_NAME... was just leaving it how it was before to avoid changing quite as much.  Will update this I suppose.","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"}],"cinder/tests/unit/targets/test_tgt_driver.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"becd720baa85e489c44636925503df2a693fe449","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.target \u003d tgt.TgtAdm(root_helper\u003dutils.get_root_helper(),"},{"line_number":32,"context_line":"                                 configuration\u003dself.configuration)"},{"line_number":33,"context_line":"        self.testvol_path \u003d \\"},{"line_number":34,"context_line":"            \u0027/dev/stack-volumes-lvmdriver-1/volume-%s\u0027 % self.VOLUME_ID"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.fake_iscsi_scan \u003d\\"},{"line_number":37,"context_line":"            (\u0027Target 1: iqn.2010-10.org.openstack:volume-%(id)s\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_1eb69e8a","line":34,"updated":"2015-06-15 11:25:08.000000000","message":"Should replace volume-%s with %s and use self.volume_name","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc77795ca98837a414586be6de29740057af1a3c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.target \u003d tgt.TgtAdm(root_helper\u003dutils.get_root_helper(),"},{"line_number":32,"context_line":"                                 configuration\u003dself.configuration)"},{"line_number":33,"context_line":"        self.testvol_path \u003d \\"},{"line_number":34,"context_line":"            \u0027/dev/stack-volumes-lvmdriver-1/volume-%s\u0027 % self.VOLUME_ID"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.fake_iscsi_scan \u003d\\"},{"line_number":37,"context_line":"            (\u0027Target 1: iqn.2010-10.org.openstack:volume-%(id)s\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_0cf0a68f","line":34,"in_reply_to":"fa32b979_1eb69e8a","updated":"2015-06-15 16:59:13.000000000","message":"Done","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"becd720baa85e489c44636925503df2a693fe449","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            \u0027/dev/stack-volumes-lvmdriver-1/volume-%s\u0027 % self.VOLUME_ID"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.fake_iscsi_scan \u003d\\"},{"line_number":37,"context_line":"            (\u0027Target 1: iqn.2010-10.org.openstack:volume-%(id)s\\n\u0027"},{"line_number":38,"context_line":"             \u0027    System information:\\n\u0027"},{"line_number":39,"context_line":"             \u0027        Driver: iscsi\\n\u0027"},{"line_number":40,"context_line":"             \u0027        State: ready\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_b91d4c68","line":37,"updated":"2015-06-15 11:25:08.000000000","message":"This should be\n\n (\u0027Target 1: %(test_vol)s\\n\u0027\n\nAnd then use for the argument\n\n self.test_vol","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"3a889385cd874c13422c274240fff7f61216869a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"             \u0027            SWP: No\\n\u0027"},{"line_number":67,"context_line":"             \u0027            Thin-provisioning: No\\n\u0027"},{"line_number":68,"context_line":"             \u0027            Backing store type: rdwr\\n\u0027"},{"line_number":69,"context_line":"             \u0027            Backing store path: /dev/stack-volumes-lvmdriver-1/volume-%(id)s\\n\u0027  # noqa"},{"line_number":70,"context_line":"             \u0027            Backing store flags:\\n\u0027"},{"line_number":71,"context_line":"             \u0027    Account information:\\n\u0027"},{"line_number":72,"context_line":"             \u0027        mDVpzk8cZesdahJC9h73\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_0a2bcd31","line":69,"updated":"2015-06-14 14:16:49.000000000","message":"You can use self.testvol_path for Backing store path here.","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc77795ca98837a414586be6de29740057af1a3c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"             \u0027            SWP: No\\n\u0027"},{"line_number":67,"context_line":"             \u0027            Thin-provisioning: No\\n\u0027"},{"line_number":68,"context_line":"             \u0027            Backing store type: rdwr\\n\u0027"},{"line_number":69,"context_line":"             \u0027            Backing store path: /dev/stack-volumes-lvmdriver-1/volume-%(id)s\\n\u0027  # noqa"},{"line_number":70,"context_line":"             \u0027            Backing store flags:\\n\u0027"},{"line_number":71,"context_line":"             \u0027    Account information:\\n\u0027"},{"line_number":72,"context_line":"             \u0027        mDVpzk8cZesdahJC9h73\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_6c9ff203","line":69,"in_reply_to":"fa32b979_0a2bcd31","updated":"2015-06-15 16:59:13.000000000","message":"Done","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"becd720baa85e489c44636925503df2a693fe449","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def test_get_target(self):"},{"line_number":80,"context_line":"        with mock.patch(\u0027cinder.utils.execute\u0027,"},{"line_number":81,"context_line":"                        return_value\u003d(self.fake_iscsi_scan, None)):"},{"line_number":82,"context_line":"            iqn \u003d \u0027iqn.2010-10.org.openstack:\u0027 + self.volume_name"},{"line_number":83,"context_line":"            self.assertEqual(\u00271\u0027, self.target._get_target(iqn))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_verify_backing_lun(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_5973e0b1","line":82,"updated":"2015-06-15 11:25:08.000000000","message":"iqn \u003d self.test_volume","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc77795ca98837a414586be6de29740057af1a3c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def test_get_target(self):"},{"line_number":80,"context_line":"        with mock.patch(\u0027cinder.utils.execute\u0027,"},{"line_number":81,"context_line":"                        return_value\u003d(self.fake_iscsi_scan, None)):"},{"line_number":82,"context_line":"            iqn \u003d \u0027iqn.2010-10.org.openstack:\u0027 + self.volume_name"},{"line_number":83,"context_line":"            self.assertEqual(\u00271\u0027, self.target._get_target(iqn))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_verify_backing_lun(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_acee5a89","line":82,"in_reply_to":"fa32b979_5973e0b1","updated":"2015-06-15 16:59:13.000000000","message":"Done","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"becd720baa85e489c44636925503df2a693fe449","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            self.assertEqual(\u00271\u0027, self.target._get_target(iqn))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_verify_backing_lun(self):"},{"line_number":86,"context_line":"        iqn \u003d \u0027iqn.2010-10.org.openstack:\u0027 + self.volume_name"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        with mock.patch(\u0027cinder.utils.execute\u0027,"},{"line_number":89,"context_line":"                        return_value\u003d(self.fake_iscsi_scan, None)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_79826454","line":86,"updated":"2015-06-15 11:25:08.000000000","message":"iqn \u003d self.test_vol","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc77795ca98837a414586be6de29740057af1a3c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            self.assertEqual(\u00271\u0027, self.target._get_target(iqn))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_verify_backing_lun(self):"},{"line_number":86,"context_line":"        iqn \u003d \u0027iqn.2010-10.org.openstack:\u0027 + self.volume_name"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        with mock.patch(\u0027cinder.utils.execute\u0027,"},{"line_number":89,"context_line":"                        return_value\u003d(self.fake_iscsi_scan, None)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_cc9abe14","line":86,"in_reply_to":"fa32b979_79826454","updated":"2015-06-15 16:59:13.000000000","message":"Done","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"becd720baa85e489c44636925503df2a693fe449","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                            \u0027--mode\u0027, \u0027logicalunit\u0027, \u0027--tid\u0027, \u00271\u0027,"},{"line_number":109,"context_line":"                            \u0027--lun\u0027, \u00271\u0027, \u0027-b\u0027,"},{"line_number":110,"context_line":"                            \u0027/dev/stack-volumes-lvmdriver-1/\u0027"},{"line_number":111,"context_line":"                            \u0027volume-\u0027 + self.VOLUME_ID)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        mock_execute.assert_called_once_with(*expected_command,"},{"line_number":114,"context_line":"                                             run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_79e9041a","line":111,"updated":"2015-06-15 11:25:08.000000000","message":"Replace lines 110 and 111 with self.tesvol_path","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc77795ca98837a414586be6de29740057af1a3c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                            \u0027--mode\u0027, \u0027logicalunit\u0027, \u0027--tid\u0027, \u00271\u0027,"},{"line_number":109,"context_line":"                            \u0027--lun\u0027, \u00271\u0027, \u0027-b\u0027,"},{"line_number":110,"context_line":"                            \u0027/dev/stack-volumes-lvmdriver-1/\u0027"},{"line_number":111,"context_line":"                            \u0027volume-\u0027 + self.VOLUME_ID)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        mock_execute.assert_called_once_with(*expected_command,"},{"line_number":114,"context_line":"                                             run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_4c878eb5","line":111,"in_reply_to":"fa32b979_79e9041a","updated":"2015-06-15 16:59:13.000000000","message":"Done","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"3a889385cd874c13422c274240fff7f61216869a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            \u0027\u003c/target\u003e\u0027 % {\u0027id\u0027: self.VOLUME_ID}"},{"line_number":147,"context_line":"        with open(os.path.join(self.fake_volumes_dir,"},{"line_number":148,"context_line":"                               self.test_vol.split(\u0027:\u0027)[1]),"},{"line_number":149,"context_line":"                  \u0027wb\u0027) as tmp_file:"},{"line_number":150,"context_line":"            tmp_file.write(persist_file)"},{"line_number":151,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":152,"context_line":"        expected \u003d (\u0027otzL\u0027, \u0027234Z\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_ca1de510","line":149,"updated":"2015-06-14 14:16:49.000000000","message":"You can use self.testvol_path for backing-store here too.","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc77795ca98837a414586be6de29740057af1a3c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            \u0027\u003c/target\u003e\u0027 % {\u0027id\u0027: self.VOLUME_ID}"},{"line_number":147,"context_line":"        with open(os.path.join(self.fake_volumes_dir,"},{"line_number":148,"context_line":"                               self.test_vol.split(\u0027:\u0027)[1]),"},{"line_number":149,"context_line":"                  \u0027wb\u0027) as tmp_file:"},{"line_number":150,"context_line":"            tmp_file.write(persist_file)"},{"line_number":151,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":152,"context_line":"        expected \u003d (\u0027otzL\u0027, \u0027234Z\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_2cb1ea8f","line":149,"in_reply_to":"fa32b979_ca1de510","updated":"2015-06-15 16:59:13.000000000","message":"Done","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"becd720baa85e489c44636925503df2a693fe449","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        mock_exec.side_effect \u003d _fake_execute"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        test_vol_id \u003d self.VOLUME_ID"},{"line_number":235,"context_line":"        test_vol_name \u003d \u0027volume-\u0027 + self.VOLUME_ID"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        with mock.patch.object(self.target, \u0027_get_target\u0027, return_value\u003dFalse):"},{"line_number":238,"context_line":"            self.assertEqual("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_993c0895","line":235,"updated":"2015-06-15 11:25:08.000000000","message":"test_vol_name \u003d self.volume_name","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc77795ca98837a414586be6de29740057af1a3c","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        mock_exec.side_effect \u003d _fake_execute"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        test_vol_id \u003d self.VOLUME_ID"},{"line_number":235,"context_line":"        test_vol_name \u003d \u0027volume-\u0027 + self.VOLUME_ID"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        with mock.patch.object(self.target, \u0027_get_target\u0027, return_value\u003dFalse):"},{"line_number":238,"context_line":"            self.assertEqual("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_ac4ada81","line":235,"in_reply_to":"fa32b979_993c0895","updated":"2015-06-15 16:59:13.000000000","message":"Done","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"becd720baa85e489c44636925503df2a693fe449","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        mock_exec.side_effect \u003d _fake_execute"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        test_vol_id \u003d self.VOLUME_ID"},{"line_number":280,"context_line":"        test_vol_name \u003d \u0027volume-\u0027 + self.VOLUME_ID"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        with mock.patch.object(self.target, \u0027_get_target\u0027, return_value\u003dFalse):"},{"line_number":283,"context_line":"            self.assertEqual("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_9963a8b1","line":280,"updated":"2015-06-15 11:25:08.000000000","message":"test_vol_name \u003d self.volume_name","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc77795ca98837a414586be6de29740057af1a3c","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        mock_exec.side_effect \u003d _fake_execute"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        test_vol_id \u003d self.VOLUME_ID"},{"line_number":280,"context_line":"        test_vol_name \u003d \u0027volume-\u0027 + self.VOLUME_ID"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        with mock.patch.object(self.target, \u0027_get_target\u0027, return_value\u003dFalse):"},{"line_number":283,"context_line":"            self.assertEqual("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_2c5faa42","line":280,"in_reply_to":"fa32b979_9963a8b1","updated":"2015-06-15 16:59:13.000000000","message":"Done","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"becd720baa85e489c44636925503df2a693fe449","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                                                       self.testvol,"},{"line_number":371,"context_line":"                                                       self.fake_volumes_dir))"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"            m_chap.side_effect \u003d lambda x, y: (\u0027otzL\u0027, \u0027234Z\u0027)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"            expected_result[\u0027auth\u0027] \u003d (\u0027CHAP otzL 234Z\u0027)"},{"line_number":376,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_b9030cb8","line":373,"updated":"2015-06-15 11:25:08.000000000","message":"m_chap.return \u003d (\u0027otzL\u0027, \u0027234Z\u0027)","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc77795ca98837a414586be6de29740057af1a3c","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                                                       self.testvol,"},{"line_number":371,"context_line":"                                                       self.fake_volumes_dir))"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"            m_chap.side_effect \u003d lambda x, y: (\u0027otzL\u0027, \u0027234Z\u0027)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"            expected_result[\u0027auth\u0027] \u003d (\u0027CHAP otzL 234Z\u0027)"},{"line_number":376,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_c71db774","line":373,"in_reply_to":"fa32b979_b9030cb8","updated":"2015-06-15 16:59:13.000000000","message":"This is done this way to match all of the mocks above... changing it to use .return_value doesn\u0027t actually work.  (This all looks like it needs refactoring.)","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5b40ab240d81eab8a9c610fe858d7a8571a8880d","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                                                       self.testvol,"},{"line_number":371,"context_line":"                                                       self.fake_volumes_dir))"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"            m_chap.side_effect \u003d lambda x, y: (\u0027otzL\u0027, \u0027234Z\u0027)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"            expected_result[\u0027auth\u0027] \u003d (\u0027CHAP otzL 234Z\u0027)"},{"line_number":376,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_9acb8553","line":373,"in_reply_to":"fa32b979_c71db774","updated":"2015-06-15 18:07:58.000000000","message":"You are right, line 361 would need to be changed to return_value\u003dNone instead of that weird lambda function as side_effect for my suggested change to work, since side_effect has precedence over return_value.\n\nAnyway, I just got carried away with my comments, since suggested change is out of the scope of this patch. :-)","commit_id":"3bdd00a7196494bb9fdb37aeb4ea6720ae5c08ee"}]}