)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7f4fbed9d9db59f638a714f6d4f76ba271b440e0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This also contains conventional nfs driver for cluster systems which requires"},{"line_number":14,"context_line":"NetApp management software as middle layer. Implementation for cloning support"},{"line_number":15,"context_line":"and basic volume type scheduler support in driver added."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"blueprint netapp-volume-driver"},{"line_number":18,"context_line":"blueprint netapp-volume-driver-cmode"},{"line_number":19,"context_line":"blueprint nfs-files-as-virtual-block-devices"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAM3%2F%2FWvE%3D","line":16,"updated":"2013-01-25 20:11:22.000000000","message":"So typically a blue-print would map to a patch/change, not just one giant change set for every blueprint.\n\nThe real problem however is that these blueprints don\u0027t exist?","commit_id":"9dc9e03c9940d367a25baa17cb18d535f6125ae3"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c39337e5a78e1d8a6362b9b149dd1905bbf36008","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This also contains conventional nfs driver for cluster systems which requires"},{"line_number":14,"context_line":"NetApp management software as middle layer. Implementation for cloning support"},{"line_number":15,"context_line":"and basic volume type scheduler support in driver added."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"blueprint netapp-volume-driver"},{"line_number":18,"context_line":"blueprint netapp-volume-driver-cmode"},{"line_number":19,"context_line":"blueprint nfs-files-as-virtual-block-devices"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAM3%2F%2FWWM%3D","line":16,"in_reply_to":"AAAAM3%2F%2FWX0%3D","updated":"2013-01-26 15:23:14.000000000","message":"So I found the bp\u0027s you reference here, the problem is NOT that the blueprint link goes to grizzly-3, however the problem is that these are Nova blueprints from Essex.\n\nAnyway, just file a new BP (only one is necessary) that describes why you have have two versions of the same code here and reference that.","commit_id":"9dc9e03c9940d367a25baa17cb18d535f6125ae3"},{"author":{"_account_id":6094,"name":"Navneet Singh","email":"navsinghnitd@gmail.com","username":"singn"},"change_message_id":"59afce61ff1ef055194ee7e40e052b03e7263242","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This also contains conventional nfs driver for cluster systems which requires"},{"line_number":14,"context_line":"NetApp management software as middle layer. Implementation for cloning support"},{"line_number":15,"context_line":"and basic volume type scheduler support in driver added."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"blueprint netapp-volume-driver"},{"line_number":18,"context_line":"blueprint netapp-volume-driver-cmode"},{"line_number":19,"context_line":"blueprint nfs-files-as-virtual-block-devices"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAM3%2F%2FWX0%3D","line":16,"in_reply_to":"AAAAM3%2F%2FWvE%3D","updated":"2013-01-26 07:39:44.000000000","message":"Submitted drivers are alternate versions of the functionality implemented by already present NetApp drivers. So mentioned blueprints used to submit drivers in previous releases. The blueprint link takes to only current grizly-3 blueprints and doesnt find there. Do you want us to submit a new blueprint for direct drivers ?","commit_id":"9dc9e03c9940d367a25baa17cb18d535f6125ae3"}],"cinder/volume/drivers/netapp.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"8e850d7980fd1496b7645eca8e8c96c524b0041e","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"            self._add_lun_to_table(discovered_lun)"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"    def _invoke_succesfully(self, na_element, do_tunneling\u003dFalse):"},{"line_number":1617,"context_line":"        \"\"\"Invoke the api for successful result."},{"line_number":1618,"context_line":"           do_tunneling sets flag for tunneling"},{"line_number":1619,"context_line":"        \"\"\""},{"line_number":1620,"context_line":"        self._is_naelement(na_element)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FqsY%3D","line":1617,"updated":"2013-01-10 08:53:19.000000000","message":"Methods with different english names present: _invoke_succesfully (without \u0027ss\u0027 in success) and invoke_successfully (with an \u0027ss\u0027 in successfully)","commit_id":"a34205ea96ac57c20f2a4085ad5f05e59e0dbb3d"},{"author":{"_account_id":6094,"name":"Navneet Singh","email":"navsinghnitd@gmail.com","username":"singn"},"change_message_id":"bb76a78127c5d81e43f6c0a8ad45810aff6df247","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"            self._add_lun_to_table(discovered_lun)"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"    def _invoke_succesfully(self, na_element, do_tunneling\u003dFalse):"},{"line_number":1617,"context_line":"        \"\"\"Invoke the api for successful result."},{"line_number":1618,"context_line":"           do_tunneling sets flag for tunneling"},{"line_number":1619,"context_line":"        \"\"\""},{"line_number":1620,"context_line":"        self._is_naelement(na_element)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fqow%3D","line":1617,"in_reply_to":"AAAAM3%2F%2FqsY%3D","updated":"2013-01-10 09:15:55.000000000","message":"We can look into it in our next impl for qos.","commit_id":"a34205ea96ac57c20f2a4085ad5f05e59e0dbb3d"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"91641518828074482228c87525041fd44ad0a34c","unresolved":false,"context_lines":[{"line_number":2273,"context_line":"            self.client.set_vfiler_tunneling(None)"},{"line_number":2274,"context_line":""},{"line_number":2275,"context_line":""},{"line_number":2276,"context_line":"class NaServer(object):"},{"line_number":2277,"context_line":"    \"\"\" Encapsulates server connection logic\"\"\""},{"line_number":2278,"context_line":""},{"line_number":2279,"context_line":"    TRANSPORT_TYPE_HTTP \u003d \u0027http\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fge0%3D","line":2276,"updated":"2013-01-18 00:08:10.000000000","message":"Would it be possible to move the stuff that isn\u0027t actually a driver into a separate file and import it? This much code in one file is unwieldy and difficult to scan through.","commit_id":"a34205ea96ac57c20f2a4085ad5f05e59e0dbb3d"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"8e850d7980fd1496b7645eca8e8c96c524b0041e","unresolved":false,"context_lines":[{"line_number":2400,"context_line":"        \"\"\"Get the vfiler tunneling\"\"\""},{"line_number":2401,"context_line":"        return self._vfiler"},{"line_number":2402,"context_line":""},{"line_number":2403,"context_line":"    def set_vfiler_tunneling(self, vfiler):"},{"line_number":2404,"context_line":"        \"\"\"Set the vfiler tunneling\"\"\""},{"line_number":2405,"context_line":"        self._vfiler \u003d vfiler"},{"line_number":2406,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fqz4%3D","line":2403,"updated":"2013-01-10 08:53:19.000000000","message":"The names of getter and setter functions/definitions are a bit different. Either making the getter \u0027get_vfiler_tunneling\u0027, or making the setter \u0027get_vfiler\u0027 will make the code look more consistent and readable.","commit_id":"a34205ea96ac57c20f2a4085ad5f05e59e0dbb3d"},{"author":{"_account_id":6094,"name":"Navneet Singh","email":"navsinghnitd@gmail.com","username":"singn"},"change_message_id":"bb76a78127c5d81e43f6c0a8ad45810aff6df247","unresolved":false,"context_lines":[{"line_number":2400,"context_line":"        \"\"\"Get the vfiler tunneling\"\"\""},{"line_number":2401,"context_line":"        return self._vfiler"},{"line_number":2402,"context_line":""},{"line_number":2403,"context_line":"    def set_vfiler_tunneling(self, vfiler):"},{"line_number":2404,"context_line":"        \"\"\"Set the vfiler tunneling\"\"\""},{"line_number":2405,"context_line":"        self._vfiler \u003d vfiler"},{"line_number":2406,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FqpA%3D","line":2403,"in_reply_to":"AAAAM3%2F%2Fqz4%3D","updated":"2013-01-10 09:15:55.000000000","message":"Taken the same method names as NMSDK has for java lib. It was to have naming consistency with NMSDK. If required we can provide alternative in future.","commit_id":"a34205ea96ac57c20f2a4085ad5f05e59e0dbb3d"}]}