)]}'
{"cinder/db/sqlalchemy/migrate_repo/versions/001_cinder_init.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"8bcbb65a910506c19cc50f5e749bb4a0bc7c1d1e","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    for table in tables:"},{"line_number":233,"context_line":"        try:"},{"line_number":234,"context_line":"            table.create()"},{"line_number":235,"context_line":"        except Exception:"},{"line_number":236,"context_line":"            raise"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_e578cc91","line":235,"updated":"2015-06-16 11:51:38.000000000","message":"Why exception is catched if we just reraise it","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    for table in tables:"},{"line_number":233,"context_line":"        try:"},{"line_number":234,"context_line":"            table.create()"},{"line_number":235,"context_line":"        except Exception:"},{"line_number":236,"context_line":"            raise"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_4ae1bcfd","line":235,"in_reply_to":"fa32b979_e578cc91","updated":"2015-06-21 00:36:13.000000000","message":"Yes, just remove try/except.","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d7848e85361634687ffcebade88d7d8ff6a83a38","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            table.create()"},{"line_number":241,"context_line":"        except Exception:"},{"line_number":242,"context_line":"            LOG.info(repr(table))"},{"line_number":243,"context_line":"            LOG.exception(_LE(\u0027Exception while creating table.\u0027))"},{"line_number":244,"context_line":"            raise"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_95a7470a","side":"PARENT","line":243,"updated":"2015-07-15 17:46:20.000000000","message":"Don\u0027t you think it\u0027s useful to log exceptions?","commit_id":"db0cca532b774970b2fa15776ab935b276c40838"}],"cinder/db/sqlalchemy/migrate_repo/versions/002_quota_class.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"6fc8340e31245a941d8f3f0d9e63a4ebc8867082","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    try:"},{"line_number":43,"context_line":"        quota_classes.create()"},{"line_number":44,"context_line":"    except Exception:"},{"line_number":45,"context_line":"        raise"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    quota_usages \u003d Table(\u0027quota_usages\u0027, meta,"},{"line_number":48,"context_line":"                         Column(\u0027created_at\u0027, DateTime(timezone\u003dFalse)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_9bea4eab","line":45,"updated":"2015-06-17 12:37:33.000000000","message":"Without the logging statement, is there a reason to keep the try/except block here? This goes for all the other examples throughout as well.","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    try:"},{"line_number":43,"context_line":"        quota_classes.create()"},{"line_number":44,"context_line":"    except Exception:"},{"line_number":45,"context_line":"        raise"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    quota_usages \u003d Table(\u0027quota_usages\u0027, meta,"},{"line_number":48,"context_line":"                         Column(\u0027created_at\u0027, DateTime(timezone\u003dFalse)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_0ae4140b","line":45,"in_reply_to":"fa32b979_9bea4eab","updated":"2015-06-21 00:36:13.000000000","message":"Agree, just remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"8660b7d6cc465fd4e08cdbc242c4bd8b7895b588","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":125,"context_line":"            fkey.drop()"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            # NOTE(jdg): If this fails shouldn\u0027t we raise rather than ignore?"},{"line_number":128,"context_line":"            pass"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    quota_classes \u003d Table(\u0027quota_classes\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_cbd4cfbe","line":127,"updated":"2015-06-16 02:53:10.000000000","message":"Looks like raising exception is more appropreiate. or failing to remove foreign key would cause dropping below new tables fail, so it won\u0027t do any harm not raising here?","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1d26be5127753f874deaffa6efe83f899164ca45","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":125,"context_line":"            fkey.drop()"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            # NOTE(jdg): If this fails shouldn\u0027t we raise rather than ignore?"},{"line_number":128,"context_line":"            pass"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    quota_classes \u003d Table(\u0027quota_classes\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_f9c9945b","line":127,"in_reply_to":"fa32b979_cbd4cfbe","updated":"2015-06-20 15:20:01.000000000","message":"+1. I think raising exception is better as well. Otherwise it will throw an exception later because the foreign key is not removed.","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":125,"context_line":"            fkey.drop()"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            # NOTE(jdg): If this fails shouldn\u0027t we raise rather than ignore?"},{"line_number":128,"context_line":"            pass"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    quota_classes \u003d Table(\u0027quota_classes\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_2adc7845","line":127,"in_reply_to":"fa32b979_f9c9945b","updated":"2015-06-21 00:36:13.000000000","message":"So I think just removing try/except here would work.","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"a182d221069d90c39581d1ae29d3eeb596d4a1c8","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        except Exception:"},{"line_number":118,"context_line":"            # FIXME(jdg): We should just raise here"},{"line_number":119,"context_line":"            # not pass, but actually fail the downgrade"},{"line_number":120,"context_line":"            pass"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    quota_classes \u003d Table(\u0027quota_classes\u0027, meta, autoload\u003dTrue)"},{"line_number":123,"context_line":"    quota_classes.drop()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_df792231","line":120,"updated":"2015-07-20 11:19:21.000000000","message":"I\u0027m confused - why not just raise here, as the fix suggests?\n\nThe except: pass makes me nervous in general. Should the try/except block just be removed?","commit_id":"b4a0a07db937f6e8a21a97db54e67870f5fec7ad"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"55258070d95ff0677a861ba5718c2ef789c5395c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        except Exception:"},{"line_number":118,"context_line":"            # FIXME(jdg): We should just raise here"},{"line_number":119,"context_line":"            # not pass, but actually fail the downgrade"},{"line_number":120,"context_line":"            pass"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    quota_classes \u003d Table(\u0027quota_classes\u0027, meta, autoload\u003dTrue)"},{"line_number":123,"context_line":"    quota_classes.drop()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_c3528f13","line":120,"in_reply_to":"3a50d1a3_526e5630","updated":"2015-07-20 20:52:56.000000000","message":"Done, I\u0027ll just consolidate these, thanks!","commit_id":"b4a0a07db937f6e8a21a97db54e67870f5fec7ad"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"314fad5c8d4703c8d27af18ac35781ff72c383fb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        except Exception:"},{"line_number":118,"context_line":"            # FIXME(jdg): We should just raise here"},{"line_number":119,"context_line":"            # not pass, but actually fail the downgrade"},{"line_number":120,"context_line":"            pass"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    quota_classes \u003d Table(\u0027quota_classes\u0027, meta, autoload\u003dTrue)"},{"line_number":123,"context_line":"    quota_classes.drop()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_f6a3d99c","line":120,"in_reply_to":"3a50d1a3_dada9078","updated":"2015-07-20 15:40:39.000000000","message":"It will be done in scope of this https://review.openstack.org/#/c/202201/ patch","commit_id":"b4a0a07db937f6e8a21a97db54e67870f5fec7ad"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"20d2764e1056cbd20c2f7a0197e81cef47391e3d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        except Exception:"},{"line_number":118,"context_line":"            # FIXME(jdg): We should just raise here"},{"line_number":119,"context_line":"            # not pass, but actually fail the downgrade"},{"line_number":120,"context_line":"            pass"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    quota_classes \u003d Table(\u0027quota_classes\u0027, meta, autoload\u003dTrue)"},{"line_number":123,"context_line":"    quota_classes.drop()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_dada9078","line":120,"in_reply_to":"3a50d1a3_df792231","updated":"2015-07-20 11:37:21.000000000","message":"Agree.  We should either decide to raise here (drop the try-except), or if there is some reason that people are reluctant to do that (?) then I think this should continue to be logged.","commit_id":"b4a0a07db937f6e8a21a97db54e67870f5fec7ad"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"00a44a127f66bfd8e383f658fe6b41eecbdcf5bb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        except Exception:"},{"line_number":118,"context_line":"            # FIXME(jdg): We should just raise here"},{"line_number":119,"context_line":"            # not pass, but actually fail the downgrade"},{"line_number":120,"context_line":"            pass"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    quota_classes \u003d Table(\u0027quota_classes\u0027, meta, autoload\u003dTrue)"},{"line_number":123,"context_line":"    quota_classes.drop()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_526e5630","line":120,"in_reply_to":"3a50d1a3_f6a3d99c","updated":"2015-07-20 16:34:02.000000000","message":"I\u0027m fine for this to be addressed in https://review.openstack.org/#/c/202201/.","commit_id":"b4a0a07db937f6e8a21a97db54e67870f5fec7ad"}],"cinder/db/sqlalchemy/migrate_repo/versions/008_add_backup.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    try:"},{"line_number":50,"context_line":"        backups.create()"},{"line_number":51,"context_line":"    except Exception:"},{"line_number":52,"context_line":"        raise"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_caedccf0","line":52,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    try:"},{"line_number":61,"context_line":"        backups.drop()"},{"line_number":62,"context_line":"    except Exception:"},{"line_number":63,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_6ab920ec","line":63,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/009_add_snapshot_metadata_table.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    try:"},{"line_number":39,"context_line":"        snapshot_metadata.create()"},{"line_number":40,"context_line":"    except Exception:"},{"line_number":41,"context_line":"        raise"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_8abee4d2","line":41,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    try:"},{"line_number":51,"context_line":"        snapshot_metadata.drop()"},{"line_number":52,"context_line":"    except Exception:"},{"line_number":53,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_2ab3180c","line":53,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/010_add_transfers_table.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    try:"},{"line_number":42,"context_line":"        transfers.create()"},{"line_number":43,"context_line":"    except Exception:"},{"line_number":44,"context_line":"        raise"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_4ab8dce5","line":44,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    try:"},{"line_number":54,"context_line":"        transfers.drop()"},{"line_number":55,"context_line":"    except Exception:"},{"line_number":56,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_eacd3087","line":56,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/015_drop_migrations_table.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    try:"},{"line_number":25,"context_line":"        table.drop()"},{"line_number":26,"context_line":"    except Exception:"},{"line_number":27,"context_line":"        raise"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_aac72863","line":27,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    try:"},{"line_number":54,"context_line":"        table.create()"},{"line_number":55,"context_line":"    except Exception:"},{"line_number":56,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_0acbb473","line":56,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/016_drop_sm_tables.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            table.drop()"},{"line_number":32,"context_line":"        except Exception:"},{"line_number":33,"context_line":"            raise"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_cac4ec60","line":33,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            table.create()"},{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_6aa040a6","line":94,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/017_add_encryption_information.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        volumes.c.encryption_key_id.drop()"},{"line_number":82,"context_line":"    except Exception:"},{"line_number":83,"context_line":"        raise"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # drop encryption key UUID and volume type id for snapshots"},{"line_number":86,"context_line":"    snapshots \u003d Table(\u0027snapshots\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_2aaa3886","line":83,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        snapshots.c.volume_type_id.drop()"},{"line_number":93,"context_line":"    except Exception:"},{"line_number":94,"context_line":"        raise"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    # drop encryption types table"},{"line_number":97,"context_line":"    encryption \u003d Table(\u0027encryption\u0027, meta, autoload\u003dTrue)"},{"line_number":98,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_4aaf7c94","line":95,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    try:"},{"line_number":99,"context_line":"        encryption.drop()"},{"line_number":100,"context_line":"    except Exception:"},{"line_number":101,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_0a92d457","line":101,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/018_add_qos_specs.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    try:"},{"line_number":43,"context_line":"        quality_of_service_specs.create()"},{"line_number":44,"context_line":"    except Exception:"},{"line_number":45,"context_line":"        raise"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    volume_types \u003d Table(\u0027volume_types\u0027, meta, autoload\u003dTrue)"},{"line_number":48,"context_line":"    qos_specs_id \u003d Column(\u0027qos_specs_id\u0027, String(36),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_aa9e4861","line":45,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        qos_specs.drop()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    except Exception:"},{"line_number":93,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_ca9b8c71","line":93,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"a182d221069d90c39581d1ae29d3eeb596d4a1c8","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":71,"context_line":"            fkey.drop()"},{"line_number":72,"context_line":"        except Exception:"},{"line_number":73,"context_line":"            pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    volume_types \u003d Table(\u0027volume_types\u0027, meta, autoload\u003dTrue)"},{"line_number":76,"context_line":"    qos_specs_id \u003d Column(\u0027qos_specs_id\u0027, String(36))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_7f49eecf","line":73,"updated":"2015-07-20 11:19:21.000000000","message":"Was this overlooked or is the pass needed? The except: pass pattern makes me nervous.","commit_id":"b4a0a07db937f6e8a21a97db54e67870f5fec7ad"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"55258070d95ff0677a861ba5718c2ef789c5395c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":71,"context_line":"            fkey.drop()"},{"line_number":72,"context_line":"        except Exception:"},{"line_number":73,"context_line":"            pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    volume_types \u003d Table(\u0027volume_types\u0027, meta, autoload\u003dTrue)"},{"line_number":76,"context_line":"    qos_specs_id \u003d Column(\u0027qos_specs_id\u0027, String(36))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_636e1bcb","line":73,"in_reply_to":"3a50d1a3_1ab9d8e9","updated":"2015-07-20 20:52:56.000000000","message":"Done","commit_id":"b4a0a07db937f6e8a21a97db54e67870f5fec7ad"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"20d2764e1056cbd20c2f7a0197e81cef47391e3d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":71,"context_line":"            fkey.drop()"},{"line_number":72,"context_line":"        except Exception:"},{"line_number":73,"context_line":"            pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    volume_types \u003d Table(\u0027volume_types\u0027, meta, autoload\u003dTrue)"},{"line_number":76,"context_line":"    qos_specs_id \u003d Column(\u0027qos_specs_id\u0027, String(36))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_1ab9d8e9","line":73,"in_reply_to":"3a50d1a3_7f49eecf","updated":"2015-07-20 11:37:21.000000000","message":"Agree.   Can the try/except just be dropped here?  Or is there something about this downgrade fkey.drop() case that is special and we actually do want to do the pass?  If so, shouldn\u0027t we log it?","commit_id":"b4a0a07db937f6e8a21a97db54e67870f5fec7ad"}],"cinder/db/sqlalchemy/migrate_repo/versions/020_add_volume_admin_metadata_table.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    try:"},{"line_number":40,"context_line":"        volume_admin_metadata.create()"},{"line_number":41,"context_line":"    except Exception:"},{"line_number":42,"context_line":"        raise"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_6a87e012","line":42,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    try:"},{"line_number":52,"context_line":"        volume_admin_metadata.drop()"},{"line_number":53,"context_line":"    except Exception:"},{"line_number":54,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_8a8ca436","line":54,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/021_add_default_quota_class.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                     \u0027hard_limit\u0027: CONF.quota_gigabytes,"},{"line_number":67,"context_line":"                     \u0027deleted\u0027: False, })"},{"line_number":68,"context_line":"    except Exception:"},{"line_number":69,"context_line":"        raise"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_4a869c14","line":69,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/023_add_expire_reservations_index.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"6fc8340e31245a941d8f3f0d9e63a4ebc8867082","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    if index:"},{"line_number":49,"context_line":"        index.drop(migrate_engine)"},{"line_number":50,"context_line":"    else:"},{"line_number":51,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_3b578259","line":51,"updated":"2015-06-17 12:37:33.000000000","message":"You can just drop the else case here since it does nothing.","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    if index:"},{"line_number":49,"context_line":"        index.drop(migrate_engine)"},{"line_number":50,"context_line":"    else:"},{"line_number":51,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_ea7bf027","line":51,"in_reply_to":"fa32b979_3b578259","updated":"2015-06-21 00:36:13.000000000","message":"Agree","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"53f904d25d72b9e53f396df69524d6d016ab70fb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    index \u003d _get_deleted_expire_index(reservations)"},{"line_number":48,"context_line":"    if index:"},{"line_number":49,"context_line":"        index.drop(migrate_engine)"},{"line_number":50,"context_line":"    else:"},{"line_number":51,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_6e671feb","line":50,"updated":"2015-07-16 15:24:58.000000000","message":"Remove full else block now as it is useless.","commit_id":"d4468ea74835354de451eab9413e0bf083fbd619"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"51aa840d29207e08f54fecd71f6bb90e96d21981","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    index \u003d _get_deleted_expire_index(reservations)"},{"line_number":48,"context_line":"    if index:"},{"line_number":49,"context_line":"        index.drop(migrate_engine)"},{"line_number":50,"context_line":"    else:"},{"line_number":51,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_6f2fd43e","line":50,"in_reply_to":"9a41bdd9_6e671feb","updated":"2015-07-17 20:03:34.000000000","message":"Good point, thanks!","commit_id":"d4468ea74835354de451eab9413e0bf083fbd619"}],"cinder/db/sqlalchemy/migrate_repo/versions/025_add_consistencygroup.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":114,"context_line":"            fkey.drop()"},{"line_number":115,"context_line":"        except Exception:"},{"line_number":116,"context_line":"            raise"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    snapshots \u003d Table(\u0027snapshots\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_0a79742f","line":115,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"6fc8340e31245a941d8f3f0d9e63a4ebc8867082","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":135,"context_line":"            fkey.drop()"},{"line_number":136,"context_line":"        except Exception:"},{"line_number":137,"context_line":"            pass"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    volumes \u003d Table(\u0027volumes\u0027, meta, autoload\u003dTrue)"},{"line_number":140,"context_line":"    consistencygroup_id \u003d volumes.columns.consistencygroup_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_1be15e9a","line":137,"updated":"2015-06-17 12:37:33.000000000","message":"This seems risky to me. Why shouldn\u0027t it be raised here?","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1d26be5127753f874deaffa6efe83f899164ca45","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":135,"context_line":"            fkey.drop()"},{"line_number":136,"context_line":"        except Exception:"},{"line_number":137,"context_line":"            pass"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    volumes \u003d Table(\u0027volumes\u0027, meta, autoload\u003dTrue)"},{"line_number":140,"context_line":"    consistencygroup_id \u003d volumes.columns.consistencygroup_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_f9a2f499","line":137,"in_reply_to":"fa32b979_1be15e9a","updated":"2015-06-20 15:20:01.000000000","message":"It\u0027s better to \"raise\" here.  Otherwise, it will throw an exception on line 141 when it tries to drop column.","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"a182d221069d90c39581d1ae29d3eeb596d4a1c8","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":120,"context_line":"            fkey.drop()"},{"line_number":121,"context_line":"        except Exception:"},{"line_number":122,"context_line":"            pass"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    volumes \u003d Table(\u0027volumes\u0027, meta, autoload\u003dTrue)"},{"line_number":125,"context_line":"    consistencygroup_id \u003d volumes.columns.consistencygroup_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_3f7926fd","line":122,"updated":"2015-07-20 11:19:21.000000000","message":"Was this overlooked or is the pass needed? The except: pass pattern makes me nervous.","commit_id":"b4a0a07db937f6e8a21a97db54e67870f5fec7ad"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"55258070d95ff0677a861ba5718c2ef789c5395c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":120,"context_line":"            fkey.drop()"},{"line_number":121,"context_line":"        except Exception:"},{"line_number":122,"context_line":"            pass"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    volumes \u003d Table(\u0027volumes\u0027, meta, autoload\u003dTrue)"},{"line_number":125,"context_line":"    consistencygroup_id \u003d volumes.columns.consistencygroup_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_036077cd","line":122,"in_reply_to":"3a50d1a3_1ab0f8f3","updated":"2015-07-20 20:52:56.000000000","message":"Done","commit_id":"b4a0a07db937f6e8a21a97db54e67870f5fec7ad"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"20d2764e1056cbd20c2f7a0197e81cef47391e3d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            fkey \u003d ForeignKeyConstraint(**params)"},{"line_number":120,"context_line":"            fkey.drop()"},{"line_number":121,"context_line":"        except Exception:"},{"line_number":122,"context_line":"            pass"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    volumes \u003d Table(\u0027volumes\u0027, meta, autoload\u003dTrue)"},{"line_number":125,"context_line":"    consistencygroup_id \u003d volumes.columns.consistencygroup_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_1ab0f8f3","line":122,"in_reply_to":"3a50d1a3_3f7926fd","updated":"2015-07-20 11:37:21.000000000","message":"Same as above.","commit_id":"b4a0a07db937f6e8a21a97db54e67870f5fec7ad"}],"cinder/db/sqlalchemy/migrate_repo/versions/026_add_consistencygroup_quota_class.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                     \u0027hard_limit\u0027: CONF.quota_consistencygroups,"},{"line_number":53,"context_line":"                     \u0027deleted\u0027: False, })"},{"line_number":54,"context_line":"    except Exception:"},{"line_number":55,"context_line":"        raise"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_ca72ac49","line":55,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/032_add_volume_type_projects.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        # pylint: disable\u003dE1120"},{"line_number":26,"context_line":"        volume_types.update().values(is_public\u003dTrue).execute()"},{"line_number":27,"context_line":"    except Exception:"},{"line_number":28,"context_line":"        raise"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    volume_type_projects \u003d Table("},{"line_number":31,"context_line":"        \u0027volume_type_projects\u0027, meta,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_6a8e0029","line":28,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    try:"},{"line_number":45,"context_line":"        volume_type_projects.create()"},{"line_number":46,"context_line":"    except Exception:"},{"line_number":47,"context_line":"        raise"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_8a93444f","line":47,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    try:"},{"line_number":57,"context_line":"        volume_types.drop_column(is_public)"},{"line_number":58,"context_line":"    except Exception:"},{"line_number":59,"context_line":"        raise"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    volume_type_projects \u003d Table(\u0027volume_type_projects\u0027, meta, autoload\u003dTrue)"},{"line_number":62,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_2a98f869","line":59,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    try:"},{"line_number":63,"context_line":"        volume_type_projects.drop()"},{"line_number":64,"context_line":"    except Exception:"},{"line_number":65,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_4a9d3c58","line":65,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/037_add_cgsnapshot_id_column_to_consistencygroups.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        consistencygroups.create_column(cgsnapshot_id)"},{"line_number":27,"context_line":"        consistencygroups.update().values(cgsnapshot_id\u003dNone).execute()"},{"line_number":28,"context_line":"    except Exception:"},{"line_number":29,"context_line":"        raise"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_eaa2109a","line":29,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    try:"},{"line_number":41,"context_line":"        consistencygroups.drop_column(cgsnapshot_id)"},{"line_number":42,"context_line":"    except Exception:"},{"line_number":43,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_0aa0948f","line":43,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/038_add_driver_initiator_data_table.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    try:"},{"line_number":37,"context_line":"        initiator_data.create()"},{"line_number":38,"context_line":"    except Exception:"},{"line_number":39,"context_line":"        raise"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_caa94c7d","line":39,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    try:"},{"line_number":48,"context_line":"        initiator_data.drop()"},{"line_number":49,"context_line":"    except Exception:"},{"line_number":50,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_6ab5a0ce","line":50,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/039_add_parent_id_to_backups.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        backups.create_column(parent_id)"},{"line_number":29,"context_line":"        backups.update().values(parent_id\u003dNone).execute()"},{"line_number":30,"context_line":"    except Exception:"},{"line_number":31,"context_line":"        raise"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_8aba64bf","line":31,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    try:"},{"line_number":42,"context_line":"        backups.drop_column(parent_id)"},{"line_number":43,"context_line":"    except Exception:"},{"line_number":44,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_2aaf987e","line":44,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/040_add_volume_attachment.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    try:"},{"line_number":58,"context_line":"        volume_attachment.create()"},{"line_number":59,"context_line":"    except Exception:"},{"line_number":60,"context_line":"        raise"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # now migrate existing volume attachment info into the"},{"line_number":63,"context_line":"    # new volume_attachment table"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_4ab45cd0","line":60,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        volume_attachment.drop()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    except Exception:"},{"line_number":140,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_eac9b05b","line":140,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/040_sqlite_downgrade.sql":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"6fc8340e31245a941d8f3f0d9e63a4ebc8867082","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"DROP TABLE volumes;"},{"line_number":83,"context_line":"ALTER TABLE volumes_v39 RENAME TO volumes;"},{"line_number":84,"context_line":"DROP TABLE volume_attachment;"},{"line_number":85,"context_line":"COMMIT;"}],"source_content_type":"text/x-sql","patch_set":2,"id":"fa32b979_f6efefe6","line":84,"updated":"2015-06-17 12:37:33.000000000","message":"My SQL-fu isn\u0027t strong but do we still need COMMIT here if there\u0027s no BEGIN TRANSACTION? Or is there a another transaction initiated elsewhere?","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"52f36a8a31b6700df78ec2c12456f56f98b6548b","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"DROP TABLE volumes;"},{"line_number":83,"context_line":"ALTER TABLE volumes_v39 RENAME TO volumes;"},{"line_number":84,"context_line":"DROP TABLE volume_attachment;"},{"line_number":85,"context_line":"COMMIT;"}],"source_content_type":"text/x-sql","patch_set":2,"id":"fa32b979_c3952f87","line":84,"in_reply_to":"fa32b979_f6efefe6","updated":"2015-06-17 20:30:34.000000000","message":"COMMIT should be removed with \u0027BEGIN TRANSACTION\u0027","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}],"cinder/db/sqlalchemy/migrate_repo/versions/041_add_modified_at_column_to_service.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    try:"},{"line_number":22,"context_line":"        services.create_column(modified_at)"},{"line_number":23,"context_line":"    except Exception:"},{"line_number":24,"context_line":"        raise"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_0ac73446","line":24,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"11f58b9a6290c1c914e90710a59f0158d9bd85b9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    try:"},{"line_number":32,"context_line":"        services.drop_column(\u0027modified_at\u0027)"},{"line_number":33,"context_line":"    except Exception:"},{"line_number":34,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_aac3a837","line":34,"updated":"2015-06-21 00:36:13.000000000","message":"remove try/except","commit_id":"982435a2564fc922103828e6d27d5425c3b786b5"}]}