)]}'
{"cinder/volume/drivers/hitachi/hbsd_horcm.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"7ae6d4cb52913c3e347a5594894a14574f2b5ca3","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"        for copy_group in self.get_copy_groups():"},{"line_number":1143,"context_line":"            pvol_group \u003d \u0027%sP\u0027 % copy_group"},{"line_number":1144,"context_line":"            if self.check_device_grp(pvol_group, pvol, ldev_name\u003dldev_name):"},{"line_number":1145,"context_line":"                return copy_group"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"    def get_paired_info(self, ldev, only_flag\u003dFalse):"},{"line_number":1148,"context_line":"        paired_info \u003d {\u0027pvol\u0027: None, \u0027svol\u0027: []}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_6db77c3a","line":1145,"updated":"2015-12-08 09:44:12.000000000","message":"I think we should keep the `return None` here. The `return None` reminds that this function has returned in every of its branch, rather than forgetting some one.","commit_id":"54955740a27488a582eb1476888452ecceff36c7"}],"cinder/volume/drivers/netapp/dataontap/client/client_7mode.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"e58265d72f8e5ae99c14fe0d3c1308d3f41f6325","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            if clone_ops_info.get_child_content(\u0027clone-state\u0027)\\"},{"line_number":263,"context_line":"                    \u003d\u003d \u0027completed\u0027:"},{"line_number":264,"context_line":"                LOG.debug(\"Clone operation with src %(name)s\""},{"line_number":265,"context_line":"                          \" and dest %(new_name)s completed\", fmt)"},{"line_number":266,"context_line":"            else:"},{"line_number":267,"context_line":"                LOG.debug(\"Clone operation with src %(name)s\""},{"line_number":268,"context_line":"                          \" and dest %(new_name)s failed\", fmt)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_8f4a0525","line":265,"updated":"2015-07-01 20:57:37.000000000","message":"\".\" at EOL","commit_id":"fabb569feda04e6f00d9f247a6d3bee1bfc343e1"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"e58265d72f8e5ae99c14fe0d3c1308d3f41f6325","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                          \" and dest %(new_name)s completed\", fmt)"},{"line_number":266,"context_line":"            else:"},{"line_number":267,"context_line":"                LOG.debug(\"Clone operation with src %(name)s\""},{"line_number":268,"context_line":"                          \" and dest %(new_name)s failed\", fmt)"},{"line_number":269,"context_line":"                raise netapp_api.NaApiError("},{"line_number":270,"context_line":"                    clone_ops_info.get_child_content(\u0027error\u0027),"},{"line_number":271,"context_line":"                    clone_ops_info.get_child_content(\u0027reason\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_ef5f11e3","line":268,"updated":"2015-07-01 20:57:37.000000000","message":"\".\" at EOL","commit_id":"fabb569feda04e6f00d9f247a6d3bee1bfc343e1"}],"cinder/zonemanager/drivers/cisco/cisco_fc_zone_driver.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"af25d4164c51dea8d1725ae8e8f271c5b44d12a6","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                    raise exception.FCZoneDriverException(msg)"},{"line_number":376,"context_line":"                LOG.debug(\"Zones deleted successfully: %s\", zone_map)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"            LOG.debug(\"Zoning session exists VSAN: %s\", zoning_vsan)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def get_san_context(self, target_wwn_list):"},{"line_number":381,"context_line":"        \"\"\"Lookup SAN context for visible end devices."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_11f5ba55","line":378,"updated":"2015-06-17 13:45:24.000000000","message":"This does not look correct - if it is then the code is rather confusing. I\u0027d like to see this function broken out into a couple of helpers so that the flow is more obvious, if possible","commit_id":"fabb569feda04e6f00d9f247a6d3bee1bfc343e1"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b80e7daa0f9f7a12a94c1842c903e20d17098371","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                    raise exception.FCZoneDriverException(msg)"},{"line_number":376,"context_line":"                LOG.debug(\"Zones deleted successfully: %s\", zone_map)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"            LOG.debug(\"Zoning session exists VSAN: %s\", zoning_vsan)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def get_san_context(self, target_wwn_list):"},{"line_number":381,"context_line":"        \"\"\"Lookup SAN context for visible end devices."}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_b3416eab","line":378,"in_reply_to":"fa32b979_11f5ba55","updated":"2015-08-31 03:43:24.000000000","message":"I agree with Duncan, don\u0027t se a return embedded up there so you will now log this message all the time base don what I\u0027m looking at.  The other cases are pretty clear, the if returns so there\u0027s no need for an else, but this one I think might be wrong.","commit_id":"fabb569feda04e6f00d9f247a6d3bee1bfc343e1"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"23166416d90c269fed1dcf51f39d992e9c2e4b50","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                    LOG.exception(msg)"},{"line_number":375,"context_line":"                    raise exception.FCZoneDriverException(msg)"},{"line_number":376,"context_line":"                LOG.debug(\"Zones deleted successfully: %s\", zone_map)"},{"line_number":377,"context_line":"        else:"},{"line_number":378,"context_line":"            LOG.debug(\"Zoning session exists VSAN: %s\", zoning_vsan)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def get_san_context(self, target_wwn_list):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_fae564a3","line":377,"updated":"2015-12-08 09:39:47.000000000","message":"It looks like the \"else\" here should have been deleted. Otherwise the logic would not be identical with it before.","commit_id":"54955740a27488a582eb1476888452ecceff36c7"}]}