)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"198e551e445e6954b27d63dadcd81a437c89367e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Andrey Pavlov \u003candrey-mp@yandex.ru\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-25 22:22:41 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Small fix in doc string definition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed \"\"\"\" at start of docstring to \"\"\""},{"line_number":10,"context_line":"and changed \u0027\u0027\u0027 to \"\"\" in docstrings"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba3cc151_bb644be5","line":7,"updated":"2015-06-30 09:15:05.000000000","message":"Initially this was a small fix for a single file. IMO you should update the commit message to describe the changes as this change is long enough now.\n\nYou can also provide some references for docstring standards to help reviewers to understand why this change is required.\ne.g. https://www.python.org/dev/peps/pep-0008/#documentation-strings","commit_id":"426fd4c52af1080e63ba284b9dd4d37dce411320"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"fdeeea8fa1adb54871180c4f546186dcbcb3570a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Andrey Pavlov \u003candrey-mp@yandex.ru\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-25 22:22:41 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Small fix in doc string definition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed \"\"\"\" at start of docstring to \"\"\""},{"line_number":10,"context_line":"and changed \u0027\u0027\u0027 to \"\"\" in docstrings"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba3cc151_fe296138","line":7,"in_reply_to":"ba3cc151_bb644be5","updated":"2015-06-30 09:42:32.000000000","message":"I don\u0027t want to spend much time to this review. It doesn\u0027t fix any bug and it doesn\u0027t help me to do my main work.","commit_id":"426fd4c52af1080e63ba284b9dd4d37dce411320"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"0c25814828d54953160370df08a4d312a084f1a0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix doc string definitions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed \"\"\"\" at start of docstring to \"\"\""},{"line_number":10,"context_line":"and changed \u0027\u0027\u0027 to \"\"\" in docstrings"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Docstring standards are here -"},{"line_number":13,"context_line":"https://www.python.org/dev/peps/pep-0008/#documentation-strings"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba3cc151_47622eaf","line":10,"updated":"2015-07-06 03:37:52.000000000","message":"Please add a period \u0027.\u0027 at the and of the sentence.","commit_id":"26704b52bfca3db030e586d935e150b8e43459aa"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"315e13131e0cda1d7f1ddaeb61b05eff5eb3a6a3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix doc string definitions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed \"\"\"\" at start of docstring to \"\"\""},{"line_number":10,"context_line":"and changed \u0027\u0027\u0027 to \"\"\" in docstrings"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Docstring standards are here -"},{"line_number":13,"context_line":"https://www.python.org/dev/peps/pep-0008/#documentation-strings"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba3cc151_3cf29507","line":10,"in_reply_to":"ba3cc151_47622eaf","updated":"2015-07-06 10:00:20.000000000","message":"Did you just downvote the patch for that?  That\u0027s harsh!!","commit_id":"26704b52bfca3db030e586d935e150b8e43459aa"}],"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2bde4ba564893c9762548eed25ff1ae2adc33355","unresolved":false,"context_lines":[{"line_number":1815,"context_line":"        return ret"},{"line_number":1816,"context_line":""},{"line_number":1817,"context_line":"    def _init_cg_volumes(self, profileid):"},{"line_number":1818,"context_line":"        \u0027\u0027\u0027Gets the cg volume list and maps/unmaps the non active volumes."},{"line_number":1819,"context_line":""},{"line_number":1820,"context_line":"        :param profileid: Replay profile identifier."},{"line_number":1821,"context_line":"        :return: Nothing"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_35af0d96","line":1818,"updated":"2015-07-24 08:38:05.000000000","message":"Probably a new change after rebase, but we need to fix this.","commit_id":"043ed6ecf3123a80ee5bb087dea39140e4c1d300"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"3f3fe04ac22f9547cc5317192ad3abda85deef5c","unresolved":false,"context_lines":[{"line_number":1815,"context_line":"        return ret"},{"line_number":1816,"context_line":""},{"line_number":1817,"context_line":"    def _init_cg_volumes(self, profileid):"},{"line_number":1818,"context_line":"        \u0027\u0027\u0027Gets the cg volume list and maps/unmaps the non active volumes."},{"line_number":1819,"context_line":""},{"line_number":1820,"context_line":"        :param profileid: Replay profile identifier."},{"line_number":1821,"context_line":"        :return: Nothing"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_55edf98c","line":1818,"in_reply_to":"3a50d1a3_35af0d96","updated":"2015-07-24 08:46:17.000000000","message":"Done.\nSame thing had appeared in cinder/tests/unit/test_backup_ceph.py","commit_id":"043ed6ecf3123a80ee5bb087dea39140e4c1d300"}],"cinder/volume/drivers/dell/dell_storagecenter_common.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"164ca5b42f5b8da6ddaa7d375454b5c70d4dabe4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            self.configuration.safe_get(\u0027volume_backend_name\u0027) or \u0027Dell\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _bytes_to_gb(self, spacestring):"},{"line_number":59,"context_line":"        \"\"\"Space is returned in a string like ..."},{"line_number":60,"context_line":"        7.38197504E8 Bytes"},{"line_number":61,"context_line":"        Need to split that apart and convert to GB."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_21bb2ce7","line":59,"updated":"2015-06-30 10:13:57.000000000","message":"This is not following pep-0257.","commit_id":"bacbe5ef61847158e8529dcf5b9beede377d726e"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"b5da6faa1da462c64fb67d1c78ae325ff236be33","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            self.configuration.safe_get(\u0027volume_backend_name\u0027) or \u0027Dell\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _bytes_to_gb(self, spacestring):"},{"line_number":59,"context_line":"        \"\"\"Space is returned in a string like ..."},{"line_number":60,"context_line":"        7.38197504E8 Bytes"},{"line_number":61,"context_line":"        Need to split that apart and convert to GB."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_6c4ccb70","line":59,"in_reply_to":"ba3cc151_21bb2ce7","updated":"2015-06-30 10:26:52.000000000","message":"What exactly?","commit_id":"bacbe5ef61847158e8529dcf5b9beede377d726e"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"f44c8c2d0727ef2391f40feb9617abbea0cd41aa","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            self.configuration.safe_get(\u0027volume_backend_name\u0027) or \u0027Dell\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _bytes_to_gb(self, spacestring):"},{"line_number":59,"context_line":"        \"\"\"Space is returned in a string like ..."},{"line_number":60,"context_line":"        7.38197504E8 Bytes"},{"line_number":61,"context_line":"        Need to split that apart and convert to GB."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_cc47171c","line":59,"in_reply_to":"ba3cc151_4cd46746","updated":"2015-06-30 10:32:50.000000000","message":"Please read commit message. I didn\u0027t fix all docstring issues.","commit_id":"bacbe5ef61847158e8529dcf5b9beede377d726e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e0e42a79400210f3df01750ab96e3704616f7857","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            self.configuration.safe_get(\u0027volume_backend_name\u0027) or \u0027Dell\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _bytes_to_gb(self, spacestring):"},{"line_number":59,"context_line":"        \"\"\"Space is returned in a string like ..."},{"line_number":60,"context_line":"        7.38197504E8 Bytes"},{"line_number":61,"context_line":"        Need to split that apart and convert to GB."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_4cd46746","line":59,"in_reply_to":"ba3cc151_6c4ccb70","updated":"2015-06-30 10:30:49.000000000","message":"https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings\n\nMulti-line docstrings consist of a summary line just like a one-line docstring, followed by a blank line..","commit_id":"bacbe5ef61847158e8529dcf5b9beede377d726e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"fe655319300658f350f6d7c4829d6a4a01a16287","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            self.configuration.safe_get(\u0027volume_backend_name\u0027) or \u0027Dell\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _bytes_to_gb(self, spacestring):"},{"line_number":59,"context_line":"        \"\"\"Space is returned in a string like ..."},{"line_number":60,"context_line":"        7.38197504E8 Bytes"},{"line_number":61,"context_line":"        Need to split that apart and convert to GB."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_6794e4e1","line":59,"in_reply_to":"ba3cc151_cc47171c","updated":"2015-06-30 11:11:55.000000000","message":"https://review.openstack.org/#/c/184820/3 fix this. You may want to take a look at this review for any conflicts.","commit_id":"bacbe5ef61847158e8529dcf5b9beede377d726e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2bde4ba564893c9762548eed25ff1ae2adc33355","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        return {}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _add_volume_to_consistency_group(self, api, scvolume, volume):"},{"line_number":104,"context_line":"        \u0027\u0027\u0027Just a helper to add a volume to a consistency group."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        :param api: Dell SC API opbject."},{"line_number":107,"context_line":"        :param scvolume: Dell SC Volume object."}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_959e2162","line":104,"updated":"2015-07-24 08:38:05.000000000","message":"Same comment.","commit_id":"043ed6ecf3123a80ee5bb087dea39140e4c1d300"}],"cinder/volume/drivers/srb.py":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"198e551e445e6954b27d63dadcd81a437c89367e","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    @staticmethod"},{"line_number":462,"context_line":"    def _activate_lv(orig, *args, **kwargs):"},{"line_number":463,"context_line":"        \"\"\"Use with `patched` to patch `lvm.LVM.activate_lv` to ignore `EEXIST`"},{"line_number":464,"context_line":"        \"\"\""},{"line_number":465,"context_line":"        try:"},{"line_number":466,"context_line":"            orig(*args, **kwargs)"},{"line_number":467,"context_line":"        except putils.ProcessExecutionError as exc:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_184bfd88","line":464,"updated":"2015-06-30 09:15:05.000000000","message":"According to the standards [1] closing \"\"\" should be on the same line for one liner docstrings.\n\n[1] https://www.python.org/dev/peps/pep-0008/#documentation-strings","commit_id":"426fd4c52af1080e63ba284b9dd4d37dce411320"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"fdeeea8fa1adb54871180c4f546186dcbcb3570a","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    @staticmethod"},{"line_number":462,"context_line":"    def _activate_lv(orig, *args, **kwargs):"},{"line_number":463,"context_line":"        \"\"\"Use with `patched` to patch `lvm.LVM.activate_lv` to ignore `EEXIST`"},{"line_number":464,"context_line":"        \"\"\""},{"line_number":465,"context_line":"        try:"},{"line_number":466,"context_line":"            orig(*args, **kwargs)"},{"line_number":467,"context_line":"        except putils.ProcessExecutionError as exc:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_9e4cd543","line":464,"in_reply_to":"ba3cc151_184bfd88","updated":"2015-06-30 09:42:32.000000000","message":"According to another standard length of line should not be greater of 79.","commit_id":"426fd4c52af1080e63ba284b9dd4d37dce411320"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6353a69f489bfd9e03e7428a58c797d9d0ebea76","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    @staticmethod"},{"line_number":462,"context_line":"    def _activate_lv(orig, *args, **kwargs):"},{"line_number":463,"context_line":"        \"\"\"Use with `patched` to patch `lvm.LVM.activate_lv` to ignore `EEXIST`"},{"line_number":464,"context_line":"        \"\"\""},{"line_number":465,"context_line":"        try:"},{"line_number":466,"context_line":"            orig(*args, **kwargs)"},{"line_number":467,"context_line":"        except putils.ProcessExecutionError as exc:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_ac8ad3bd","line":464,"in_reply_to":"ba3cc151_9e4cd543","updated":"2015-06-30 10:47:48.000000000","message":"@Andrey, and both rules should be followed ;-)\n\nBut since the purpose of this patch wasn\u0027t to fix *all* issues, this is ok, no need to change it in this patch.  By the way oneliner docstrings should also end with a .","commit_id":"426fd4c52af1080e63ba284b9dd4d37dce411320"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"1da5dbf0aa437bebce2de992cf37e4795462501a","unresolved":false,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    @staticmethod"},{"line_number":462,"context_line":"    def _activate_lv(orig, *args, **kwargs):"},{"line_number":463,"context_line":"        \"\"\"Use with `patched` to patch `lvm.LVM.activate_lv` to ignore `EEXIST`"},{"line_number":464,"context_line":"        \"\"\""},{"line_number":465,"context_line":"        try:"},{"line_number":466,"context_line":"            orig(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_1513bb0e","line":463,"updated":"2015-06-30 13:12:40.000000000","message":"IMHO, you should have formatted it based on the docstring standards mentioned in previous patch set review if you are modifying these lines of docstring in this patch.","commit_id":"bacbe5ef61847158e8529dcf5b9beede377d726e"}]}