)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"cc9ce94068b4285e4518caddc501f9964da978eb","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change depends on a change not yet merged in TaskFlow!"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: I38a9a5f3bf7550e924468bb4a86652cb8beb306c"},{"line_number":15,"context_line":"Change-Id: Ia4739c87ca83ae725e16256e3f2c596c5e6d935b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_067e9e69","line":14,"updated":"2015-06-18 15:25:02.000000000","message":"Since Cinder depends on taskflow package, having a commit dependency like this is hard to track (meaning: even this change is merged in taskflow, Cinder can only have it until it\u0027s released in next taskflow version AND openstack/global-requirement has been updated).","commit_id":"d8570771401c2dfdcc18a92d52c4e0275825f117"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1ec592f5eed0b05522f7c4fd9160cdacf3754209","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP: Refactoring of manager\u0027s create_volume flow"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"First round on refactoring the manager\u0027s create_volume flow. I\u0027ve"},{"line_number":10,"context_line":"also removed some unused parameters from create_volume RPC call to"},{"line_number":11,"context_line":"c-vol."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change depends on a change not yet merged (or packaged) in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_dc03690e","line":10,"updated":"2015-06-29 16:44:22.000000000","message":"consistencygroup_id and cgsnapshot_id that you removed are NOT unused!","commit_id":"a77a9fbc2a5e5077dde185ba90bfe1c2e231386c"}],"cinder/volume/flows/api/create_volume.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d2aaef35348e72a2936642fbbb995b0494afc36d","unresolved":false,"context_lines":[{"line_number":718,"context_line":"                    image_id\u003dimage_id,"},{"line_number":719,"context_line":"                    source_volid\u003dsource_volid,"},{"line_number":720,"context_line":"                    source_replicaid\u003dsource_replicaid,"},{"line_number":721,"context_line":"                    consistencygroup_id\u003dcgroup_id)"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    def execute(self, context, **kwargs):"},{"line_number":724,"context_line":"        scheduler_hints \u003d kwargs.pop(\u0027scheduler_hints\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_3c20559b","side":"PARENT","line":721,"updated":"2015-06-29 16:32:50.000000000","message":"Why is this removed?  This will break adding a volume to a consistencygroup.","commit_id":"31d123ceb43013aae9e4545ff5d14a784f4fe857"}],"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"cc9ce94068b4285e4518caddc501f9964da978eb","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        volume_id \u003d kwargs[\u0027volume_id\u0027]"},{"line_number":156,"context_line":"        # Use a different context when rescheduling."},{"line_number":157,"context_line":"        if self.reschedule_context:"},{"line_number":158,"context_line":"            cause \u003d list(flow_failures.values())[0]"},{"line_number":159,"context_line":"            context \u003d self.reschedule_context"},{"line_number":160,"context_line":"            try:"},{"line_number":161,"context_line":"                self._pre_reschedule(context, volume_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_c6119653","line":158,"updated":"2015-06-18 15:25:02.000000000","message":"I still don\u0027t like the mixture of taskflow internal knowledge and cinder code like this.  Can we change this in taskflow to expose a more friendly interface for downstream project to consume some needed info of inter-flow state?","commit_id":"d8570771401c2dfdcc18a92d52c4e0275825f117"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d2aaef35348e72a2936642fbbb995b0494afc36d","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        \u0027volume_id\u0027: volume_id,"},{"line_number":764,"context_line":"        \u0027source_replicaid\u0027: source_replicaid,"},{"line_number":765,"context_line":"        \u0027consistencygroup_id\u0027: consistencygroup_id,"},{"line_number":766,"context_line":"        \u0027cgsnapshot_id\u0027: cgsnapshot_id,"},{"line_number":767,"context_line":"    }"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    volume_flow.add(ExtractVolumeRefTask(db, host, set_error\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_9cee4121","side":"PARENT","line":766,"updated":"2015-06-29 16:32:50.000000000","message":"What is the reason of removing all these?  This will break consistency group completely.  Removing consistencygroup_id will prevent a volume from being added to the CG.  Removing cgsnapshot_id will prevent creating CG from CG snapshot from happening.","commit_id":"31d123ceb43013aae9e4545ff5d14a784f4fe857"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d2aaef35348e72a2936642fbbb995b0494afc36d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class OnFailureRescheduleTask(flow_utils.CinderTask):"},{"line_number":50,"context_line":"    \"\"\"Triggers a rescheduling request to be sent when reverting occurs. If we"},{"line_number":51,"context_line":"    do not reschedule this task also sets the error state on volume."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Reversion strategy: Triggers the rescheduling mechanism whereby a cast gets"},{"line_number":54,"context_line":"    sent to the scheduler rpc api to allow for an attempt X of Y for scheduling"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_3c6e15ca","line":51,"updated":"2015-06-29 16:32:50.000000000","message":"This change breaks the docstring hacking rule.\n\nhttp://docs.openstack.org/developer/hacking/#docstrings","commit_id":"a77a9fbc2a5e5077dde185ba90bfe1c2e231386c"}],"cinder/volume/manager.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d2aaef35348e72a2936642fbbb995b0494afc36d","unresolved":false,"context_lines":[{"line_number":405,"context_line":"                      filter_properties\u003dNone, allow_reschedule\u003dTrue,"},{"line_number":406,"context_line":"                      snapshot_id\u003dNone, image_id\u003dNone, source_volid\u003dNone,"},{"line_number":407,"context_line":"                      source_replicaid\u003dNone, consistencygroup_id\u003dNone,"},{"line_number":408,"context_line":"                      cgsnapshot_id\u003dNone):"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        \"\"\"Creates the volume.\"\"\""},{"line_number":411,"context_line":"        context_elevated \u003d context.elevated()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_bce7853f","side":"PARENT","line":408,"updated":"2015-06-29 16:32:50.000000000","message":"I don\u0027t understand this change.","commit_id":"31d123ceb43013aae9e4545ff5d14a784f4fe857"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"2f4bfe493ced071551f8339bf36cb9a7a1ab4915","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                # if rescheduling occurred."},{"line_number":482,"context_line":"                try:"},{"line_number":483,"context_line":"                    rescheduled \u003d flow_engine.storage.get_revert_result("},{"line_number":484,"context_line":"                        create_volume.OnFailureRescheduleTask.make_name("},{"line_number":485,"context_line":"                            [create_volume.ACTION]))"},{"line_number":486,"context_line":"                except tfe.NotFound:"},{"line_number":487,"context_line":"                    pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_9bc26733","line":484,"updated":"2015-07-22 00:16:26.000000000","message":"I wonder if u should return a name mapping from \u0027flow_engine \u003d create_volume.get_flow(\u0027 then u don\u0027t need to do this, and u can just reference the name that was used inside of it...\n\nSo it would be something like:\n\n  flow_engine, names \u003d create_volume.get_flow(...)\n\nThen later:\n\n  flow_engine.storage.get_revert_result(names[\u0027rescheduler_task\u0027])\n\nOr something like that...","commit_id":"64c36a4cf5571757107556cab2838d7fd7ecd743"}],"cinder/volume/rpcapi.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d2aaef35348e72a2936642fbbb995b0494afc36d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        1.22 - Adds create_consistencygroup_from_src."},{"line_number":66,"context_line":"        1.23 - Adds attachment_id to detach_volume."},{"line_number":67,"context_line":"        1.24 - Removed unused parameters consistencygroup_id and cgsnapshot_id"},{"line_number":68,"context_line":"               from create_volume."},{"line_number":69,"context_line":"    \u0027\u0027\u0027"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_fc4bcd29","line":68,"updated":"2015-06-29 16:32:50.000000000","message":"I don\u0027t understand this change.  Have you tested creating CG, creating a volume as part of CG, and creating CG from CG snapshot?","commit_id":"a77a9fbc2a5e5077dde185ba90bfe1c2e231386c"}]}