)]}'
{"cinder/volume/drivers/san/hp/hp_lefthand_iscsi.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"0d65fdd2ba7cd16cdaa4370771dc17d94751a07b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                            driver.SnapshotVD,"},{"line_number":53,"context_line":"                            driver.RetypeVD,"},{"line_number":54,"context_line":"                            driver.MigrateVD,"},{"line_number":55,"context_line":"                            driver.BaseVD):"},{"line_number":56,"context_line":"    \"\"\"Executes commands relating to HP/LeftHand SAN ISCSI volumes."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    Version history:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_bf8545ae","line":55,"updated":"2015-06-19 15:57:22.000000000","message":"I\u0027m still really not a fan of this at all.  What I mean is; if we want to use abc I think that\u0027s fine, but this business of an abstract class for each method and declaring those methods in an inheritance structure is just plain kookie IMO.\n\nWhy not just use abc flat out?  Just use the abc decorator on required methods and be done rather than this crazy inheritance chain and mess that\u0027s been created?  \n\nI\u0027d propose all of these \"xxxVD\" classes are dropped completely, decorators are only applied to those methods that have been determined as \"required\" and we move on.  Over time we can revisit/update the required methods if we want but I don\u0027t see any real value in using these classes.\n\nI COMPLETELY understand my rant above has NOTHING to do with your patch, I just would like to raise this before we merge any more of this craziness.","commit_id":"a8030b7cb6f8199234d85d8c7574b563e5a24fe9"}]}