)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"57c58282ac3880dffa72ed23b67ae13f026ed8ff","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Related Nova change: I8efc2628b09d4e9e59831353daa080b20e17ccde"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Depends-On: Icf12fd87e2fc4b95be8568f7d455ce6dc78d8d92"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"DocImpact: Attaching \u0027encrypted\u0027 RBD volumes to a Nova server"},{"line_number":44,"context_line":"           instance created from the libvirt virt driver will fail"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_a1002e03","line":41,"updated":"2015-07-08 19:13:21.000000000","message":"Needs to depend on I8548d41095513b9e669f773e3f35353e9228ead9 now since we moved the configuration from devstack-gate to devstack.","commit_id":"5c3251cea2c08d4dc439033b940a10d610c76a3e"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c7ecc98b7cbc2c8c0a54769d1fab38f766a21abe","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                \u0027secret_type\u0027: \u0027ceph\u0027,"},{"line_number":794,"context_line":"                \u0027secret_uuid\u0027: self.configuration.rbd_secret_uuid,"},{"line_number":795,"context_line":"                \u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":796,"context_line":"                \u0027encrypted\u0027: volume.get(\u0027encryption_key_id\u0027) is not None,"},{"line_number":797,"context_line":"            }"},{"line_number":798,"context_line":"        }"},{"line_number":799,"context_line":"        LOG.debug(\u0027connection data: %s\u0027, data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_e74d5bc5","line":796,"updated":"2015-06-22 08:40:48.000000000","message":"I would prefer to check for empty string as well:\n\n bool(volume.get(\u0027encryption_key_id\u0027))","commit_id":"b9d99b2c6de144fbd3e4de83ba1b9b4d335aaa0a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"06f6b647cdd7968a0567a104fe55be7bbf7a9b28","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                \u0027secret_type\u0027: \u0027ceph\u0027,"},{"line_number":794,"context_line":"                \u0027secret_uuid\u0027: self.configuration.rbd_secret_uuid,"},{"line_number":795,"context_line":"                \u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":796,"context_line":"                \u0027encrypted\u0027: volume.get(\u0027encryption_key_id\u0027) is not None,"},{"line_number":797,"context_line":"            }"},{"line_number":798,"context_line":"        }"},{"line_number":799,"context_line":"        LOG.debug(\u0027connection data: %s\u0027, data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_eea068f6","line":796,"in_reply_to":"fa32b979_4d3e5a8c","updated":"2015-06-24 08:25:53.000000000","message":"Matt, just because that\u0027s how it\u0027s done everywhere else doesn\u0027t seem like a good enough reason not to do it better here.  ;-)\n\nAnyway, I don\u0027t think this is an issue, that\u0027s why I didn\u0027t downvote the patch.","commit_id":"b9d99b2c6de144fbd3e4de83ba1b9b4d335aaa0a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b21a328fa370e7a171d3508526ab736c3d5946ba","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                \u0027secret_type\u0027: \u0027ceph\u0027,"},{"line_number":794,"context_line":"                \u0027secret_uuid\u0027: self.configuration.rbd_secret_uuid,"},{"line_number":795,"context_line":"                \u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":796,"context_line":"                \u0027encrypted\u0027: volume.get(\u0027encryption_key_id\u0027) is not None,"},{"line_number":797,"context_line":"            }"},{"line_number":798,"context_line":"        }"},{"line_number":799,"context_line":"        LOG.debug(\u0027connection data: %s\u0027, data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_4d3e5a8c","line":796,"in_reply_to":"fa32b979_e74d5bc5","updated":"2015-06-23 15:51:32.000000000","message":"Gorka, this is pretty much how it\u0027s handled in all other volume drivers.\n\nI\u0027ve re-opened bug 1440227 so that this can be handled in all volume drivers.  I proposed that it\u0027s checked in the volume manager after calling initialize_connection to check if the \u0027encrypted\u0027 key is in connection_info[\u0027data\u0027] and if not, set it using this same generic logic that\u0027s found in the volume drivers that are setting the key today.","commit_id":"b9d99b2c6de144fbd3e4de83ba1b9b4d335aaa0a"}]}