)]}'
{"cinder/tests/unit/test_solidfire.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"154317c08880320d302a22f624e9876dcf07e820","unresolved":false,"context_lines":[{"line_number":982,"context_line":"        with mock.patch.object(sfv,"},{"line_number":983,"context_line":"                               \u0027_issue_api_request\u0027,"},{"line_number":984,"context_line":"                               side_effect\u003d_fake_issue_api_req):"},{"line_number":985,"context_line":"            self.assertEquals(1,"},{"line_number":986,"context_line":"                              sfv._create_template_account(\u0027foo\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_a046fd78","line":985,"updated":"2015-06-23 22:23:24.000000000","message":"pep8 error:\n\n./cinder/tests/unit/test_solidfire.py:985:30: H234  assertEquals is deprecated, use assertEqual","commit_id":"2e79faee07ceaaa67b2420770d793c8c71af9312"}],"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"680fce9b8d9d1d2b8511e946d4c4f907fe0e87bf","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            id \u003d self._issue_api_request("},{"line_number":171,"context_line":"                \u0027GetAccountByName\u0027,"},{"line_number":172,"context_line":"                {\u0027username\u0027: account_name})[\u0027result\u0027][\u0027account\u0027][\u0027accountID\u0027]"},{"line_number":173,"context_line":"        except exception.SolidFireAPIException:"},{"line_number":174,"context_line":"            chap_secret \u003d self._generate_random_string(12)"},{"line_number":175,"context_line":"            params \u003d {\u0027username\u0027: account_name,"},{"line_number":176,"context_line":"                      \u0027initiatorSecret\u0027: chap_secret,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f9cd1487","line":173,"updated":"2015-06-20 15:07:17.000000000","message":"Can you add a unit test, i.e., assertRaises for this exception?","commit_id":"4c043bbd19c20554b800c9a83adcba2e95e23ed4"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"efd1379c4118c8f1a4784bfbdd30c519c202828e","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            id \u003d self._issue_api_request("},{"line_number":171,"context_line":"                \u0027GetAccountByName\u0027,"},{"line_number":172,"context_line":"                {\u0027username\u0027: account_name})[\u0027result\u0027][\u0027account\u0027][\u0027accountID\u0027]"},{"line_number":173,"context_line":"        except exception.SolidFireAPIException:"},{"line_number":174,"context_line":"            chap_secret \u003d self._generate_random_string(12)"},{"line_number":175,"context_line":"            params \u003d {\u0027username\u0027: account_name,"},{"line_number":176,"context_line":"                      \u0027initiatorSecret\u0027: chap_secret,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_cac80225","line":173,"in_reply_to":"fa32b979_d6c00fe3","updated":"2015-06-23 21:17:27.000000000","message":"Done","commit_id":"4c043bbd19c20554b800c9a83adcba2e95e23ed4"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"80253f026e02fde5afef30b299b0d84d6417cf6a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            id \u003d self._issue_api_request("},{"line_number":171,"context_line":"                \u0027GetAccountByName\u0027,"},{"line_number":172,"context_line":"                {\u0027username\u0027: account_name})[\u0027result\u0027][\u0027account\u0027][\u0027accountID\u0027]"},{"line_number":173,"context_line":"        except exception.SolidFireAPIException:"},{"line_number":174,"context_line":"            chap_secret \u003d self._generate_random_string(12)"},{"line_number":175,"context_line":"            params \u003d {\u0027username\u0027: account_name,"},{"line_number":176,"context_line":"                      \u0027initiatorSecret\u0027: chap_secret,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_d6c00fe3","line":173,"in_reply_to":"fa32b979_f953d46a","updated":"2015-06-22 07:09:04.000000000","message":"Agree with xing-yang, it will be better if a unit test is added.","commit_id":"4c043bbd19c20554b800c9a83adcba2e95e23ed4"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9c54dcfaa2a5b38e5ee49b915293be9c5a4a4765","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            id \u003d self._issue_api_request("},{"line_number":171,"context_line":"                \u0027GetAccountByName\u0027,"},{"line_number":172,"context_line":"                {\u0027username\u0027: account_name})[\u0027result\u0027][\u0027account\u0027][\u0027accountID\u0027]"},{"line_number":173,"context_line":"        except exception.SolidFireAPIException:"},{"line_number":174,"context_line":"            chap_secret \u003d self._generate_random_string(12)"},{"line_number":175,"context_line":"            params \u003d {\u0027username\u0027: account_name,"},{"line_number":176,"context_line":"                      \u0027initiatorSecret\u0027: chap_secret,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f953d46a","line":173,"in_reply_to":"fa32b979_f9cd1487","updated":"2015-06-20 15:50:00.000000000","message":"sure, the only reason I didn\u0027t was it was kinda lame that I write a mock that raises and check that this catches it... but it probably makes sense.\n\nI\u0027ll write a unit test some time this week-end.\nThanks!","commit_id":"4c043bbd19c20554b800c9a83adcba2e95e23ed4"}]}