)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1d9c9245e6fddeacb6da940dd14f70bc63f3fdc9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mitsuhiro Tanino \u003cmitsuhiro.tanino@hds.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-30 19:40:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LVM: Remove unnecessary volume export after generic volume migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we migrate an unattached volume using generic volume migration,"},{"line_number":10,"context_line":"volume export is remained at destination host after volume migration"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_a285a5cf","line":7,"updated":"2015-07-08 13:01:03.000000000","message":"Please reword to limit to 50 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"dcead71687dec17e743dace2b9a1c7714d996173"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"596204f01e2c80bd6d375b15384fef93fb0f7083","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mitsuhiro Tanino \u003cmitsuhiro.tanino@hds.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-30 19:40:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LVM: Remove unnecessary volume export after generic volume migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we migrate an unattached volume using generic volume migration,"},{"line_number":10,"context_line":"volume export is remained at destination host after volume migration"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_a597d38e","line":7,"in_reply_to":"ba3cc151_a285a5cf","updated":"2015-07-08 21:51:07.000000000","message":"Done","commit_id":"dcead71687dec17e743dace2b9a1c7714d996173"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1d9c9245e6fddeacb6da940dd14f70bc63f3fdc9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"LVM: Remove unnecessary volume export after generic volume migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we migrate an unattached volume using generic volume migration,"},{"line_number":10,"context_line":"volume export is remained at destination host after volume migration"},{"line_number":11,"context_line":"even if we succeed the volume migration."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This problem happens when the destination backend uses LVM driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_42ddb9de","line":10,"updated":"2015-07-08 13:01:03.000000000","message":"/is remained at destination/remains at the destination/","commit_id":"dcead71687dec17e743dace2b9a1c7714d996173"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"596204f01e2c80bd6d375b15384fef93fb0f7083","unresolved":false,"context_lines":[{"line_number":7,"context_line":"LVM: Remove unnecessary volume export after generic volume migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we migrate an unattached volume using generic volume migration,"},{"line_number":10,"context_line":"volume export is remained at destination host after volume migration"},{"line_number":11,"context_line":"even if we succeed the volume migration."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This problem happens when the destination backend uses LVM driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_658d4b7b","line":10,"in_reply_to":"ba3cc151_42ddb9de","updated":"2015-07-08 21:51:07.000000000","message":"Done","commit_id":"dcead71687dec17e743dace2b9a1c7714d996173"}],"cinder/tests/unit/fake_driver.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1d9c9245e6fddeacb6da940dd14f70bc63f3fdc9","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            }}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"class LoggingVolumeDriver(driver.BaseVD):"},{"line_number":121,"context_line":"    \"\"\"Logs and records calls, for unit tests.\"\"\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_42605901","line":120,"updated":"2015-07-08 13:01:03.000000000","message":"Is this necessary for this change?","commit_id":"dcead71687dec17e743dace2b9a1c7714d996173"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"596204f01e2c80bd6d375b15384fef93fb0f7083","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            }}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"class LoggingVolumeDriver(driver.BaseVD):"},{"line_number":121,"context_line":"    \"\"\"Logs and records calls, for unit tests.\"\"\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_e5c63b9b","line":120,"in_reply_to":"ba3cc151_42605901","updated":"2015-07-08 21:51:07.000000000","message":"I thought this was needed when I created this patch, but I misunderstood something. I confirmed again and this change was not necessary for this patch.","commit_id":"dcead71687dec17e743dace2b9a1c7714d996173"}],"cinder/volume/driver.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"e3ee9d51d4cb129946e4669f88e958c503e77c46","unresolved":false,"context_lines":[{"line_number":650,"context_line":"            try:"},{"line_number":651,"context_line":"                conn \u003d rpcapi.initialize_connection(context, volume,"},{"line_number":652,"context_line":"                                                    properties)"},{"line_number":653,"context_line":"                # Call remote manager\u0027s attach_volume for host attach."},{"line_number":654,"context_line":"                rpcapi.attach_volume(context, volume, None, CONF.my_ip, None,"},{"line_number":655,"context_line":"                                     \u0027ro\u0027)"},{"line_number":656,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_989b2617","line":653,"updated":"2015-06-24 07:56:45.000000000","message":"This call of attach_volume is not necessary, because the export creation is in initialize_connection. attach_volume actually does nothing, but some db changes.\nThe attach and detach do not behave in a symmetric way. During attach, export is created in initialize_connection. While export deletion is done in detach_volume not the terminate_connection.\n\nI think you can remove the line rpcapi.attach_volume, unless you have some other reasons?","commit_id":"9c8e1f5592bb7a01f8fdbaafa2e4e27de9b8b41c"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"ae806b91e64ecd494c67bc08692f5b1db9688681","unresolved":false,"context_lines":[{"line_number":650,"context_line":"            try:"},{"line_number":651,"context_line":"                conn \u003d rpcapi.initialize_connection(context, volume,"},{"line_number":652,"context_line":"                                                    properties)"},{"line_number":653,"context_line":"                # Call remote manager\u0027s attach_volume for host attach."},{"line_number":654,"context_line":"                rpcapi.attach_volume(context, volume, None, CONF.my_ip, None,"},{"line_number":655,"context_line":"                                     \u0027ro\u0027)"},{"line_number":656,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_60f763d3","line":653,"in_reply_to":"fa32b979_989b2617","updated":"2015-06-24 19:43:21.000000000","message":"During detach_volume, there is a check whether the volume has attached status in DB or not. Therefore, without attach_volume even if this method only updates DB, we can\u0027t detach the volume properly. That\u0027s why I added the attach_volume here.","commit_id":"9c8e1f5592bb7a01f8fdbaafa2e4e27de9b8b41c"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"34c7859db300b214dfff92aca51c3117e17b1ee4","unresolved":false,"context_lines":[{"line_number":364,"context_line":"            rpcapi.terminate_connection(context, volume, properties,"},{"line_number":365,"context_line":"                                        force\u003dforce)"},{"line_number":366,"context_line":"            # Call remote manager\u0027s detach_volume to remove export."},{"line_number":367,"context_line":"            rpcapi.detach_volume(context, volume, None)"},{"line_number":368,"context_line":"        else:"},{"line_number":369,"context_line":"            # Call local driver\u0027s terminate_connection and remove export."},{"line_number":370,"context_line":"            # NOTE(avishay) This is copied from the manager\u0027s code - need to"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_323171a3","line":367,"updated":"2015-07-12 01:49:26.000000000","message":"remote manager\u0027s detach_volume method doesn\u0027t really remove export in case of LVM driver.  So this doesn\u0027t really fix the problem.","commit_id":"b180db56918298137b137dbf770f90b977db52ab"}]}