)]}'
{"cinder/api/contrib/quotas.py":[{"author":{"_account_id":11057,"name":"sajeesh cs","email":"sajeesh.cs@cern.ch","username":"sajeeshcs"},"change_message_id":"d5a1de1841eb7f8433d3e10cb95772b2346d41e6","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    @wsgi.serializers(xml\u003dQuotaTemplate)"},{"line_number":146,"context_line":"    def defaults(self, req, id):"},{"line_number":147,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":148,"context_line":"        authorize_show(context)"},{"line_number":149,"context_line":"        return self._format_quota_set(id,"},{"line_number":150,"context_line":"                                      QUOTAS.get_defaults(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_48ea61d9","line":147,"updated":"2015-06-25 14:45:33.000000000","message":"I think ,in this function you have to make a keystone call to find the parent_id.Based on that, your default resource values will change. If the parent_id is not None , then default quota values will be zero","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"a943b7ea06ed7453e0832552b2ae508ce6eedb2e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":148,"context_line":"        authorize_show(context)"},{"line_number":149,"context_line":"        return self._format_quota_set(id,"},{"line_number":150,"context_line":"                                      QUOTAS.get_defaults(context,"},{"line_number":151,"context_line":"                                                          parent_id\u003dNone))"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @wsgi.serializers(xml\u003dQuotaTemplate)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_83a74e0a","line":150,"updated":"2015-06-25 11:50:54.000000000","message":"as you\u0027ve defined def get_defaults(self, context, resources, parent_id\u003dNone):\"  in cinder/quotas.py, you don\u0027t need to pass parent_id\u003dNone here.","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":11057,"name":"sajeesh cs","email":"sajeesh.cs@cern.ch","username":"sajeeshcs"},"change_message_id":"d5a1de1841eb7f8433d3e10cb95772b2346d41e6","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":148,"context_line":"        authorize_show(context)"},{"line_number":149,"context_line":"        return self._format_quota_set(id,"},{"line_number":150,"context_line":"                                      QUOTAS.get_defaults(context,"},{"line_number":151,"context_line":"                                                          parent_id\u003dNone))"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @wsgi.serializers(xml\u003dQuotaTemplate)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_fc3b02e8","line":150,"in_reply_to":"fa32b979_83a74e0a","updated":"2015-06-25 14:45:33.000000000","message":"This  should be QUOTAS.get_defaults(context, parent_id\u003dparent_id)","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"}],"cinder/quota.py":[{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"a943b7ea06ed7453e0832552b2ae508ce6eedb2e","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        return db.quota_class_get(context, quota_class, resource_name)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def get_default(self, context, resource):"},{"line_number":101,"context_line":"        \"\"\"Get a specific default quota for a resource.\"\"\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        default_quotas \u003d db.quota_class_get_default(context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_a34b7286","line":100,"updated":"2015-06-25 11:50:54.000000000","message":"Don\u0027t we need to pass \u0027parent_id\u0027 here too?","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":11057,"name":"sajeesh cs","email":"sajeesh.cs@cern.ch","username":"sajeeshcs"},"change_message_id":"d5a1de1841eb7f8433d3e10cb95772b2346d41e6","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        return db.quota_class_get(context, quota_class, resource_name)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def get_default(self, context, resource):"},{"line_number":101,"context_line":"        \"\"\"Get a specific default quota for a resource.\"\"\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        default_quotas \u003d db.quota_class_get_default(context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_fce782e0","line":100,"in_reply_to":"fa32b979_a34b7286","updated":"2015-06-25 14:45:33.000000000","message":"+1 parent id should be there","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"a943b7ea06ed7453e0832552b2ae508ce6eedb2e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \"\"\"Get a specific default quota for a resource.\"\"\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        default_quotas \u003d db.quota_class_get_default(context)"},{"line_number":104,"context_line":"        return default_quotas.get(resource.name, resource.default)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_defaults(self, context, resources, parent_id\u003dNone):"},{"line_number":107,"context_line":"        \"\"\"Given a list of resources, retrieve the default quotas."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_03533e3a","line":104,"updated":"2015-06-25 11:50:54.000000000","message":"If we need to pass \u0027parent_id\u0027, the return must be changed.","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":11057,"name":"sajeesh cs","email":"sajeesh.cs@cern.ch","username":"sajeeshcs"},"change_message_id":"d5a1de1841eb7f8433d3e10cb95772b2346d41e6","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \"\"\"Get a specific default quota for a resource.\"\"\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        default_quotas \u003d db.quota_class_get_default(context)"},{"line_number":104,"context_line":"        return default_quotas.get(resource.name, resource.default)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_defaults(self, context, resources, parent_id\u003dNone):"},{"line_number":107,"context_line":"        \"\"\"Given a list of resources, retrieve the default quotas."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_a31d4e63","line":104,"in_reply_to":"fa32b979_03533e3a","updated":"2015-06-25 14:45:33.000000000","message":"+1","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"df5767749bc9c29abc6e2b4ea18245aae1addc95","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                    \"it is now deprecated. Please use the \""},{"line_number":127,"context_line":"                    \"default quota class for default \""},{"line_number":128,"context_line":"                    \"quota.\") % {\u0027res\u0027: resource.name})"},{"line_number":129,"context_line":"            if parent_id is not None:"},{"line_number":130,"context_line":"                if not resource.flag:"},{"line_number":131,"context_line":"                    quotas[resource.name] \u003d"},{"line_number":132,"context_line":"                        default_quotas.get(resource.name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_d031c80c","line":129,"updated":"2015-06-22 23:55:33.000000000","message":"you can collapse lines 129 to 138 into:\n\n  if parent_id and not resource.flag:\n      quotas[resource.name] \u003d 0\n  else:\n      quotas[resource.name] \u003d default_quotas.get(resource.name,\n                               resource.default)","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"a943b7ea06ed7453e0832552b2ae508ce6eedb2e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                    \"quota.\") % {\u0027res\u0027: resource.name})"},{"line_number":129,"context_line":"            if parent_id is not None:"},{"line_number":130,"context_line":"                if not resource.flag:"},{"line_number":131,"context_line":"                    quotas[resource.name] \u003d"},{"line_number":132,"context_line":"                        default_quotas.get(resource.name,"},{"line_number":133,"context_line":"                                           resource.default)"},{"line_number":134,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_c3cd5632","line":131,"updated":"2015-06-25 11:50:54.000000000","message":"Why do you need to check resource.flag? I think you can just do:\n\nquotas[resource.name] \u003d default_quotas.get(resource.name, 0 if parent_id else resource.default)","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"a943b7ea06ed7453e0832552b2ae508ce6eedb2e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        return quotas"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def get_class_quotas(self, context, resources, quota_class,"},{"line_number":143,"context_line":"                         defaults\u003dTrue):"},{"line_number":144,"context_line":"        \"\"\"Given list of resources, retrieve the quotas for given quota class."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        :param context: The request context, for access checks."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_4324e6c3","line":143,"updated":"2015-06-25 11:50:54.000000000","message":"Don\u0027t we need to pass \u0027parent_id\u0027 here too?","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":11057,"name":"sajeesh cs","email":"sajeesh.cs@cern.ch","username":"sajeeshcs"},"change_message_id":"d5a1de1841eb7f8433d3e10cb95772b2346d41e6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        return quotas"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def get_class_quotas(self, context, resources, quota_class,"},{"line_number":143,"context_line":"                         defaults\u003dTrue):"},{"line_number":144,"context_line":"        \"\"\"Given list of resources, retrieve the quotas for given quota class."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        :param context: The request context, for access checks."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_e37a76f0","line":143,"in_reply_to":"fa32b979_4324e6c3","updated":"2015-06-25 14:45:33.000000000","message":"We have to think about it .","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"a943b7ea06ed7453e0832552b2ae508ce6eedb2e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                quotas[resource.name] \u003d class_quotas[resource.name]"},{"line_number":163,"context_line":"                continue"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            if defaults:"},{"line_number":166,"context_line":"                quotas[resource.name] \u003d default_quotas.get(resource.name,"},{"line_number":167,"context_line":"                                                           resource.default)"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_665578c0","line":165,"updated":"2015-06-25 11:50:54.000000000","message":"If we need to pass \u0027parent_id\u0027 as argument of get_class_quotas(...), this should be changed in order to be return 0 when the current project is a subpoject (project_id !\u003d None).","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"a943b7ea06ed7453e0832552b2ae508ce6eedb2e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                                                           resource.default)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        return quotas"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def get_project_quotas(self, context, resources, project_id,"},{"line_number":172,"context_line":"                           quota_class\u003dNone, defaults\u003dTrue,"},{"line_number":173,"context_line":"                           usages\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_660c98ec","line":170,"updated":"2015-06-25 11:50:54.000000000","message":"Don\u0027t we need to pass \u0027parent_id\u0027 here too?","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":11057,"name":"sajeesh cs","email":"sajeesh.cs@cern.ch","username":"sajeeshcs"},"change_message_id":"d5a1de1841eb7f8433d3e10cb95772b2346d41e6","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                                                           resource.default)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        return quotas"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def get_project_quotas(self, context, resources, project_id,"},{"line_number":172,"context_line":"                           quota_class\u003dNone, defaults\u003dTrue,"},{"line_number":173,"context_line":"                           usages\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_484261ac","line":170,"in_reply_to":"fa32b979_660c98ec","updated":"2015-06-25 14:45:33.000000000","message":"yes","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"a943b7ea06ed7453e0832552b2ae508ce6eedb2e","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        else:"},{"line_number":208,"context_line":"            class_quotas \u003d {}"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        default_quotas \u003d self.get_defaults(context, resources, parent_id\u003dNone)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        for resource in resources.values():"},{"line_number":213,"context_line":"            # Omit default/quota class values"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_a62700b5","line":210,"updated":"2015-06-25 11:50:54.000000000","message":"If we need to pass \u0027parent_id\u0027 as argument of get_project_quotas(...), we can just pass \u0027parent_id\u003dparent_id\u0027 here.","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":11057,"name":"sajeesh cs","email":"sajeesh.cs@cern.ch","username":"sajeeshcs"},"change_message_id":"d5a1de1841eb7f8433d3e10cb95772b2346d41e6","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        else:"},{"line_number":208,"context_line":"            class_quotas \u003d {}"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        default_quotas \u003d self.get_defaults(context, resources, parent_id\u003dNone)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        for resource in resources.values():"},{"line_number":213,"context_line":"            # Omit default/quota class values"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_1c14a69d","line":210,"in_reply_to":"fa32b979_a62700b5","updated":"2015-06-25 14:45:33.000000000","message":"+1","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"a943b7ea06ed7453e0832552b2ae508ce6eedb2e","unresolved":false,"context_lines":[{"line_number":499,"context_line":"    @property"},{"line_number":500,"context_line":"    def default(self):"},{"line_number":501,"context_line":"        \"\"\"Return the default value of the quota.\"\"\""},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        return CONF[self.flag] if self.flag else -1"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_a1cc716a","line":502,"updated":"2015-06-25 11:50:54.000000000","message":"Don\u0027t we have to see here if the current project is a subproject and return 0 in this case?","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":11057,"name":"sajeesh cs","email":"sajeesh.cs@cern.ch","username":"sajeeshcs"},"change_message_id":"d5a1de1841eb7f8433d3e10cb95772b2346d41e6","unresolved":false,"context_lines":[{"line_number":499,"context_line":"    @property"},{"line_number":500,"context_line":"    def default(self):"},{"line_number":501,"context_line":"        \"\"\"Return the default value of the quota.\"\"\""},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        return CONF[self.flag] if self.flag else -1"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_dc807ec1","line":502,"in_reply_to":"fa32b979_a1cc716a","updated":"2015-06-25 14:45:33.000000000","message":"Yes, if this function is used for finding the default quota","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"03926fc06407c02457c426b8facb4202f599a830","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        if it exists."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        :param context: The request context, for access checks."},{"line_number":113,"context_line":"        :param resources: A dictionary of the registered resources."},{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        quotas \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_7b052d78","line":113,"updated":"2015-07-01 07:44:42.000000000","message":"missing param parent_id","commit_id":"1ec47aed225462950460439a13caa93c35cd9475"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"98a2a80f7bd35ac5859ff670817009c82aeb4123","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        if it exists."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        :param context: The request context, for access checks."},{"line_number":113,"context_line":"        :param resources: A dictionary of the registered resources."},{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        quotas \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_04203647","line":113,"in_reply_to":"ba3cc151_7b052d78","updated":"2015-07-01 12:12:17.000000000","message":"Done","commit_id":"1ec47aed225462950460439a13caa93c35cd9475"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"03926fc06407c02457c426b8facb4202f599a830","unresolved":false,"context_lines":[{"line_number":639,"context_line":"    def get_defaults(self, context, parent_id\u003dNone):"},{"line_number":640,"context_line":"        \"\"\"Retrieve the default quotas."},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        :param context: The request context, for access checks."},{"line_number":643,"context_line":"        \"\"\""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        return self._driver.get_defaults(context, self.resources, parent_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_fbf93d81","line":642,"updated":"2015-07-01 07:44:42.000000000","message":"missing param parent_id","commit_id":"1ec47aed225462950460439a13caa93c35cd9475"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"98a2a80f7bd35ac5859ff670817009c82aeb4123","unresolved":false,"context_lines":[{"line_number":639,"context_line":"    def get_defaults(self, context, parent_id\u003dNone):"},{"line_number":640,"context_line":"        \"\"\"Retrieve the default quotas."},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        :param context: The request context, for access checks."},{"line_number":643,"context_line":"        \"\"\""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        return self._driver.get_defaults(context, self.resources, parent_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_a4186a1f","line":642,"in_reply_to":"ba3cc151_fbf93d81","updated":"2015-07-01 12:12:17.000000000","message":"Done","commit_id":"1ec47aed225462950460439a13caa93c35cd9475"}],"cinder/tests/unit/test_quota.py":[{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"a943b7ea06ed7453e0832552b2ae508ce6eedb2e","unresolved":false,"context_lines":[{"line_number":553,"context_line":"        parent_id \u003d None"},{"line_number":554,"context_line":"        driver \u003d FakeDriver()"},{"line_number":555,"context_line":"        quota_obj \u003d self._make_quota_obj(driver)"},{"line_number":556,"context_line":"        result \u003d quota_obj.get_defaults(context, parent_id)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        self.assertEqual(driver.called, [(\u0027get_defaults\u0027,"},{"line_number":559,"context_line":"                                          context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_414fa591","line":556,"updated":"2015-06-25 11:50:54.000000000","message":"The default value of parent_id is already None, so we don\u0027t need to change this test.","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"a943b7ea06ed7453e0832552b2ae508ce6eedb2e","unresolved":false,"context_lines":[{"line_number":845,"context_line":"        self._stub_volume_type_get_all()"},{"line_number":846,"context_line":"        parent_id \u003d None"},{"line_number":847,"context_line":"        result \u003d self.driver.get_defaults(None,"},{"line_number":848,"context_line":"                                          quota.QUOTAS.resources,"},{"line_number":849,"context_line":"                                          parent_id)"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_81284d98","line":848,"updated":"2015-06-25 11:50:54.000000000","message":"The default value of parent_id is already None, so we don\u0027t need to change this test.","commit_id":"814a809475896550fd654b3e4e5607a637a6bf7b"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"a2290e64773bf98477b20490802282cced6fed27","unresolved":false,"context_lines":[{"line_number":875,"context_line":"                gigabytes\u003d0,"},{"line_number":876,"context_line":"                backups\u003d0,"},{"line_number":877,"context_line":"                backup_gigabytes\u003d0,"},{"line_number":878,"context_line":"                per_volume_gigabytes\u003d0))"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"    def _stub_quota_class_get_default(self):"},{"line_number":881,"context_line":"        # Stub out quota_class_get_default"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_406e3802","line":878,"updated":"2015-07-01 07:19:03.000000000","message":"expected, actual","commit_id":"1ec47aed225462950460439a13caa93c35cd9475"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"98a2a80f7bd35ac5859ff670817009c82aeb4123","unresolved":false,"context_lines":[{"line_number":875,"context_line":"                gigabytes\u003d0,"},{"line_number":876,"context_line":"                backups\u003d0,"},{"line_number":877,"context_line":"                backup_gigabytes\u003d0,"},{"line_number":878,"context_line":"                per_volume_gigabytes\u003d0))"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"    def _stub_quota_class_get_default(self):"},{"line_number":881,"context_line":"        # Stub out quota_class_get_default"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_8433e6aa","line":878,"in_reply_to":"ba3cc151_406e3802","updated":"2015-07-01 12:12:17.000000000","message":"just to keep consistency with the other tests, we are following the same pattern, as you can see here, for example: https://github.com/openstack/cinder/blob/master/cinder/tests/unit/test_quota.py#L847","commit_id":"1ec47aed225462950460439a13caa93c35cd9475"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8e6a19b6d235774062b6c55aece0057c6feda311","unresolved":false,"context_lines":[{"line_number":621,"context_line":"             False,"},{"line_number":622,"context_line":"             False,"},{"line_number":623,"context_line":"             parent_project_id), ])"},{"line_number":624,"context_line":"        self.assertEqual(result1, quota_obj.resources)"},{"line_number":625,"context_line":"        self.assertEqual(result2, quota_obj.resources)"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def test_get_subproject_quotas(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_b26e3a2d","line":624,"updated":"2015-07-08 20:30:05.000000000","message":"assertEqual argument order should be (expected, actual).","commit_id":"828894e4daefeee4b90a4e13d5c28faf88857312"}]}