)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"4225d6056d69d84e29e32b3779d390b24bde40cb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to volume UUID in volume\u0027s vCenter config file so"},{"line_number":11,"context_line":"that other VMware solutions can uniquely identify"},{"line_number":12,"context_line":"Cinder volumes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I08a5f1a39def14f164ab3ca08a480310ce0b79ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a50d1a3_d9eab474","line":13,"updated":"2015-07-30 05:52:49.000000000","message":"Bug or bp link?","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8b590bbb6e037bd1bac0ae77e236e81c79091def","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to volume UUID in volume\u0027s vCenter config file so"},{"line_number":11,"context_line":"that other VMware solutions can uniquely identify"},{"line_number":12,"context_line":"Cinder volumes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I08a5f1a39def14f164ab3ca08a480310ce0b79ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_3ce7e4ad","line":13,"in_reply_to":"1a4dcd0f_580b417d","updated":"2015-08-10 06:02:02.000000000","message":"Vincent,\n\nThere is no bug associated with this patch. As mentioned by some of the cores, a bp is not required for a small driver feature.\n\nKurt,\n\nThe bug you referred is fixed by https://review.openstack.org/205494","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"a72ea8375136ea604f0b5770e5d55d8687825f4e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to volume UUID in volume\u0027s vCenter config file so"},{"line_number":11,"context_line":"that other VMware solutions can uniquely identify"},{"line_number":12,"context_line":"Cinder volumes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I08a5f1a39def14f164ab3ca08a480310ce0b79ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_580b417d","line":13,"in_reply_to":"3a50d1a3_d9eab474","updated":"2015-08-06 17:16:47.000000000","message":"Please include Closes-Bug: 1475738, see http://docs.openstack.org/infra/manual/developers.html#committing-a-change","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"}],"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"fabaafd7534edc4f8d279078ec62c4be3205ba2c","unresolved":false,"context_lines":[{"line_number":1612,"context_line":"        disk_type \u003d VMwareEsxVmdkDriver._get_disk_type(volume)"},{"line_number":1613,"context_line":"        extra_config \u003d self._get_extra_config(volume)"},{"line_number":1614,"context_line":"        vm_create_spec \u003d self.volumeops.get_create_spec("},{"line_number":1615,"context_line":"            name, 0, disk_type, summary.name, profile_id,"},{"line_number":1616,"context_line":"            extra_config\u003dextra_config)"},{"line_number":1617,"context_line":"        vm_import_spec.configSpec \u003d vm_create_spec"},{"line_number":1618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_15b4e9ef","line":1615,"updated":"2015-06-23 11:52:20.000000000","message":"I just suggest you explain a bit why 0 here and what it means.","commit_id":"4a614ae5d2fe677eb33e51bfdf3d86ceecf640c2"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b4760e80862461b8366c3b7fa74d52e7a4110910","unresolved":false,"context_lines":[{"line_number":1612,"context_line":"        disk_type \u003d VMwareEsxVmdkDriver._get_disk_type(volume)"},{"line_number":1613,"context_line":"        extra_config \u003d self._get_extra_config(volume)"},{"line_number":1614,"context_line":"        vm_create_spec \u003d self.volumeops.get_create_spec("},{"line_number":1615,"context_line":"            name, 0, disk_type, summary.name, profile_id,"},{"line_number":1616,"context_line":"            extra_config\u003dextra_config)"},{"line_number":1617,"context_line":"        vm_import_spec.configSpec \u003d vm_create_spec"},{"line_number":1618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_509b5fc9","line":1615,"in_reply_to":"fa32b979_15b4e9ef","updated":"2015-06-23 12:06:28.000000000","message":"The second argument is disk size.\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/vmware/volumeops.py#L720\n\nWe don\u0027t know the final disk size when we create a virtual disk from streamOptimized  disk image. So we set it to zero.\n\nAfter we create this disk, we stream data from streamOptimized disk image to vCenter (line 1623). vCenter sets the disk size correctly once the streaming operation finishes.\n\nAlso see line 1104. I will add a comment in a separate patch if needed.","commit_id":"4a614ae5d2fe677eb33e51bfdf3d86ceecf640c2"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"04ba98652a6742362611b508934760b5a7f19faa","unresolved":false,"context_lines":[{"line_number":1612,"context_line":"        disk_type \u003d VMwareEsxVmdkDriver._get_disk_type(volume)"},{"line_number":1613,"context_line":"        extra_config \u003d self._get_extra_config(volume)"},{"line_number":1614,"context_line":"        vm_create_spec \u003d self.volumeops.get_create_spec("},{"line_number":1615,"context_line":"            name, 0, disk_type, summary.name, profile_id,"},{"line_number":1616,"context_line":"            extra_config\u003dextra_config)"},{"line_number":1617,"context_line":"        vm_import_spec.configSpec \u003d vm_create_spec"},{"line_number":1618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_d052da66","line":1615,"in_reply_to":"fa32b979_358a2365","updated":"2015-06-24 12:04:19.000000000","message":"Done","commit_id":"4a614ae5d2fe677eb33e51bfdf3d86ceecf640c2"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"ede4bdf3346229da87991939460d45cff30ce4c0","unresolved":false,"context_lines":[{"line_number":1612,"context_line":"        disk_type \u003d VMwareEsxVmdkDriver._get_disk_type(volume)"},{"line_number":1613,"context_line":"        extra_config \u003d self._get_extra_config(volume)"},{"line_number":1614,"context_line":"        vm_create_spec \u003d self.volumeops.get_create_spec("},{"line_number":1615,"context_line":"            name, 0, disk_type, summary.name, profile_id,"},{"line_number":1616,"context_line":"            extra_config\u003dextra_config)"},{"line_number":1617,"context_line":"        vm_import_spec.configSpec \u003d vm_create_spec"},{"line_number":1618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_358a2365","line":1615,"in_reply_to":"fa32b979_509b5fc9","updated":"2015-06-24 06:57:53.000000000","message":"OK, I think a comment or some meaningful arg replacing 0 will be helpful here","commit_id":"4a614ae5d2fe677eb33e51bfdf3d86ceecf640c2"},{"author":{"_account_id":6498,"name":"Divakar Padiyar Nandavar","email":"divakar.padiyar-nandavar@hpe.com","username":"divakar-padiyar-nandavar"},"change_message_id":"a90cd9d4dd572c17850a34b70cbdeae5ccb37cf8","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"        # The size of stream optimized glance image is often suspect,"},{"line_number":1103,"context_line":"        # so better let VC figure out the disk capacity during import."},{"line_number":1104,"context_line":"        dummy_disk_size \u003d 0"},{"line_number":1105,"context_line":"        extra_config \u003d self._get_extra_config(volume)"},{"line_number":1106,"context_line":"        vm_create_spec \u003d self.volumeops.get_create_spec(volume[\u0027name\u0027],"},{"line_number":1107,"context_line":"                                                        dummy_disk_size,"},{"line_number":1108,"context_line":"                                                        disk_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_e4501561","line":1105,"updated":"2015-07-24 10:28:03.000000000","message":"Why aren\u0027t you using the annotations for this?","commit_id":"9b48be51c39f231cd671d59f69f9d20a16815633"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"17646c4f273416a5faf9a917553c3d4841501e20","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"                                                        summary.name,"},{"line_number":1130,"context_line":"                                                        profile_id,"},{"line_number":1131,"context_line":"                                                        adapter_type,"},{"line_number":1132,"context_line":"                                                        extra_config)"},{"line_number":1133,"context_line":"        # convert vm_create_spec to vm_import_spec"},{"line_number":1134,"context_line":"        cf \u003d self.session.vim.client.factory"},{"line_number":1135,"context_line":"        vm_import_spec \u003d cf.create(\u0027ns0:VirtualMachineImportSpec\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_7faa221b","line":1132,"updated":"2015-08-10 15:40:06.000000000","message":"extra_config\u003dextra_config","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"4849d3eadbc76219ee6f5d8fec82706d9750d22d","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"                                                        summary.name,"},{"line_number":1130,"context_line":"                                                        profile_id,"},{"line_number":1131,"context_line":"                                                        adapter_type,"},{"line_number":1132,"context_line":"                                                        extra_config)"},{"line_number":1133,"context_line":"        # convert vm_create_spec to vm_import_spec"},{"line_number":1134,"context_line":"        cf \u003d self.session.vim.client.factory"},{"line_number":1135,"context_line":"        vm_import_spec \u003d cf.create(\u0027ns0:VirtualMachineImportSpec\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_6f700bdd","line":1132,"in_reply_to":"1a4dcd0f_7faa221b","updated":"2015-08-11 10:40:58.000000000","message":"Done","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"fb041b03cabb0e1271e39ee21ccf67a3ac020a74","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                profile_id \u003d profile.uniqueId"},{"line_number":417,"context_line":"        return profile_id"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def _get_extra_config(self, volume):"},{"line_number":420,"context_line":"        return {EXTRA_CONFIG_VOLUME_ID_KEY: volume[\u0027id\u0027]}"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def _create_backing(self, volume, host\u003dNone, create_params\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_c393f359","line":419,"updated":"2015-08-12 13:34:15.000000000","message":"Shouldn\u0027t this method be @staticmethod ?","commit_id":"cb98bb48f1af590ecdc0f5e064fdad31ef61eec8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bbe0a87597da032a1faa3cc6ec3529029243d249","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                profile_id \u003d profile.uniqueId"},{"line_number":417,"context_line":"        return profile_id"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def _get_extra_config(self, volume):"},{"line_number":420,"context_line":"        return {EXTRA_CONFIG_VOLUME_ID_KEY: volume[\u0027id\u0027]}"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def _create_backing(self, volume, host\u003dNone, create_params\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_db8bc1c1","line":419,"in_reply_to":"1a4dcd0f_c393f359","updated":"2015-08-12 21:21:33.000000000","message":"@staticmethod is only valuable for public methods.","commit_id":"cb98bb48f1af590ecdc0f5e064fdad31ef61eec8"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"af7d0d634d5290b4df26eac27d1575eff435ed47","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                profile_id \u003d profile.uniqueId"},{"line_number":417,"context_line":"        return profile_id"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def _get_extra_config(self, volume):"},{"line_number":420,"context_line":"        return {EXTRA_CONFIG_VOLUME_ID_KEY: volume[\u0027id\u0027]}"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def _create_backing(self, volume, host\u003dNone, create_params\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_1ebdae67","line":419,"in_reply_to":"1a4dcd0f_c393f359","updated":"2015-08-12 13:52:56.000000000","message":"Cyril,\n\nThe plan is to extend it in future to add additional info to the volume backing. One example is to add a vCenter extension key to the volume backing which will require access to instance variables.","commit_id":"cb98bb48f1af590ecdc0f5e064fdad31ef61eec8"}],"cinder/volume/drivers/vmware/volumeops.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"17646c4f273416a5faf9a917553c3d4841501e20","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        :return: spec for creation"},{"line_number":751,"context_line":"        \"\"\""},{"line_number":752,"context_line":"        create_spec \u003d self._get_create_spec_disk_less(name, ds_name, profileId,"},{"line_number":753,"context_line":"                                                      extra_config)"},{"line_number":754,"context_line":"        create_spec.deviceChange \u003d self._create_specs_for_disk_add("},{"line_number":755,"context_line":"            size_kb, disk_type, adapter_type)"},{"line_number":756,"context_line":"        return create_spec"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_bf0c2a43","line":753,"updated":"2015-08-10 15:40:06.000000000","message":"profileId\u003dprofileId, extra_config\u003dextra_config","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"4849d3eadbc76219ee6f5d8fec82706d9750d22d","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        :return: spec for creation"},{"line_number":751,"context_line":"        \"\"\""},{"line_number":752,"context_line":"        create_spec \u003d self._get_create_spec_disk_less(name, ds_name, profileId,"},{"line_number":753,"context_line":"                                                      extra_config)"},{"line_number":754,"context_line":"        create_spec.deviceChange \u003d self._create_specs_for_disk_add("},{"line_number":755,"context_line":"            size_kb, disk_type, adapter_type)"},{"line_number":756,"context_line":"        return create_spec"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_ef7c1bb7","line":753,"in_reply_to":"1a4dcd0f_bf0c2a43","updated":"2015-08-11 10:40:58.000000000","message":"Done","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"17646c4f273416a5faf9a917553c3d4841501e20","unresolved":false,"context_lines":[{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        create_spec \u003d self.get_create_spec(name, size_kb, disk_type, ds_name,"},{"line_number":800,"context_line":"                                           profileId, adapter_type,"},{"line_number":801,"context_line":"                                           extra_config)"},{"line_number":802,"context_line":"        return self._create_backing_int(folder, resource_pool, host,"},{"line_number":803,"context_line":"                                        create_spec)"},{"line_number":804,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_92184577","line":801,"updated":"2015-08-10 15:40:06.000000000","message":"profileId\u003dprofileId, adapter_type\u003dadapter_type, extra_config\u003dextra_config","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"4849d3eadbc76219ee6f5d8fec82706d9750d22d","unresolved":false,"context_lines":[{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        create_spec \u003d self.get_create_spec(name, size_kb, disk_type, ds_name,"},{"line_number":800,"context_line":"                                           profileId, adapter_type,"},{"line_number":801,"context_line":"                                           extra_config)"},{"line_number":802,"context_line":"        return self._create_backing_int(folder, resource_pool, host,"},{"line_number":803,"context_line":"                                        create_spec)"},{"line_number":804,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_4f442f73","line":801,"in_reply_to":"1a4dcd0f_92184577","updated":"2015-08-11 10:40:58.000000000","message":"Done","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"17646c4f273416a5faf9a917553c3d4841501e20","unresolved":false,"context_lines":[{"line_number":830,"context_line":"                   \u0027ds_name\u0027: ds_name})"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        create_spec \u003d self._get_create_spec_disk_less(name, ds_name, profileId,"},{"line_number":833,"context_line":"                                                      extra_config)"},{"line_number":834,"context_line":"        return self._create_backing_int(folder, resource_pool, host,"},{"line_number":835,"context_line":"                                        create_spec)"},{"line_number":836,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_922fe587","line":833,"updated":"2015-08-10 15:40:06.000000000","message":"profileId\u003dprofileId, extra_config\u003dextra_config","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"4849d3eadbc76219ee6f5d8fec82706d9750d22d","unresolved":false,"context_lines":[{"line_number":830,"context_line":"                   \u0027ds_name\u0027: ds_name})"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        create_spec \u003d self._get_create_spec_disk_less(name, ds_name, profileId,"},{"line_number":833,"context_line":"                                                      extra_config)"},{"line_number":834,"context_line":"        return self._create_backing_int(folder, resource_pool, host,"},{"line_number":835,"context_line":"                                        create_spec)"},{"line_number":836,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_0f5f0742","line":833,"in_reply_to":"1a4dcd0f_922fe587","updated":"2015-08-11 10:40:58.000000000","message":"Done","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"17646c4f273416a5faf9a917553c3d4841501e20","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"            disk_move_type \u003d \u0027moveAllDiskBackingsAndDisallowSharing\u0027"},{"line_number":1130,"context_line":"        clone_spec \u003d self._get_clone_spec(datastore, disk_move_type, snapshot,"},{"line_number":1131,"context_line":"                                          backing, disk_type, host,"},{"line_number":1132,"context_line":"                                          resource_pool, extra_config)"},{"line_number":1133,"context_line":"        task \u003d self._session.invoke_api(self._session.vim, \u0027CloneVM_Task\u0027,"},{"line_number":1134,"context_line":"                                        backing, folder\u003dfolder, name\u003dname,"},{"line_number":1135,"context_line":"                                        spec\u003dclone_spec)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_d2632ddc","line":1132,"updated":"2015-08-10 15:40:06.000000000","message":"please use named options for all parameters that the definition names.\n\nhost\u003dhost, resource_pool\u003dresource_pool, extra_config\u003dextra_config","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"4849d3eadbc76219ee6f5d8fec82706d9750d22d","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"            disk_move_type \u003d \u0027moveAllDiskBackingsAndDisallowSharing\u0027"},{"line_number":1130,"context_line":"        clone_spec \u003d self._get_clone_spec(datastore, disk_move_type, snapshot,"},{"line_number":1131,"context_line":"                                          backing, disk_type, host,"},{"line_number":1132,"context_line":"                                          resource_pool, extra_config)"},{"line_number":1133,"context_line":"        task \u003d self._session.invoke_api(self._session.vim, \u0027CloneVM_Task\u0027,"},{"line_number":1134,"context_line":"                                        backing, folder\u003dfolder, name\u003dname,"},{"line_number":1135,"context_line":"                                        spec\u003dclone_spec)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_6f3ecbdb","line":1132,"in_reply_to":"1a4dcd0f_d2632ddc","updated":"2015-08-11 10:40:58.000000000","message":"Done","commit_id":"1d1582f65302d9484d1a2be334cf0d82b8666137"}]}