)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e81f19187c526328789ffd65f4a644af80d5cd81","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Stinner \u003cvstinner@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-23 12:27:52 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port test_backup_ceph and test_rbd to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add cinder.utils.convert_str() function: helper to convert a string to"},{"line_number":10,"context_line":"  a native string: convert to bytes on Python 2, convert to Unicode on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_c8054610","line":7,"updated":"2015-06-24 14:49:05.000000000","message":"Please, add note to the message header that you added changed to RBDDriver too","commit_id":"9fce33357ef0627c22ca4a621d3efe670841bbea"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"4a4be9957252df2bfbf4d220a102c33aed794292","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Stinner \u003cvstinner@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-23 12:27:52 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port test_backup_ceph and test_rbd to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add cinder.utils.convert_str() function: helper to convert a string to"},{"line_number":10,"context_line":"  a native string: convert to bytes on Python 2, convert to Unicode on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_adcc9135","line":7,"in_reply_to":"fa32b979_aa1d5774","updated":"2015-06-24 15:29:12.000000000","message":"Thank you, Victor","commit_id":"9fce33357ef0627c22ca4a621d3efe670841bbea"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"e9a7793cad57ea4ed40b4656e1c5006e2532854d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Stinner \u003cvstinner@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-23 12:27:52 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port test_backup_ceph and test_rbd to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add cinder.utils.convert_str() function: helper to convert a string to"},{"line_number":10,"context_line":"  a native string: convert to bytes on Python 2, convert to Unicode on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_aa1d5774","line":7,"in_reply_to":"fa32b979_c8054610","updated":"2015-06-24 15:19:04.000000000","message":"Ok, I rewrote the title of all patches of the patch serie to be more accurate.","commit_id":"9fce33357ef0627c22ca4a621d3efe670841bbea"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"83bad4a98a11b53e34b1ca269aa0f85ac421ab27","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port test_backup_ceph and test_rbd to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add cinder.utils.convert_str() function: helper to convert a string to"},{"line_number":10,"context_line":"  a native string: convert to bytes on Python 2, convert to Unicode on"},{"line_number":11,"context_line":"  Python 3. Function needed by ceph and rbd drivers."},{"line_number":12,"context_line":"* Replace encodeutils.safe_encode() with utils.convert_str()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_72d9c856","line":9,"updated":"2015-06-23 12:39:20.000000000","message":"Why we add it to cinder not oslo?","commit_id":"9fce33357ef0627c22ca4a621d3efe670841bbea"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"529cbfe447757076bf202affcf4a03a4fe2ffdf0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port test_backup_ceph and test_rbd to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add cinder.utils.convert_str() function: helper to convert a string to"},{"line_number":10,"context_line":"  a native string: convert to bytes on Python 2, convert to Unicode on"},{"line_number":11,"context_line":"  Python 3. Function needed by ceph and rbd drivers."},{"line_number":12,"context_line":"* Replace encodeutils.safe_encode() with utils.convert_str()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_98efcdb0","line":9,"in_reply_to":"fa32b979_15fb867c","updated":"2015-06-23 13:16:24.000000000","message":"Agree, changing behaviour here is unacceptable. About encodeutils.safe_encode(), it was done due this bug https://bugs.launchpad.net/cinder/+bug/1333446","commit_id":"9fce33357ef0627c22ca4a621d3efe670841bbea"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a58c98fea7aa0764ab4d1ba5ddd752259bae50c0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port test_backup_ceph and test_rbd to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add cinder.utils.convert_str() function: helper to convert a string to"},{"line_number":10,"context_line":"  a native string: convert to bytes on Python 2, convert to Unicode on"},{"line_number":11,"context_line":"  Python 3. Function needed by ceph and rbd drivers."},{"line_number":12,"context_line":"* Replace encodeutils.safe_encode() with utils.convert_str()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_41a70c0b","line":9,"in_reply_to":"fa32b979_26da1e4c","updated":"2015-06-23 13:57:24.000000000","message":"ah, thats nice, encoding stuff already crap","commit_id":"9fce33357ef0627c22ca4a621d3efe670841bbea"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c68c65b731eba199d37418759897ff018227bb2f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port test_backup_ceph and test_rbd to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add cinder.utils.convert_str() function: helper to convert a string to"},{"line_number":10,"context_line":"  a native string: convert to bytes on Python 2, convert to Unicode on"},{"line_number":11,"context_line":"  Python 3. Function needed by ceph and rbd drivers."},{"line_number":12,"context_line":"* Replace encodeutils.safe_encode() with utils.convert_str()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_15fb867c","line":9,"in_reply_to":"fa32b979_52b7e4d7","updated":"2015-06-23 13:00:45.000000000","message":"I asked on #openstack-oslo. For Doug Hellmann, it\u0027s weird to have a different result type depending on the Python major version.\n\nI wrote this helper function to avoid duplicating \"if six.PY2: var \u003d encodeutils.safe_encode(var)\" everywhere in the code. I don\u0027t understand why encodeutils.safe_encode() is used in the first place. Why a function would get Unicode? Why not encoding Unicode in the caller?\n\nRemoving completly safe_encode() requires better knowledge of Cinder than I have. Anyway, I don\u0027t like adding Python 3 support *and* changing the behaviour of the code in the same change. If someone wants to rework this part of the code, please write a new patch.","commit_id":"9fce33357ef0627c22ca4a621d3efe670841bbea"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"1b6a3575e89497df0297aa6ddf22bee47b9674e5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port test_backup_ceph and test_rbd to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add cinder.utils.convert_str() function: helper to convert a string to"},{"line_number":10,"context_line":"  a native string: convert to bytes on Python 2, convert to Unicode on"},{"line_number":11,"context_line":"  Python 3. Function needed by ceph and rbd drivers."},{"line_number":12,"context_line":"* Replace encodeutils.safe_encode() with utils.convert_str()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_52b7e4d7","line":9,"in_reply_to":"fa32b979_72d9c856","updated":"2015-06-23 12:47:12.000000000","message":"Cinder is the first OpenStack project that I see which needs such function. I\u0027m not sure that other OpenStack projects would use such function.","commit_id":"9fce33357ef0627c22ca4a621d3efe670841bbea"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"e02b8d98b308534e1b1c35f0f911c3cf4e50f3ff","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port test_backup_ceph and test_rbd to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add cinder.utils.convert_str() function: helper to convert a string to"},{"line_number":10,"context_line":"  a native string: convert to bytes on Python 2, convert to Unicode on"},{"line_number":11,"context_line":"  Python 3. Function needed by ceph and rbd drivers."},{"line_number":12,"context_line":"* Replace encodeutils.safe_encode() with utils.convert_str()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_26da1e4c","line":9,"in_reply_to":"fa32b979_98efcdb0","updated":"2015-06-23 13:47:43.000000000","message":"Oh, thanks for the link.\n\nBy the way, I would prefer to call safe_encode() with incoming\u003d\u0027utf-8\u0027 to have a reliable encoding, not depend on the locale encoding. But that\u0027s unrelated to Python 3, it must be changed in a different patch.","commit_id":"9fce33357ef0627c22ca4a621d3efe670841bbea"}]}