)]}'
{"cinder/tests/unit/test_blockbridge.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cba255fec6ee71cac9106d94fbf11b91c5ba1fb7","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import base64"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"try:"},{"line_number":21,"context_line":"    from unittest import mock"},{"line_number":22,"context_line":"except ImportError:"},{"line_number":23,"context_line":"    import mock"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_f4ae792e","line":20,"updated":"2015-06-26 16:01:39.000000000","message":"Would it be less overhead to have an if six.PY3 check rather than throwing an exception?","commit_id":"583d03e117a95ce24253eec63a3b7ef564e69307"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"6341e9ef1f7afe81f108c29ba0e3d38e777b6ed3","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import base64"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"try:"},{"line_number":21,"context_line":"    from unittest import mock"},{"line_number":22,"context_line":"except ImportError:"},{"line_number":23,"context_line":"    import mock"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_8a77c49e","line":20,"in_reply_to":"fa32b979_f4ae792e","updated":"2015-06-26 16:29:29.000000000","message":"By overhead, do you mean a performance overhead? An import in Python takes a few milliseconds and it\u0027s only done once at startup. Moreover, who cares of test performances? :-)\n\n\"try/except ImportError\" is a common pattern to get a Python 2 or Python 3 module. I prefer ImportError to test the feature rather than the Python version. For example, unittest.mock was introduced in Python 3.3, no \"if six.PY3:\" is not exact. \"if sys.version_info \u003e\u003d (3, 3):\" would be better.","commit_id":"583d03e117a95ce24253eec63a3b7ef564e69307"}]}