)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f40c7b5366ddd8de7f978500b9d25d6dd1a76be8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"its existennce. if not present, raise NotFound exception so that"},{"line_number":11,"context_line":"it can be handled properly in service that use the api, like Heat."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3107b8df0121de1ebe9e812ef7a842d09500e030"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_1291ed46","line":13,"updated":"2015-06-25 12:45:36.000000000","message":"Please file a Launchpad bug and add link it here using:\n\n    Closes-Bug: bug-id","commit_id":"11ce9535dbf79c60c56af336cdbea7cbb4293834"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"718d6919c75911268fc227fba7c9945b74a147bf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rakesh H S \u003crh-s@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-27 17:48:28 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check for existence of volume type encryption before deleting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds a check for volume type encryption existence before"},{"line_number":10,"context_line":"marking it as deleted. If it isn\u0027t present call returns 404 error"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa32b979_4f2d35fc","line":7,"updated":"2015-06-27 14:22:57.000000000","message":"https://wiki.openstack.org/wiki/GitCommitMessages says: \"The first line should be limited to 50 characters ...\"","commit_id":"35e792692fdb06144958a67e200cd1dc41576568"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7a2b4f1a7e4c9d42ab286028cf3b46ba15444465","unresolved":false,"context_lines":[{"line_number":10,"context_line":"marking it as deleted. If it isn\u0027t present call returns 404 error"},{"line_number":11,"context_line":"code so that it can be handled properly in services that use the"},{"line_number":12,"context_line":"REST API (like Heat)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3107b8df0121de1ebe9e812ef7a842d09500e030"},{"line_number":15,"context_line":"Closes-Bug: #1468751"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba3cc151_4938cea0","line":13,"updated":"2015-06-30 14:20:23.000000000","message":"Please, add APIImpact note","commit_id":"a024f147042df398aa9c5a16dc497cff04635975"}],"cinder/api/contrib/volume_type_encryption.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"80ad2f1bec26197d3d83819069cd21848e0a2237","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            try:"},{"line_number":192,"context_line":"                db.volume_type_encryption_delete(context, type_id)"},{"line_number":193,"context_line":"            except exception.VolumeTypeEncryptionNotFound:"},{"line_number":194,"context_line":"                raise webob.exc.HTTPNotFound()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f25f0d3f","line":194,"updated":"2015-06-23 15:47:12.000000000","message":"You should add the explaination too, i.e.\nexcept exception.VolumeTypeEncryptionNotFound as error:\n    webob.exc.HTTPNotFound(explanation\u003derror.msg)","commit_id":"c22b78f4b60885df9eba6d5e703b770842ac1342"}],"cinder/tests/unit/api/contrib/test_volume_type_encryption.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"76b136e633923feb9574a25aa6599eb83bcf443c","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        db.volume_type_destroy(context.get_admin_context(), volume_type[\u0027id\u0027])"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test_delete_with_no_encrption(self):"},{"line_number":479,"context_line":"        volume_type \u003d self._default_volume_type"},{"line_number":480,"context_line":"        # create an volume type"},{"line_number":481,"context_line":"        db.volume_type_create(context.get_admin_context(), volume_type)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_818edb77","line":478,"updated":"2015-06-26 10:34:14.000000000","message":"s/encrption/encryption/","commit_id":"98ff08e28f17c0739076703d9b633d75fb644a50"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"d9f323a94cf4e0340ffa9f5dcf9217c92a7a8ac2","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        db.volume_type_destroy(context.get_admin_context(), volume_type[\u0027id\u0027])"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test_delete_with_no_encrption(self):"},{"line_number":479,"context_line":"        volume_type \u003d self._default_volume_type"},{"line_number":480,"context_line":"        # create an volume type"},{"line_number":481,"context_line":"        db.volume_type_create(context.get_admin_context(), volume_type)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_d471dcdf","line":478,"in_reply_to":"fa32b979_818edb77","updated":"2015-06-27 12:41:49.000000000","message":"Done","commit_id":"98ff08e28f17c0739076703d9b633d75fb644a50"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"acb1a8c33cfcc538d1c37909c21e75700ee94f54","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test_delete_with_no_encryption(self):"},{"line_number":479,"context_line":"        volume_type \u003d self._default_volume_type"},{"line_number":480,"context_line":"        # create an volume type"},{"line_number":481,"context_line":"        db.volume_type_create(context.get_admin_context(), volume_type)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        # without creating encryption type, try to delete"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_085a562a","line":480,"updated":"2015-07-02 09:59:40.000000000","message":"s/an/a","commit_id":"41646ab48be69f01afa943190d6fc41234c78976"}],"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f40c7b5366ddd8de7f978500b9d25d6dd1a76be8","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"            self._assertEqualObjects(encryption, encryption_get,"},{"line_number":1147,"context_line":"                                     self._ignored_keys)"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"    def test_volume_type_encryption_update_with_no_create(self):"},{"line_number":1150,"context_line":"        self.assertRaises(exception.VolumeTypeEncryptionNotFound,"},{"line_number":1151,"context_line":"                          db.volume_type_encryption_update,"},{"line_number":1152,"context_line":"                          self.ctxt,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_b2928155","line":1149,"updated":"2015-06-25 12:45:36.000000000","message":"Not related to the patch, but good catch anyway.","commit_id":"11ce9535dbf79c60c56af336cdbea7cbb4293834"}]}