)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"11046feb1758b7df0e236bad6c6b4e6652741624","unresolved":false,"context_lines":[{"line_number":12,"context_line":"method, so we need to call it in Cinder Service wait() method"},{"line_number":13,"context_line":"which gets called when graceful shutdown is requested by sending"},{"line_number":14,"context_line":"the process SIGTERM."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iea877e062272103ea48583b5638dec6174e99de0"},{"line_number":17,"context_line":"Closes-Bug: 1464822"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a41bdd9_19bb0810","line":15,"updated":"2015-07-17 13:23:57.000000000","message":"Does this need a DocImpact? I could be wrong, but I just thought I\u0027d ask.","commit_id":"fa17e0b9f6957ca9a30491079ec9fd7992d1e7c2"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"2fbf09cd89a450077e3a1f6d68645406e9582d21","unresolved":false,"context_lines":[{"line_number":12,"context_line":"method, so we need to call it in Cinder Service wait() method"},{"line_number":13,"context_line":"which gets called when graceful shutdown is requested by sending"},{"line_number":14,"context_line":"the process SIGTERM."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iea877e062272103ea48583b5638dec6174e99de0"},{"line_number":17,"context_line":"Closes-Bug: 1464822"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a41bdd9_b60c5943","line":15,"in_reply_to":"9a41bdd9_19bb0810","updated":"2015-07-17 18:48:37.000000000","message":"DocImpact flag is included original patch in oslo.service. Therefore, I think we don\u0027t need DocImpact for this bug fix. I will add reference of 190175 into commit message.\n\nhttps://review.openstack.org/#/c/190175/\n\nGraceful shutdown WSGI/RPC server\n\nCurrently, termination of WSGI application or RPC server immediately stops\nservice and so interrupts in-progress request.\n\nGraceful handler for SIGTERM signal was added.\nSIGINT signal handler was removed to allow instantaneous termination of\nservice.\n\nDocImpact: graceful termination of process can be done by sending SIGTERM\nsignal to parent WSGI process. Graceful termination is not instantaneous.\nTo force instantaneous termination SIGINT signal must be sent.","commit_id":"fa17e0b9f6957ca9a30491079ec9fd7992d1e7c2"}],"cinder/service.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"fc8fde52378060aa67bd54c96fd91be11c0b2757","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                x.wait()"},{"line_number":281,"context_line":"            except Exception:"},{"line_number":282,"context_line":"                pass"},{"line_number":283,"context_line":"        if self.rpcserver:"},{"line_number":284,"context_line":"            self.rpcserver.wait()"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def periodic_tasks(self, raise_on_error\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_89119654","line":283,"updated":"2015-06-24 08:47:33.000000000","message":"Do we need to put it under try block, or we shouldn\u0027t ignore error during wait?","commit_id":"f53a488a638d299ddc892b85d51f3b1952abf5f6"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"76f468c88937e84c96ffddacd6170c50fba60af4","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                x.wait()"},{"line_number":281,"context_line":"            except Exception:"},{"line_number":282,"context_line":"                pass"},{"line_number":283,"context_line":"        if self.rpcserver:"},{"line_number":284,"context_line":"            self.rpcserver.wait()"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def periodic_tasks(self, raise_on_error\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_c26e902e","line":283,"in_reply_to":"fa32b979_89119654","updated":"2015-06-24 11:13:37.000000000","message":"In my understanding, threadgroup might raise exception, we shouldn\u0027t ignore the error.\n\n            except Exception:\n                LOG.exception(_LE(\u0027Error waiting on ThreadGroup.\u0027))","commit_id":"f53a488a638d299ddc892b85d51f3b1952abf5f6"}]}