)]}'
{"cinder/tests/unit/test_cmd.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5c355c1bb0b4c2ae4778f9802868a386f58a9b8d","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        volume_id \u003d \u0027123\u0027"},{"line_number":442,"context_line":"        host \u003d \u0027fake@host\u0027"},{"line_number":443,"context_line":"        volume \u003d {\u0027id\u0027: volume_id,"},{"line_number":444,"context_line":"                  \u0027host\u0027: host + \u0027#pool1\u0027,"},{"line_number":445,"context_line":"                  \u0027status\u0027: \u0027available\u0027}"},{"line_number":446,"context_line":"        volume_get.return_value \u003d volume"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_76f61892","line":444,"updated":"2015-06-25 20:20:34.000000000","message":"I think we should have 2 tests, one with pool and another without.  Or at least test both cases.","commit_id":"8076457cd069cfd734976c544f4aed49c38b4fc9"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"39dea2fbda435996042501317895025c081b3e32","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        volume_id \u003d \u0027123\u0027"},{"line_number":442,"context_line":"        host \u003d \u0027fake@host\u0027"},{"line_number":443,"context_line":"        volume \u003d {\u0027id\u0027: volume_id,"},{"line_number":444,"context_line":"                  \u0027host\u0027: host + \u0027#pool1\u0027,"},{"line_number":445,"context_line":"                  \u0027status\u0027: \u0027available\u0027}"},{"line_number":446,"context_line":"        volume_get.return_value \u003d volume"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_85ed8eb9","line":444,"in_reply_to":"fa32b979_259fe266","updated":"2015-06-26 08:11:32.000000000","message":"I\u0027ve wrapped host with extract_host method method, you can see how it will work with pool or not  in unit test for extract_host, also it covers a lot of other cases.","commit_id":"8076457cd069cfd734976c544f4aed49c38b4fc9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3bf842063cc62b7a690f4641aa78309bec0ea87f","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        volume_id \u003d \u0027123\u0027"},{"line_number":442,"context_line":"        host \u003d \u0027fake@host\u0027"},{"line_number":443,"context_line":"        volume \u003d {\u0027id\u0027: volume_id,"},{"line_number":444,"context_line":"                  \u0027host\u0027: host + \u0027#pool1\u0027,"},{"line_number":445,"context_line":"                  \u0027status\u0027: \u0027available\u0027}"},{"line_number":446,"context_line":"        volume_get.return_value \u003d volume"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_259fe266","line":444,"in_reply_to":"fa32b979_6a2db9a7","updated":"2015-06-26 08:04:08.000000000","message":"Not really, before this patch we only had delete command test for hosts without pool (well it didn\u0027t really care about pools, but you get the idea) and now we only have it for it with pool.\n\nIt\u0027s not only about what code you are introducing, but also about testing the different scenarios to avoid regressions.\n\nIf tomorrow someone else\u0027s change breaks delete without pool, how would we know?","commit_id":"8076457cd069cfd734976c544f4aed49c38b4fc9"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"99ee2a76c2cfe7fb86eae064c309bc73257923b4","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        volume_id \u003d \u0027123\u0027"},{"line_number":442,"context_line":"        host \u003d \u0027fake@host\u0027"},{"line_number":443,"context_line":"        volume \u003d {\u0027id\u0027: volume_id,"},{"line_number":444,"context_line":"                  \u0027host\u0027: host + \u0027#pool1\u0027,"},{"line_number":445,"context_line":"                  \u0027status\u0027: \u0027available\u0027}"},{"line_number":446,"context_line":"        volume_get.return_value \u003d volume"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_6a2db9a7","line":444,"in_reply_to":"fa32b979_76f61892","updated":"2015-06-26 07:50:31.000000000","message":"You propose to test extract_host method, which already have good unit test, I think it is redundant.","commit_id":"8076457cd069cfd734976c544f4aed49c38b4fc9"}]}