)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3e769ac0df5d575adebf21f56a2a1d463d291e90","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  -h, --help  show this help message and exit"},{"line_number":26,"context_line":"  -w W        Duration between request to services and their"},{"line_number":27,"context_line":"              status check(in seconds) (default: 4)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Implements: blueprint cinder-manage-healthchecks-api"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I1265e550ae0760f7b7910123bb51a83caf762a92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_2f891c6f","line":28,"updated":"2015-06-25 16:40:11.000000000","message":"Should we add DocImpact here?","commit_id":"e327fa807e4c3215e51cb4d42d4a6dbdaed95bbf"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"afa6b1bb13dcd72e519ca0191e7e9b923dbcd23b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  -h, --help  show this help message and exit"},{"line_number":26,"context_line":"  -w W        Duration between request to services and their"},{"line_number":27,"context_line":"              status check(in seconds) (default: 4)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Implements: blueprint cinder-manage-healthchecks-api"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I1265e550ae0760f7b7910123bb51a83caf762a92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_a14d1c9b","line":28,"in_reply_to":"fa32b979_2f891c6f","updated":"2015-06-26 11:56:03.000000000","message":"Done","commit_id":"e327fa807e4c3215e51cb4d42d4a6dbdaed95bbf"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"8e599f7081dacaa292bf7b902c96b31ca31b4776","unresolved":false,"context_lines":[{"line_number":12,"context_line":"db record, and by each \u0027consumer\u0027 retrieving those records from"},{"line_number":13,"context_line":"the db, and verifying update was within allowed time window."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This mechanism don\u0027t include important part of service"},{"line_number":16,"context_line":"communication - rpc. This change is extend command"},{"line_number":17,"context_line":"cinder-manage service list. It possible to sends messages"},{"line_number":18,"context_line":"via rpc to all cinder services, and services will update"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a41bdd9_f53940d8","line":15,"updated":"2015-07-14 14:53:13.000000000","message":"Suggest: \"...mechanism doesn\u0027t include an important part...\"","commit_id":"ee153edd035e36041ba285071d3079a734c023da"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"8e599f7081dacaa292bf7b902c96b31ca31b4776","unresolved":false,"context_lines":[{"line_number":13,"context_line":"the db, and verifying update was within allowed time window."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This mechanism don\u0027t include important part of service"},{"line_number":16,"context_line":"communication - rpc. This change is extend command"},{"line_number":17,"context_line":"cinder-manage service list. It possible to sends messages"},{"line_number":18,"context_line":"via rpc to all cinder services, and services will update"},{"line_number":19,"context_line":"\u0027modified_at\u0027 field, than after configured time we check this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a41bdd9_95bc7407","line":16,"updated":"2015-07-14 14:53:13.000000000","message":"Suggest: \"This change extends the command: cinder-manage service list.\"","commit_id":"ee153edd035e36041ba285071d3079a734c023da"}],"cinder/backup/manager.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3e769ac0df5d575adebf21f56a2a1d463d291e90","unresolved":false,"context_lines":[{"line_number":708,"context_line":"            notifier.info(context, \"backups.reset_status.end\","},{"line_number":709,"context_line":"                          notifier_info)"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    def update_service_state(self, ctxt):"},{"line_number":712,"context_line":"        \"\"\"Update service timestamp - modified_at\"\"\""},{"line_number":713,"context_line":"        srv \u003d self.db.service_get_by_args(ctxt, self.host, CONF.backup_topic)"},{"line_number":714,"context_line":"        srv_status \u003d {\u0027modified_at\u0027: timeutils.utcnow()}"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_7474dbcd","line":711,"updated":"2015-06-25 16:40:11.000000000","message":"This method is almost the same in all managers. Please, move it to the base class","commit_id":"e327fa807e4c3215e51cb4d42d4a6dbdaed95bbf"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"afa6b1bb13dcd72e519ca0191e7e9b923dbcd23b","unresolved":false,"context_lines":[{"line_number":708,"context_line":"            notifier.info(context, \"backups.reset_status.end\","},{"line_number":709,"context_line":"                          notifier_info)"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    def update_service_state(self, ctxt):"},{"line_number":712,"context_line":"        \"\"\"Update service timestamp - modified_at\"\"\""},{"line_number":713,"context_line":"        srv \u003d self.db.service_get_by_args(ctxt, self.host, CONF.backup_topic)"},{"line_number":714,"context_line":"        srv_status \u003d {\u0027modified_at\u0027: timeutils.utcnow()}"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_017648d8","line":711,"in_reply_to":"fa32b979_7474dbcd","updated":"2015-06-26 11:56:03.000000000","message":"Done","commit_id":"e327fa807e4c3215e51cb4d42d4a6dbdaed95bbf"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ca11ed3f1a7ce8def0a9012dbbda76ef06e5781f","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        \"\"\"Update service timestamp - modified_at\"\"\""},{"line_number":713,"context_line":"        srv \u003d self.db.service_get_by_args(ctxt, self.host, CONF.backup_topic)"},{"line_number":714,"context_line":"        srv_status \u003d {\u0027modified_at\u0027: timeutils.utcnow()}"},{"line_number":715,"context_line":"        self.db.service_update(ctxt, srv[\u0027id\u0027], srv_status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_cabbbee3","line":715,"updated":"2015-06-25 17:02:37.000000000","message":"Race condition could happen here. The same comment for the rest of services","commit_id":"e327fa807e4c3215e51cb4d42d4a6dbdaed95bbf"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"afa6b1bb13dcd72e519ca0191e7e9b923dbcd23b","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        \"\"\"Update service timestamp - modified_at\"\"\""},{"line_number":713,"context_line":"        srv \u003d self.db.service_get_by_args(ctxt, self.host, CONF.backup_topic)"},{"line_number":714,"context_line":"        srv_status \u003d {\u0027modified_at\u0027: timeutils.utcnow()}"},{"line_number":715,"context_line":"        self.db.service_update(ctxt, srv[\u0027id\u0027], srv_status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_c17f00aa","line":715,"in_reply_to":"fa32b979_cabbbee3","updated":"2015-06-26 11:56:03.000000000","message":"Done","commit_id":"e327fa807e4c3215e51cb4d42d4a6dbdaed95bbf"}],"cinder/cmd/manage.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3e769ac0df5d575adebf21f56a2a1d463d291e90","unresolved":false,"context_lines":[{"line_number":447,"context_line":"               \u0027status check(in seconds) (default: %(default)d)\u0027)"},{"line_number":448,"context_line":"    def list(self, wait_time):"},{"line_number":449,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":450,"context_line":"        print_format \u003d \"%-16s %-36s %-16s %-10s %-8s %-20s %-20s\""},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        client \u003d rpc_client(topic\u003dNone)"},{"line_number":453,"context_line":"        for topic in [CONF.scheduler_topic, CONF.volume_topic,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_1456af29","line":450,"updated":"2015-06-25 16:40:11.000000000","message":"Why do you moved it here?","commit_id":"e327fa807e4c3215e51cb4d42d4a6dbdaed95bbf"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"afa6b1bb13dcd72e519ca0191e7e9b923dbcd23b","unresolved":false,"context_lines":[{"line_number":447,"context_line":"               \u0027status check(in seconds) (default: %(default)d)\u0027)"},{"line_number":448,"context_line":"    def list(self, wait_time):"},{"line_number":449,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":450,"context_line":"        print_format \u003d \"%-16s %-36s %-16s %-10s %-8s %-20s %-20s\""},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        client \u003d rpc_client(topic\u003dNone)"},{"line_number":453,"context_line":"        for topic in [CONF.scheduler_topic, CONF.volume_topic,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_ad50b8d5","line":450,"in_reply_to":"fa32b979_1456af29","updated":"2015-06-26 11:56:03.000000000","message":"I don\u0027t moved it, just add new format","commit_id":"e327fa807e4c3215e51cb4d42d4a6dbdaed95bbf"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3e769ac0df5d575adebf21f56a2a1d463d291e90","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":450,"context_line":"        print_format \u003d \"%-16s %-36s %-16s %-10s %-8s %-20s %-20s\""},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        client \u003d rpc_client(topic\u003dNone)"},{"line_number":453,"context_line":"        for topic in [CONF.scheduler_topic, CONF.volume_topic,"},{"line_number":454,"context_line":"                      CONF.backup_topic]:"},{"line_number":455,"context_line":"            cctxt \u003d client.prepare(topic\u003dtopic, fanout\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_cf83d054","line":452,"updated":"2015-06-25 16:40:11.000000000","message":"Please, make new functionality optional to get current behaviour  as default","commit_id":"e327fa807e4c3215e51cb4d42d4a6dbdaed95bbf"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"afa6b1bb13dcd72e519ca0191e7e9b923dbcd23b","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":450,"context_line":"        print_format \u003d \"%-16s %-36s %-16s %-10s %-8s %-20s %-20s\""},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        client \u003d rpc_client(topic\u003dNone)"},{"line_number":453,"context_line":"        for topic in [CONF.scheduler_topic, CONF.volume_topic,"},{"line_number":454,"context_line":"                      CONF.backup_topic]:"},{"line_number":455,"context_line":"            cctxt \u003d client.prepare(topic\u003dtopic, fanout\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_2d5b48f8","line":452,"in_reply_to":"fa32b979_cf83d054","updated":"2015-06-26 11:56:03.000000000","message":"Done","commit_id":"e327fa807e4c3215e51cb4d42d4a6dbdaed95bbf"}]}