)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"95f174d8024fb835df05b78a7d5e1f181df1ced2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* When parsing share configuration: replace \\040 with a space explicitly"},{"line_number":10,"context_line":"  instead of using the Python unicode_escape encoding."},{"line_number":11,"context_line":"* tox.ini: add cinder.tests.unit.test_glusterfs to Python 3.4"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Blueprint cinder-python3"},{"line_number":14,"context_line":"Change-Id: Iea943a1f2dfb050fe43ff41411e258adb3f3b6d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_eabaf1e0","line":12,"updated":"2015-06-30 14:59:00.000000000","message":"Do you also want to note the utf-8 encoding change in remotefs.py in the commit message?","commit_id":"ca514fa5023053fe745b411d502cba12589ed44a"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"4956d0ab08d267ea9225162d9b3535adcda1ae65","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* When parsing share configuration: replace \\040 with a space explicitly"},{"line_number":10,"context_line":"  instead of using the Python unicode_escape encoding."},{"line_number":11,"context_line":"* tox.ini: add cinder.tests.unit.test_glusterfs to Python 3.4"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Blueprint cinder-python3"},{"line_number":14,"context_line":"Change-Id: Iea943a1f2dfb050fe43ff41411e258adb3f3b6d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_ed31ab0c","line":12,"in_reply_to":"ba3cc151_eabaf1e0","updated":"2015-06-30 15:16:06.000000000","message":"Done","commit_id":"ca514fa5023053fe745b411d502cba12589ed44a"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b2995e2d5159bc300c633fbf560319579def1012","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"                share_address \u003d share_info[0].strip()"},{"line_number":457,"context_line":"                if six.PY2:"},{"line_number":458,"context_line":"                    share_address \u003d share_address.decode(\u0027unicode_escape\u0027)"},{"line_number":459,"context_line":"                share_opts \u003d None"},{"line_number":460,"context_line":"                if len(share_info) \u003e 1:"},{"line_number":461,"context_line":"                    share_opts \u003d share_info[1].strip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_1848d286","line":458,"updated":"2015-06-30 13:41:28.000000000","message":"I\u0027m not confident in this change. The unicode_escape is a special encoding. It decodes \"\\xe9\" (4 characters: \\, x, e, 9) to the Unicode character U+00E9 (é). Was it a deliberate choice? Or is the ASCII encoding expected here?","commit_id":"6ac07ad762aa95008be7203ff8b8706b34ea1faa"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b2995e2d5159bc300c633fbf560319579def1012","unresolved":false,"context_lines":[{"line_number":754,"context_line":"        \"\"\""},{"line_number":755,"context_line":"        if isinstance(base_str, six.text_type):"},{"line_number":756,"context_line":"            base_str \u003d base_str.encode(\u0027utf-8\u0027)"},{"line_number":757,"context_line":"        return hashlib.md5(base_str).hexdigest()"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    def _get_mount_point_for_share(self, share):"},{"line_number":760,"context_line":"        \"\"\"Return mount point for share."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_98a62252","line":757,"updated":"2015-06-30 13:41:28.000000000","message":"By the way, I wrote a similar change for os-brick: it looks like at least this method is duplicated in cinder and os-brick:\nhttps://review.openstack.org/#/c/197062/1/os_brick/remotefs/remotefs.py\n\ncinder might reuse os-brick code here.","commit_id":"6ac07ad762aa95008be7203ff8b8706b34ea1faa"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d5ec884a8831f54e7f0590fef60951851cb274d1","unresolved":false,"context_lines":[{"line_number":454,"context_line":"                #  [ \u0027address:/vol\u0027, \u0027-o options\u003d123,rw --other\u0027 ]"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"                share_address \u003d share_info[0].strip()"},{"line_number":457,"context_line":"                # Bug #1180984: Replace \\040 with a space, to support paths"},{"line_number":458,"context_line":"                # with spaces"},{"line_number":459,"context_line":"                share_address \u003d share_address.replace(\"\\\\040\", \" \")"},{"line_number":460,"context_line":"                share_opts \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_b77afeef","line":457,"updated":"2015-06-30 20:12:31.000000000","message":"Please don\u0027t add bug numbers into comments.  Just describing what\u0027s going on is preferable.\n\nWould be better to mention the related bug in the commit message.","commit_id":"8043c669e8bfa13d7119217fa3a668ff9b75d1fe"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"541d5103429645967673217a2ce024db783a6a74","unresolved":false,"context_lines":[{"line_number":454,"context_line":"                #  [ \u0027address:/vol\u0027, \u0027-o options\u003d123,rw --other\u0027 ]"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"                share_address \u003d share_info[0].strip()"},{"line_number":457,"context_line":"                # Bug #1180984: Replace \\040 with a space, to support paths"},{"line_number":458,"context_line":"                # with spaces"},{"line_number":459,"context_line":"                share_address \u003d share_address.replace(\"\\\\040\", \" \")"},{"line_number":460,"context_line":"                share_opts \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_dd1c8379","line":457,"in_reply_to":"ba3cc151_b77afeef","updated":"2015-06-30 20:53:24.000000000","message":"Ok.","commit_id":"8043c669e8bfa13d7119217fa3a668ff9b75d1fe"}]}