)]}'
{"cinder/tests/unit/test_cmd.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6ea6475b66e289a69e52894f406faea6cf0c2d48","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import sys"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"try:"},{"line_number":18,"context_line":"    from unittest import mock"},{"line_number":19,"context_line":"except ImportError:"},{"line_number":20,"context_line":"    import mock"},{"line_number":21,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_df0be28c","line":18,"updated":"2015-07-01 18:26:33.000000000","message":"I didn\u0027t see you doing this in any of the other patches.  Why the change on this one?","commit_id":"6436f9633ceeed217034bce50b40168bf2218b74"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac77c82a925e5264adf6cba8e449deeb7ebcf50d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import sys"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"try:"},{"line_number":18,"context_line":"    from unittest import mock"},{"line_number":19,"context_line":"except ImportError:"},{"line_number":20,"context_line":"    import mock"},{"line_number":21,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_b4afff28","line":18,"in_reply_to":"ba3cc151_d47f2315","updated":"2015-07-02 11:50:03.000000000","message":"I agree, better avoid try..except for imports when possible.  Thanks for the explanation.","commit_id":"6436f9633ceeed217034bce50b40168bf2218b74"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"1a782e73d5cbd2bd243b1e0086e542e7772e95b4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import sys"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"try:"},{"line_number":18,"context_line":"    from unittest import mock"},{"line_number":19,"context_line":"except ImportError:"},{"line_number":20,"context_line":"    import mock"},{"line_number":21,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_d47f2315","line":18,"in_reply_to":"ba3cc151_df0be28c","updated":"2015-07-02 11:41:35.000000000","message":"In the common case, it\u0027s fine to use the third-party mock module.\n\nI had to use unittest.mock on Python 3 in some tests because of bugs in the third-party module. These bugs don\u0027t affect all Cinder tests, only a few of them.\n\nI don\u0027t like writing try/except ImportError, and I prefer shorter patches which are easier to review. That\u0027s why I didn\u0027t replace \"import mock\" with this try/except ImportError in other files.","commit_id":"6436f9633ceeed217034bce50b40168bf2218b74"}]}